Winamp & Shoutcast Forums

Winamp & Shoutcast Forums (http://forums.winamp.com/index.php)
-   NSIS Discussion (http://forums.winamp.com/forumdisplay.php?f=65)
-   -   warning: MUI_LANGUAGE (http://forums.winamp.com/showthread.php?t=382600)

OrdiMars 12th October 2015 08:15

warning: MUI_LANGUAGE
 
Hi,

when I compile my install.exe file I get the following message:
!warning: MUI_LANGUAGE should be inserted after the MUI_[UN]PAGE_* macros (macro:MUI_LANGUAGE:8)

However, this is an extract of my .nsi file:
!insertmacro MUI_PAGE_FINISH

; Uninstaller pages
!insertmacro MUI_UNPAGE_INSTFILES

; Language files
!insertmacro MUI_LANGUAGE "French"


So, MUI_LANGUAGE is inserted after MUI_PAGE_FINISH and MUI_UNPAGE_INSTFILES ... why do I get this message ? ! ?


Thanks in advance for any pointers,
L@u

JasonFriday13 12th October 2015 09:24

Do you have any other pages after MUI_LANGUAGE?

Also, check out the examples: http://sourceforge.net/p/nsis/code/H...comeFinish.nsi.

Anders 12th October 2015 12:30

When you are using a beta version if is helpful if you inform us of this fact.

This is a bug in MUI v1. It should be fixed in the next version. You can just ignore this warning but if you want to remove it you can add !insertmacro MUI_DEFAULT MUI_PAGE_UNINSTALLER_PREFIX "" before inserting the language macros.

jweinraub 1st December 2015 16:52

I never had this warning popup either and now it is coming.
I added what you told the OP to remove warning but why is the warning happening? What does the fix do that removes it? Will this warning cause an issue error later on?


PHP Code:

# defines were here

SetCompressor bzip2

!include "Version.nsh"
!include WinVer.nsh
!include LogicLib.nsh
!include x64.nsh

#  MUI 1.67 compatible ------
!include "MUI.nsh"

#  MUI Settings
!define MUI_ABORTWARNING
!define MUI_ICON "setup.ico"
!define MUI_UNICON "uninstall.ico"

#  Welcome page
!insertmacro MUI_PAGE_WELCOME

#  eula
!define MUI_LICENSEPAGE_RADIOBUTTONS
!insertmacro MUI_PAGE_LICENSE "eula_pcc_2013.rtf"
!define MUI_LICENSEPAGE_RADIOBUTTONS
!insertmacro MUI_PAGE_LICENSE "VRI_FIRMWARE_EULA.rtf"

#  Directory page
!insertmacro MUI_PAGE_DIRECTORY

#  Instfiles page
!insertmacro MUI_PAGE_INSTFILES

#  Finish page
!define MUI_FINISHPAGE_RUN "$INSTDIR\prog.EXE"
!define MUI_FINISHPAGE_RUN_NOTCHECKED
!insertmacro MUI_PAGE_FINISH

#  Uninstaller pages
!insertmacro MUI_UNPAGE_INSTFILES

#  Reserve files
!insertmacro MUI_RESERVEFILE_INSTALLOPTIONS


#  Language files
# adding this removes warning but why is it needed, what changed to cause this?
!insertmacro MUI_DEFAULT MUI_PAGE_UNINSTALLER_PREFIX ""
!insertmacro MUI_LANGUAGE "English"

BrandingText "${PRODUCT_PUBLISHER}"
#  MUI end ------

Function .onInit 


Anders 1st December 2015 20:06

Quote:

Originally Posted by jweinraub (Post 3042494)
I never had this warning popup either and now it is coming.

You are using BETA software, some minor issues should be expected.

Quote:

Originally Posted by jweinraub (Post 3042494)
I added what you told the OP to remove warning but why is the warning happening?

A small bug snuck in

Quote:

Originally Posted by jweinraub (Post 3042494)
What does the fix do that removes it?

Check the source if you really care.

Quote:

Originally Posted by jweinraub (Post 3042494)
Will this warning cause an issue error later on?

Probably not but there should be a new BETA soon so you might as well live with the warning, it is harmless and can be ignored...


All times are GMT. The time now is 17:34.

Copyright © 1999 - 2010 Nullsoft. All Rights Reserved.