View Single Post
Old 13th April 2007, 14:59   #2
DrO
 
Join Date: Sep 2003
Posts: 27,873
if an api is unsupported then the return value should be 1 in all cases. obviously that may cause issues for a number of apis but for some like when you get a function pointer, it's ideal for checking things.

i don't think there's much of an issue with a "if (winampVersion >= 0x0531) ..." check (or just doing as check at the start and then caching the version check results. adding in a IS_X_SUPPORTED would on the whole cause more complexity (both in the winamp core and also within plugins and it's no more different than the x>=y check).

there is the other option of just coding for a specific version of the winamp core/bundled plugins of that install (is basically what the winamp plugins do). it's just those of us naive enough to want to work on all versions that the issues like version checking arise

-daz
DrO is offline   Reply With Quote