Passing in quotes as an argument to a macro

[cowwoc]

Hi,

I've got a function which takes in a string as an argument. I want to pass in the string '"' -- that is, single quotes.

Problem is NSIS gives me:

Error: unterminated string parsing line at macro:IndexOf:2
Error in macro IndexOf on macroline 2

and my macro is defined as:

!macro IndexOf String SubString StartingIndex Result
Push "${String}"
Push "${SubString}"
Push "${StartingIndex}"
Call IndexOf
Pop "${Result}"
!macroend
!define IndexOf "!insertmacro IndexOf"

So obviously Push "${SubString}" is failing but I have no idea how to fix it. Passing in non-quote characters works fine. I also tried "$\"" as an argument and it fails too.

Gili

[cowwoc]

Using backticks for Push worked, but it feels like a hack. What happens if the input string actually contains backtick characters?

[dienjd]

Does this work for you?

code:


Name "quotetest"

Outfile "quotetest.exe"



!macro test param1

  MessageBox MB_OK "${param1}"

!macroend



Section ""

  StrCpy $0 '"'

  !insertmacro test "$0"

SectionEnd

[cowwoc]

Yes, that testcase works. Not sure why Push would fail then...

[Afrow UK]

Tried?
Push '${String}'
Push '${SubString}'
Push '${StartingIndex}'
Call IndexOf
Pop '${Result}'

-Stu

[Comm@nder21]

or even use ``

as ' and " are quite common. but nsis supports ` as third quotation mark.

[cowwoc]

My point though is that there should be a way to generally quote a variable without having to know what quotes are used inside. Why can't NSIS know that "$someVar" means that it should get quoted regardless of the type of quotes inside?