Old 23rd June 2009, 18:27   #1
qwertymodo
Junior Member
 
Join Date: Sep 2008
Posts: 26
Send a message via Yahoo to qwertymodo
Possible bug in 2.45 !searchparse

I have a script that works fine in 2.44 and fails on a call to !searchparse after upgrading to 2.45. I don't remember the exact error message because I downgraded back to 2.44 to double check, and it compiled just fine on 2.44, but it was something about the search token was not found in the file. Here are the script and the text file it is parsing, both from the beginning until the relevant line and then one line after.

code:

!define BUILDSCRIPTVERSION `version="1.3.4.0"`

!searchparse /file AppInfo.cfg `AppInfoVersion="` CFG_VER_MAJOR `.` CFG_VER_MINOR `.` CFG_UPDATE `.` CFG_REVISION `"`
!searchparse ${BUILDSCRIPTVERSION} `version="` SCRIPT_VER_MAJOR `.` SCRIPT_VER_MINOR `.` SCRIPT_UPDATE `.` SCRIPT_REVISION `"`
!if "${CFG_VER_MAJOR}.${CFG_VER_MINOR}" != "${SCRIPT_VER_MAJOR}.${SCRIPT_VER_MINOR}"
!error "Incompatible AppInfo.cfg file. Please use AppInfo.cfg version ${SCRIPT_VER_MAJOR}.${SCRIPT_VER_MINOR}.${SCRIPT_UPDATE}.x"
!endif

!if ${CFG_UPDATE} < ${SCRIPT_UPDATE}
!error "Incompatible AppInfo.cfg file. Please use AppInfo.cfg version ${SCRIPT_VER_MAJOR}.${SCRIPT_VER_MINOR}.${SCRIPT_UPDATE}.x"
!endif

!searchparse /file AppInfo.cfg `LauncherSourceFile="` PROGRAMSCRIPT `"` <<<HERE IS WHERE IT FAILS
!searchparse /file AppInfo.cfg `MainAppEXE="` APPEXE `"`

. . .



It fails on parsing `LauncherSourceFile="` so apparently it is making it through `AppInfoVersion="` just fine. Here's the text file it is parsing:

code:

AppInfoVersion="1.3.4.0"

#***REQUIRED LINES***

AppName="PortableApps Launcher Wizard"
LauncherSourceFile="PALauncherWizard.nsi"

#MainAppEXE is the exe of the actual app, not the launcher
#Include its relative path within the U3 Package
#i.e. Device\MainAppEXE.exe
MainAppEXE="Device\PALauncherWizard.exe"

. . .



As I said, it compiles just fine with 2.44, but not with 2.45. I noticed in the 2.45 changelog that there was a bugfix for searchparse, so perhaps that broke something else...

If this is the wrong place to post this, please just point me in the right direction.
qwertymodo is offline   Reply With Quote
Old 24th June 2009, 11:15   #2
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,343
Try the latest build. There was another !searchparse fix since 2.45.

http://nsis.sourceforge.net/Development_Files

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 25th June 2009, 01:04   #3
qwertymodo
Junior Member
 
Join Date: Sep 2008
Posts: 26
Send a message via Yahoo to qwertymodo
Appears to be fixed in the latest nightly build. Thanks for the heads up
qwertymodo is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump