Bug report: Crash after using updinfo

[WizardX]

Got the following error and a shoutcast crash:
2011-08-07 17:06:36 I msg:[ADMINCGI] XML title update [Boeh]
terminate called after throwing an instance of 'std::runtime_error'
what(): XML parser error: syntax error at line 1
Aborted

It happened after conducting the following command:

wget --user-agent "Mozilla" "http://sc-03.deep.fm:7000/admin.cgi?sid=1&type=xml&pass=cutaway&mode=updinfo&url=http://deep.fm&song=Boeh"

[DrO]

you're telling the DNAS to expect xml (v2) style metadata yet you're sending 'Boeh' which is clearly not xml. re-check the options you're sending to the DNAS and you'll find why it aborts.

maybe the DNAS shouldn't abort when it tries to process an invalid xml response (something affecting the non-Windows versions due to how expat is implemented) but in some respects it's probably better so things which are clearly wrong won't be allowed through. or i just drop the xml parameter and make the DNAS automatically work it out.

-daz

[WizardX]

I see, It wasn't that clear to me. But fair enough. In my opinion under no circumstances the daemon should abort. If someone wants to get us down they can use this to make us having a really bad day.

I tried changing the info without the xml type set, I got succesfully updated (2011-08-07 19:30:15 I msg:[ADMINCGI] Title update [Boeh]) according to the logfile, but nothing displayed in the clients winamp. Can this because the encoder sends out v1 to the DNAS?

[DrO]

if someone manages to compromise the source / admin password then maybe you have a point. as i said that's how the expat library which is used for xml handling currently works though i may look into trying to change that.

the clients should eventually see it though it can take a while and also it depends on what stream you're sending it to i.e. if sid=1 is the stream connected or not. checking the summary page will show if it's been recognised or not (in addition to the log message).

-daz

[WizardX]

The summary page shows the new title. Thats why I suspect DNAS to correctly have received my update. Only winamp doesn't display it. I guess it's the fact I'm broadcasting an old-style v1 stream to the DNAS. Will change that later on today because of downtime it brings

Thanks for your reply!

[DrO]

i've tested combinations of v1 and v2 stuff and if the summary page is showing the updated title then Winamp should be receiving it (depending on the version of Winamp you're using). though it is generally better to have a complete v2 stack if using that (though v1 inputs are still supported).

-daz

[WizardX]

I ran 5.581 but updated to 5.621 and that fixed the Title issue. Good to know

[DrO]

that makes sense as it wasn't until 5.60x that proper ShOUTcast 2 client support was added (mainly with respect to metadata handling).

-daz