Testing for regkey (not value) existence

banaman8d · 19th August 2003, 17:43

I realize that you want to use labels because it is more resilient to modifications in the code, but this macro cannot be used in certain situations because of the uniqueness (or lack of) of the keys.

For instance:

!insertmacro KeyExists A_ROOT A_MAINKEY A_KEY
; Do something like ExecWait that should modify the key
...
; And this will have duplicate labels...
!insertmacro KeyExists A_ROOT A_MAINKEY A_KEY

I agree with using labels in the name of maintainability, but not at the expense of the efficacy of the macro. If I use the above, I have to remember that it won't work if I use it twice in the same function for the same key. For a small macro like this one, doesn't it make more sense to relax the 'rule' for the benefit of the functionality?

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode

19th August 2003, 17:43	#1
banaman8d Junior Member Join Date: May 2003 Posts: 19	I realize that you want to use labels because it is more resilient to modifications in the code, but this macro cannot be used in certain situations because of the uniqueness (or lack of) of the keys. For instance: !insertmacro KeyExists A_ROOT A_MAINKEY A_KEY ; Do something like ExecWait that should modify the key ... ; And this will have duplicate labels... !insertmacro KeyExists A_ROOT A_MAINKEY A_KEY I agree with using labels in the name of maintainability, but not at the expense of the efficacy of the macro. If I use the above, I have to remember that it won't work if I use it twice in the same function for the same key. For a small macro like this one, doesn't it make more sense to relax the 'rule' for the benefit of the functionality?