Bugs in in_dshow and ML

[HalloWelt]

Hey there,

I just found a few new(? - searched, but didn't find them) bugs.

- in_dshow since 5.12
...is good to make winamp behave like an old tape deck. Attachment: small wmv-file (from save.tv, they're famous for small gaps) to show.
http://rapidshare.de/files/21753482/...unk_1.wmv.html

- Media Library since 5.22
-- drag&drop of folder into ML playlist should import folder contents, but imports the folder himself - without any content!
-- doubleclick on a ML playlist does action "play", even when "enqueue" is selected in preferences.
-- ML playlists aren't saved when closing ML anymore (like it was til 5.21), now you have to exit winamp. Not funny.

All bugs proved with clean installs of 5.112, 5.12, 5.13, 5.2, 5.21 and 5.22 on Win2k SP4.

ciao
HalloWelt

btw: for all who suffer from 5.22 ML: just replace it with 5.21 ML. Works fine here. Goto plugins dir, delete ml_*.dll, copy gen_ml.dll and ml_*.dll from 5.21. Only your playlists need help (import, identify, rename, sort - ml\playlist.xml is a good support). If you have a copy of gen_ml.ini before 5.22, just replace, it contains the playlist information for prevoius versions.

[DJ Egg]

Can't get rapidshare download to work. Try using sendspace or yousendit instead.

Attached zip is invalid/corrupt.


Reproduced:

- drag&drop of folder into ML playlist should import folder contents, but imports the folder itself - without any content!

- doubleclick on a ML playlist does action "play", even when "enqueue" is selected in preferences.

These two will be fixed for 5.23 (though there might be a separate ml_playlists.dll update available before then).

[HalloWelt]

Yes, the attachment is too large, I'm surprised it is displayed (2 large -> upload denied).

New try:
http://www.sendspace.com/file/rpfnl5


-- ML playlists aren't saved when closing ML anymore (like it was til 5.21), now you have to exit winamp.

I did further test on this topic usign FileMon.
When changing a playlist and closing Winamp, the playlist isn't saved. This happens only on Winamp exit and klick on another playlist.

But I'm astonished. 5.112 behaves the same way. I could bet it would save even on ML close. Got this impression with an crappy profile which caused Winamp to crash quite often. Changed a playlist, exit ML, playlist was saved (changes were present after crash).

Nevertheless if it's a bug or not, when changing a ML playlist and close ML, the playlist should be saved.

btw: on my in-mind bug list there is another bug - some mp3's (which are played correctly in other players) are aborted. But up to now I didn't get the opportunity to explore this. Even don't know if this is still present in 5.22.

[DJ Egg]

The two bugs I reproduced (according to my previous reply) have been fixed for 5.23

We can't reproduce any of the other reported issues.

[HalloWelt]

fixed:
- drag&drop of folder into ML playlist should import folder contents, but imports the folder itself - without any content!


still present in 5.23:
- doubleclick on a ML playlist does action "play", even when "enqueue" is selected in preferences.

recently discovered:
- When installer should move profile files from program dir to %appdata%, the file path to ml playlists in playlists.xml is not changed, they still point to %programfilesdir%\winamp\plugins\ml.

- File access erros are not handled correctly (at least in ml). If a playlist can't be opened (because it's moved by the installer...), Winamp crashes. If a playlist can't be saved (-> access rights), Winamp crashes. An information popup would be quite nice.

We can't reproduce any of the other reported issues.

Ok, i'll check this on another machine. And keelhaul my Win if it's limited to here.

[DJ Egg]

Yup, the "dbl-click on ml playlists not enqueuing" issue is known.
Hopefully it will be fixed for 5.24
For now, please use 'rt-click > enqueue' instead.

The paths issue in playlists.xml will definitely be looked into. Thanks.