CRCCheck Fails

damiant · 23rd March 2009, 20:01

When specifying "CRCCheck off" with an installation NSIS still performs the CRCCheck and reports "Installer integrity check has failed".

The situation is where I add extra bytes on the end of the installer EXE in order to customize the applications settings.

Shouldn't the CRCCheck be turned off when i tell it to be turned off within the script?

kichik · 23rd March 2009, 20:08

That message could still appear if the installer is so corrupted that it can't be read. Appending data to the installer can't cause this. Make sure you're not modifying anything else in the installer. Maybe your editor converts newlines (\n -> \r\n).

Anders · 23rd March 2009, 20:14

I don't know why it would still check, but I do know that if you append data to the end of the installer, it should still pass the CRC check so you are doing something wrong

damiant · 23rd March 2009, 20:38

Looks like you guys are right. I viewed the "before" and "after" EXE files in a hex editor and i was off by one byte. A bug in my code not yours.

I was previously using Innosetup and it worked there and i shouldn't have assumed that my code would have worked with NSIS.

By the way NSIS is an awesome way to boot strap .NET apps and actually reduces the size of the resulting EXE.

23rd March 2009, 20:01	#1
damiant Junior Member Join Date: Mar 2009 Posts: 2	CRCCheck Fails When specifying "CRCCheck off" with an installation NSIS still performs the CRCCheck and reports "Installer integrity check has failed". The situation is where I add extra bytes on the end of the installer EXE in order to customize the applications settings. Shouldn't the CRCCheck be turned off when i tell it to be turned off within the script?

23rd March 2009, 20:08	#2
kichik M.I.A. [NSIS Dev, Mod] Join Date: Oct 2001 Location: Israel Posts: 11,343	That message could still appear if the installer is so corrupted that it can't be read. Appending data to the installer can't cause this. Make sure you're not modifying anything else in the installer. Maybe your editor converts newlines (\n -> \r\n). NSIS FAQ \| NSIS Home Page \| Donate $ "I hear and I forget. I see and I remember. I do and I understand." -- Confucius

23rd March 2009, 20:14	#3
Anders Moderator Join Date: Jun 2002 Location: ${NSISDIR} Posts: 5,449	I don't know why it would still check, but I do know that if you append data to the end of the installer, it should still pass the CRC check so you are doing something wrong IntOp $PostCount $PostCount + 1

23rd March 2009, 20:38	#4
damiant Junior Member Join Date: Mar 2009 Posts: 2	My bad - it works perfectly Looks like you guys are right. I viewed the "before" and "after" EXE files in a hex editor and i was off by one byte. A bug in my code not yours. I was previously using Innosetup and it worked there and i shouldn't have assumed that my code would have worked with NSIS. By the way NSIS is an awesome way to boot strap .NET apps and actually reduces the size of the resulting EXE.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode