Old 30th July 2009, 11:01   #1
mj_blue
Junior Member
 
Join Date: Sep 2007
Posts: 13
ScrollLicence enabling too soon using RTF

Hi,

I am using an RTF file in my licence dialog and am also using the ScrollLIcennse plugin. However when clicking down through the Licence the buttons become enabled after scrolling down about 3 screesn (licence is approx 6 page downs worth).

This behaviour can be seen using the included ExampleNormal.nsi and changing the MUI_PAGE_LICENSE to a large ish RTF file.

Is there some limit on the file size that this can handle?

If I take the rtf file and save it as .txt and include this instead it then works fine.

I've attached an example licence in txt format (can't attach rtf) which if you save as rtf it shows the bhaviour

I've had a look at the cpp but can't really see why this would be happenning unless the rtf send some unexpected line code.

Thanks

Mark
Attached Files
File Type: txt licence.txt (8.1 KB, 121 views)
mj_blue is offline   Reply With Quote
Old 30th July 2009, 11:12   #2
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
Look at the readme.txt. There's a /LINES switch.

Stu
Afrow UK is offline   Reply With Quote
Old 30th July 2009, 11:28   #3
mj_blue
Junior Member
 
Join Date: Sep 2007
Posts: 13
Hi Stu,

thanks for the quick response, I did have alook at this and If I chane this (It seems to show 9 lines normally) it has a slight differences in that it gets perhaps one page down further before enabling the buttons.

I also set my line to be:

ScrollLicense::Set /NOUNLOAD /LINES 1

and this also didn't help as it it enabled when I get to about line 60 of 130

If I use:

ScrollLicense::Set /NOUNLOAD /CHECKBOX

this seems to work fine and only enables when I get to the bottom
mj_blue is offline   Reply With Quote
Old 30th July 2009, 12:13   #4
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
I'm not sure what the problem is but I do think the method my plugin uses is rather poor (in my defence I wrote it quite a while ago!)

If I have time this weekend I will re-write.

Stu
Afrow UK is offline   Reply With Quote
Old 30th July 2009, 12:18   #5
mj_blue
Junior Member
 
Join Date: Sep 2007
Posts: 13
Thanks Stu, as I said I tried to look into fixing itmyself but did get a bit lost..

As a workaround I can use the /CHECKBOX option but if you could look at it, it would be appreciated

Thanks

Mark
mj_blue is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump