Reading value from Config file to textbox

[pkonduru]

Hi All,

I have a Custom Dialog that has a few ports that the user must enter. I have some default values in them. If there a config file existing in the install directory, the ports must auto populate on the custom dialog. I have all the pieces of the code in place. I just wanted to know if there is a cleaner way of doing it. I am pasting excerpts for just one of the port. Will need to duplicate this code for the other ports also.

1)In my main nsi I have this. $PortNumber is a global variable. I grab the value of the port.

IfFileExists $INSTDIR\conf\tomcat.properties 0 pastFilecheck
MessageBox MB_OK "found the properties file"
${ConfigRead} "$INSTDIR\conf\my.properties" "port.shutdown=" $R1
MessageBox MB_OK "Port number is: $R1"
StrCpy $PortNumber $R1
pastFilecheck:

2)In my custom dialog .nsh file I have this. Check if port value exists or load the default value.

${If} $PortNumber == ''
StrCpy $PortNumber '9954'
MessageBox MB_OK "New port number is :$PortNumber"
${NSD_SetText} $hCtl_FoundationDialog_TextBox1 $PortNumber

${EndIf}
; === TextBox1 (type: Text) ===
${NSD_CreateText} 127.7u 37.54u 111.24u 12.31u "$PortNumber"
Pop $hCtl_FoundationDialog_TextBox1

[demiller9]

It looks like you are trying to set the port number into the textbox before you have the textbox handle. Did you paste the code in the order it gets used?

[pkonduru]

Hi demiller9,

Yes, i pasted the code in the order it gets called. Basically the first part of the code is from a custom page leave function which comes before the actual page that has the port information. My code works fine, I only wanted to know if there is a cleaner way of doing this.

--Pavan

[JasonFriday13]

On the very first run, this line does nothing because the textbox handle is null:

Originally Posted by pkonduru

${NSD_SetText} $hCtl_FoundationDialog_TextBox1 $PortNumber

[pkonduru]

I set the $PortNumber to 9954 if its empty/null.
So, on the first run it does show 9954.

[JasonFriday13]

That's weird, it shouldn't work but it does.