Old 20th January 2003, 16:51   #1
ThalosXenor
Junior Member
 
Join Date: Jan 2003
Posts: 7
easy (i think) fix for a known bug

ok, the coordinant bug that puts one of the playlist buttons in the wrong place can be easily resolved without making all pre-fix skins obsolete. here's what you have to do:

fix the bug in winamp. but still keep it there.

add in a text file to all new skins (just add it to the base skin, and notify the community) that winamp will look for upon loading of the skin. if the text file is there, winamp will have the button in it's proper place, if the skin doesn't have the file, it will load the skin with the bug.

Not too hard, is it? (that's a genuine question there, i know very little about programming.)
ThalosXenor is offline   Reply With Quote
Old 20th January 2003, 18:09   #2
Sawg
Guest
 
Posts: n/a
http://www.winamp.com/nsdn/winamp2x/dev/skins/faq.jhtml

Quote:
4) Some of the skin coordinates are wrong. Can you guys fix them?
In a word, no. Due to lack of quality assurance back in the days when Winamp was still shareware, a number of coordinate glitches seeped into the release version. Before we could correct them, people had already begun making skins left and right. If we make these fixes now, we will effectively render our thousands of skins obsolete. Fortunately, the errors are minor and easily worked around.
  Reply With Quote
Old 20th January 2003, 19:07   #3
ThalosXenor
Junior Member
 
Join Date: Jan 2003
Posts: 7
yeah, that's why i said the thing about the text file triggering the fixes, and no text file leaving it the way it was.
ThalosXenor is offline   Reply With Quote
Old 23rd January 2003, 18:46   #4
D-Light
Junior Member
 
Join Date: Jan 2003
Location: Montreal, Canada
Posts: 7
Send a message via ICQ to D-Light
I was thinking about the same thing because I'm sure winamp 2.x will still be used for a LONG time, and a lot of skins will continue to come out... and for this fix to work, winamp would load old skins the same way it used to do, and for new skins (would have a config file instead of viscolor.txt and pledit.txt) it would fix all those coordinates.

Here's a little example of how the skincfg.ini file could look like:

code:
[General]
TransColor = #FF00FF

[Main]
TitleBG = #FFFFFF
TitleFG = #000000
TitleFont = Lucida Grande
TitleSize = 7

[Playlist]
Normal = #000000
Current = #3966A0
NormalBG = #FFFFFF
SelectedBG = #9AC1EA
ListFont = Lucida Grande

[Equalizer]
SoftGraph = Yes // Anti-alias graph curve? Yes|No

[Minibrowser]
mbBG = #FFFFFF
mbFG = #000000
mbFont = Lucida Grande
mbSize = 7

[VisColors]
BG1 = #FFFFFF
BG2 = #FFFFFF
Peak = rgb(73,146,221)
Spec01 = rgb(116,154,219) // Top of Spectrum
Spec02 = rgb(113,154,220)
Spec03 = rgb(116,157,222)
Spec04 = rgb(119,162,224)
Spec05 = rgb(123,167,226)
Spec06 = rgb(127,172,228)
Spec07 = rgb(134,180,231)
Spec08 = rgb(109,166,226)
Spec09 = rgb(73,146,221)
Spec10 = rgb(84,158,226)
Spec11 = rgb(90,167,231)
Spec12 = rgb(95,174,234)
Spec13 = rgb(100,181,238)
Spec14 = rgb(105,189,241)
Spec15 = rgb(108,195,243)
Spec16 = rgb(116,203,245) // Bottom of Spectrum
Osc1 = rgb(134,180,231) // Brightest
Osc2 = rgb(123,167,226)
Osc3 = rgb(119,162,224)
Osc4 = rgb(116,157,222)
Osc5 = rgb(113,154,220) // Dimmest


I added a few things in here that are currently not even supported, like:

TransColor: Define a color that will make any part transparent in ANY bitmap.

Font/Size: So that the skin designer can define a font and a size for both main window (when bitmap font disabled by user) and minibrowser.

SoftGraph: Would be realy nice to have a smooth graph optional in a new version. It would looks a LOT nicer.


Note: would be nice to also be able to use 2 color formats: HEX ( #FFFFFF ) and RGB ( rgb(255,255,255) ) but if this would not be possible, then HEX is the answer
D-Light is offline   Reply With Quote
Old 24th January 2003, 10:05   #5
binary hero
Banned
 
Join Date: Jun 2001
Posts: 7,004
Send a message via ICQ to binary hero
d-light, we did try suggesting things like a pledit-ex.bmp (like the numbers-ex.bmp) which winamp uses if it is there, and uses the correct coordinates (like numbers-ex.bmp, which has the - sign)

and i'd prefer to use rgb instead of hex (simply because i believe hex to be a tool of the devil)

softgraph...i'm not too sure on, maybe have it as an option in winamp, it could use a lot of CPU (a hell of a lot in fact, having to antialias every frame...)

as for the rest of it, you have a load of good ideas.
binary hero is offline   Reply With Quote
Old 24th January 2003, 20:45   #6
D-Light
Junior Member
 
Join Date: Jan 2003
Location: Montreal, Canada
Posts: 7
Send a message via ICQ to D-Light
Yeah, actualy, for the new coordinates, -ex after the filename would probably be better.

For the HEX/RGB, I prefer HEX, because I can simply copy 1 value from Photoshop, instead of copying 3 values, but like I said in my example, would be nice to be able to use both formats.

For the soft graph, I was talking about the equalizer, not the Osciliscope. So that it looks like this: instead of this: . This can't use that much more CPU, because it doesn't change while the song plays. I also saw other players having an anti-aliased one, and it wasn't any slower.
D-Light is offline   Reply With Quote
Old 25th January 2003, 01:58   #7
ThalosXenor
Junior Member
 
Join Date: Jan 2003
Posts: 7
Yeah, D-Light's got what i'm saying. then you could keep support for the other three text files, and that way all the old versions would works, as well as the new versions... I think... right?

With the soft graph, you could always make it so that the user has like... 3 or 4 spaces of horizontal pixels (and one of them maked as the center of that pixel set), where they can set it to lighter colors that'd blend into the background of the vis thingy. (but again, that would post the trigger question, where the text files in the .wsz file just trigger different reactions from winamp.)

But i think what Binary ment about anti-aliasing every frame, was the horizontal rows of the image for the eq-vis thingy would have to be antialiased. could always be wrong tho.

bit instrad of skincfg.ini, i think it sould probably be skincfg.txt
ThalosXenor is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Wishlist

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump