My plugin - gen_library.dll

[hniu]

Originally posted by Joonas
Well..since Search mode searchs all files and folders from all your nodes a file you click on doesn't necessarily belong to the folder you selected. Thus I can select U2 folder and an Elvis mp3-file. Alt+G would then take me to the U2-folder and Ctrl+G would take me to the folder where the Elvis mp3-file reside. That is different no? Also if I understand what you want correctly it does work like that...I think perhaps you're confused since Ctrl+G seems to be broken...but if you choose Go to folder from the menu both jump to Browse mode yes?

I was using the wrong terminology. Yes you can select file and folder at the same time, which do not belong to the same place. When I meant selected, I meant the one that is highlighted in blue (selected and active). For example, if you select folder it will be highlighted in blue, but if after that you select a file, the folder will turn white and the file will be blue instead (selected and active).

I don't really think this feature is very important, just thought it is logical...

I think I see your point but that all depends on whether you have that kind of directory structure...if you go deeper and have like Albums - Pop&Rock - Artist - Album how will I know how deep it should search for sub-folders? Would kinda suck if it doesn't find Artist since it doesn't scan deeper than Pop&Rock no?

I didn't mean searching one level only, I meant stop going further down, when you do find a folder. For example:

-pop&rock
----art11
---------alb11
---------alb22
----art22
---------alb33
---------alb44
-pop
----art33+art11
---------alb55
---------alb66

if you search for "pop", you get:
-pop&rock
-pop

if you search for "art11", you get:
-art11
-art33+art11

if you search for "alb22", you get:
-alb22

And so on... This is not good, if you are looking for something you cannot find (that is why there should be a choice), but it is very helpful if you want a quick access to artist's folder or album's folder. Just type the name, select the result and go to browse mode.

Cheers,

[hniu]

sorry... I posted the same thing twice and I can't delete this message now...

[Joonas]

* Fixed Alt+S for focus search field and Alt+M for switching modes. Also works with modern skin now...
* Fixed playlist being cleared when folder is empty
* Fixed issue with D:\ becoming D:\\
* Fixed menu not being checked in classic skin.
* Fixed Select all on menu
* Fixed window being hidden when in modern skin (again..)
* Introduced hniu:s folder search in preferences (at least I think this is what he means )

/Joonas

[hniu]

Originally posted by Joonas
* Introduced hniu:s folder search in preferences (at least I think this is what he means )

Yes, that what he meant!!! It is really cool thanx for that!

Few small issues about playlists (I maybe wrote about it before, but the are not that many things left to change, you know ):
- When you enqueue a folder with both audio files and playlists DL enqueues files twice (actual files + files from playlist). I think playlists should have a priority.
- It would be nice, if playlist files have slightly different appearance from media files. Italics maybe?

Also, I liked siebe83's suggestion about a column with track numbers.

Cheers,

[electricmime]

could you add an "open" feature.. so we can open things that cant be opened in winamp? (i know this isnt meant to be a replacement for explorer, and i dont plan on using it for that, but some of the stuff i dl has no track number/title, so you have to open the txt file included to get that info, and this would prevent having to go to exploer, either manually or by go to folder)

[Joonas]

I guess I could add an open...but for what filetypes should you be able to "open"? And in what program?

As for columns...the trouble with adding new ones is that I use a switch to decide what to put there...if any is removed it mess up...guess I could use an if-statement instead...anyone knows if if:s are much slower than switch? (I've heard sometimes that you should use switch if there were massive amounts of data going through it...)

/Joonas

[siebe83]

maybe this is an idea?
http://forums.winamp.com/showthread....34#post1348034
it's a plugin made by shaneh, it puts a submenu in the playlist popup menu, with all options as in explorer context menu...
Though it's Shaneh's idea, so i don't know how he'd feel you copying it...

I don't know of any coding, sorry...

[electricmime]

Originally posted by Joonas
I guess I could add an open...but for what filetypes should you be able to "open"? And in what program?

As for columns...the trouble with adding new ones is that I use a switch to decide what to put there...if any is removed it mess up...guess I could use an if-statement instead...anyone knows if if:s are much slower than switch? (I've heard sometimes that you should use switch if there were massive amounts of data going through it...)

/Joonas

well, i would assume it would just open in the program you chose as default, and what filetypes would be whatever you put in the little extension thing (so if i added txt;mp3;flac it would show txts too, and when i double clicked on a txt, or right clicked and open, or however you want to do it, it would open it up as if i double clicked it in exploer..)

[Paparazzi]

Originally posted by Joonas
I guess I could add an open...but for what filetypes should you be able to "open"? And in what program?
/Joonas

Nice idea by electricmime. Maybe it could be split to "Open" & "Open in Winamp". This could the solve the "Problem" that BahramA has . It could be used for opening *.dat (Vcd) files in winamp!

Cheers

[siebe83]

Some (modern AND classic) skin issues (see screenshot):
1. on decreasing width of listview, sometimes a little black line of the search bar remains (looks as if the search bar has a mininum width or something...)
2. a horizontal line beneath 'browse folder' (or 'matching folders') is used by two areas, i think...
3. the mode buttons do not want to disappear on decreasing width of the listview

1&3 appear most visibly on slowly decreasing the width of the listview
2 is visible on opening library (until you select the folder panel: then only 2px of the scroll bar will be covered by the area above it)

4. increasing the width of the PLUGIN will make the mode buttons look weird: it seems as they are not refreshed, or not correctly relocated...

5. by accident move the folder/songs panel divider to the uttermost right, and you'll lose the song panel
you can get it back by increasing the width of the plugin
BUT: moving the divider to the uttermost left, and there'll be no way to get it back! (only mode buttons are still visible, see point 3)
I had to make WA crash to get my songs panel back...

btw: This is not the way I mostly use DL
Just tried to find bugs...

[siebe83]

off course i forgot the attachment

[Joonas]

Open & Open with Winamp? Isn't Open with Winamp the same as Play?

Some issues has been dealt with as for the problem with the window redrawing. Some of the remaining (i.e. Mode buttons) is strange...hopefully they will be resolved later.

/Joonas

[billyvnilly]

"explore this folder" doesnt seem to be working for me. Evertime i try it, winamp crashes w/o error report.

Im running winXP pro sp1
5.03 w/ update
dynamic lib, Dro's pluginpack, albumlist2, and nxsballon are installed.

[Joonas]

Originally posted by billyvnilly
"explore this folder" doesnt seem to be working for me. Evertime i try it, winamp crashes w/o error report.

That's really strange...nothing fancy going on there. Just executing Explorer on that folder...
It happens both in Search and Browse mode? If you run the plugin clean without the other plugins does it work then?
Would be good if I could reproduce it myself to figure out what's causing it.

/Joonas

[siebe83]

Would it be possible, if a whole folder or multiple songs are PLAYED from the DL, and shuffle is enabled, that a random song of the list would be played? (instead of the first one)

Also, would it be possible to sort this way:
A,a,B,b,C,D,e,F
instead of the way it is now:
A,B,C,D,F,a,b,e
(already mentioned before I believe, but I don't remember you answering it; if you did, I apologize... )

[Joonas]

Well, I guess I could set it to pick one at random. Though no actual playing is taken place in DL as you know. It just puts all the songs in the playlist and the playlist decide whether the songs should be played with shuffle. Although...is it wise to play one at random? If you pick several songs from a folder and choose play isn't it likely you want to play one of those songs even though you might have more songs? And if you pick a whole folder...well you will hear all the songs eventually. Does it matter that it is the first one or a random song at the very start?

I dunno...I can add that functionality just wants to express my thoughts ont it

Today was a slack day...nothing done really. Sorry...

/Joonas

[siebe83]

I meant, selecting some songs, right-click -> play
So only those files will be in the playlist, so one of these will be played.
I often right-click my 'music' folder and click play. It will always start with the same song. It isn't a big issue, but I thought it would be nice not to have the same song started all the time...

[billyvnilly]

Originally posted by Joonas
That's really strange...nothing fancy going on there. Just executing Explorer on that folder...
It happens both in Search and Browse mode? If you run the plugin clean without the other plugins does it work then?
Would be good if I could reproduce it myself to figure out what's causing it.

/Joonas

I did clean install w/ just ur plugin. Tried both classic and modern skin. Tried both search and browse mode. This is the exact same pattern i get. I try to explore it once and nothing happens, i try to again and winamp closes w/o error report. One time i did get winamp report involving ntdll.dll...does this have anything to do w/ dl?

[Joonas]

Originally posted by billyvnilly
I did clean install w/ just ur plugin. Tried both classic and modern skin. Tried both search and browse mode. This is the exact same pattern i get. I try to explore it once and nothing happens, i try to again and winamp closes w/o error report. One time i did get winamp report involving ntdll.dll...does this have anything to do w/ dl?

ntdll.dll sounds like an old bug...sure you're using the latest release? I think I rooted that one out. As for explore it calls ShellExecute and just tells Windows that it wants to explore a specific folder, so I dunno. Anyone else experiencing this problem?

/Joonas

[siebe83]

Would it be possible to have the root folders folded up on opening DL? (so not unfolded as it is now)

Also, it might be practical to have some sort of notification when a root folder is not present. Now it just shows the root folder as if it has no content.

[Joonas]

* Further fixes to key shortcuts. Some didn't work properly when switching between modern and classic.
* You can now hide unwanted columns. Right-click on the columnheaders bring up a menu. Try if it works...kinda late so I might've been doing something wrong

As for unfolding...I especially made it unfold since I didn't like it not to...but I guess it should be unfolded or "optioned"

[edit]and yes I've noticed that length of tracks aren't displayed properly, 3:01 becomes 3:1 but I will fix tomorrow [/edit]

/Joonas

[billyvnilly]

Originally posted by Joonas
ntdll.dll sounds like an old bug...sure you're using the latest release? I think I rooted that one out. As for explore it calls ShellExecute and just tells Windows that it wants to explore a specific folder, so I dunno. Anyone else experiencing this problem?

/Joonas

yes, ive downloaded ur plugin almost religously everyday. I have the latest version that i know of. Perhaps start numbering your alpha/betas whatever...but that error messege is very very rare, most of the time i dont get anything. R there XP users out there that have it working?

[siebe83]

i'm using XP SP1 and it used to work for me
though the latest release, it won't do anything
it's not only with 'explore this folder': none of the right-click menus work any more -> the menu pops up, but clicking an option doesn't do anything...
[edit]
the right-clicking menu does not work properly in both the songs and the folder panel: clicking play, enqueue, view info, go to folder, etc. -> nothing does anything [/edit]
so i think this is another issue...

as i said, 'explore this folder' always worked fine...

btw, the columns are great!

[hniu]

As we are talking about folding/unfolding folders. One small thing: would it be possible to make the folder unfold automatically when you are going to it through "go to the folder" function or when switching from "search" to "browse" mode with folder selected?

Cheers,

[Joonas]

* Fixed the menus.

Actually as I lay down last night to sleep I realized that the menus probably wouldn't work...talk about sleepless night The columns required some tuning of menus which I accidently applied to all menus.

Originally posted by hniu
As we are talking about folding/unfolding folders. One small thing: would it be possible to make the folder unfold automatically when you are going to it through "go to the folder" function or when switching from "search" to "browse" mode with folder selected?

When you pick "go to folder" doesn't it already unfold? As for the selected folder switching...I'll think about

As for billyvnilly:s problem...it's might strange. As I said before ShellExecute is a Windows API command and it shouldn't cause any problem, and surely not cause Winamp to crash

Anyone brilliant who knows any issues with this?

I've added some try and catch code...let's see if it works. Can't try it myself since it doesn't crash for me...

/Joonas

[siebe83]

all right, menus are working again
you know what you are doing

hope this release'll fix billyvnilly's prob as well...

question:
in the options of DL it says settings on file extensions will only have effect after closing and reopening DL
for me, it will only after closing and reopening winamp...
would it be possible to have some refresh function inside DL?
(or change the text in the options, maybe? or make it really take effect on closing/reopening DL, but that might slow down opening DL the second time, and i don't want that )

[Joonas]

That text is correct, it is the code that's not

Same problem that DL doesn't refresh if you move some mp3s while DL is closed causes it to not refresh when you change filetypes. Will have a look at that now as I feel we're finally seeing the end of this *wipes sweat off his forehead*

/Joonas

[siebe83]

A lot of posts ago I mentioned a sorting problem in search mode. I think I have an idea what it's caused by, but i'm not sure...

My two values in the registry:
MP3 Directory="C:\Gedownloade bestanden\Kazaa" (still used btw?)
Root nodes="C:\Gedownloade bestanden\Kazaa;C:\Geluiden\Overig;C:\Gedeelde map;C:\Geluiden\Testmap;C:\Documents and Settings\Siebe de Korte\Bureaublad;C:\Server;C:\Geluiden\Muziek"

When I press the 'search mode' button, I will see the songs in "C:\Gedownloade bestanden\Kazaa" listed first. As soon as I scroll down, right, or select the songs, those songs out of the window or getting selected will refresh to the songs in "C:\Documents and Settings\Siebe de Korte\Bureaublad" (ie, the songs that should be listed first in the first place)

after that I changed:
Root nodes="C:\Geluiden\Overig;C:\Gedownloade bestanden\Kazaa;C:\Gedeelde map;C:\Geluiden\Testmap;C:\Documents and Settings\Siebe de Korte\Bureaublad;C:\Server;C:\Geluiden\Muziek"

And guess what: the same happens, but with the songs in "C:\Geluiden\Overig"

So maybe, make the root nodes automatically ordered in the value, or make the listview refresh correctly.

It's easier to reproduce (if it's reproducable...) when you type something in the search bar. For instance 'b', so songs of different roots with a 'b' in it will appear.

[siebe83]

wasn't really clear what i meant, i guess
here's a screenshot...

the only thing I did was type 'ky b' in the search bar, and after that I clicked the second song in "C:\Geluiden\Overig"

if you select all files, it will all be ordered correctly (ie the songs in "C:\Geluiden\Overig" will appear at the bottom)

[billyvnilly]

no, "explore this folder" still does not work!?! which is even more odd because DrO's Find File on Disk does work for me.



btw i do like all the columns. Great job.

[Joonas]

How is your root structure then? Is the root on a network disc? A removable disc? Is there anything else that you can think of that might cause this?

DrO: if you read this...does your FindFile plugin do anything in particular? Your expertise would be highly appreciated

/Joonas - the know-it-not...

[Joonas]

* Length of file is now displayed properly.
* Might have fixed the update of items that siebe noticed...I stress the might
* Fix of refresh on change when window isn't open and on change of filetypes

/Joonas

[siebe83]

don't know anything to post
as far as i see, you fixed it

[billyvnilly]

Originally posted by Joonas
How is your root structure then? Is the root on a network disc? A removable disc? Is there anything else that you can think of that might cause this?

DrO: if you read this...does your FindFile plugin do anything in particular? Your expertise would be highly appreciated

/Joonas - the know-it-not...

No, my root struc is just normal, im just on a home computer. winamp and my music are on C: drive, along with OS. See i cant think of anything else...i havent messed with explorer.exe or the windows folder at alll.

And dont sell urself short...this is a kick ass plugin and u were the first to build it for winamp5...go BETA testing!

[Paparazzi]

I've got almost the same problem. In my case, I am able to "Explore this folder", but I am NOT able to "Go to folder".

Another problem I have is that I have now started using the Winamp 5 Single UI skin. This one takes up a lot of the desktop. I have placed the Dynamic Library on top of this skin. Now, if I click on any other program and WA goes to the background, calling up WA again makes the Dynamic Library window fall behind the WA. To see it, I either have to move the WA out of the way or press Alt+D first to remove the DL and then again to bring it up in front. Is there no way to make it remember that the DL was on top of WA when WA was sent to the back initially? Wonder if that made sense.

The DL itself is now 99% perfect and almost set to be ported to the ML!

Cheers

[Joonas]

Gah! Go to folder doesn't work either??? What kind of systems are you running really? ;P What kind of behaviour do you experience then? I don't suppose Winamp crash here to? And in what mode? You're using the menu or the shortcut? Some info plz

Anyway, as for the on top issue...that's something that Winamp handles itself I think...best I can do is give you a hotkey for bringing DL to front...would that help?

/Joonas

[Paparazzi]

I know you must be pissed of after having done all that work to come up with lame reports like that!

Anyways, I use WinXP Pro on a PIV 2.4Ghz 512DDr, WA 5.03a and the DL is the latest as I downloaded it just before sending that post.

For me, On the left pane, if I right click on any folder and choose "Explore this Folder", it works perfectly... goes straight there. On the right pane, if I choose a song and the right click to choose "Go to folder", nothing happens.

Regarding another key to bring it to the front, don't bother, I think it would be easier to just press Alt+D twice!

Also, is it set that the left pane width cannot be reduced beyond the width that is set now? I wanted to make it only as wide as the largest folder name width.

Cheers

/edit/ Just cleaned the registry and the "Go to folder" now works! Thanks

[Joonas]

I'll take it, it works then? I'm not pissed...it's just a bit frustrating when bugs come up that I can't reconstruct since it makes it quite impossible to figure out what the problem is...

As for the size, I will let it drop some more...I don't want it to be able to become infinitely small though since you must always be able to restore it. Before if you dragged to far at either side it just disappeared

But now it's 150 pixels..so let's say I drop it to some 100 or so.

Will add playlists now

/Joonas

[billyvnilly]

Originally posted by Paparazzi
I know you must be pissed of after having done all that work to come up with lame reports like that!

/edit/ Just cleaned the registry and the "Go to folder" now works! Thanks

how do u clean ur registry? Can i clean it safetly since "explore thsi folder" uses windows? perhaps this could be my problem as well?

[Joonas]

Find this folder in the registry:

HKEY_LOCAL_MACHINE\SOFTWARE\Little Bear Software

Delete it. You have to set up your root folders again but nothing that could cause it to fail will be left. Be certain you only select this folder though as messing up your registry is a safe way to have your work cut out for you (á la reinstallation of Windows )

Although I dunno what it was that was messing up Go to folder...

/Joonas