My plugin - gen_library.dll

[Joonas]

Ah, when you use the keyboard it does show up...
will look at it.

[edit]
* No focus rectangle

This version: v0.9.8.5e
[/edit]

/Joonas

[Joonas]

* Tried to implement a request from billy...Remove broken files have become Repair broken files. It works like this...instead of just removing a filepath that isn't valid DL will ask if you wish to update it. If you say no it will just remove it, Cancel will abort the whole operation...
If you answer Yes, it will pop up a select directory dialog where you can select the new path...if the path is correct it will update the playlist. If not it will just say that it couldn't find the file there either and it will all iterate...

To make this more painless though DL will remember all paths that you tell it...(not forever...just this one operation) and will attempt to find other files too...good if you have a playlist with lots of party songs and just moved the party folder...

Hope this explains some of what I meant...I guess it should be able to remove that question everytime though...and just attempt to update...I dunno.

What do you guys think?

This version: v0.9.8.6

/Joonas

[siebe83]

Complicated...
Not to use, but to make it work properly, I mean...

Anyway, I tried a bit, and Winamp crashed a few times:
I got a playlist with one broken link. I select 'Repair broken links'. Dialog pops up, I click yes and I point it to a wrong folder. Same dialog pops up again, I click yes again, and I point it to the same folder, or to another folder (wrong or right folder doesn't matter). Winamp crashes:
AppName: winamp.exe AppVer: 5.0.0.7 ModName: gen_library.dll
ModVer: 0.0.0.0 Offset: 00009f84

I got a playlist with one broken link. I select 'Repair broken links'. Dialog pops up, I click yes and I point it to a wrong folder. Same dialog pops up again, and I click No. Winamp crashes:
Runtime error.

I didn't test with multiple broken links yet...

I like the idea and if it worked without crashes it'd be a really great feature (and I think you can do it ).

-----------

As for the no focus rectangle. What happens now is that the longest folder/playlist name has a white bar at the right. The longest in that it stretches the most to the right of all folder/playlist names. See screenshot.
If I fold the folder 'Testmap', the same happens with blahblah.m3u[edit --> hopefully more clear]it happens with blahblah.m3u instead of test.m3u[/edit]
(in that little white bar, the dotted line will appear as well, as soon as keyboard has been used)

[jojo 544]

Sounds awsome !!!

If this is what i think it is i'm looking for stuff like this looooooooong time now.
Gonna try it right away and report to U later

Edit: Yes, like Siebe i get crashes to, but hey, that's why we're testing right? if this could work it would double the value of the whole plugin (for me at least )

[billyvnilly]

awesome joonas, very awesome. the way it is now, if you have multiple files that should be in the same folder, it asks on the first one, and guesses on the rest correct...

i had a playlist and everything was in album...i then put everything into album\cd\ when the first one asked, i clicked yes and pointed to the correct folder, but on the rest i clicked yes, and nothing popped up. is it guessing/assuming?

also, how hard is it to do it to where you point to the actual file, ino alot of people would like to point at renamed files.

[jojo 544]

I'm sure you remember this threat

http://forums.winamp.com/showthread....light=filepath

This plugin also came up there:
http://www.winamp.com/plugins/details.php?id=100248

I had contact with the author a few weeks ago, and he is intressed to re-write his plugin but he's very busy so it might take some time. He asked me what exactly i wanted the plugin to do. I think he wants to do a complete new stand alone program to fix playlists.

If you could pull this off in DL i'll mail him to forget about it and someone else was faster

I mean like you try to make it now in DL we can browse for a folder to find the new link to the broken file. Why not make DL look for it? (like the search mode does when look for string '(file entry of broken link)'

I give you the same wishes i had send the author of m3u checker, maybe you get some ideas, just see if you can us some:

When no exact matches for broken links are found, i would like to be able to set some options to find simular files like:

a)filename and tittle are found in full path (f.e.' The Pool - Jamaica runnin' is changed to 'F:\My Music\vinyl\The Pool - Jamaica runnin 12''/a1 Jamaica runnin'
b)Only tittle is match
c)Artist and some strings of tittle match (f.e. ‘Neon – waves’ has changed to ‘Neon – Waves (full version)’
d).... (some more configurable options)
[edit]When found some alternative matches i like the plugin to give a list of those to choose from, or if non of them is ok, the option to manualy browse for the file, or if the file no longer exists, the option to skip and go to next.[/edit]

If this is all to much maybe save it for a later version.
Anyway this makes me jump and cheer

[Dick65]

Joonas
Remove broken files have become Repair broken files.
...
If you answer Yes, it will pop up a select directory dialog where you can select the new path...

Another great feature.
I currently use PlaylistRepairer to do this. Pretty much what JoJo is talking about.
The a/m tool has automated searches, too - but that's not necessary as far as I'm concerned. Just being able to browse for re-named files would be great.

.

Talking 'bout playlist repair: Is there a way to move a track up or down in a playlist? I can't do it!

[jojo 544]

Originally posted by Dick65
Another great feature.
I currently use PlaylistRepairer to do this.

Waw, i didn't know this one. pitty the homepage is in German (i don't understand very well) and it doesn't seem to find ogg files for replacements. but it could be usefull.
Thanks for posting that link

[Joonas]

Originally posted by billyvnilly
awesome joonas, very awesome. the way it is now, if you have multiple files that should be in the same folder, it asks on the first one, and guesses on the rest correct...

i had a playlist and everything was in album...i then put everything into album\cd\ when the first one asked, i clicked yes and pointed to the correct folder, but on the rest i clicked yes, and nothing popped up. is it guessing/assuming?

also, how hard is it to do it to where you point to the actual file, ino alot of people would like to point at renamed files.

* hopefully some bug fixes

Haven't looked at the drawing bug yet though...

Point to the actual file is somewhat trickier...seems like DL (or Windows?) does something to the file causing the whole root to refresh...

To move files in a playlist hold down Alt+Dragging it...should perhaps mention this somewhere :P Or put Ctrl+Drag to move/copy and just draggint to move?

I like your ideas jojo...but some of it would be a drag to put in :P

This version: v0.9.8.6b

/Joonas

[billyvnilly]

joonas would you be willing to do it as a seperate ml plugin as well (is it too diff't?) Ino u arent a ml guy. but bc there is no sidecar in WA5 most users have been bent to the will of importing playlists to the ml

[siebe83]

woot, I didn't even know it was possible to change the order in a playlist
(or is it new?)


umm, maybe normal dragging just be moving (inside a playlist), and dragging with right-mouse button is moving/copying
dunno...

oh, btw: atm when you drag a file inside a playlist, it displays the + sign. Shouldn't that be a O with / through it? (just like in folders)

[jojo 544]

Little thingy: (not realy a bug but a bit funny)
In pref's the about box can be opened again when it's already open, as many times as one loves to
Maybe my ideas were indeed a bit to much to put in
( offtopic: For all who cares: i'll post a reply in the auto update thread when i get news on that other plugin, if anyone else has other tips like Dick65, i'd love to know about)

[Joonas]

Okay...new stuff.

* You can browse for the specific files as well as a folder...all folders will be stored and checked so if you just moved the entire files you will only be asked once...

* New dialog for this too...hopefully not too many new bugs :P

* As for dragging...fixed so it doesn't look like you can drag when you really can't...thanks siebe!

Right-drag would mess up the right-click menu...so I dunno what to do there. Any other ideas?

* You can only click once on the About button now.

* Dirty fix to prevent faulty drawing in the treeview too

This version: v0.9.8.6c

[edit]
"moved the entire files" should of course be "moved the entire folder of files"
[/edit]

/Joonas

[Dick65]

Joonas
* You can browse for the specific files as well as a folder...all folders will be stored and checked so if you just moved the entire files you will only be asked once...

Damn awesome !!!

Joonas
Or put Ctrl+Drag to move/copy and just draggint to move?
Joonas
Right-drag would mess up the right-click menu...so I dunno what to do there. Any other ideas?

Agree that right-click would not be good. I'd prefer:
Drag to move inside the playlist.
CTRL+Drag to copy.

Would it be possible to copy within the same playlist as well?

[Joonas]

Originally posted by Dick65
Agree that right-click would not be good. I'd prefer:
Drag to move inside the playlist.
CTRL+Drag to copy.

Should it then be Ctrl+Drag everywhere? Cause you can't right now copy from playlists...

Would it be possible to copy within the same playlist as well? [/B]

I guess...rather not though *lazy* :P

/Joonas

[Thunder Pussy]

Hi. There's a weird behavior with the most recent beta. The only columns available are path, last changed, and comment. When artist, etc are checked the column heads disappear and a great deal of whitespace appears to the left of the path column. When closing & reopening dl the column head reappears. The Year column works but not track, artist, length, album, or #--they appear as whitespace. Attached is a pic.


Regards,

[siebe83]

Originally posted by Joonas
Should it then be Ctrl+Drag everywhere?

You mean when dragging from a 'folder listview' to playlists or other folders? Rather not. I mean, in that case normal dragging wouldn't do anything while it's easier than ctrl+dragging...

Btw, there really should be some kind of readme coming with this plugin, especially with all those hidden features

Cause you can't right now copy from playlists...

I don't get the connection

[edit]oh wait, what I quoted was a reply to someone; this really confuses me

Wait, I got an idea. Maybe make it so that when you drag INSIDE a playlist, it moves (i.e. changes order), and as soon as you get outside of the listview you can drag to other playlists or to the main window/playlist.
Mmh, maybe too complicated/buggy/unpredictable.

Actually, maybe just leave it as it is
I really prefer to have normal dragging to drag files to the main window/playlist editor (from folder and playlist listviews). I think it's better to have one exception (i.e. changing order in playlist) than to mess up the way you can add files to the playlist editor now.


I'll check out the repair broken links thingie later...

[edit2]
Oh, and I don't have the column problem ¿¢? reported...

[Joonas]

Originally posted by ¿¢?
Hi. There's a weird behavior with the most recent beta. The only columns available are path, last changed, and comment. When artist, etc are checked the column heads disappear and a great deal of whitespace appears to the left of the path column. When closing & reopening dl the column head reappears. The Year column works but not track, artist, length, album, or #--they appear as whitespace. Attached is a pic.


Regards,

Strange...have you used any other beta the past few weeks? Cause this shouldn't be due to anything in the latest beta...long time ago since I touched that code.

[edit]
You can always try to "Delete preferences" under the Root tab in Preferences if you can't solve it...that will delete all settings.
[/edit]

/Joonas

[Thunder Pussy]

Originally posted by Joonas
Strange...have you used any other beta the past few weeks? Cause this shouldn't be due to anything in the latest beta...long time ago since I touched that code.

[edit]
You can always try to "Delete preferences" under the Root tab in Preferences if you can't solve it...that will delete all settings.
[/edit]

/Joonas

Delete preferences fixed it. I've been using betas all along, and updating it when each new beta comes out, so maybe it was something cumulative that caused it. It's a mystery. Everything's back how it should be now. Thanks much, ¿¢?

[Joonas]

Glad it worked though.

Anything else? Anyone?

/Joonas

[Dick65]

Joonas
Should it then be Ctrl+Drag everywhere? Cause you can't right now copy from playlists...

No need for copy-to-folder (ie harddisk), I guess. Copy-to-playlist is sufficient.

For moving inside a playlist I still prefer DRAG (over ALT+DRAG) as it is standard Windows behaviour.

[Dick65]

Siebe83
Btw, there really should be some kind of readme coming with this plugin, especially with all those hidden features.

Same here! Readme would be helpful. Also to further explain the preferences.

[jojo 544]

There seems to be something broken for saving playlists again I mean when i make changes in a playlist that is in a treeview folder i can't save them no mather how i try.

I agree on the drag instead alt drag; and a read me sure would be nice.

[Joonas]

Originally posted by jojo 544
There seems to be something broken for saving playlists again I mean when i make changes in a playlist that is in a treeview folder i can't save them no mather how i try.

I agree on the drag instead alt drag; and a read me sure would be nice.

I think I disagree. It is better if Drag is always drag in the entire plugin and not different just because you're in a playlist...I also think it is more often you wish to drag files to Winamp or to a playlist than you wish to move. I do agree that the Alt+Drag must be noted somewhere so people now about it.

* I think I've fixed the save bug now

This version: v0.9.8.7

Happy new year!

/Joonas

[siebe83]

When dragging a file from the listview (from playlist or folder, doesn't matter), next to another folder/playlist in the treeview, nothing happens while the + cursor is displayed and the folder/playlist next to it is highlighted. A bit confusing. See attached screenshot for better explanation.

So I tested this 'Repair broken links' feature a bit (from now on called RBL). What's the idea of 'Skip'? For me, it just removes the file from the playlist. That's the idea? If so, maybe mention it. (I expected it to just leave the entry alone, i.e. leave the dead link in the playlist)
'Skip all' DOES leave the file(s) alone though...
If you choose to make 'Skip' leave the file alone, it'd be nice to have a button 'Remove (from playlist)' and maybe also 'Remove all'.

Why does the x button in top right corner of the dialog not work? It would be nice if that button canceled the whole operation.

"Browse directory" should be "Browse folder" (since you call it 'folder' everywhere).

---------

When I have two dead links in a playlist, select RBL, and press 'skip' for the first one (and it removes that file from playlist), sometimes the dialog doesn't even come up for the second one. I have to select RBL again to be able to handle the second dead entry. If I then choose 'Skip' again, sometimes it crashes (Runtime error). I also got weird file numbering once (i.e. two files in the playlist, numbered 1, 3).
I can't be more clear in this case, I can't find a good reproduction method. Maybe check the code for the Skip action...

---------

Maybe related to previous issue... (really confusing: some errors seem to be related, but again in different circumstances, dunno...)
When a file is missing > RBL > Browse directory > Cancel > sometimes missing file will be removed from playlist, in that case playlist numbering is wrong, sometimes I get a runtime error...

---------

Heh, I got this error: "An error occured. File update failed since file was not present in memory. Please report this." So here I am
Here's what I did: I got a file in a playlist, a.mp3 supposed to be in folder F. Actually that file is in folder F/SF. So I did RBL, and pointed it to F/SF (using Browse directory*) and DL updated the playlist.**
After that I moved the file to folder F***, and again did RBL and pointed DL to folder F****. Then I got that error.

* The same happens when using 'Browse file' instead of 'Browse directory'.
** I also tried with saving playlist at this point.
*** I also tried moving the file to a completely different folder E > same error.
**** When I choose 'Skip' (instead of 'Browse xxx') at this point, DL will crash: Runtime error.

---------

So I put the same file in a playlist twice: b.mp3 pointing to folder D. Actually b.mp3 is stored in folder E. RBL > I point it to folder E. After that, one of the b.mp3 entries is updated. The other isn't!
So according to the playlist, I now have one b.mp3 in folder D (non-existing), and one in folder E. So I do RBL again. It comes up with the file b.mp3 in folder D, and I say it's in folder E*. Nothing happens! Only after a restart of Winamp > RBL > point to folder E, it updates the second entry correctly.
* If I choose 'Skip' at this point, it will remove the correct (i.e. the previously updated one pointing to folder E) b.mp3 from playlist (and leave in the wrong one)

---------

A missing file in a playlist will display a Last changed date of 01/01/1601 01:00
Maybe that should just be a 'n/a'?
Also, after updating the file, the tags are read and displayed, but the Last changed date stays the same (01/01/1601 01:00) until a Winamp restart.

---------

That's what I came across till now... Nice feature and I hope you can sort it all out

Happy new year!

just got home, I wrote this earlier today, but internet didn't work > now it does

[Joonas]

Okay...

I've dropped the Browse file option. It just introduced way too much specials...like what if you add another playlist instead of a file...yikes! No no...if you want to totally change it you should remove and re-add later...

Other than that I rewrote most of the code. See if it solved any of the bugs you found...I couldn't recreate most of them so I dunno... :/

Also fixed so if you drag it doesn't look like that you can even though you're not even close to a node. And n/a for Last changed for files not found.

This version: v0.9.8.8

[edit]
Noticed that the text doesn't fit in the dialog. Will fix it until next version.
[/edit]

/Joonas

[Cianca]

Hi joonas

Your plugin is amazing!!!!

I have 2 questions/request:


1) When i play a selected sub-folder there is an options to automatically sort the folder tracks when that folder contain an .m3u list???


2) There is a way to integrate this plugin in winamp media library???

So the media library will show:

- Now playing
- Local Media
- Playlists
- Dinamic Library


thanx

[electricmime]

what exactly does the repair broken links thing do? does it just change it in dynamic library.. your playlist.. or your media library entries as well...

for example.. i usually rip to my c: drive, but later(when i feel like it or make room for it) i move it to my second hd.. will this change all the links in my playlist as well as update the links in the ml if i added them

[Joonas]

Originally posted by Cianca
1) When i play a selected sub-folder there is an options to automatically sort the folder tracks when that folder contain an .m3u list???
[/Quote]

No. Sorry.

2) There is a way to integrate this plugin in winamp media library???

So the media library will show:

- Now playing
- Local Media
- Playlists
- Dinamic Library

Originally posted by electricmime
what exactly does the repair broken links thing do? does it just change it in dynamic library.. your playlist.. or your media library entries as well...

for example.. i usually rip to my c: drive, but later(when i feel like it or make room for it) i move it to my second hd.. will this change all the links in my playlist as well as update the links in the ml if i added them [/B]

Dynamic Library has exactly nothing to do with ML

/Joonas

[siebe83]

This one is still reproducable for me. (I edited it a bit to adjust to new situation)

Originally posted by siebe83
Heh, I got this error: "An error occured. File update failed since file was not present in memory. Please report this." So here I am
Here's what I did: I got a file in a playlist, a.mp3 supposed to be in folder F. Actually that file is in folder F/SF. So I did RBL, and pointed it to F/SF (using Browse folder) and DL updated the playlist.**
After that I moved the file to folder F***, and again did RBL and pointed DL to folder F****. Then I got that error.

** I also tried with saving playlist at this point.
*** I also tried moving the file to a completely different folder E > same error.
**** When I choose 'Remove' (instead of 'Browse folder') at this point, DL will crash: Runtime error.

In the 'Repair aborted.' dialog it says "Some or none of the files has been updated."
Should be "Some or none of the files have been updated." (maybe a native speaker could confirm this?)

Other bugs seem to have gone

[billyvnilly]

file has
files have


...correct

[Joonas]

Okay, siebe - how about now?

This version: v0.9.8.8b

/Joonas

[paul spino]

joonas
i always wished the winamp library would show the albums in a tree view then i stumbled across this plugin about a month ago. i just downloaded the latest version and it's awesome. great job joonas. is there anyway to have the cd drives, the streaming media and the options to rip,eject etc. Incorporated into your plugin.if that was possible there would be no need for winamp library.

[Joonas]

Originally posted by paul spino
joonas
i always wished the winamp library would show the albums in a tree view then i stumbled across this plugin about a month ago. i just downloaded the latest version and it's awesome. great job joonas. is there anyway to have the cd drives, the streaming media and the options to rip,eject etc. Incorporated into your plugin.if that was possible there would be no need for winamp library.

Streaming media - no
CD-drives - you can always add them as roots?
Rip, eject etc - no

DL isn't meant to replace Media Library. At least not in this version. Sorry.

But glad you like it

/Joonas

[siebe83]

Originally posted by Dick65
Would it be possible to copy within the same playlist as well?

You could always right-click the file > Send to playlist > select the current playlist

@jonas:

The bug I mentioned in my previous post is gone, as far as I see

There still seem to be some problems when the same song is in the playlist twice (or more times). To be honest, I don't feel like testing to find a good reproduction method atm. Maybe later...
(it looks as if it's a bit different than a few posts back, but not sure...)

And now for something completely different...
This really doesn't bother me a lot, so if it's hard to fix, I don't really care.
- You know that button next to the right-winkey which will popup the right-click menu in practically all Windows apps? It doesn't work when a folder or playlist is selected in the treelist. It will popup the root management menu only...
- In the listview, that button does work. But, when you select something with the arrow keys and press enter, it will perform the selected action AND it will play that file (since enter is also the shortcut for 'Play'). Actually this problem has nothing to do with that button, but rather with the menu itself... The same goes for the menu in the treeview...

[paul spino]

thanks for the replies guys. joonas i forgot to ask you in my first post. while in winamp- preferences- plugins when i select dynamic library and select configue nothing happens. the last version i used (i don't remember which one) also did the same thing. is it designed that way i remember one of the earlier versions it worked. thanks

[Joonas]

Originally posted by siebe83
There still seem to be some problems when the same song is in the playlist twice (or more times). To be honest, I don't feel like testing to find a good reproduction method atm. Maybe later...
(it looks as if it's a bit different than a few posts back, but not sure...)

Will look at it.

And now for something completely different...
This really doesn't bother me a lot, so if it's hard to fix, I don't really care.
- You know that button next to the right-winkey which will popup the right-click menu in practically all Windows apps? It doesn't work when a folder or playlist is selected in the treelist. It will popup the root management menu only...
- In the listview, that button does work. But, when you select something with the arrow keys and press enter, it will perform the selected action AND it will play that file (since enter is also the shortcut for 'Play'). Actually this problem has nothing to do with that button, but rather with the menu itself... The same goes for the menu in the treeview... [/B]

Both fixed as far as I can tell.
Also fixed so that clicking Config will jump to the page. Don't know how that broke...don't even know how I unbroke it :P Some compiler shit I guess.

This version: v0.9.8.9

/Joonas

[Joonas]

* Fixed the bug where multiple entries of the same song wouldn't be updated when repairing

I'm really locking this release now. I still take feature requests though since I plan to release a v1.1 quite soon after this v1.0 has been released which will include bug fixes (not too many I hope) and also some kind of smart playlists where you can ask to create a playlist with songs rated that and that...and yes that will mean that the ML rating system will be introduced in v1.1.

Hope some of you guys will stay and test that version too.

But until then, anything else broken in this release? (Really wanna release soon :P)

This version: v0.9.8.9b

/Joonas

[d3x7r0]

Originally posted by Joonas
[B(...)some kind of smart playlists where you can ask to create a playlist with songs rated that and that...and yes that will mean that the ML rating system will be introduced in v1.1.(...)[/B]

Will you copy the system and make it independent or will you use the current ML data? If you'r going to use ML data why not turn DL into an ML plugin. I've been saying that from the begining LOL

BTW my sugestion is: move the saved data from the registry to an INI file, using DL in a USB Flash disk would be cool

[Joonas]

Originally posted by d3x7r0
Will you copy the system and make it independent or will you use the current ML data? If you'r going to use ML data why not turn DL into an ML plugin. I've been saying that from the begining LOL

Nope, not gonna happen. :P

I guess I'll drop the whole idea though...my thought was that the ratings were saved as tags...*sigh* apparently it is just another ML-bloat.

BTW my sugestion is: move the saved data from the registry to an INI file, using DL in a USB Flash disk would be cool [/B]

This is something I could do eventually. It's just that the registry is so much easier to work with than a text file...also ini-files are really obsolete But some people still like them I guess.

/Joonas