Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Reply
Thread Tools Search this Thread Display Modes
Old 11th February 2006, 14:17   #441
Squadman
Senior Member
 
Squadman's Avatar
 
Join Date: Nov 2004
Location: UK
Posts: 284
Send a message via AIM to Squadman
DrO, you legend!

That fixed it! You're right, it is much faster than previous builds. Thanks.
Squadman is offline   Reply With Quote
Old 11th February 2006, 14:24   #442
DrO
 
Join Date: Sep 2003
Posts: 27,873
phew, looks like my setting merging messed things up, i'll have to make sure that code is working correctly on newer installs or something, heh

-daz
DrO is offline   Reply With Quote
Old 11th February 2006, 14:25   #443
TazDevil
Senior Member
 
TazDevil's Avatar
 
Join Date: Nov 2003
Location: Cyprus
Posts: 359
Here is the ini...

There is an issue with the Close button, it never shows, and in general, button organisation requires a look-see, (i got confused when changing positions and all)

also there is a mysterious value in
[WindowShade]
=406
Attached Files
File Type: txt winamp.ini.txt (12.1 KB, 616 views)

NEW Multiple Output Plugin v1.5 | Download | outputs data to one or more audio/file output devices
Crystal Classic Skins v1.1 | Download | transparency effects for classic skins

Last edited by TazDevil; 11th February 2006 at 14:56.
TazDevil is offline   Reply With Quote
Old 11th February 2006, 16:35   #444
Cianca
Senior Member
 
Join Date: Mar 2002
Posts: 336
Ehy DrO.. could be cool merge the JTFE's "shell options" with the ones in WA's "files types"

however i don't know if this is a thing really possible





The universal god of light, love, wisdom and rok n rol
Cianca is offline   Reply With Quote
Old 12th February 2006, 00:46   #445
DrO
 
Join Date: Sep 2003
Posts: 27,873
Squadman: issue is fixed for the next build now. i'd altered the function to fix it's handling of extra spaces on the end of the search string but that messed up the building of the internal list for the parts of the string which need to be compared.

Cianca: the aim is to move the shell options page to be a sub-page like the missing files one is since merging a plugin's preferences onto the existing winamp page is possible but i don't like doing it (is too hacky and any winamp changes would force a change in this plugin)

TazDevil: with that winshade entry, i think there might be a window created with no title that the code is catching since the settings are based on a per window title basis since you can't have multiple gen frame windows with the same window title it seems

-daz
DrO is offline   Reply With Quote
Old 12th February 2006, 02:59   #446
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 14.5 is out:: release info

------------------------------------------------------------

and second time lucky...

-daz
DrO is offline   Reply With Quote
Old 12th February 2006, 08:45   #447
TazDevil
Senior Member
 
TazDevil's Avatar
 
Join Date: Nov 2003
Location: Cyprus
Posts: 359
Quote:
Originally posted by DrO
Build 14.5 is out:: release info

------------------------------------------------------------

and second time lucky...

-daz
Sorry to bother you but now i can put the Close button on the dialog and not the Enqueue button althought the enqueue button check in the preferences is always checked (i cannot uncheck it, when i click it)
and the button order does not represent the check boxes order (hehe copy paste issue i guess, has fixed teh Close button and broken the Enqueue, which recieves the empty space now)

Size works correctly though for skinned and smooth option off, thanks

[edit]
i have reset it to defaults
not i cas see all buttons but still i cannot uncheck the Close button from configuration...
You might be using variables from before the changeover or smt, reading or writting wrong/old/changed variables

[edit 2]
what does the WinShade value 406 and 395 represent out of curiosity, because i dont see a boolean value for on/off and there is only one in [JTFE] called skfr_winshade = 1/0

so if i suppose that the value is the original size for each window then there is only one boolean value for on/off,
maybe that is the reason that when JTF window is shaded and set to reload on winamp start and DL lets say is not shaded on next startup DL will be shaded as well, you might use the same variable for all windows on startup ? (each window should have its own on/off value )
hmm ok you can use the 0, non-0 evaluation but still..

by the way the issue is still not solved... now i have checked it out :S

NEW Multiple Output Plugin v1.5 | Download | outputs data to one or more audio/file output devices
Crystal Classic Skins v1.1 | Download | transparency effects for classic skins

Last edited by TazDevil; 12th February 2006 at 09:23.
TazDevil is offline   Reply With Quote
Old 12th February 2006, 10:00   #448
Rfire
Junior Member
 
Join Date: Jan 2006
Posts: 21
Just wanted to note that in build 14.5 it is also very slow with Winamp 5.2 build 427, but is fast with any previous builds including 393.
Rfire is offline   Reply With Quote
Old 12th February 2006, 12:24   #449
Squadman
Senior Member
 
Squadman's Avatar
 
Join Date: Nov 2004
Location: UK
Posts: 284
Send a message via AIM to Squadman
That fixes my problems DrO, thanks very much.

Searching seems a lot faster, the only thing that bugs me, is it's still very slow to search for 'the'. And when you do search for 'the', instead of displaying just the tracks with 'the' in the name, it displays my playlist from the very beginning, but with several entries missing. The playlist looks like when I showed you the picture with AC/DC circled.

Can this be rectified?
Squadman is offline   Reply With Quote
Old 12th February 2006, 14:02   #450
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,875
@Squadman
Is "the" in the path (dir structure) for those entries which don't have "the" in the title?
I get the same thing happening, but only because those files are in
C:\Documents and Settings\The Egg\My Documents\My Music\...
and afaik, it's always been like this, even without gen_jumpex installed.


btw, I can reproduce TazDevil's problem where you can't uncheck 'close' (Prefs > Jump to File > Menus & Buttons), but afaik, this is by design... ie. the Close button has to be there, heh.


Not sure what Rfire means by 'slow' though, heh.
'Slow' in what way? Slow to load the Jump dialog? Slow to type in anything? Slow to show results? etc etc
DJ Egg is online now   Reply With Quote
Old 12th February 2006, 14:09   #451
Rfire
Junior Member
 
Join Date: Jan 2006
Posts: 21
Quote:
Originally posted by DJ Egg

Not sure what Rfire means by 'slow' though, heh.
'Slow' in what way? Slow to load the Jump dialog? Slow to type in anything? Slow to show results? etc etc
All of the above, but the slow to type problem is what is most severe. I'll type in "good" for instance, and it'll take about 2 seconds for each letter to show.

BTW, I have a very large playlist (over 20,000 entries). I wonder what was changed in the most recent Winamp build that makes JTFE type slow.
Rfire is offline   Reply With Quote
Old 12th February 2006, 16:12   #452
Squadman
Senior Member
 
Squadman's Avatar
 
Join Date: Nov 2004
Location: UK
Posts: 284
Send a message via AIM to Squadman
@DJ Egg: I have all my music from the path: C:\Documents and Settings\Rikk\My Documents\My Music\All Ripped Music\

After that, it seperates into 'Band Name\Album Name\MP3's.
All the artist's I have that have 'the' in the path album name, have 'the' in the ID3 artist's name.

But I turned off 'gen_jumpex.dll' in the Winamp Dir, and the problem that I explained in my earlier post (see above) about 'the', went away.

DrO, I have bad news. After loading my playlist back into Winamp, the slowdown returned while scrolling through the playlist. I thought it had gone away, but it seems to disappear after you've scrolled past the file in the playlist. But it is extremtly annoying and has only started since build 14.

:X
Squadman is offline   Reply With Quote
Old 12th February 2006, 16:23   #453
DrO
 
Join Date: Sep 2003
Posts: 27,873
TazDevil: i was working with the contents of winamp.ini you'd sent so there shouldn't have been the need to clear the plugin's settings to get all of the buttons back but no harm in a default settings restore to clean things up (i've got to start in 0.96ff replacement installs which'll be fun so i hope i don't find any other issues like that).

with the close button, that is how it's always been in that you can't remove it otherwise the underlying original jump to file dialog which i'm working on doesn't correctly work. is only how it's been for the last 2 years, heh

the WinShade values refer to the height of a window in it's shaded mode with a 0 indicating that it's not shaded. the skfr_winshade value in the ini file is a throwback to the old jtf window only winshade mode before i'd expanded the code out to handle other gen frame windows. what i can do though is have a look at the handling of null titled windows (which i have a feeling DL may be in this case)

Squadman: the compare funtion in winamp and in jtfe is passed a string formed as [playlist entry][space][title] and without jtfe present you should see the same results i believe.

crap, i forgot to sort out the issues with the missing files stuff last night (was far too late at the time). next build will have the fixes possibly in the next hour or so depending on other things

Rfire: what changed was that the jtfe search function was able to work again (as it does on 5.13 and below). searching in a 21k playlist does give me some bad speed hit especially when i'm searching for a common term like 'the' for example. using the search result limiting does help things a lot though. however the original search function which is built into the jump to file dialog (which jtfe overrides) is not ideal since it ignores any non-alphbetical characters and doesn't handle foreign/multi-byte characters (if it's not a-z then it fails).

the new search function is designed to handle all of the parts that the built in version does not handle and unfortunately that means there is slightly more processing per entry which can become noticeable on large playlists. with the search limiting enabled then it will improve things a lot for me but being initially concise in the search will give a faster result.

i've internally removed any other extra processing that's not needed and it did give me a slightly better response but there's not a lot else that can be done without breaking things like the multi-byte handling which has been on the todo list for ages and has been the main thing i've had low comments about the plugin for (even though it was winamp's fault, heh). if there is anything else which shows up then i'll try to improve things but i'm not sure if anything else can be done over what i've said.

-daz
DrO is offline   Reply With Quote
Old 12th February 2006, 16:31   #454
DrO
 
Join Date: Sep 2003
Posts: 27,873
Squadman: could you post the jump to file extra section of your winamp.ini please since i can't see any reason at the moment for the missing files code to be enabled

-daz
DrO is offline   Reply With Quote
Old 12th February 2006, 16:57   #455
Squadman
Senior Member
 
Squadman's Avatar
 
Join Date: Nov 2004
Location: UK
Posts: 284
Send a message via AIM to Squadman
No problem.
Attached Files
File Type: txt jtfe.txt (2.3 KB, 467 views)
Squadman is offline   Reply With Quote
Old 12th February 2006, 17:35   #456
TazDevil
Senior Member
 
TazDevil's Avatar
 
Join Date: Nov 2003
Location: Cyprus
Posts: 359
hehe sorry to report it then, i havent realised, since i never changed those options ever, and having the button issue i had to test every thing. well now i set it to default it all reset back to normal i think, and a note in the help section dialog about the buttons wouldnt help to mention that the close button cannot be removed

NEW Multiple Output Plugin v1.5 | Download | outputs data to one or more audio/file output devices
Crystal Classic Skins v1.1 | Download | transparency effects for classic skins
TazDevil is offline   Reply With Quote
Old 12th February 2006, 22:31   #457
DrO
 
Join Date: Sep 2003
Posts: 27,873
TazDevil: note added to the help information on that page

Squadman: there's nothing wrong with the code using your settings that i can see but i'm checking things over a bit more.

i'm aiming to get a 14.6 out soon (working on fixing gen_tray took a bit longer than i'd hoped)

-daz
DrO is offline   Reply With Quote
Old 13th February 2006, 01:57   #458
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 14.6 is out:: release info

------------------------------------------------------------

and they do say they come in 3's, hehe

Squadman: found and hopefully fixed it all now this time. just as a note, the missing file cache is only whilst the plugin is loaded so everytime winamp is reloaded it has to reform it but with the changes made you shouldn't have any issues now with it (i hope )

-daz
DrO is offline   Reply With Quote
Old 13th February 2006, 17:41   #459
Squadman
Senior Member
 
Squadman's Avatar
 
Join Date: Nov 2004
Location: UK
Posts: 284
Send a message via AIM to Squadman
DrO, i'm sorry to say this, but this build has made things worse. The problem is still there, but now I can't Enqueue anything with the middle mouse button, and it's painfully slow to Enqueue with 'Q'. Going back to build 14.5 solves the last to problems.

I've tried a clean install of both 5.13 and 5.2.427. I've deleted all JTFE details in my 'Winamp.ini', i've uninstalled every plugin that doesn't come with Winamp Full. The problem is still there. I've discovered, that scanning over the playlist slowly get's rid of the problem, but it comes back after a restart, and I think when loading a new playlist into Winamp. The slowness doesn't seem to occur when I set Winamp to 'Read Metadata only when file(s) are played'. Only when the files have been read, it happens.

Anything else I can do. Any idea's? Thanks very much for all time you've spent looking at this problem so far btw.
Squadman is offline   Reply With Quote
Old 13th February 2006, 17:53   #460
DrO
 
Join Date: Sep 2003
Posts: 27,873
can anyone else reproduce this??
i'll try to make some test builds to try out a few things for you later, will pm you details as needed

-daz
DrO is offline   Reply With Quote
Old 14th February 2006, 01:50   #461
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 14.7 is out:: release info

------------------------------------------------------------

this one needs some testing due to the changes with the cache code... i think i've caught any of the related change issues but you never know, heh

-daz
DrO is offline   Reply With Quote
Old 14th February 2006, 14:22   #462
spin26
Member
 
Join Date: Sep 2004
Posts: 78
hi... i dont know how long this bug is...
on manage mode (at the jtf box) up and down commands are broken...the title losses focus after 1 command... unlike on previous builds...
it seems the mange mode on the prefernces is different than in the main jtf box 'cause theres no prob on the the preferences one...
spin26 is offline   Reply With Quote
Old 14th February 2006, 23:22   #463
AnodA
Member
 
Join Date: Aug 2004
Location: AC
Posts: 73
misc tab in 14.7

I updated jtfe from test build 12 to 14.7 (winamp 5.13 'Misc->disable sorting' was activated) -> 'misc' tab in preferences page is there

Then i did a clean install of winamp 5.13_full and installed 14.7 after that -> 'misc' tab is missing in preferences page.

Is this on purpose, a bug or a removed feature? (win xp sp2 btw.)
AnodA is offline   Reply With Quote
Old 14th February 2006, 23:36   #464
DrO
 
Join Date: Sep 2003
Posts: 27,873
issue is from not having the media library installed (since there is/was a scheduler page in there which i internally hide and the calculation of which page to hide without the media library installed is broken, i'll have that fixed for the next build.

-daz
DrO is offline   Reply With Quote
Old 15th February 2006, 00:33   #465
AnodA
Member
 
Join Date: Aug 2004
Location: AC
Posts: 73
Quote:
Originally posted by DrO
issue is from not having the media library installed (since there is/was a scheduler page in there which i internally hide and the calculation of which page to hide without the media library installed is broken, i'll have that fixed for the next build.
Oh, that's the point - disabled installation of ml indeed.

Happy coding...
AnodA is offline   Reply With Quote
Old 15th February 2006, 05:15   #466
osmosis
Major Dude
 
osmosis's Avatar
 
Join Date: Jan 2006
Location: Cananada
Posts: 841
great update to a great plugin! seems to reduce memory and open/close times in winamp significantly

Request: A little SmartView Query Language love.
osmosis is offline   Reply With Quote
Old 16th February 2006, 19:05   #467
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
Hi!

I've just upgraded to 14.7 and noted something.
Since I have a large playlist (>11K) I use the "Limit the number of search results to be displayed upto..." (should it not be "up to"?) to 100 entrys.

When oppening the JTFE dialog with the search field empty, this limit is not imposed: it list all 11K entrys making it slow.

This slugginess it just a bit annoying since that I start typing right after opening the windows: I type the first few chars, then the window updates -> sets focus to the search field selecting whatever I wrote, and as I continue typing it replaces the selection with the new entrys.

Hummm maybe this is just a bit confusing.. I'm not in an english mood right now...
upsfeup is offline   Reply With Quote
Old 16th February 2006, 19:34   #468
DrO
 
Join Date: Sep 2003
Posts: 27,873
i'm just trying this with 14.7 and last night's internal dev build and with a limit of 17 and it only shows 17 for me. Egg has just done it with a limit of 7000 and that worked correctly (was working with a 14k entry playlist).

can you confirm the search count indicated at the top of the jtf dialog when there is no search present.

as for the typo, that will be looked at when i finish the lang file support

-daz
DrO is offline   Reply With Quote
Old 16th February 2006, 19:44   #469
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
Quote:
Originally posted by DrO

can you confirm the search count indicated at the top of the jtf dialog when there is no search present.
-daz
Yes.

Open search dialog (F3)
Cleared search
Closed dialog using Close button
Open search dialog again: It shows: "(Found 11921)", text search editbox is empty.

If I type a search it limits to 100 entrys.
If I open the search box with text on editbox it also limits to 100 entrys.
upsfeup is offline   Reply With Quote
Old 16th February 2006, 19:49   #470
DrO
 
Join Date: Sep 2003
Posts: 27,873
can you please attach a copy of your winamp.ini. what winamp version and OS are you using?

-daz
DrO is offline   Reply With Quote
Old 16th February 2006, 19:58   #471
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
Sure:

Winamp version: 5.13
OS: WIndows XP SP2
Attached Files
File Type: zip winamp.ini.zip (4.4 KB, 504 views)
upsfeup is offline   Reply With Quote
Old 16th February 2006, 20:35   #472
DrO
 
Join Date: Sep 2003
Posts: 27,873
fixed for build 15 (i can't reproduce it now that i had managed to reproduce it on my XP and main win2k installs)

-daz
DrO is offline   Reply With Quote
Old 16th February 2006, 20:52   #473
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
Thats was fast!

Now I just have to find a way of getting the window even faster so that the overwrite is less notable.

(I surely need a XP clean install)
upsfeup is offline   Reply With Quote
Old 17th February 2006, 02:15   #474
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 15 is out:: release info

------------------------------------------------------------

more fixes, memory tweaks (looks like i was part to blame for some of the mem bloat issues though this and the last few builds remedy this now ), other stuff, etc

-daz
DrO is offline   Reply With Quote
Old 17th February 2006, 03:38   #475
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
Quote:
Originally posted by niktheguru
Only one thing annoys me, the fact that after i install it my whole playlist gets wiped!! (and i keep forgetting this....and losing my playlist ) is there any way we can stop this in future?
This just happened to me too while updating to R15. Really weird! :S
upsfeup is offline   Reply With Quote
Old 17th February 2006, 03:41   #476
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,875
Can't reproduce that issue here. It's never happened to me, and I've installed just about every build of JTFE there's ever been.
DJ Egg is online now   Reply With Quote
Old 17th February 2006, 04:32   #477
spin26
Member
 
Join Date: Sep 2004
Posts: 78
i got a bug here...
"remove file from queue on alt+click " dont work on the
jtfe [edit: i mean search box] box...
works great on playlist though
spin26 is offline   Reply With Quote
Old 17th February 2006, 06:19   #478
Maktaka
Junior Member
 
Maktaka's Avatar
 
Join Date: Oct 2002
Posts: 17
Erg, this build (15) just completely broke enqueueing for me. I can open up the JTFE box and queue files with the enqueue button in there, but I cannot enqueue files from the playlist using either the right click menu or with the 'Q' keyboard shortcut. I can use either the right-click menu or keyboard shortcuts to do any of the other JTFE options (e.g. Queue Management), but queueing from the playlist is totally nonfunctional. This is a clean Winamp install on a WinXP SP2 install that is less than a week old. I tried resetting the JTFE settings back to default (using the button in preferences) but it's staying quite broke. The only other plugins I've got are also by DrO (a handful picked out of the plugin pack).

Edit: Just did some more fiddling and I found that when I do actually use the JTFE box to enqueue a file, it doesn't play the file I select, it play the file AFTER the one I queueued up.
I also found that I can enqueue files on the playlist if I use the middle-mouse button as long as that feature is turned on. If I disable the feature, it only disables middle-mouse enqueueing but doesn't bring back normal enqueueing options.

Edit 2: Tried out a couple other builds to see where the problem starts for me (it doesn't exist with the version of 0.96 bundled with 5.13). Annnnd the problem went away (sort of). I reverted back to 0.96 from 5.13. It was crashing when I went through the JTFE options in Winamp, so I hit the preferences reset button again (on 0.96). That got the immediate crashing issue gone, so I started jumping up through the various 0.97 builds. The inability to queue in the playlist never re-manifested itself, however build 15 is still incorrectly playing queued files (plays file after the queued one). 14.7 and below are all fine for me on all counts.

Last edited by Maktaka; 17th February 2006 at 06:51.
Maktaka is offline   Reply With Quote
Old 17th February 2006, 13:22   #479
DrO
 
Join Date: Sep 2003
Posts: 27,873
upsfeup: was winamp running when you tried to install it, if so try closing winamp manually first and then installing. i don't know what else would cause the playlist to be cleared, very strange..

spin26: i can't remember if that was ever intended for the jtf dialog, i think it was mainly for the playlist but will check 0.96 handling later on and if need be implement as needed (that option title will be changing for the next build to clarify it's usage )

Maktaka: with all of the edits i'm not quite sure where things stand with you now so.. does playlist enqueue work correctly with b15? as for the crash with going back to 0.96 in the preferences, that's due to there being extra entries in the rclick menu section which 0.96 indexes incorrectly when trying to handle the extended 0.97R implementation. 0.97R will fix this handling if i ever expand it in future and have extra entries.

i've reproduced the playing of the track after the expected queued song and will have that fixed later tonight

-daz
DrO is offline   Reply With Quote
Old 17th February 2006, 14:08   #480
upsfeup
Member
 
Join Date: Feb 2005
Posts: 58
DrO:
Yes, as a matter of fact I installed with the winamp running but I also installed 14.7 in the same way and back then it didn't empty the playlist... so this is still weird. :P

Ohhh and the "Playing of the track after the expected also happens here" .. I'll wait for the next build too.
upsfeup is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump