26th October 2006, 21:11
|
#1 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Next On Stop (v1.2.2)
I recently installed the latest version of DrO's 'Next On Stop' plugin (v1.2.2).
As with most all of DrO's plugins ... I love the concept  Unfortunately, I think I broke it.  The bugs seem to occur when Next On Stop is installed and the "Manual Playlist Advance" property is checked. This property is part of the Repeat functionality. On the Classic Skin one can access the property by right clicking the repeat button. NOTE: Winamp is suppose to repeat a single track if BOTH the "Repeat" Property AND the "Manual Playlist Advance" property are checked. Bug #1A:
Expected Behavior - Winamp STOPS and remains on SAME track Bug #1B:
Expected Behavior - Winamp STOPS and remains on SAME track Bug #2A:
and continue playing through the playlist. Expected Behavior - Winamp continues playing the SAME track Bug #2B:
Expected Behavior - Winamp continues playing the SAME track Bug #3: (This is the same bug that siebe83 reported on 05/04/2004)
and continue playing Expected Behavior - Winamp STOPS and advances to the ENQUEUED track My System Specs:
This issue occurs regardless of whether or not DrO's 'Three Mode Repeat' is installed. DrO - Please let me know if I can provide any other information. #1 Wish - Album Art Config #2 Wish - Add Encoded Tag To The ML I recommend DrO's Plugins and ◊ Screen Lock Detector ◊ Power Hour ◊ ShnAmp ◊ TrayAmp ◊ WinampSwitch ◊ Last edited by jph6t; 26th October 2006 at 21:37. |
|
|
|
27th October 2006, 00:53
|
#2 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: Next On Stop (v1.2.2)
Quote:
|
|
|
|
|
|
28th October 2006, 22:56
|
#3 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
some of the issues are valid, some are just down to the way in which jtfe is currently coded (and will need some changes to be made to that i think) but some things are working as is correctly expected. so....
#1A: this is meant to advance to the next track #1B: this should advance to the next track or really the next enqueued track - this is now fixed i believe in my dev build #2A: this should stay on the same track and has been fixed to do so in the internal build #2B: this should stay on the same track and i've fixed it to do so _but_ it's clearing the jtfe queue incorrectly (probably requires a jtfe fix for this tho) #3: this is a weird one to try and fix since it's related to issues above and i think needs a jtfe change as well. as such i should be able to get a newer build out of this but i'll say that with the #1 that it is meant to advance to the next track on stopping since the few users when it was first coded commented that it was a bug to stick to the same track which i agree especially with the aim of the plugin -daz |
|
|
|
|
30th October 2006, 03:00
|
#4 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: Next On Stop (v1.2.2)
Thank you for your attention to my post DrO.
I appreciate your being so cool about the feedback. I read your opinion that my bug #1 above is expected behavior, and I now see your point. But I still say an argument could be made either way. I appreciate that the original intention of this plugin was to correct the perceived error of Winamp staying on the same track after clicking the STOP button. I agree with this position. It's why I installed 'Next On Stop'. But Bug #1 documents actions being taken by 'Next On Stop' WITHOUT my clicking of the STOP button. With what you are saying, CHECKING the "Manual Playlist Advance" property ALONE now acts like an auto-stop option ... i.e. installing 'Next On Stop' turns "Manual Playlist Advance" into a stop at the end of each track option. Which I guess, functionally speaking, is what it always was. It's just the name of the property is not the most accurate when combined with 'Next On Stop'. So in short, I think our disconnect was that I was thinking of 'Next On Stop' only in the sense of the pressing of the stop button (or another specific user-generated stop - like "Stop after current"). And you instead are applying 'Next On Stop' for ANY STOP ACTION. Correct? |
|
|
|
|
5th November 2006, 18:04
|
#5 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: Next On Stop (v1.2.2)
Bug #4
Within an Artist/Album Smart View of the Media Library, select an album that has multiple tracks. Select a single song among the album's listed tracks, right click and select "Play selection". All the tracks of the given album will populate the Playlist, and Winamp should begin playing the track that is highlighted in the ML. Instead, with 'Next On Stop' installed, Winamp will begin playing the track listed AFTER the highlighted track. If you try and replicate this bug, and it does NOT happen on the first try ... try it again. Sometimes Winamp will behave as expected the first time. However, this bug will always occur the second time and all times after that. I have not been able to isolate the action that resets this loop, and puts one back to the working "first time" scenario. Note that this bug only occurs when you right click on a selected song. If you right click on an album title, and select "Play selection", all the tracks of the album will enqueue in the Player and Winamp will begin playing the first track as it should. My System Specs:
DrO - Please let me know if I can provide any other information. #1 Wish - Album Art Config #2 Wish - Add Encoded Tag To The ML I recommend DrO's Plugins and ◊ Screen Lock Detector ◊ Power Hour ◊ ShnAmp ◊ TrayAmp ◊ WinampSwitch ◊ Last edited by jph6t; 5th November 2006 at 18:20. |
|
|
|
|
5th November 2006, 21:31
|
#6 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
if winamp isn't playing or the playlist is already empty then it'll start playing the correct track. for some reason the ml's attempt to tell which file to start playing is messing up the internal logic and hence is making NOS advance to the wrong track. is going to involve some more hacking to try to fix this one as well it seems
-daz |
|
|
|
|
5th November 2006, 22:16
|
#7 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
i've attached a temp build (1.3 Alpha 1) which seems to fix at least #4 and certain aspects of the other bugs (generally anything related to the jtfe queue is not guaranteed to be fixed/working) but it's not complete and won't be until i rectify some issues within the jtfe plugin - both will need further modification but this is a start.
as such this is not an official release and will not be refered to in any of my installers/webpages (just for info for anyone else trying this out) -daz |
|
|
|
|
6th November 2006, 02:19
|
#8 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_1
Nice work DrO!
 I installed your alpha release (attached above), and it seems to have resolved most of the NOS-side bugs I reported earlier. The only issue now is some unexpected affects on/interactions with the JTF queue (like when testing bug #2B) ... but it sounds like you are already aware of these and the fix would be on the JTF-side. I'll stay tuned for your next release. Meanwhile, have a good week and thanks again! Last edited by jph6t; 6th November 2006 at 02:44. |
|
|
|
|
6th November 2006, 04:52
|
#9 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Next On Stop w/ Playlist Separator
When 'Next On Stop' is installed along with DrO's 'Playlist Separator',
the following bug occurs: Bug #5A:
Expected Behavior - Winamp PLAYS the track AFTER the separator. Bug #5B:
Expected Behavior - Winamp PLAYS the ENQUEUED track. My Plugin Versions:
DrO - Please let me know if I can provide any other information. |
|
|
|
|
6th November 2006, 12:55
|
#10 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
sounds like the advance code in both plugin's is conflicting, i'll probably just have to do a check on the file being played and use the blocking method that was needed to fix #4 with any separators. either way fixing #5A+B should be a quick fix (famous last words) so i should be able to find 30mins tonight to try and resolve that for a alpha2 build.
yeah, anything related to #2B and similar will act funny (since i think it'll hold to the correct track but the queue will still be removed which obviously isn't the desired behaviour) also as a note, just not having the plugin enabled (without a full removal) shouldn't cause any undesired behaviour (is how i've been quickly testing between unhandled and handled behaviour with the plugin) -daz |
|
|
|
|
6th November 2006, 15:43
|
#11 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Quote:
|
|
|
|
|
|
6th November 2006, 15:45
|
#12 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Quote:
|
|
|
|
|
|
6th November 2006, 15:47
|
#13 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
just unchecking the advance to next on stop option will kill the plugin's features
-daz |
|
|
|
|
6th November 2006, 15:50
|
#14 | |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
Quote:
-daz |
|
|
|
|
|
6th November 2006, 15:53
|
#15 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Quote:
|
|
|
|
|
|
12th November 2006, 03:18
|
#16 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_1
Bug #6:
- Updating the ID3v1 tag will NOT trigger the track to advance. - Disabling or uninstalling 'Next On Stop' makes Winamp work as expected. DrO - Please let me know if I can provide any other information. |
|
|
|
|
12th November 2006, 08:42
|
#17 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
it's a quirk of the id3v2 tag updates where it has to stop playback and then restart it so that it all works out correctly due to the placement of the tag in the file. the attached build should resolve the issue i believe (i've not had a chance to fix the #5 issues but i need to head out now and the #6 bug was an easy fix). i'll also need to add the fix in for the main window as well but that will be done later as well
-daz |
|
|
|
|
14th November 2006, 13:03
|
#18 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_2
|
|
|
|
|
14th November 2006, 15:37
|
#19 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
yeah thereis a beep in the code since i needed to check things were being skipped correctly and forgot to take it out. next build will remove the beep
-daz |
|
|
|
|
14th November 2006, 18:49
|
#20 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha
In using either of the v1.3.alpha builds (above) I experience the following ...
Bug #7: This bug relates to bug #2A (and I speculate its fix).
Winamp will start playing the SAME track from the beginning. Expected Behavior - Winamp advances to and starts playing the NEXT track (either in the Playlist or the JTF queue) - Pushing the NEXT button while Winamp is stopped will not trigger the same behavior. When stopped, pushing the NEXT button advances the track. - Disabling or uninstalling 'Next On Stop' makes Winamp work as expected. DrO - Please let me know if I can provide any other information. |
|
|
|
|
14th November 2006, 21:50
|
#21 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_2
After installing the alpha-2 build (above) I experience the following ...
Bug #8:
Winamp will advance to the enqueued track and STOP. Expected Behavior - Winamp advances to and starts playing the ENQUEUED track - Disabling or uninstalling 'Next On Stop' makes Winamp work as expected. DrO - Please let me know if I can provide any other information. |
|
|
|
|
15th November 2006, 03:57
|
#22 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_2
After installing the alpha-2 build (above) I experience the following ...
Bug #9:
Expected Behavior - Upon end of queue ... Winamp closes - Disabling or uninstalling 'Next On Stop' makes Winamp work as expected. DrO - Please let me know if I can provide any other information. Last edited by jph6t; 15th November 2006 at 05:08. |
|
|
|
|
15th November 2006, 23:11
|
#23 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
i think i've managed to fix #7 and #8 (1.3 alpha specific issue) and got rid of the beeps
so from what i can see, i'm now left with #2(a+b), #3, #5(a+b) and #9 which from what i can tell with the work done so far are all dependant on jtfe fixes (and any other new quirks and/or finds  )
|
|
|
|
|
15th November 2006, 23:36
|
#24 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Re: gen_nos_v1_3_alpha_3
After installing the alpha-3 build (above) I experience the following ...
In testing the fix for Bug #7 ... on any song but the first in the Playlist, clicking the NEXT button causes Winamp to begin playing the PREVIOUS track instead of the NEXT one as expected. On the first song in the Playlist, Winamp advances to the NEXT track as expected. Add to the conditions of Bug #7 the checking of the shuffle property and one will find that shuffle no longer works when clicking the NEXT button. Instead, Winamp will begin playing the PREVIOUS track in the playlist just as it would if the shuffle property was unchecked. Bug #8 is still occuring to me. Last edited by jph6t; 16th November 2006 at 01:15. |
|
|
|
|
3rd December 2006, 10:14
|
#25 |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Next On Stop w/ JTF
I recently installed the latest version of DrO's 'Jump To File' (JTF) plugin
(v0.97.10 (Build 86)) When ‘Next On Stop' is installed along with JTF the following bug occurs: Bug #10
Winamp will advance to the enqueued track and STOP. Push the NEXT button again and Winamp will NOT advance. Expected Behavior - Winamp advances to AND begins playing the enqueued track. My Plugin Versions:
DrO - Please let me know if I can provide any other information. |
|
|
|
|
3rd December 2006, 21:01
|
#26 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Next On Stop (NOS) Bugs
Quote:
So I ran back through the tests. Seems that some of the bugs that were fixed got broken (with different unexpected results) in later builds. Here's a recap: Bug #1A:
Expected Behavior - Winamp STOPS and advances to the NEXT track Bug #1B:
(even though shuffle play is not selected). Expected Behavior - Winamp STOPS and advances to the ENQUEUED track Bug #2A: - FIXED
Bug #2B: - FIXED
Bug #3: - NOS w/ JTF (This is the same bug that siebe83 reported on 05/04/2004)
and STOP Expected Behavior - Winamp STOPS and advances to the ENQUEUED track Bug #4: - FIXED Bug #5A: - NOS w/ Playlist Separator
Expected Behavior - Winamp PLAYS the track AFTER the separator. Bug #5B: - NOS w/ Playlist Separator
Expected Behavior - Winamp PLAYS the ENQUEUED track. Bug #6: - FIXED Bug #7:
On the first song in the Playlist, Winamp advances to the NEXT track as expected. If files are ENQUEUED via JTF then the first (and only first) entry will be cleared from the queue. (Note - Add to the conditions of Bug #7 the checking of the shuffle property and one will find that shuffle no longer works when clicking the NEXT button. Instead, Winamp will begin playing the PREVIOUS track in the playlist just as it would if the shuffle property was unchecked.) Expected Behavior - Winamp advances to and starts playing the NEXT track (either in the Playlist or the JTF queue) Bug #8: - NOS w/ JTF
Winamp will advance to the enqueued track and STOP. Expected Behavior - Winamp advances to and starts playing the ENQUEUED track Bug #9: - NOS w/ JTF
Expected Behavior - Upon end of queue ... Winamp closes Bug #10 – sorry DrO, I later realized this is nearly identical to Bug #8
Winamp will advance to the enqueued track and STOP. Push the NEXT button again and Winamp will NOT advance. Expected Behavior - Winamp advances to AND begins playing the enqueued track. My System Specs:
#1 Wish - Album Art Config #2 Wish - Add Encoded Tag To The ML I recommend DrO's Plugins and ◊ Screen Lock Detector ◊ Power Hour ◊ ShnAmp ◊ TrayAmp ◊ WinampSwitch ◊ Last edited by jph6t; 3rd December 2006 at 21:24. |
|
|
|
|
|
3rd December 2006, 21:11
|
#27 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
you're not the only one who was getting lost keeping track of things
had thought it would basically be anything related to the jtfe queue. i'll be looking into those issues once i've fixed the other issues already noted within the jtfe plugin since they rank higher for a larger proportion of users over the interaction between this one and jtfe-daz |
|
|
|
|
3rd December 2006, 21:14
|
#28 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Quote:
Thanks DrO! Have a good week. |
|
|
|
|
|
14th December 2006, 05:07
|
#29 |
|
Major Dude
Join Date: Mar 2003
Location: Canada
Posts: 841
 |
(Sorry for stealing your format, jph6t)
Bug # 11 - NOS w/ Close After Current Select Close After Current. Winamp will play out the rest of the song, stop, NOT advance, and close. When re-opened, Winamp will still be set to play the same song. Expected Behavior - Winamp stops, advances to the next track, and THEN closes. Note: Expected Behavior will occur if both Stop After Current AND Close After Current are selected. My System Specs:
The world is made of conflicts: good and evil, order and chaos, light and dark, hot and cold. All are essential to life. None can prevail for any length of time, or life will fail. In the end, the best any can hope for is balance. Last edited by Nimelennar; 14th December 2006 at 05:39. |
|
|
|
|
14th December 2006, 15:26
|
#30 | |
|
Major Dude
Join Date: May 2004
Location: USA
Posts: 750
|
Bug report format
Quote:
DrO replies to so many posts and builds so many great plugins, I just hate to see him have to suffer through the "I have a bug, fix it" posts that put him in a position to have to figure out how to recreate the scenario. I'd rather do the work of figuring out how to recreate the problem, and give him a detailed description on how to replicate the error. Leaving him to focus on the fixes. But really it should be DrO we ask about prefered format ... as he is the primary audience (plus newbies doing forum searchs to find answers to their problems). |
|
|
|
|
|
15th December 2006, 12:52
|
#31 |
|
-
Join Date: Sep 2003
Location: UK
Posts: 22,278
|
i quite like the format of the bug reports since it makes it easier to read through and follow what's happening (or not) and what is expected. the more information you can provide then the better it can be especially for some of the obscure issues.
i'm trying to schedule some time to look into the issues as things stand with the newer jtfe build so i'll try and sort everything else out in one go i hope (loading orders/quirks in message handling are the main reason for the issues in the plugin at the moment) but i'm sure i'll get something sorted out for it all -daz |
|
|
|
 |
|
|||||||
| Thread Tools | Search this Thread |
| Display Modes | |
|
|
Android is a trademark of Google Inc. Use of this trademark is subject to Google Permissions.
The free customizable Winamp media player that plays mp3 + other audio files,
syncs your iPod, subscribes to Podcasts and more.
Copyright © 1999 - 2013 Nullsoft. All Rights Reserved.
Linear Mode
