Old 10th December 2003, 20:28   #1
DrO
 
Join Date: Sep 2003
Posts: 27,873
Skinned Preferences

Skinned Preferences

Being the kind person i am, i thought i'd work on improving skin support for my Jump to File Extended and Extended Playlist plugins.

At the same time i thought i'd make another little plugin that i want which would also allow me to improve skin handling.

So attached is my current build of the plugin i'm working on (what another one - doesn't that guy have anything else to do!?!?! ). A preview of this was posted here.

It's still an EARLY RELEASE but it shows things as they stand.
* no frame support
* skin style doesn't update when you change the current skin
* link controls are skinned when they shouldn't be
* tab controls are partially handled
* static controls are overriden ie the file type icons don't show


Any issues ie crashes, etc then please let me know and as always enjoy!

-daz
Attached Files
File Type: zip gen_prefs_skin_preview.zip (4.1 KB, 580 views)
DrO is offline   Reply With Quote
Old 10th December 2003, 22:33   #2
Dipso
Senior Member
 
Dipso's Avatar
 
Join Date: Aug 2002
Location: Norway
Posts: 379
You are one insane coding maniac

Phear the headbanging llama!!!

http://dipso.deviantart.com <- Art, Graphics, Photography.
Dipso is offline   Reply With Quote
Old 10th December 2003, 22:37   #3
DrO
 
Join Date: Sep 2003
Posts: 27,873
just insane i think

-daz
DrO is offline   Reply With Quote
Old 10th December 2003, 23:11   #4
D&B
Banned
 
Join Date: Mar 2001
Posts: 1,027
Im at work so I cant try it, but I saw a screenshot from DJ Egg and it looked great.

Ill give a try when I get home.
D&B is offline   Reply With Quote
Old 10th December 2003, 23:16   #5
DrO
 
Join Date: Sep 2003
Posts: 27,873
i'm not certain on this but it may even be possible to use the eventual core of this plugin to work on any winamp dialog but it's still a glimmer of a thought at the moment (pushing a few ideas around at the moment about that and maybe even menus as well )

-daz
DrO is offline   Reply With Quote
Old 13th December 2003, 07:22   #6
Plague
f(caffeine){
return wasabi;
}
(Forum King)
 
Plague's Avatar
 
Join Date: Jul 2001
Location: Sweden
Posts: 3,984
I saw the preview screenshot back then and loved it!
When this plugin is finished, it'll really rock, it already shows incredible potential!

great work, as always.

-Plague
Plague is offline   Reply With Quote
Old 13th December 2003, 08:17   #7
mark e
Major Dude
 
mark e's Avatar
 
Join Date: Aug 2001
Posts: 1,117
_When going to preferences::

WINAMP caused a general protection fault
in module KERNEL32.DLL at 0167:bff73641.
Registers:
EAX=00000001 CS=0167 EIP=bff73641 EFLGS=00010246
EBX=00000000 SS=016f ESP=00000001 EBP=0073cffc
ECX=00000000 DS=016f ESI=00000084 FS=4527
EDX=01b63558 ES=016f EDI=00000001 GS=0000
Bytes at CS:EIP:
5f 5e c9 c2 0c 00 52 51 33 c0 48 50 50 65 ff 32
Stack dump:
65000000 16007004 650c4d00 65007004 54007004 79f000ff 21f000ea 00f000ea d212bb00 3a107b08 520c4d00 6a0c4d00 820c4d00 9a0c4d00 650c4d00 0b007004


_Running:: Win98, WA5RC666, Default Modern Skin (With unoffical color theme)...
mark e is offline   Reply With Quote
Old 13th December 2003, 09:02   #8
Reaper
Forum King
 
Join Date: Apr 2002
Posts: 2,928
Hmm.. odd bug on the buttons in the plugin sections. Perhaps this is the "link controls are skinned when they shouldn't be" you mentioned?


ml_iPod - [Homepage] | [Forums] | [Wiki]
Reaper is offline   Reply With Quote
Old 13th December 2003, 09:37   #9
Dextro
Senior Member
 
Dextro's Avatar
 
Join Date: May 2002
Location: Lisbon, Portugal
Posts: 293
Cool, can't wait to see this plugin working (got that some error Reaper).

I forsee that someday everyone will use Dr. O's Plugins but who am I to say that?

Dextro is offline   Reply With Quote
Old 13th December 2003, 17:21   #10
Wetzel
Junior Member
 
Join Date: May 2003
Location: Los Angeles
Posts: 32
Send a message via AIM to Wetzel Send a message via Yahoo to Wetzel
that's pretty darn nifty, heh.

it's working fine for me, in winXP pro SP1, but i am getting the same problem as Reaper with the buttons, and it seems for some preferences (like JTFE) the names of the tabs dissapear, but then for media library it looks fine . . .
Wetzel is offline   Reply With Quote
Old 13th December 2003, 17:53   #11
DrO
 
Join Date: Sep 2003
Posts: 27,873
@Reaper: yeah that's the link issue

@Plague: just adapted to handle any dialog now (just the open file dialog not working and i've had issues with hacking that beforehand!) even the browse for... dialogs are handled (may put something up tomorrow to test the changes out on at least XP systems )

@mark e: i'm working on improving Win98 compatibility (finally got my old 98 system up again to test on )

@Wetzel: that's fixed now - basically in the release version it depends on the level of the windows from the parent and i wasn't handling all levels correctly. but it's fixed now.

-daz
DrO is offline   Reply With Quote
Old 13th December 2003, 17:57   #12
Plague
f(caffeine){
return wasabi;
}
(Forum King)
 
Plague's Avatar
 
Join Date: Jul 2001
Location: Sweden
Posts: 3,984
coo.
oh, one thing, could you add an option to turn it off?

-Plague
Plague is offline   Reply With Quote
Old 13th December 2003, 18:03   #13
DrO
 
Join Date: Sep 2003
Posts: 27,873
that'll be added soon
since it's now gone to the next stage of development i'll be adding a few basic config options to hopefully give a bit of control over what is done

-daz
DrO is offline   Reply With Quote
Old 14th December 2003, 00:19   #14
maximumw
Junior Member
 
Join Date: Nov 2003
Location: Serbia
Posts: 31
If you fixed the wetzel,reaper and my problem with button where are that plugin!!! And here is an idea for playlist menu next to a view file info can it be a open file location like in winamp3?
maximumw is offline   Reply With Quote
Old 14th December 2003, 01:52   #15
WHEREamI
Major Dude
 
Join Date: Jul 2002
Location: Wasabidev
Posts: 606
Quote:
(just the open file dialog not working and i've had issues with hacking that beforehand!)
Isn't that because it uses the OS's file dialog? or is that what ur saying? I wouldn't worry about hacking that though. Get it to work with everything else, and everyone will be happy. More than happy. Ecstatic!

~WHEREamI
WHEREamI is offline   Reply With Quote
Old 14th December 2003, 03:20   #16
iron2000
Senior Member
 
iron2000's Avatar
 
Join Date: Mar 2002
Location: Singapore
Posts: 391
DrO,you forgot to add a link of this new masterpiece to your sig.

Thanx
iron2000 is offline   Reply With Quote
Old 14th December 2003, 13:07   #17
DrO
 
Join Date: Sep 2003
Posts: 27,873
@WHEREamI: you're right, it is the OS's file dialog but the code at the moment doesn't discriminate windows correctly at the moment. basically any window that is owned by winamp directly will be skinned. that's why the code is doing the browse for windows (but they will be supported - just need to get the icon background winampified )

@maximumw: there's a few issues with the code under Win98 that i need to fix before i put out the next test version

@iron2000: he he, there's only so much space in the signature. it looks like it will be the first plugin to official go on the new site.

-daz
DrO is offline   Reply With Quote
Old 14th December 2003, 23:08   #18
DrO
 
Join Date: Sep 2003
Posts: 27,873
here's the latest test version [list=1][*]Fixed Win98 crash issues i hope[*]Will attempt to skin all potential windows not just the prefs dialog[*]Fixed the button and link controls (*)[/list=1]
* note the background is not correct - still to fix that

gen_prefs_skin v0.48

-daz
DrO is offline   Reply With Quote
Old 15th December 2003, 00:00   #19
Plague
f(caffeine){
return wasabi;
}
(Forum King)
 
Plague's Avatar
 
Join Date: Jul 2001
Location: Sweden
Posts: 3,984
very nice!
this is MUCH better, I love it already!

-Plague
Plague is offline   Reply With Quote
Old 15th December 2003, 00:16   #20
ozloi
Member
 
ozloi's Avatar
 
Join Date: Oct 2003
Location: http://www.danvers-state-ia.com
Posts: 50
Send a message via AIM to ozloi
o man, this plugin is so sweet...im so glad i decided to try it out...
ozloi is offline   Reply With Quote
Old 15th December 2003, 00:21   #21
D&B
Banned
 
Join Date: Mar 2001
Posts: 1,027
Very cool! I want all your plugins to be finished right now! j/k im just impatient, you have been doing amazing work and it just makes me drool at the thought of more.
D&B is offline   Reply With Quote
Old 15th December 2003, 01:44   #22
Raftysworld
Member
 
Join Date: Oct 2003
Location: Snohomish WA
Posts: 69
Send a message via AIM to Raftysworld Send a message via Yahoo to Raftysworld
Incredible job, as usual Dro. My first complaint after a initial test is the "Open file(s)" dialog, along with Add files, and Load Playlist, etc. Those all in their current state look rather poor with the WA style.

[Edit] After testing it with other skins/color themes, it might just be the WA5 modern skin with the copper theme doesn't go too well. With the classic skin, the dialogs looked rather pleasant.
Raftysworld is offline   Reply With Quote
Old 15th December 2003, 02:32   #23
WHEREamI
Major Dude
 
Join Date: Jul 2002
Location: Wasabidev
Posts: 606
hey DrO, Does this mean you can take the skinning code out of JTFE? or will it work better if JTFE has it itself instead of relying on this. Just curious.

~WHEREamI
WHEREamI is offline   Reply With Quote
Old 15th December 2003, 12:38   #24
Dipso
Senior Member
 
Dipso's Avatar
 
Join Date: Aug 2002
Location: Norway
Posts: 379
He probably could, but then it wouln't be skinnable without this plugin would it?

Phear the headbanging llama!!!

http://dipso.deviantart.com <- Art, Graphics, Photography.
Dipso is offline   Reply With Quote
Old 15th December 2003, 17:33   #25
amano
Major Dude
 
amano's Avatar
 
Join Date: Apr 2003
Location: where the llamas come from!
Posts: 952
hmm. I think that taking out the skinning code from JTFE would be the cleaner solution. so every plugin does his own job. one does the winamp skinning, one does the Enqueue things. no code is doubled. small and clean.

eeeee eeeeeee eeeee eeeee eeeee
8 8 8 8 8 8 8 8 8 8 88
8eee8 8e 8 8 8eee8 8e 8 8 8
88 8 88 8 8 88 8 88 8 8 8
88 8 88 8 8 88 8 88 8 8eee8
amano is offline   Reply With Quote
Old 15th December 2003, 17:36   #26
Plague
f(caffeine){
return wasabi;
}
(Forum King)
 
Plague's Avatar
 
Join Date: Jul 2001
Location: Sweden
Posts: 3,984
I agree..
That would be the best way to do it..

-Plague
Plague is offline   Reply With Quote
Old 15th December 2003, 18:05   #27
DrO
 
Join Date: Sep 2003
Posts: 27,873
@badrad: i'm cloning myself right now

@WHEREamI: the code at the moment will check for the jtfe window and will ignore it for the moment. once the window frames are setup correctly then i was thinking of dropping out the skinned code from jtfe.

@Dipso: yeah that's something i've thought of as well but since the plugin at the moment is only 7k i don't think that will matter too much for people to download as well (could add this as a recommended addition )

@amano: that's why i've got so many of the plugins (think it's 10 now) - not bad for a self taught programmer i think

-daz
DrO is offline   Reply With Quote
Old 15th December 2003, 18:39   #28
mark e
Major Dude
 
mark e's Avatar
 
Join Date: Aug 2001
Posts: 1,117
perfect! works on Win98!


\ me waits now JTFE final and Extended Playlists! Is there any news? dates? (offtopic)
mark e is offline   Reply With Quote
Old 15th December 2003, 21:30   #29
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
perfect! works on Win98!
that's great

offtopic(ish) reply - jtfe has been started on again proper (just tonight) with config code being updated at the moment and i'm expanding the playlist editor integration so there will be customisable menu options, positions, etc are coming

the next build will be pretty cool

-daz
DrO is offline   Reply With Quote
Old 15th December 2003, 21:48   #30
D&B
Banned
 
Join Date: Mar 2001
Posts: 1,027
DrO, what do you want for christmas?
D&B is offline   Reply With Quote
Old 15th December 2003, 21:59   #31
DrO
 
Join Date: Sep 2003
Posts: 27,873
now that would be telling
well to get a new build of jtfe out with all previous issues fixed and all the new ones working fully first time would be great for me

how about you badrad?

-daz
DrO is offline   Reply With Quote
Old 15th December 2003, 22:34   #32
Dipso
Senior Member
 
Dipso's Avatar
 
Join Date: Aug 2002
Location: Norway
Posts: 379
Would be a great X-mas present for the peeps in thiese forums also i bet

Phear the headbanging llama!!!

http://dipso.deviantart.com <- Art, Graphics, Photography.
Dipso is offline   Reply With Quote
Old 15th December 2003, 22:45   #33
D&B
Banned
 
Join Date: Mar 2001
Posts: 1,027
Quote:
Originally posted by DrO
well to get a new build of jtfe out with all previous issues fixed and all the new ones working fully first time would be great for me
Sounds more like a Christmas present for us, but hey, if thats what you want....

Quote:
Originally posted by DrO
how about you badrad?
Ha, Im massively in debt due to school so I told everyone to get me cash. And a gameboy advance
D&B is offline   Reply With Quote
Old 15th December 2003, 23:08   #34
ozloi
Member
 
ozloi's Avatar
 
Join Date: Oct 2003
Location: http://www.danvers-state-ia.com
Posts: 50
Send a message via AIM to ozloi
not sure idf this been mentioned but here goes...i just updated to the lates build of winamp and when i wnet to check on the file icon setting and so forth the icons didnt appear...id upload a screenshot but i dont know how to upload images..
ozloi is offline   Reply With Quote
Old 15th December 2003, 23:38   #35
DrO
 
Join Date: Sep 2003
Posts: 27,873
@ozloi: already aware of it but thanks for saying - working on that for the next test release

@Dipso:

@badrad: happy users is all i want. also Lego is the way to go

-daz
DrO is offline   Reply With Quote
Old 16th December 2003, 05:33   #36
iron2000
Senior Member
 
iron2000's Avatar
 
Join Date: Mar 2002
Location: Singapore
Posts: 391
Does this work for modern skins only?

Thanx
iron2000 is offline   Reply With Quote
Old 16th December 2003, 05:58   #37
Rellik
Major Dude
 
Rellik's Avatar
 
Join Date: Oct 2003
Location: localhost
Posts: 1,099
It does work with classic skins that have the gen window bitmap defined
Rellik is offline   Reply With Quote
Old 16th December 2003, 08:07   #38
DrO
 
Join Date: Sep 2003
Posts: 27,873
@iron2000: it will work with any skin as long as you are using Winamp 2.9 upwards (will abort loading if the wrong Winamp version is found).

Modern skins will work correctly (due to the nature of them) and as Rellik said if the classic skin has support for general purpose windows then it will also appear correctly. if the classic skin does not then the classic base skin style will be used instead.

(personally i run with a the Winamp3 styled classic skin which looks 1337 i think )

as a note frame support is starting to go in (that's the fun part to do) and i've almost got tab controls fully sorted now, yay.

-daz
DrO is offline   Reply With Quote
Old 17th December 2003, 21:24   #39
maximumw
Junior Member
 
Join Date: Nov 2003
Location: Serbia
Posts: 31
The colors need's some work can't see all the text in pref. window!! Good work on "find on disk" its exactly what i have in mind but i did not understand jump to track and close after curent!
maximumw is offline   Reply With Quote
Old 17th December 2003, 21:41   #40
DrO
 
Join Date: Sep 2003
Posts: 27,873
@maximumw: the colours are all based on what is set in the skin which is basically out of my control.

jump to track allows you to specify a track to start playing, similar idea to the jump to time option that's already built in to Winamp.

close after current allows Winamp to stop and close once a track finishes playing. it's just an extension of the 'stop after current' option

-daz
DrO is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump