Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Wishlist

Reply
Thread Tools Search this Thread Display Modes
Old 25th March 2005, 15:10   #41
DrO
 
Join Date: Sep 2003
Posts: 27,873
Close after Current v1.5/1.5.1
  • Fixed an issue with the plugin's preference dialog and Modern skins
  • 'Persist' mode is now maintained if the stop button was pressed or closing was aborted
  • When not playing the menu entry is now greyed to indicate the mode is not available
  • (1.5.1 addition) Fix to allow Next on Stop v1.2.1 to advance to the next track correctly when the advance option is enabled (sends a fake stopping message)
download v1.5.1

thought i'd finally get around to fixing a few things with this that have been bugging me (no pun intended) for a while

-daz
DrO is offline   Reply With Quote
Old 25th October 2006, 19:15   #42
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Close After Current w/ Close To Tray

Sorry to post to a very old thread ... but this seemed the most appropriate place.

I recently installed the latest version of DrO's 'Close After Current' plugin (v1.5.2).

As with most all of DrO's plugins ... I love the concept and interface.
Unfortunately, I think I broke it.

Bug:

I have also installed DrO's 'Close To Tray' plugin. When 'Close To Tray' is installed along with 'Close After Current', 'Close After Current' will NOT exit Winamp when the track ends. Instead Winamp will stop and minimize ... i.e. these two plugins together turns 'Close After Current' into a stop & minimize after current.

The 'Close After Current' Logoff, Restart, and Shutdown options work fine with 'Close To Tray' installed.

Uninstalling 'Close To Tray' makes 'Close After Current' work as intended.

My System Specs:
  • Windows XP Professional SP2
  • DirectX 9.0c
  • Internet Explorer v6
  • Winamp v5.3 Full + Update Pack v5.3a
  • Separate User Setting Option
  • Running all the plugins in my signature
DrO - Please let me know if I can provide any other information.

Last edited by jph6t; 25th October 2006 at 19:42.
jph6t is offline   Reply With Quote
Old 25th October 2006, 19:40   #43
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Close After Current v1.5 - Grayed Menu

I don't know that I like the grayed menu entry introduced in v1.5
of DrO's Close After Current.

I actually think DrO is 100% right to gray the "Close after current" menu entry
when Winamp is NOT playing (to indicate the mode is not available) ...

HOWEVER, seeing as the Stop entries do NOT gray out when not playing (nor any of the other right-click menu options on the other buttons), graying out the "Close after current" entry ignores the pattern set forth by all the other menus and menu entries.

The perfect fix would be for all the other menus to go DrO's route, and gray out entries that are not available. But I imagine that would be a lot of trouble, so the quick fix would be to NOT gray out the "Close after current" entry when Winamp is not playing.
jph6t is offline   Reply With Quote
Old 26th October 2006, 03:02   #44
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Re: Close After Current w/ Close To Tray

Quote:
Originally posted by jph6t
Close After Current w/ Close To Tray Bug
Can anyone else replicate this bug?
jph6t is offline   Reply With Quote
Old 26th October 2006, 06:42   #45
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Close After Current w/ Close To Tray - Secondary Affect

Another strange behavior I noticed in relation to the above documented bug is that if "Close after current" is selected while 'Close To Tray' is installed ... and with tracks enqueued ... and then functionally speaking, Winamp is stopped & minimized ... when one maximizes Winamp, Jump To File (JTF) will no longer work.

Enqueued tracks will be ignored upon track advance, and the right-click JTF menu items will no longer work.

Granted this bug with JTF is not really a problem, as Winamp should have exited after "Close after current" instead of minimizing. Had it, we couldn't get to this scenerio.
jph6t is offline   Reply With Quote
Old 26th October 2006, 12:53   #46
DrO
 
Join Date: Sep 2003
Posts: 27,873
the two are working correctly as i'd expect them to do considering that they were never designed to work with each other. as such it's a feature request that we're looking at to get them to work with each other in a more consistant way.

the submenu ideally should be greyed out as you point out or just hidden when it's not even going to be useable (no point in showing something that's not needed). so i'll have to look into some updates either on one or both of them to introduce an override mode.

the jtfe issue isn't one i've seen but i vaguely remember someone reporting a similar issue before which i think is probably down the order in which the plugins are loaded/unloaded playing up. not one i can easily fix if i can't reproduce my end

-daz
DrO is offline   Reply With Quote
Old 26th October 2006, 13:34   #47
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
DrO -

Thanks for your attention to my post.

Quote:
Originally posted by DrO
the jtfe issue isn't one i've seen but i vaguely remember someone reporting a similar issue before which i think is probably down the order in which the plugins are loaded/unloaded playing up. not one i can easily fix if i can't reproduce my end
As I said above though, this is NOT really a bug, w/o the main bug present (which I described in my larger post above) we could never get to the point where this bug presents itself.
jph6t is offline   Reply With Quote
Old 28th October 2006, 15:04   #48
DrO
 
Join Date: Sep 2003
Posts: 27,873
Close after Current v1.6
  • Altered the plugin to only show the closing options submenu when Winamp is playing and not in all cases as before
  • Altered the internal handling on startup to work better with the Time Restore and Autoplay plugin's delay load option (could incorrectly cause this one to enter a load/unload loop)
  • Internal changes to allow this to work better with the Close to Tray plugin (when the compatability option is enabled in that plugin)
download v1.6

-daz
DrO is offline   Reply With Quote
Old 28th October 2006, 20:22   #49
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Re: Close After Current w/ Close To Tray

Wow! Quick turnaround on the new release(s). Thanks DrO!

So I installed 'Close After Current' v1.6 & 'Close To Tray' v1.2

The closing options sub-menu is indeed gone when Winamp is not playing.
Nice! I like that change! I didn't even think of that before.


I went into the Winamp Preferences and clicked the new option
in 'Close To Tray' to "Enable Close after Current support".

As far as interaction with 'Close To Tray' ... it's still not working as expected.

'Close After Current' no longer stops & minimizes, as noted above,
but instead choosing "Close after current" now just stops Winamp ...
i.e. these 2 plugins together turn 'Close After Current' into stop after current.
jph6t is offline   Reply With Quote
Old 28th October 2006, 20:41   #50
alex_gamer
Senior Member
 
alex_gamer's Avatar
 
Join Date: Apr 2006
Location: the crossroads of life...
Posts: 285
Re: Re: Close After Current w/ Close To Tray

Quote:
Originally posted by jph6t
i.e. these 2 plugins together turn 'Close After Current' into stop after current.
same here, DrO.

the computer is never at fault for an error; a human is, though.
DO NOT PM me for tech support.
No matter what you're doing, use the right tool for the job!
alex_gamer is offline   Reply With Quote
Old 28th October 2006, 20:42   #51
DrO
 
Join Date: Sep 2003
Posts: 27,873
i don't get that on my main install but just done a fresh winamp install and it's happened with that so i'm starting to think it's a plugin loading order issue (especially since you're running xp and i bet you're drives are ntfs formatted).

i'll look into this in a sec (had only just gotten back home)

-daz
DrO is offline   Reply With Quote
Old 28th October 2006, 22:36   #52
DrO
 
Join Date: Sep 2003
Posts: 27,873
Close after Current v1.6.1
  • Fixed the plugin to work without the persist mode having to be enabled (bug introduced in 1.6)
download v1.6.1

*take 2*

-daz
DrO is offline   Reply With Quote
Old 28th October 2006, 22:53   #53
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Re: Close after Current v1.6.1

I installed 'Close After Current' v1.6.1 & 'Close To Tray' v1.2.1

I only had a quick chance, before having to step out, to play around with the different scenarios and try and break either plugin ... but so far from here ...
seems 100%!!! Both look to working A-OK and as expected!

Nice work DrO!

I'll play with it more when I get home and if I find anything I will let you know.
jph6t is offline   Reply With Quote
Old 28th October 2006, 22:59   #54
DrO
 
Join Date: Sep 2003
Posts: 27,873
*fingers crossed* since i've spent too long trying to sort them out today

-daz
DrO is offline   Reply With Quote
Old 28th October 2006, 23:14   #55
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Quote:
Originally posted by DrO
*fingers crossed* since i've spent too long trying to sort them out today
I think you can likely rest easy DrO ... I've been breaking plugins like it was my job
the past week ... so I kind of have down the different combinations to check.

Sorry about all the bug reports btw. I feel bad about that. Hope you didn't take any offense. I really tried to play with it after finding a bug, and isolate the exact circumstances in which the bug would occur ... and then right a detailed description that would allow you to replicate with little effort (and hopefully aid in the debugging process).

As opposed to just posting a message that said:
"They don't work together. Please fix".

All the best ...
jph6t is offline   Reply With Quote
Old 28th November 2006, 18:19   #56
MertcanKaya1991
Member
 
MertcanKaya1991's Avatar
 
Join Date: Sep 2006
Location: TÃœRKÄ°YE
Posts: 83
Hey DrO. I made a turkish language file. If you want to put this i can send it to you. It's version is 1.0 because i don't understand the last sentence.
MertcanKaya1991 is offline   Reply With Quote
Old 28th November 2006, 18:23   #57
DrO
 
Join Date: Sep 2003
Posts: 27,873
yeah, emailing it to me is fine. what specifically is the issue you have for the translation?

-daz
DrO is offline   Reply With Quote
Old 28th November 2006, 18:32   #58
MertcanKaya1991
Member
 
MertcanKaya1991's Avatar
 
Join Date: Sep 2006
Location: TÃœRKÄ°YE
Posts: 83
ııı. i don't understand your question fully but i made it for use it turkish. Thats all. And i made a new language file for JTFE. But it isn't finished yet. The old one is too old. I can give it too you too when i finished it.
MertcanKaya1991 is offline   Reply With Quote
Old 28th November 2006, 19:18   #59
DrO
 
Join Date: Sep 2003
Posts: 27,873
i meant what is it that you didn't understand about the last sentance in the language file for this plugin

-daz
DrO is offline   Reply With Quote
Old 28th November 2006, 19:24   #60
MertcanKaya1991
Member
 
MertcanKaya1991's Avatar
 
Join Date: Sep 2006
Location: TÃœRKÄ°YE
Posts: 83
haa OK. Thanks.
MertcanKaya1991 is offline   Reply With Quote
Old 28th November 2006, 21:23   #61
DrO
 
Join Date: Sep 2003
Posts: 27,873
Close after Current v1.6.2
  • Fixed the language support to work again (the location of the plugins\cac folder wasn't being correctly generated)
  • Adjusted the language selection combo to not sort the files and to remove the editbox style to it
  • Added german and turkish translations
download v1.6.2

-daz
DrO is offline   Reply With Quote
Old 15th January 2007, 21:18   #62
cpopham
Junior Member
 
Join Date: Jan 2007
Posts: 4
I have just DL WinAmp and installed it and then I DL the DrO's latest version v1.6.2, WinAmp is playing my files, I have went into the plugins and set the mode to persist across instances, but I cannot find the shutdown options for WinAmp, I looked in all the menus, pressed CTRL SHFT and V and nothing.

Any ideas?

Thanks, Chester
cpopham is offline   Reply With Quote
Old 15th January 2007, 21:25   #63
Koopa
16-Bit Moderator
 
Koopa's Avatar
 
Join Date: Apr 2004
Posts: 4,341
Right click at the Stop button or take a look at the screenshot.

Koopa is offline   Reply With Quote
Old 15th January 2007, 21:54   #64
DrO
 
Join Date: Sep 2003
Posts: 27,873
the option is only available when winamp is already playing (was done for consistancy with other similar actions)

-daz
DrO is offline   Reply With Quote
Old 15th January 2007, 22:06   #65
cpopham
Junior Member
 
Join Date: Jan 2007
Posts: 4
I found it after reinstalling WinAmp. I may have had a bad install. Now, it closes the window when it is done, but the thread is still running and I cannot start WinAmp again until I kill the thread. The plugin should kill the thread as well right? I also notice that if I hit the close button on WinAmp, the thread stays alive. WinAmp is not minimizing to my tray, so the thread should stop when I close WinAmp, right?

The joys of figuring out new software
cpopham is offline   Reply With Quote
Old 15th January 2007, 22:17   #66
DrO
 
Join Date: Sep 2003
Posts: 27,873
the plugin just sends the same message as is sent when you click on the close button. try disabling in_wm.dll (just rename to in_wm.off) and see if that works (is the only thing i can think off if winamp's not closing correctly or someother installed 3rd party plugin is present maybe?). if not then there's a few other suggestions in this thread

-daz
DrO is offline   Reply With Quote
Old 15th January 2007, 22:27   #67
cpopham
Junior Member
 
Join Date: Jan 2007
Posts: 4
Perfect, thanks for the quick responses from everyone!!!

Chester
cpopham is offline   Reply With Quote
Old 15th January 2007, 22:30   #68
DrO
 
Join Date: Sep 2003
Posts: 27,873
can i ask which fix worked?

-daz
DrO is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Wishlist

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump