Old 24th July 2006, 03:56   #1
pjn123
Major Dude
 
pjn123's Avatar
 
Join Date: Jan 2006
Location: /\/¯¯¯¯¯\/\ , South-Africa
Posts: 1,030
BugAMP - A skin with current Winamp bugs

Working on my current skin, Winamp2006, I discovered a few bugs in WinampModernSkin Engine and disided to make a skin that will demostrate all these bugs I know of.

Please feel free to post your own updated version of this skin by changing the relevant info like build number and Winamp version and adding your extra bug, keeping the current type of layout.

I hope this will help Benski and other skin developers.

Attached: BugAmp build001
Attached Files
File Type: wal bugamp build001.wal (4.2 KB, 881 views)

ClassicPro© v2.01 : This plugin allows you to use cPro skins in Winamp. ClassicPro skins are all SUI skins and loads very quickly. ClassicPro skins is even easier to skin than Winamp Classic skins. A new layout have been added since version 2.
Download ClassicPro© ==== cPro Skins ==== ClassicPro© Homepage ==== SC Forums
pjn123 is offline   Reply With Quote
Old 24th July 2006, 12:11   #2
hammerhead
The Shark
(Forum King)
 
hammerhead's Avatar
 
Join Date: Jul 2002
Posts: 2,537
Send a message via AIM to hammerhead
Good idea, I'll post one later on about a SetTargetXY/A bug I've found.
hammerhead is offline   Reply With Quote
Old 20th August 2006, 23:48   #3
BugMaster
Member
 
Join Date: Jun 2006
Location: Russia
Posts: 63
May be it would be good to post this bugs in Core Bug Reports or Official Plugin Bug Reports threads.
Than it would be higher probability that Winamp Developers fix this bugs.
BugMaster is offline   Reply With Quote
Old 6th July 2007, 19:27   #4
Benski
Ben Allison
Former Winamp Developer
 
Benski's Avatar
 
Join Date: Jan 2005
Location: Brooklyn, NY
Posts: 1,047
Better late than never...

Horizontal slider issue and maximum w/h issue are fixed for 5.36. I'm still working through the others.
Benski is offline   Reply With Quote
Old 6th July 2007, 20:24   #5
SLoB
Major Dude
 
SLoB's Avatar
 
Join Date: Jul 2003
Location: UK
Posts: 1,316
good to hear bugs still being squashed Ben

this may have been logged before?
altho not related to this skin but in general
media library - Winamp Remote header/background doesnt change colour to match system color settings, still retains original modern winamp colours
SLoB is offline   Reply With Quote
Old 6th July 2007, 20:28   #6
Benski
Ben Allison
Former Winamp Developer
 
Benski's Avatar
 
Join Date: Jan 2005
Location: Brooklyn, NY
Posts: 1,047
Quote:
Originally posted by SLoB
good to hear bugs still being squashed Ben

this may have been logged before?
altho not related to this skin but in general
media library - Winamp Remote header/background doesnt change colour to match system color settings, still retains original modern winamp colours
I don't care much about Winamp Remote I think that's a problem on Orb's end.
Benski is offline   Reply With Quote
Old 6th July 2007, 20:32   #7
Benski
Ben Allison
Former Winamp Developer
 
Benski's Avatar
 
Join Date: Jan 2005
Location: Brooklyn, NY
Posts: 1,047
Also, a note for pjn123 and others. If you have this in your onTimer function

mytimer.onTimer()
{
mytimer.stop();
mytimer.start();
// do stuff ...
}

REMOVE IT

This just clogs up the system, and can hang Winamp if your timer value is smaller than the timer resolution, or if your timer takes an extremely long time.

Winamp will only call each timer once per "pass", and by calling stop()/start(), it removes the already-called-flag and so Winamp will call your timer over and over.
Benski is offline   Reply With Quote
Old 6th July 2007, 20:36   #8
SLoB
Major Dude
 
SLoB's Avatar
 
Join Date: Jul 2003
Location: UK
Posts: 1,316
glad you mentioned timers

timers need to be stopped say on a layout change as timers set to running in one layout still get called if another layout is visible, using mytimer.stop(); in the yourlayout.onSetVisible(Boolean on/off) event to make sure the timer is stopped when the layout is not visible
SLoB is offline   Reply With Quote
Old 6th July 2007, 20:55   #9
Benski
Ben Allison
Former Winamp Developer
 
Benski's Avatar
 
Join Date: Jan 2005
Location: Brooklyn, NY
Posts: 1,047
Hmm... and it looks like I may have fixed the dreaded 'can't unload script within script' error....
Benski is offline   Reply With Quote
Old 6th July 2007, 20:58   #10
SLoB
Major Dude
 
SLoB's Avatar
 
Join Date: Jul 2003
Location: UK
Posts: 1,316
so with all these bugs being fixed then Ben your looking for requests now? heheh
SLoB is offline   Reply With Quote
Old 6th July 2007, 22:06   #11
pjn123
Major Dude
 
pjn123's Avatar
 
Join Date: Jan 2006
Location: /\/¯¯¯¯¯\/\ , South-Africa
Posts: 1,030
Thanks Benski!
You really know how to surprise!

Quote:
Originally posted by Benski
and maximum w/h issue are fixed for 5.36.
The maximum bug fixed will help SUI skins that have a video frame/group with a fixed w/h... With "Resize video window" enabled Winamp goes mad and keep resizing the window bigger and bigger. IMO Winamp should disable that video option by default because that really irritates uninformed users... even in classic skin, especially if you just organized your windows and the video window start with it naughty tricks...

Anyway thanks Benski! I'll make use of the max w/h and setClipboard function in my next skin, Azenis 2.

Benski if you need another small bug:
In the Preferences >> Modern Skins... Current skin tab:
If a skin is in a wal file the info isn't displayed... just the name. Works 100% for modern skins in a folder aka extracted modern skins. No need to say but the above issue is just for skins without a custom about group... (see pic)
Attached Images
File Type: jpg smallbug.jpg (23.4 KB, 329 views)

ClassicPro© v2.01 : This plugin allows you to use cPro skins in Winamp. ClassicPro skins are all SUI skins and loads very quickly. ClassicPro skins is even easier to skin than Winamp Classic skins. A new layout have been added since version 2.
Download ClassicPro© ==== cPro Skins ==== ClassicPro© Homepage ==== SC Forums
pjn123 is offline   Reply With Quote
Old 9th July 2007, 07:46   #12
Logy
Senior Member
 
Logy's Avatar
 
Join Date: Jun 2004
Location: Terengganu, Malaysia, Asia, Earth
Posts: 302
same here when you click the skin tab and click the modern skin available and below the info... have the name only, not the info on the skin itself!!!! winamp default modern skin (it is display a info, because it is not in .wal extension!!!)

adios!!!

The English suffix -logy denotes a field of study or academic discipline.
Logy is offline   Reply With Quote
Old 20th August 2007, 03:23   #13
Benski
Ben Allison
Former Winamp Developer
 
Benski's Avatar
 
Join Date: Jan 2005
Location: Brooklyn, NY
Posts: 1,047
Smile

Tooltip bug has been fixed
Benski is offline   Reply With Quote
Old 23rd August 2007, 12:37   #14
martin.deimos
Android/UI Development
 
martin.deimos's Avatar
 
Join Date: Sep 2004
Location: Bavaria
Posts: 1,242
Send a message via ICQ to martin.deimos Send a message via AIM to martin.deimos Send a message via Yahoo to martin.deimos
pjn, for the video resize there is a cfgattrib:
PHP Code:
cfgattrib="{0542AFA4-48D9-4c9f-8900-5739D52C114F};Prevent video resize" 
set it to 0 on skin load and save it's original value and store it back on unload.
Nevertheless, i found another way to prevent this:
i fixed this w/ adding lockminmax="1" to my layout. so if wnd is maximized --> set it to 1 otherwise to 0

WebSite: www.skinconsortium.com - Community for Userinterface Design & Coding
Skins: Click Here
martin.deimos is offline   Reply With Quote
Old 23rd August 2007, 17:50   #15
pjn123
Major Dude
 
pjn123's Avatar
 
Join Date: Jan 2006
Location: /\/¯¯¯¯¯\/\ , South-Africa
Posts: 1,030
thanks martin!

Will test it later

ClassicPro© v2.01 : This plugin allows you to use cPro skins in Winamp. ClassicPro skins are all SUI skins and loads very quickly. ClassicPro skins is even easier to skin than Winamp Classic skins. A new layout have been added since version 2.
Download ClassicPro© ==== cPro Skins ==== ClassicPro© Homepage ==== SC Forums
pjn123 is offline   Reply With Quote
Old 24th August 2007, 04:20   #16
pjn123
Major Dude
 
pjn123's Avatar
 
Join Date: Jan 2006
Location: /\/¯¯¯¯¯\/\ , South-Africa
Posts: 1,030
lockminmax="1" works 100%! Thanks again.

Benski should really do this internal if the video container have relatw="0" || relath="0"

ClassicPro© v2.01 : This plugin allows you to use cPro skins in Winamp. ClassicPro skins are all SUI skins and loads very quickly. ClassicPro skins is even easier to skin than Winamp Classic skins. A new layout have been added since version 2.
Download ClassicPro© ==== cPro Skins ==== ClassicPro© Homepage ==== SC Forums
pjn123 is offline   Reply With Quote
Old 24th August 2007, 07:25   #17
martin.deimos
Android/UI Development
 
martin.deimos's Avatar
 
Join Date: Sep 2004
Location: Bavaria
Posts: 1,242
Send a message via ICQ to martin.deimos Send a message via AIM to martin.deimos Send a message via Yahoo to martin.deimos
i think it is up to us skinners, since for a normal window (no sui) i like it being resized to the normal video rez.
and adding this param to layout is not much effort

WebSite: www.skinconsortium.com - Community for Userinterface Design & Coding
Skins: Click Here
martin.deimos is offline   Reply With Quote
Old 24th August 2007, 10:21   #18
SLoB
Major Dude
 
SLoB's Avatar
 
Join Date: Jul 2003
Location: UK
Posts: 1,316
then it should go in some documentation somewhere and also be updated on the wiki/maki cheats thread
SLoB is offline   Reply With Quote
Old 24th August 2007, 13:37   #19
martin.deimos
Android/UI Development
 
martin.deimos's Avatar
 
Join Date: Sep 2004
Location: Bavaria
Posts: 1,242
Send a message via ICQ to martin.deimos Send a message via AIM to martin.deimos Send a message via Yahoo to martin.deimos
i hope to find more time for the wiki...
so if anyone will contribute:
http://wiki.skinconsortium.com
this should serve as the new wiki for all who need quick help, but needs much more contributors

WebSite: www.skinconsortium.com - Community for Userinterface Design & Coding
Skins: Click Here
martin.deimos is offline   Reply With Quote
Reply
Go Back   Winamp & SHOUTcast Forums > Skinning and Design > Modern Skins

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump