Old 25th December 2016, 13:52   #1
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
Fix breaks Playlist buttons

First of all, I wish you all a merry Christmas.

The iNTELLIdesign skin throws two error messages at startup:
  • mismatched tag at line 68
  • not well-formed (invalid token) at line 347
The first one is caused by this line in XML/system-colors.xml and can be fixed by adding a / before >:
PHP Code:
<color id="wasabi.text.color" value="color.Text" gammagroup="LCD"
The second one can be fixed by editing XML/standardframe.xml.

However, fixing the mismatched tag in system-colors.xml breaks the button bar in the playlist editor. I wonder how I could both fix system-colors.xml and not break the playlist editor.

The attached iNTELLIdesign_broken_pledit.wal fixes both standardframe.xml and system-colors.xml but breaks the playlist editor.
iNTELLIdesign_mismatched_tag.wal only fixes standardframe.xml: the playlist editor is ok but it starts up with a mismatched tag error message.
Attached Files
File Type: wal iNTELLIdesign_broken_pledit.wal (651.6 KB, 49 views)
File Type: wal iNTELLIdesign_mismatched_tag.wal (650.5 KB, 50 views)
ariszlo is online now   Reply With Quote
Old 25th December 2016, 14:21   #2
Aminifu
Forum King
 
Aminifu's Avatar
 
Join Date: Aug 2011
Location: Chicago, IL
Posts: 4,555
Happy Holidays!

What happens if you deactivate the mismatched tag line (remove it or turn it into a comment)?

Winamp Pro 5.666.3516 fully-patched - Komodo X Touchscreen by Victhor skin
Windows 10 Home 64-bit desktop - Logitech Z906 5.1 speaker system
Aminifu is offline   Reply With Quote
Old 25th December 2016, 16:44   #3
PeterK.
Senior Member
 
Join Date: Sep 2016
Posts: 180
Please bear in mind that this skin was designed (and coded!) for the 5.24 version from 2006(!).

Hence do not expect it to work properly with the latest 5.66 release.
PeterK. is offline   Reply With Quote
Old 25th December 2016, 18:22   #4
Victhor
Late skinner & Moderator
 
Victhor's Avatar
 
Join Date: May 2003
Location: Argentina
Posts: 1,382
Actually, from Winamp 3 (when modern skins were implemented), most skins work properly, so is more likely that if it's not working is due to a faulty skin that from something implement by Winamp..

· · TMCT · KOMODO X
Victhor is offline   Reply With Quote
Old 25th December 2016, 19:07   #5
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
Quote:
Originally Posted by Aminifu View Post
What happens if you deactivate the mismatched tag line (remove it or turn it into a comment)?
The playlist buttons will be broken.

Quote:
Originally Posted by PeterK. View Post
Please bear in mind that this skin was designed (and coded!) for the 5.24 version from 2006(!).
Hence do not expect it to work properly with the latest 5.66 release.
OK but it is still weird why the playlist buttons are all right with a mismatched tag in system-colors.xml and broken with a syntactically correct system-colors.xml.

Quote:
Originally Posted by Victhor View Post
Actually, from Winamp 3 (when modern skins were implemented), most skins work properly, so is more likely that if it's not working is due to a faulty skin that from something implement by Winamp..
Yes, I am trying to figure out what is done wrong with this skin.
ariszlo is online now   Reply With Quote
Old 25th December 2016, 20:02   #6
Victhor
Late skinner & Moderator
 
Victhor's Avatar
 
Join Date: May 2003
Location: Argentina
Posts: 1,382
On line 347 there is a opening comment-out sign which sort of ends on 356/357. The closing sign ("--") is duplicated. I think that'll solve it.

· · TMCT · KOMODO X
Victhor is offline   Reply With Quote
Old 25th December 2016, 21:03   #7
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
Yes, it fixes the second error message but not the first one.
ariszlo is online now   Reply With Quote
Old 26th December 2016, 03:35   #8
Victhor
Late skinner & Moderator
 
Victhor's Avatar
 
Join Date: May 2003
Location: Argentina
Posts: 1,382
Weird.. really fixing a syntax error triggers the other error... tried a lot of things, couldn't make it work really.

The closer I got was to revert the PL buttons to a generic wasabi style... not ideal but functional ¬_¬

Attached just the XML's I've changed.
Attached Thumbnails
Click image for larger version

Name:	Playlist.jpg
Views:	63
Size:	61.0 KB
ID:	52917  
Attached Files
File Type: zip XMLs.zip (2.9 KB, 35 views)

· · TMCT · KOMODO X
Victhor is offline   Reply With Quote
Old 27th December 2016, 17:17   #9
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
Thanks Victhor for trying to help. I have figured out how to fix this.

1. In skin.xml, I added this line:
<include file="xml/standardframe.xml"/>
after this:
<include file="xml/system-colors.xml"/>

2. Moved this line up:
<include file="xml/tabsheet.xml"/>
before this:
<include file="xml/pledit.xml"/>

The skin is not ready for publication, yet. It still has some minor issues and I will have to get permission from the original authors, too.
Attached Files
File Type: wal iNTELLI_design_1.2-wip.wal (624.4 KB, 39 views)
ariszlo is online now   Reply With Quote
Old 14th January 2017, 18:26   #10
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
Fixed everything I wanted to fix. Changelog in the readme.
Attached Thumbnails
Click image for larger version

Name:	iNTELLIdesign-1.2.png
Views:	40
Size:	101.2 KB
ID:	52951  
Attached Files
File Type: wal iNTELLIdesign_1.2.wal (596.1 KB, 34 views)
ariszlo is online now   Reply With Quote
Old 22nd January 2017, 09:48   #11
ariszlo
Senior Member
 
Join Date: Jun 2015
Location: Hungary
Posts: 270
The version number of the skin in the previous post should be relegated to 1.2-wip2.
ariszlo is online now   Reply With Quote
Reply
Go Back   Winamp & SHOUTcast Forums > Skinning and Design > Modern Skins

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump