Opus support? {Implemented with a 3rd party plug-in by thinktink)

[Omega X]

Version 1.1.15.36 is being recognized as malware by Avast.

[thinktink]

Be specific please.

[thinktink]

Originally Posted by Omega X

Version 1.1.15.36 is being recognized as malware by Avast.

Unable to replicate:

Plugins/in_bpopus.dll
https://www.virustotal.com/en/file/f...6a2b/analysis/

Plugins/enc_bpopus.dll
https://www.virustotal.com/en/file/c...dc9b/analysis/

opusfile/libogg-0.dll
https://www.virustotal.com/en/file/d...e026/analysis/

opusfile/libopus-0.dll
https://www.virustotal.com/en/file/2...1730/analysis/

opusfile/libopusfile-0.dll
https://www.virustotal.com/en/file/8...4260/analysis/

BogProgOpus1_1_15_36Install.exe
https://www.virustotal.com/en/file/9...03d3/analysis/

[Kaminari]

Avira doesn't report suspicious signature either.

[Omega X]

The zip attachment was throwing off a warning.

What ever it was, its not triggering today. Might have just been a false positive.

[thinktink]

Sounds like a silent background update to remove the false positive.

[kzuse]

I have another question.

What exactly is the file "ShellExecAsUser.dll" for, which is included in the installer? Is it installed alongside the other files or is it only part of the installer?

Thank you!

[thinktink]

Originally Posted by kzuse

I have another question.

What exactly is the file "ShellExecAsUser.dll" for, which is included in the installer? Is it installed alongside the other files or is it only part of the installer?

Thank you!

It is only for the installer.

[kzuse]

Thanks!

[kzuse]

Whereas it works like a charm on Windows XP, I can't get it running on Win 7 (32-bit)...

It seems it doesn't find the opusfile dlls, although I see in ProcessMonitor that they get read by winamp.exe.

But in bpopus's about box, it says "Opus library not installed".

Where have the files to be placed in Win7? Not inside the Winamp Program folder unter .\opusfile?

Under XP this works perfectly (I manually extracted them from the installer).

Thank your for any advice!

[thinktink]

The opus library files should be getting installed into "%PROGRAMFILES%\Winamp\opusfile".

The installer also includes a Winamp compatible opus encoder that also loads the files. If you remove enc_bpopus.dll from the plugins folder and the opusfile libraries aren't loaded anymore then it means I didn't update in_bpopus.dll load path, but that's a bit odd since the the load path is coded in the same file that is shared between the separate projects (it's a load dynamic encapsulation unit) so I would be a bit be-puzzled if that happens.

[thinktink]

Attached is a special build of the plugin that will pop a message box that should point to the full path of the Winamp executable. Extract it and temporarily install it into the \Plugins folder and 1) Tell me what it says; 2) See if it works.

[kzuse]

Thanks... under Win7, it pops up and says "C:\Program Files\Winamp\winamp.exe" two times on Startup of Winamp.

But, still it says "Not installed" for the opusfile Libraries and opus Playback doesn't work. I have both in_bpopus and enc_bpopus installed in the Plugins folder. I also have the "opusfile" folder correctly located under Winamp's Program directory.

As I said, if I investigate with "Process Explorer", I see that those files also get loaded into memory. Maybe they are incompatible with Windows 7?

Under XP, everything is fine! Whether with the build 36 or with build 37 (which only pops up one time under XP, and it says "C:\Programme\Winamp\winamp.exe" as under XP the Program Files directory was localized to German, not so in Windows 7!). Under XP I can play opus files perfectly.

Strange issue...

Unfortunately I am on a business trip from tomorrow until Wednesdeay so I cannot further investigate at my home PC (which is the one that runs Windows 7) until then.

Thanks for your effort!!!

Best regards,
kzuse

[thinktink]

Originally Posted by kzuse

Thanks... under Win7, it pops up and says "C:\Program Files\Winamp\winamp.exe" two times on Startup of Winamp.

But, still it says "Not installed" for the opusfile Libraries and opus Playback doesn't work. I have both in_bpopus and enc_bpopus installed in the Plugins folder. I also have the "opusfile" folder correctly located under Winamp's Program directory.

Damn, this must mean that for some reason either Win7 is remapping calls or I screwed something up on the dynamic search and load for the support libraries.

When you get a chance, install the attached build 39. It will (if successful, other wise it will beep insistently until Winamp finishes loading) create a log file named "OpusLibSearchLog.txt" on your desktop. Attach that file in your next post.

[kzuse]

Hi thinktink,

thanks for the experimental Build. I ran it on both my XP and my 7 machine. (Both 32 bit, both German OS and German Winamp):

I attached both files.

The only difference is the path and the fact that Win7 seems to do the Plugin search twice. But it really seems that he can find the DLLs and read the files but somehow, he refuses to load them. In the about box of in_bpopus, it still says: Not installed.

Strange thing....

[thinktink]

That's interesting...

[thinktink]

Close Winamp, delete the old log, extract and install the newly attached and post the new log. I have a suspicion that the libraries are not loading but why I don't know. This new one will log the OS error codes from the calls to load the libraries.

[kzuse]

So.... it seems Windows refuses to load libopusfile. I guess this has something to do with ASLR (Address Space Layout Randomization) or DEP (Data Execution Prevention) or DLL rebasing or any combination of these three, which play an important role in Windows 7 but not so in Windows XP.

See attached log file.

The message
"Error: 998 Unzulässiger Zugriff auf einen Speicherbereich."

is in German and could be translated more ore less like this:

"Error: 998 Disallowed Access to a memory address"

And ideas?
Is libopusfile to blame?

I used the one from your installer package....

Have you managed to get the plugin running on a Windows 7 (32 bit)?

Thank you and have a nice weekend!!!

[DrO]

last time I saw that error code when loading a dll was due to the file being corrupted.

[kzuse]

Hmm... I don't think it's corrupted. I extracted it from a ZIP, which should have thrown an error if the checksum was incorrect...

I also double-checked the files on my XP machine and on the Windows 7 one (with both CRC32 and MD5) and they are definitely identical...

[thinktink]

Originally Posted by kzuse

...
Is libopusfile to blame?
...

Looks like it is. :|

It is odd that it seems fine on Win7 64bit. Or maybe its because of the language version of Windows you're running. I'm going to try a different loading pattern later on and see if it works.

[thinktink]

Forgot to mention, go into the library folder and remove the Read Only flag on all if the DLLs and see if it works. It's a long shot but just in case...

[kzuse]

None of the libraries has the Read Only flag set.

BUT I have found a Workaround!!!!!

I just now use the three libraries from:
https://ftp.mozilla.org/pub/mozilla....-0.2-win32.zip

instead of the ones you included in the Installer.
Although these ones are older (!!!!!!) than your ones. I actually ask how that can be and where your ones come from? I think the ones from the Opus/Mozilla server are always the newest ones.

Alas, it does work fine with those ones. Maybe you should update the installer with the files. Now I can play back opus files on both Win7 and XP - perfect

Best regards,
kzuse

[thinktink]

It must either be the installer, Winamp's optimizer, the OS during the install, or Win7 32bit doesn't like loading DLLs with the Read Only flag set. I downloaded the zip file you linked to and compared all the DLLs in a hex editor and could not find any differences.

The DLLs in the plugin installer (I re-downloaded it from the forums just in case) are exactly the same as the ones from the link you provided.

If it happens again, chuck all three DLLs into a zip archive and attach it here. Might provide a clue as to how it's happening and how to prevent it.

[DrO]

the optimizer stage in the Winamp installer is no longer present in the recent 5.7 beta and 5.64 builds. unless this is all being done against an older version... (haven't looked properly at any of the earlier posts about this so i've probably missed what Winamp version is being used).

[thinktink]

The archive you posted is exactly the same as the archive I used for the support libraries, I compared the two in a hex editor. These are the DLLs I'm using in the installer.

http://www.opus-codec.org/downloads/
https://ftp.mozilla.org/pub/mozilla....-0.2-win32.zip

Something is going on on your machine (if you're using the latest version of Winamp that doesn't optimize stuff anymore.)

"When you have eliminated the impossible, whatever remains, however improbable, must be the truth"

[kzuse]

This is really, really, really strange.

I just redownloaded the installer, extracted it with 7zip and voila, the DLLs are the same to the ones from the Opus/Mozilla site!!! (Same checksums).

Seems that some rebasing or some other strange mechanism has changed them on my machine. I also did a virus check but couldn't find anything.

I replaced them on all my machines now (XP and 7) with the ones from the Opusfile site.


For documentary and research purposes, I attach the ones I had before and where libopusfile doesn't load under Win7. (I also double-checked them with AntiVir but one can never be sure - so download them at your own risk, but I don't think its a malware issue).

I cannot explain it in any way...

[thinktink]

I looked at them in a hex editor and I can confirm that they're getting changed like I had seen before with the Winamp installer's optimizer though I can't tell if it's actually the Winamp installer or some other program doing it.

[kzuse]

OK I think I got it.

I already had your plugin installed BEFORE I had Winamp 5.64. (it was 5.63).

Then I took the (extracted) DLLs to my Win7 computer, not thinking of that they might have been changed and optimized for my XP PC.

The only odd thing about this theory is that Optimization actually should only occur upon running the Winamp installer, and the 5.63 installer was never run AFTER the in_bpopus installation. I only ran the 5.64 installer, which shouldn't do optimization... still strange, but I think it has something to do with the prior 5.63 installation on my machine.

[DrO]

well something was done to the dlls to cause it to happen so there must have been some re-run of the Winamp installer which had that feature - as some of the early 5.7 builds did. though this is one of the reasons why we ended up disabling the optimisation stage (despite the advantage it had on loading times for older machines), the other being that it was causing failures to load on Vista and more specifically Windows 8 (though why some dlls causes the OSes BindImage(..) method to corrupt the dlls is beyond what i could work out).

[embryonic]

Winamp is refusing to play Opus files with Unicode characters in their paths.

Files in other formats work fine, as do Opus files with normal names.
When I rename them to remove Unicode characters, Winamp plays them normally.

Please look into it if possible.

[thinktink]

Originally Posted by embryonic

Winamp is refusing to play Opus files with Unicode characters in their paths.

Files in other formats work fine, as do Opus files with normal names.
When I rename them to remove Unicode characters, Winamp plays them normally.

Please look into it if possible.

That's odd, I thought I already solved that issue. Which version of the plugin do you have installed? There is a torrent out and about of a really old version of the plugin and it didin't do unicode named files very well. Also. would it be possible to provide an example file inside a zip archive to test with?

[embryonic]

I tried both 1.1.15.36 and 1.1.15.43 with the newest Opus libraries.

Some files work, but some files don't even if they have the exact same name. Some work when put into C: and not in D:, but some don't work at all. It's hit and miss.

[thinktink]

Originally Posted by embryonic

I tried both 1.1.15.36 and 1.1.15.43 with the newest Opus libraries.

Some files work, but some files don't even if they have the exact same name. Some work when put into C: and not in D:, but some don't work at all. It's hit and miss.

Thank you for the example. I will look into it now.

[thinktink]

It seems to be working just fine on my WinXP devel. machine (including inside that unicode named folder and on my D: (pen) drive.) What are your system specs and Winamp version? Might be easier to provide a Koopa Info Tool report.

[embryonic]

I'm using Windows 8 x64 with Winamp 5.64.

Report is attached below.

[Kaminari]

No problem here with build 36 and Unicode (Win7-64).

[thinktink]

Hang on a tic. Something's up.

[EDIT/]
Nevermind, false alarm.

[thinktink]

Save your current playlist and then clear it.

Close Winamp.

Extract, and install the attached in this post.

Reopen Winamp and put one of the offending files in your playlist and play it once.

Close Winamp (and I recommend reinstalling the current release version (build 36)).

Doing so with the attached build will generate a log file on your desktop named "OpusFileNamesLog.txt". Please attach it in your next post.

[EDIT/]
Forgot the attachment.

[embryonic]

I am posting two logs, one is working and one is not.