Old 17th January 2011, 21:43   #1
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Question Please add an optional no text CRC progress dialog

Greetings:

I have asked this in the past a few times and have been told that I just need to modify the NSIS source code. Unfortunately, our legal department does not allow us to touch the source code, so that option is out.

The issue is that the initial "Setup is validating... 99%" (sorry, I know the text is incorrect) is in English with no option for localization nor for individual installer to adjust that text.

Would it be possible to add an option for suppressing this text into the NSIS installer settings? The result would be the installer icon and a numerical percentage only on that dialog that should be self-evident to the customer as to what is going on.

Is there any other ideas that anyone else has on resolving this? Turning off the CRC is pretty much out of the question as it could lead to installing corrupt data.

Derek
CrushBug is offline   Reply With Quote
Old 17th January 2011, 23:29   #2
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,178
Did you try hex editing the stub? Replace the text with just %d%% (and a ending 0)

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 18th January 2011, 02:30   #3
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Sorry, I don't know all the files off hand. What is the file name of the stub? Thanks for the suggestion, I look forward to trying it out.
CrushBug is offline   Reply With Quote
Old 18th January 2011, 07:00   #4
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,178
NSIS\stubs

Something like

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 18th January 2011, 22:45   #5
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Thanks Anders, I will take a shot at this.

Back to the original issue. We have been joyfully using NSIS for about 8 years now and this is one of the issues that our Localization QA and Cert always ding us on and we have to fight back with "Cannot Fix".

Do you think that this is something that could be fixed natively within NSIS in some manner? Something like adding a new stub "lzma_notext" and SetCompressor support?
CrushBug is offline   Reply With Quote
Old 19th January 2011, 00:15   #6
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
Why not get your coders to submit a patch? Or would your legal department not allow that?

Stu
Afrow UK is offline   Reply With Quote
Old 19th January 2011, 00:57   #7
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
We are not allowed to download the source code, thus we are blocked from that as well.

I did find the string "verifying installer: %d" in the "lzma" stub but I could not find the string "Please wait while Setup is loading..." so hex editing the stub would only help with one part. If that string is stored elsewhere, please let me know and I would be willing to give it a shot.

The primary concern is the message in the French market and the Toubon Law since those English strings are shown on a French OS.

Thanks to both of you for responding on this matter.
CrushBug is offline   Reply With Quote
Old 19th January 2011, 08:12   #8
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,178
http://nsis.svn.sourceforge.net/view...37&view=markup shows the 6 hardcoded english strings, "verifying installer: %d%%" appears in all stubs, "unpacking data: %d%%" is only present when solid compression is used. I don't remember anything along the lines of "Please wait while Setup is loading..."

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 19th January 2011, 11:15   #9
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
Please wait while Setup is loading... is in MUI only. Without checking it is probably hard coded in modern.exe.

Stu
Afrow UK is offline   Reply With Quote
Old 19th January 2011, 15:29   #10
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,178
Quote:
Originally Posted by Afrow UK View Post
Please wait while Setup is loading... is in MUI only. Without checking it is probably hard coded in modern.exe.
You are correct sir, thankfully it is easy to change that with ChangeUI and resource hacker

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 19th January 2011, 17:43   #11
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Oh, ok, so this is a little more complicated and yes, we are using MUI2. Thanks again for your help.

I have searched through the files in my NSIS install directory and I cannot find the "Please wait while Setup is loading" string in modern.exe or any other files. Can either of you direct me where I should be looking or if I shouldn't be looking for plain text?
CrushBug is offline   Reply With Quote
Old 19th January 2011, 17:50   #12
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Sorry, I forgot to search for text in wide format, so I did find "‚Please wait while Setup is loading..." in modern.exe

A hacking I will go... a hacking I will go...
CrushBug is offline   Reply With Quote
Old 19th January 2011, 19:56   #13
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
You could have used Resource Hacker to modify modern.exe.

Stu
Afrow UK is offline   Reply With Quote
Old 19th January 2011, 20:01   #14
DrO
 
Join Date: Sep 2003
Posts: 27,873
funny that, hacking the exe is fine but doing it the proper way in the code isn't allowed (sounds like you legal department have too many bugs of their own).

-daz
DrO is offline   Reply With Quote
Old 19th January 2011, 21:46   #15
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Quote:
You could have used Resource Hacker to modify modern.exe.
I will, once I get back to this.

Quote:
funny that, hacking the exe is fine but doing it the proper way in the code isn't allowed
At this point, it hasn't gone back to legal for approval (and I doubt they would give it). I am just trying to see if resolving this myself is even possible.

Their core issue they have has to do with downloading open source source code. There aren't that many problems with using pre-compiled open source solutions (NSIS for example =).

But to get back to the original point, it would certainly be beneficial if NSIS offered at least a No Text options for these messages natively. Even better if they were fully localized. Considering the massive and awesome localization support that NSIS offers (I have made internal version of our installers in pirate and wookie) the fact that this message is hard coded in English feels like a tragic oversight.
CrushBug is offline   Reply With Quote
Old 20th January 2011, 18:00   #16
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,178
They can't be localized since the language stuff has not been loaded when that dialog is open

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 20th January 2011, 18:39   #17
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
Quote:
Originally Posted by Anders View Post
They can't be localized since the language stuff has not been loaded when that dialog is open
Fair enough and that makes sense. At that point a no text option would get us out of trouble with loc and cert.
CrushBug is offline   Reply With Quote
Old 21st January 2011, 02:39   #18
JamesBellinger
Junior Member
 
Join Date: Jan 2011
Posts: 2
Is there a reason those strings couldn't be localized by default for major languages? It would probably take under 1 KB.
JamesBellinger is offline   Reply With Quote
Old 21st January 2011, 17:41   #19
CrushBug
Senior Member
 
Join Date: May 2005
Posts: 119
I think they could be, but the issue is more like there is no code in those stubs for OS system language detection. While the strings themselves could be small there would probably be challenges with detection and displaying the strings properly in all situations.
CrushBug is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump