Opus support? {Implemented with a 3rd party plug-in by thinktink)

[Koopa]

Originally Posted by thinktink

Ok, that's just weird. I can't think of anything specific with the new code that could cause issues like that so fast. From the txt report it seems like it's something in the metadata handling though you telling me that it happens as soon as you try to encode something that it crashes (instead of after encoding metadata during the transfer).

As an experiment, keep the previous version of in_bpopus but install the new version of enc_bpopus and see what it does. Then do new version of in_bpopus and old version of enc_bpopus and see what happens there.

I sadly only saved a copy of the old enc_bpopus.dll, before i upgraded to 1.5 could you give me a copy of the old in_bpopus.dll v1.4.26.96? Then I will make the test.

[thinktink]

Attached (hopefully).

[Koopa]

Thanks.

Just tested it, the old in_bpopus.dll (v1.4.26.96) and the new enc_bpopups.dll (v1.3.5.11) don't produce any crash.

With the newer in_bpoups.dll (v1.5.27.100) I get a crash as soon as the transcoder window was opened.
I hope this info will help you.

[thinktink]

I can't think of any reason for enc_bpopus to be even aware of in_bpopus let alone be accessing anything during the transcoder configuration window. They share source code but even at that they each get their own copy.

Continue using the old in_bpopus with the new enc_bpopus 'till I get this damn mess sorted out...

[Koopa]

Originally Posted by thinktink

I can't think of any reason for enc_bpopus to be even aware of in_bpopus let alone be accessing anything during the transcoder configuration window. They share source code but even at that they each get their own copy.

Continue using the old in_bpopus with the new enc_bpopus 'till I get this damn mess sorted out...

I was wondering about it too, because when I transcode an mp3 file to opus, the Nullsoft MPEG Audio decoder should be the input plugin which is used for decoding during the transcoding process.

Don't worry, I'm sure that you will find the cause of it and if you need any testing etc, just lemme know.

[thinktink]

If you remove/rename libsoxr.dll inside Winamp's main install directory, do the errors from enc_bpopus.dll stop?

[thinktink]

See if the attached (no installer) clears up the problems with the tag editor.

I'm having suspicions that libsoxr.dll is corrupting the heap(s), how, I don't know, but when I remove libsoxr support the crashes from enc_bpopus.dll stop. The crashes are occurring during memory (de-)allocation.

[thinktink]

New version 1.5.28.102 (with encoder version 1.3.6.21) now available for download.
Download

• Fixed encoder (frame misalignment.)
• Fixed decoder (pointer check and CRITICAL_SECTIONed access.)
• Added ENCODER_OPTIONS tag to show the options set for the encode (kinda like what is shown from the Opus tools package.)

What's the difference between a pregnant woman and my plugins? I can unscrew my plugins...

[Koopa]

v1.5.28.102 (with encoder version 1.3.6.21) fixed any transcoder related crash for me.

Though, i still have the frozen alt+3 dialog window as soon as i open the tag editor.

[thinktink]

Try this, load a non-opus file into your playlist and open the tag editor, select the first tab and change something in the first tab WITHOUT switching tabs before closing the tag editor, then re-open the tag editor for an Opus file, see if it crashes.

[Koopa]

Just did it, I've loaded a MP3 file to my playlist > opened the tag editor > switched to the basic tab > changed something > pressed ok.

Then I loaded an opus file to my playlist > this time I successfully could open the alt+3 dialog > I could use the basic tab and the artwork tab > when i switch to the advanced tab it hangs, but no crash:



I'm not able to do anything when the the advanced tab is selected.

[thinktink]

Damn. Hangon, I'll upload a version with the advanced tab removed. I think I know what it is but it's going to take a very long time to fix.

[thinktink]

Version 1.5.29.106 available.

As a work-around I've removed the column header from the list view that shows which tags are available in the file and it seemed to stop showing the caught internal exception (shows up as a superfluous debug breakpoint on my install.)

Download

[thinktink]

Working correctly now?

[Koopa]

Originally Posted by thinktink

Version 1.5.29.106 available.

As a work-around I've removed the column header from the list view that shows which tags are available in the file and it seemed to stop showing the caught internal exception (shows up as a superfluous debug breakpoint on my install.)

Download

That is just working fine, I can use the advanced tab and nothing hangs or freezes.

[thinktink]

Version 1.5.30.112 available.

• Restored sanity on the Advanced tab: Put the column headers back in and fixed the UI of the Value edit box.
• Changed the tags updating code to keep compatibility with the code changes in libopusfile v0.6
• Installer package includes the updated libopusfile v0.6 libraries(recommended update.)

Download

Originally Posted by MyInbox

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

opusfile version 0.6

I'm pleased to annouce the latest development release of the opusfile
playback library.

Changes since the v0.5 release:
- Fix bugs with comment handling
- Fix build for BSD
- Fix bugs handling invalid and non-opus streams

Some of these bugs kept basic functionality of the APIs from
working at all, so we recommend all users upgrade.

Downloads:

http://downloads.xiph.org/releases/o...ile-0.6.tar.gz
http://downloads.xiph.org/releases/o...usfile-0.6.zip

or

https://ftp.mozilla.org/pub/mozilla....ile-0.6.tar.gz
https://ftp.mozilla.org/pub/mozilla....le-0.6.tar.zip

and


https://ftp.mozilla.org/pub/mozilla....-0.6-win32.zip

A version is available for Mac through the Homebrew package manager.

SHA-2 checksums:

2428717b356e139f18ed2fdb5ad990b5654a238907a0058200b39c46a7d03ea6
opusfile-0.6.tar.gz
753339225193df605372944889023b9b3c5378d672e8784d69fa241cd465278c
opusfile-0.6.zip
5c461b6e037f3843b31295c1eefbaf785bf165442f47fc90267bbcbd939b6e1b
opusfile-0.6-win32.zip

The opusfile and opusurl libraries provide a high-level API for
decoding and seeking within .opus files on disk or over http(s).

opusfile depends on libopus and libogg.
opusurl depends on opusfile and openssl.

The library is functional, but there are likely issues
we didn't find in our own testing. Please give feedback
in #opus on irc.freenode.net or at opus@xiph.org.

Programming documentation is available in tree and online
at http://opus-codec.org/docs/

Thanks to everyone who contributed!

-r
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTm0GlAAoJEEcAD3uxRB3vcJIH/1S93Rzb9CB0NhVKXhBmB9B+
HBAesIvfDa0EgQmKQwu2HxA8zLcZq1Auwtx0AX23Gd3uYtbwEADWer1ZD/tGTR2B
rLbXcd/7FIewa3IX3T/1FOwIodQ3mGrPhWbgQVevM3REb16qZXyfYRukUJDTrlJ8
J//Uu2HHkaoo0nkw+cuPoVpokVY/Z3yq6Mwr40o2Go6NRlPKPPY956DIBVExR4vH
ObYozKHW3gekXWKK2dJtdmsboE1WS+MD7dH/xep+LEQvZhgU1ArnWXojes/o3yFJ
16W8pYvsG9ml6i0+4j9Z6Ntxt5mCTcm7ekN/fIGSCbS/pTb82MtJkjOluCvvqdA=
=dBdW
-----END PGP SIGNATURE-----

[kzuse]

If I try to open this stream, the plugin crashes with a dialog box saying "Abnormal program termination":

http://fokus-europa.de/podlove/file/...ommission.opus

(Not only in this version, but also in the previous one.)

All other podcast streams I tried until now are working perfectly. Maybe it's a corrupt bitstream, but anyway it shouldn't crash

Best regards,
kzuse

[Kaminari]

I don't have any issue opening this url directly into Winamp. It doesn't appear to be a stream but a 30 MB file.

[thinktink]

Originally Posted by kzuse

If I try to open this stream, the plugin crashes with a dialog box saying "Abnormal program termination":

http://fokus-europa.de/podlove/file/...ommission.opus

(Not only in this version, but also in the previous one.)

All other podcast streams I tried until now are working perfectly. Maybe it's a corrupt bitstream, but anyway it shouldn't crash

Best regards,
kzuse

I agree it should never crash even on a bad stream or file but I am unable to reproduce your error on Windows 7 Pro 64bit SP1 or on Windows XP Home 32bit SP3. I tried playing directly from the remote site and playing it from the local harddrive (after downloading) on both systems. I checked metadata viewing/editing, album art, transcoding, and replay-gain calculations.

[kzuse]

OK so it's probably the URL handler. I forgot to extract the opusurl related files... As they weren't present in older versions too, and some other remote files do work well also WITHOUT them present (so bpopus uses its internal URL handler)...

Maybe this internal handler has an issue, but this issue isn't exposed, because the handler is not used as long as the DLLs are present...

[thinktink]

Originally Posted by kzuse

OK so it's probably the URL handler. I forgot to extract the opusurl related files... As they weren't present in older versions too, and some other remote files do work well also WITHOUT them present (so bpopus uses its internal URL handler)...

Maybe this internal handler has an issue, but this issue isn't exposed, because the handler is not used as long as the DLLs are present...

1. Why didn't you just run the installer?
2. Exactly which files did you forget to extract?

[kzuse]

1. Because I love to experiment (And see how it works and what is written, before I run an installer...)

2. I didn't extract the following files, as in previous versions it worked without them as well (and also in the current one, many other file links do work well):

- libeay32.dll
- ssleay32.dll
- libopusurl-0.dll

I now added them as they seem to be important, also if one doesn't open HTTPS connections to stream podcast episodes...

[thinktink]

k, I think the fix is in. Will post a beta version later.

[thinktink]

Originally Posted by kzuse

...

- libeay32.dll
- ssleay32.dll
- libopusurl-0.dll

...

Remove those 3 files, install the contents of the attached into the plugins folder, and see if it still crashes. I doubt it will but I want to make sure it doesn't before publishing.

[kzuse]

Unfortunately, it still does (it first shows "Waiting for data..." for one or two seconds or so, then Winamp just closes). It doesn't show the "Abnormal program termination" box any more.

With the mentioned files present, it works fine... So I think you shouldn't invest too much time in the own URL handler code... Maybe it's some strange redirection scheme those podcast servers use. Because if I try to download one of those episodes with wget, I don't get directly the OPUS file, but I rather get an index.html file containing the start page from "metaebene.me" which is the homepage of this podcasters network.

Try

wget http://logbuch-netzpolitik.de/podlov...-orgelbau.opus

And for some reason you don't end up getting an .opus file on your hard disk.


------

Alas, I found another issue which is more like a bug, it's in the new advanced tag options tab:

The "Value" column of the list view doesn't seem to correctly render unicode characters, whereas the Value textfield on the right does (and also the unicode characters are in the normal Tag box "Comments" displayed correctly). Probably the list view isn't unicode capable on its own so the unicode characters must first be decoded to ANSI, I think? One could also consider this a cosmetic bug, but it's at least confusing to a new user who isn't aware of those Unicode issues...

Look at this example:


Best regards, many thanks and a nice sunny weekend,
kzuse

[thinktink]

Originally Posted by kzuse

Unfortunately, it still does (it first shows "Waiting for data..." for one or two seconds or so, then Winamp just closes). It doesn't show the "Abnormal program termination" box any more.

Well, I guess it's an improvement. I also found a hang issue while the plugin is waiting for data to come in (that never does) and found a couple of exceptions that weren't getting caught. I'm not seeing them anymore so I would like to know what your system specs are.

Originally Posted by kzuse

With the mentioned files present, it works fine... So I think you shouldn't invest too much time...

It's enough to drive me crazy just knowing it's there and it IS meant to be working when libopusurl-0.dll is not there so it does need to be fixed.

Originally Posted by kzuse

And for some reason you don't end up getting an .opus file on your hard disk.

As near as I can tell, the link you provided redirects once. It seemed to handle the redirect request fine, just the server takes forever starting the download on my end so it just times out. Odd, maybe that's why you're getting the crash and I'm not, it's coming in faster for you than me and hits code my install doesn't reach. I've got some experiments to run.

Originally Posted by kzuse

Alas, I found another issue which is more like a bug, it's in the new advanced tag options tab:

The "Value" column of the list view doesn't seem to correctly render unicode characters, whereas the Value textfield on the right does (and also the unicode characters are in the normal Tag box "Comments" displayed correctly). Probably the list view isn't unicode capable on its own so the unicode characters must first be decoded to ANSI, I think? One could also consider this a cosmetic bug, but it's at least confusing to a new user who isn't aware of those Unicode issues...

This is a known flaw. I had to use VCL forms (which doesn't support Unicode strings) since somehow Winamp was mangling the hell out of the standard dialog box window I was trying to create. Somehow, Winamp kept making the dialog box units and fonts unworkably much bigger and a number of controls would get clipped off into total obscurity. The VCL form was somewhat of a quick fix though I had to create a Unicode compatible edit box in it to get it to work right. It's going to be like that for a while until I find the patience to look into it again.

[kzuse]

Originally Posted by thinktink

I'm not seeing them anymore so I would like to know what your system specs are.

Windows XP Pro SP3, 32bit, German Language, Winamp 5.666 Build 3516, no other 3rd-party Plugins installed; 2GB of RAM.

16 Mbit DSL internet connection. But the metaebene.me server seems to be really slow. I tried some more times and other podcast episodes, sometimes Winamp also doesn't close, but rather hangs up in the "Waiting for data..." state. If I click on the "X" the window goes to the (not responding) state and if I click again, it closes (Windows usual behavior for programs that hang.)

I don't think this information is so very helpful, but maybe you'll spot the issue some time anyway...

Regarding the unicode thing: I can perfectly live with that, as I actually don't use the Advanced tab at all, but I thought I should report it for the case you might not have noticed. I also consider it as a cosmetic bug that is perfectly acceptable at this time...

Best regards,
kzuse

[thinktink]

I finally got http://fokus-europa.de/podlove/file/...ommission.opus working. I wasn't using the original host string for the "Host" field in the client request and always adding the default port number. I also found a crash when I changed the timeout. I've added the ability to change the timeout for online streams/files from the configuration as well.

[DrO]

Originally Posted by thinktink

This is a known flaw. I had to use VCL forms (which doesn't support Unicode strings) since somehow Winamp was mangling the hell out of the standard dialog box window I was trying to create. Somehow, Winamp kept making the dialog box units and fonts unworkably much bigger and a number of controls would get clipped off into total obscurity. The VCL form was somewhat of a quick fix though I had to create a Unicode compatible edit box in it to get it to work right. It's going to be like that for a while until I find the patience to look into it again.

we don't do anything on the dialog other than re-position it and leave the dialog manager to do anything it normally does as part of associating the child dialog with the owner dialog. sounds more like something with how you'd setup things maybe wasn't right - might be an idea to check dialog styles from what we provide in one of the implementations and go from there (but everything we're using is just direct API access so weirdness really should not happen).

[thinktink]

Originally Posted by DrO

we don't do anything on the dialog other than re-position it and leave the dialog manager to do anything it normally does as part of associating the child dialog with the owner dialog. sounds more like something with how you'd setup things maybe wasn't right - might be an idea to check dialog styles from what we provide in one of the implementations and go from there (but everything we're using is just direct API access so weirdness really should not happen).

When weird things like this happen I usually do blame myself first and I usually end up being correct, however this time, I don't see how. I copy/pasta'd the dialog resource from one of the input plugins (I forget which but probably in_flac.dll) and then called CreateDialogParamW(...) with a rudimentary dialog procedure that had just WM_INITDIALOG in it that did nothing but return TRUE, that's it. It may very well be my fault still somehow, but as I said before, I'm not seeing how right now.

[j7n]

The plugin doesn't seem to support ReplayGain as written by foobar2000 (global gain – album, R128_TRACK_GAIN metadata value – track, different scale). The album gain is correctly applied, if present, but plugin reports that the gain values aren't present, therefore Winamp applies the "adjustment for files without Replay Gain" (usually negative) in addition to it, leading to unusually low volume relative to music in other formats.

It would be convenient if the average bitrate was reported in the format info text field (on the file info dialog), since the instantaneous bitrate fluctuates too wildly to estimate quality from it.

I wish the plugin was smaller in size, without the large bitmap in the about box. Why does a sound decoder come bundled with an SSL library?

1.5.31.122

[DrO]

er, as Winamp doesn't support R128, it's probably better that it doesn't get told the values to use as you're then applying a value which is not correct for the replaygain option that Winamp uses. but that's just my thought on thnigs.

[thinktink]

Originally Posted by j7n

The plugin doesn't seem to support ReplayGain as written by foobar2000 (global gain – album, R128_TRACK_GAIN metadata value – track, different scale). The album gain is correctly applied, if present, but plugin reports that the gain values aren't present, therefore Winamp applies the "adjustment for files without Replay Gain" (usually negative) in addition to it, leading to unusually low volume relative to music in other formats.

The libopusfile api and the codec itself supports track R128 replay gain last time I checked but not natively from Winamp so there's a bit of discombobulation that I might be able to resolve in-spite of Winamp's lack of direct R128 RG support. I'll look into it later after I resolve some other issues. Thanks for the link.

Originally Posted by j7n

It would be convenient if the average bitrate was reported in the format info text field (on the file info dialog), since the instantaneous bitrate fluctuates too wildly to estimate quality from it.

That seems like an easy fix. I'll look into it.

Originally Posted by j7n

I wish the plugin was smaller in size, without the large bitmap in the about box.

Not going to happen anytime soon since it's such an extreme hassle to code UI windows without the large VCL overhead. As I do with most of my plugins I slowly convert VCL forms into standard Windows dialogs IF there are no issues with the standard API and it's not a burden much larger than the functionality of the plugin itself. In this case, right now, it is a much larger burden.

Originally Posted by j7n

Why does a sound decoder come bundled with an SSL library?

Because the makers of the libopusfile library mandated it to ensure playback from SSL sources and Winamp has yet to release the WASABI interface API for JNetLib and it's SSL support so I have to distribute the SSL library that comes with the libopusfile package to enable that support. Sorry, not much I can do about that.

[PPeti66x]

Is possible to support the old WinAmp 2.x by this plugin?
Is source code available?

[thinktink]

I've not tested for 2.x support for this plugin. Did you try it and it crashed?

[DrO]

seriously why use 2.x ? or maybe we just don't bother to keep Winamp developed as anyone still using 2.x is as bad as someone still using IE6.

[PPeti66x]

thinktink:
This plugin not works with WinAmp 2.x (tested with WinAmp v2.95 on Win7SP1 x64, BPOPUS v1.3.19.61, and 1.5.31.22). It is not listed in input plugins configuration menu, opus format not listed in file types menu. No crash or error message.

DrO:
Because I have still an old computer with Win98SE, and for me is better to use old software which is working perfectly on old and on new computer than use different versions on different computers. WinAmp 2.95 have all features, what I need, so I have no reason to change to 5.x.
PS: Try the Firefox or Chrome on 200MHz Pentium computer, and you will know, that IE6 is not as bad as others say.

(Sorry, my english is bad.)

[thinktink]

If it's not even showing up in the list of input plugins on the preferences page I doubt I'll be able to get it to work with both old and new clients simultaneously. I'll consider it on my next development round but it won't be high priority.

[PPeti66x]

I checked the compatibility, the minimum version is 5.25 for playing, but plugin configuration button not works (tested v5.25 and v5.35) - ends with crash. In v5.63 worked correctly.
If plugin not uses special features from WinAmp 5.x then may be replacing WinAmp SDK files with older version is enough to resolve the compatibility problems.

[DrO]

PPeti66x: if my Pentium II machine still worked then i might have tried things out but that thing died a few years ago and it's more costly to get it up and running again than what i'd get out of trying to use it.

i take the point but asking the few remaining plug-in authors to support something they don't actively use and haven't done for pretty much a decade is like asking MS to bring back support for Win98.

as for the Firefox / Chrome example, they're built to take advantage of newer CPUs and other aspects than trying to cater for what is not the norm with such an old setup. so it's no surprise that they don't work well in the scenario you've mentioned since they rely heavily on multi-threading, etc which a Pentium just does not do all that well compared to what is around now (even CPUs from a decade ago).

from a technical point, i know you want to be using newer formats, but asking someone to cripple a plug-in for a Winamp version no one generally supports is not a good use of time when free time for Winamp plug-ins is at a minimum for those that do still do them. and really the minimum any active plug-in dev should be targeting is 5.5 and newer (and even that is going back 7 years).

obviously it's down to thinktink in this case if he wants to spend the time and effort to support older Winamp releases, but it's a lot to ask for someone who is giving you so much for free (and that's assuming any of the Opus dlls even work on such an old CPU i.e. if they're built for post-Pentium CPUs then even if the plug-in is fixed, it's not going to help resolve that side of things).


and at least you're not asking for use to re-instate Win98 support, as that definitely won't be happening and even WinXP support is on the limit due to it being out of official support and it limiting some native implementations (which Win98 caused even more headaches).