Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Closed Thread
Thread Tools Search this Thread Display Modes
Old 13th May 2013, 20:04   #321
Batter Pudding
Major Dude
 
Batter Pudding's Avatar
 
Join Date: Jun 2008
Posts: 1,665
Quote:
Originally Posted by molecular View Post
Alphabetical sorts do not include words like "THE". (See many many many many old posts on this)
Batter Pudding is offline  
Old 13th May 2013, 20:48   #322
molecular
Junior Member
 
Join Date: May 2013
Posts: 11
When open setting Matroska Demuxer, Flash Video Decoder in "Input", you get crash Winamp

PS: Will Winamp developed for Windows 8 Modern UI or for iOS?
Attached Files
File Type: zip report.zip (56.5 KB, 146 views)
molecular is offline  
Old 13th May 2013, 21:12   #323
DrO
 
Join Date: Sep 2003
Posts: 27,873
it's a bug in the language pack as it's not been updated to be compatible with all of the string changes made in v5.7.

with all of the Winamp Cloud work going, there's unlikely (if it is even going to happen) to be native Windows 8 and iOS apps. and both would require starting from scratch which means you'd be looking at a few years to get a stable app.
DrO is offline  
Old 14th May 2013, 03:11   #324
dstudd
Junior Member
 
Join Date: May 2013
Posts: 34
Quote:
Originally Posted by DrO View Post
can you go to preferences -> plug-ins and check 'Disable SEH for DSP plug-ins (useful for plug-in developers)' and the next time it crashes, attach the report (the one you've attached is consistent with the ones i've been looking at). if that is already checked then is nothing else to do as all i can see is something is trying to update a value in the registry, but what i cannot determine from the stack dump.

I have Disabled SEH for DSP plug-ins as you suggested. Here is the next crash info.
It has also been emailed via the usual means.

Winamp client version: 5.7 build 3381 Beta
winamp caused an Access Violation (0xc0000005)
in module dsp_dfx.dll at 0023:04907d13.

Exception handler called in Winamp
Attached Files
File Type: zip report.zip (85.3 KB, 130 views)
dstudd is offline  
Old 14th May 2013, 17:57   #325
DrO
 
Join Date: Sep 2003
Posts: 27,873
ironically it offers even less information other than it's ending up crashing in dfx. best thing to do is to try to contact them and see if there's anything they can offer on the matter as i'm not able to determine the point of issue in their dll.
DrO is offline  
Old 16th May 2013, 08:05   #326
dstudd
Junior Member
 
Join Date: May 2013
Posts: 34
Quote:
Originally Posted by DrO View Post
ironically it offers even less information other than it's ending up crashing in dfx. best thing to do is to try to contact them and see if there's anything they can offer on the matter as i'm not able to determine the point of issue in their dll.
The matter has been raised with DFX. Awaiting an outcome from request #277.
dstudd is offline  
Old 17th May 2013, 23:49   #327
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,824
Winamp 5.7 Beta 7, build 3381 to 3392 changelog

* Fixed: [pmp_android/usb] Transfers fail if <Albumartist> contains illegal characters

- Fixed Prefs dialog staying offscreen when last monitor/position it was on is no longer valid

- Also save last position of Alt+3 & Ctrl+E dialog windows

- [Beta-builds-only] Attempt to load gen_crasher.dll first
(so we can hopefully catch any crashes which were missed when other gen plugins loaded first)

- [Winamp Setup] Show Winamp version in About dialog instead of e.g. 1.0.0.1

- [Winamp Setup] Fixed dialogs & messageboxes not showing the Winamp icon

- [elevatorps.dll] Fixed dll name in version info

- [in_mp3] Made ID3v1 tag changes only update Basic Info tab when no ID3v2 tag present
- (ID3v2 tag should always take precedence - how long has this 'bug' existed?)
- Made ID3v1 tag changes not auto-update an existing ID3v2 tag (these should be separate, right?)

- [in_flac] Possible fix for jph6t's FLAC genre issue

- [in_flac] Fixed seek-before-play crash (5.7-beta-specific)

- [gen_ml] Updated default node order on new/clean installs

- [gen_ml] Force drawing update of header when changing the cloud column status

- [ml_disc] Another potential crash on cd load fix...

- [ml_local] Change "Library" (ex: Local Media) to "Local Library" for main ml node...

- [ml_local] Added a "Cloud (Hidden)" string for Customize Columns dialog...

- [ml_local] Add files to library: potential crash fix

- [ml_local] Also save last position of edit metadata dialog

- [ml_impex] Allow iTunes playlist import to obey the 'add to cloud' settings

- [ml_plg] Fixed placement of 'View tracks similar to' menu item in ml_playlists to match ml_local etc.

- [ml_plg] Fixed incorrect title in uninstall plugin dialog

- [ml_playlists] Fixed tooltip in root view > Cloud column to show an appropriate string (Upload playlist to Cloud & Available in the Cloud)

- [ml_playlists] Refresh playlist root view once Cloud has become available

- [ml_playlists / gen_ml] Various "SendTo" tweaks...

- [ml_playlists] Added a "Save" button (for saving any changes without having to refresh the view; greyed-out if no changes have been made)

- [ml_playlists] Set playlist name as the filename on the Export dialog (instead of just being empty)

- [ml_playlists] Set m3u8 as the default export type instead of m3u, but remember the last filter selection, if changed

- [ml_playlists] Optimizations for importing/loading a large number of playlists

- [ml_playlists] Remember last selected folder

- [ml_playlists] Fixed to not set cloud status when cloud support is not installed

- [ml_playlists] Show a message if a playlist source file is missing

- [ml_playlists] Various other tweaks/fixes

- [cloud] MIME value generation tweaks; Misc database optimizations; Crash fixes

- [cloud] Database nuke bump (please wait for 'first pull completed' msg before using cloud features)

- [ml_cloud] Store created playlists
- Cloud playlists created locally: %appdata%\Winamp\Plugins\ml\playlists\plf***.m3u8
- Playlists pulled from Cloud made with other devices: %appdata%\Winamp\Cloud\Playlists\cloud-<uid>.m3u8

- [ml_cloud] Fixed updates being saved to wrong playlist file...

- [ml_cloud] Fixed playlist updates from Cloud not being processed/saved correctly

- [ml_cloud] Fixed cloud icon not being reset correctly

- [ml_cloud] New playlist strings: Always prompt; Keep the playlist; Remove the playlist

- [ml_cloud] Added "Show 'Local Library' Source" to Cloud Library root node menu

- [ml_cloud] Renamed 'Cloud Sources' node to 'Cloud Library'

- [ml_cloud] Force library open (if it isn't already) when clicking "here" link in prefs

- [ml_cloud] Show logged in username on 'Cloud Account' header in Prefs

- [ml_cloud] windowoffscreen support for cloud status window

- [ml_cloud] Fixed external windows (eg. Sign-in > Terms) not being skinned in the Winamp style

- [ml_cloud] Help menu item now active (Help contents still a w.i.p. - please don't broadcast url)

- [ml_cloud/devices/pmp/pmp_cloud] Made 'Cloud Library' node switch between the Sign-In page and an 'All Sources' view (after login)

- [ml_cloud/devices/pmp] Added an 'Add Sources' view under Cloud (same as old Cloud Sources view, serverside w.i.p.)

- [ml_pmp] Added "Hide Source" to Cloud->Local Library node rt-click menu

- [ml_pmp] Crash fix (lang pack related)

- [ml_pmp] Fixed Transfer & Sources nodes being removed when removing a Cloud source

- [ml_pmp] Prevent right-click menus appearing when scanning

- [ml/pmp_cloud] Disabled renaming of "Winamp Storage" view

- [ml/pmp_cloud] Added "Beta" to plugin version strings

- [ml/pmp_cloud] Changed all string instances of "device" to "source"

- [pmp_cloud] Changed "Winamp Cloud" to "Winamp Storage" for new installs

- Various crash fixes from crash reports

- Various other misc fixes/tweaks etc.
DJ Egg is offline  
Old 18th May 2013, 03:00   #328
Chris000001
Senior Member
 
Join Date: Nov 2003
Location: CA
Posts: 105
I think there has been a bug in the installer for a long time. I deselect Detector Plug-in for Internet Explorer every time. It sets 'winampDetectExplorer=0' in install.ini, but it's always checked to install the next time I run the installer. I have attached my install.ini (renamed to .txt so I could attach it.) Also, I use a pretty minimal install, but I always end up with ml_downloads.dll in my plug-ins folder in program files (x86). If I delete it, I don't seem to lose anything. My guess is it is part of something else that I don't install.
Attached Files
File Type: txt install.ini.txt (1.6 KB, 137 views)
Chris000001 is offline  
Old 18th May 2013, 03:07   #329
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
Quote:
Originally Posted by DJ Egg View Post
- Also save last position of Alt+3 & Ctrl+E dialog windows
THANK YOU to you, DrO, or whoever was kind enough to see to this!



Quote:
Originally Posted by DJ Egg View Post
- [in_mp3] Made ID3v1 tag changes only update Basic Info tab when no ID3v2 tag present
- (ID3v2 tag should always take precedence - how long has this 'bug' existed?)
- Made ID3v1 tag changes not auto-update an existing ID3v2 tag (these should be separate, right?)

- [in_flac] Possible fix for jph6t's FLAC genre issue
hmm... is the v1/v2 stuff in regards to the v1 genre issue, or something else?

Quote:
Originally Posted by DJ Egg View Post
- [ml_local] Also save last position of edit metadata dialog
same thing as first above, right?

thx again, I will try to put it all thru the paces on the cloud asap.

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Old 18th May 2013, 03:29   #330
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
Originally Posted by Chris000001 View Post
I think there has been a bug in the installer for a long time. I deselect Detector Plug-in for Internet Explorer every time. It sets 'winampDetectExplorer=0' in install.ini, but it's always checked to install the next time I run the installer.
that is expected (though annoying) behaviour. if you use the up arrow key when on the components then it'll take you back to your previous install.

Quote:
Originally Posted by Chris000001 View Post
Also, I use a pretty minimal install, but I always end up with ml_downloads.dll in my plug-ins folder in program files (x86). If I delete it, I don't seem to lose anything. My guess is it is part of something else that I don't install.
without checking, it's likely due to it being used for some of the general download handling of files within the library so it can end up being installed when maybe it's not needed to be cautious. am sure Egg or I will check it out and adjust the installer as needed if it's really not needed based on your install.ini.
DrO is offline  
Old 18th May 2013, 04:06   #331
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,824
As far as I know, ml_downloads only gets installed alongside Online Services (ml_online.dll) & Podcast Directory (ml_wire.dll).
As Chris000001 installed Online Services, that is why ml_downloads.dll exists.
Online Services such as MP3 Of The Day would use it to download files.
DJ Egg is offline  
Old 18th May 2013, 04:26   #332
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,824
@MrSinatra

Yes, it's kind of the same thing, though Ctrl+E in the Playlist Editor (in winamp.exe) is for the Edit Playlist Entry dialog,
whereas Ctrl+E in ml_local is for the ML Edit Metadata dialog.

Positions for both are now saved anyway.

Re: in_mp3/id3 tags

It might have something to do with the ID3v1 genre issue,
though to be perfectly honest, I couldn't reproduce that issue before the changes, and I still can't.

However, whilst trying to reproduce it, I noticed some other more pressing issues...

When editing field values in an ID3v1 tag, I noticed that the ID3v2 tag and Basic Info tab info were also being updated.

Now, I remember the days when ID3v2 tags were seen as the spawn of Satan,
but these days, I very rarely ever use or look at ID3v1 tags anymore.

Before we implemented the unified tag editor in v5.5, ID3v1 and ID3v2 tags were both in the same single window in the MP3 tag editor.
When you edited ID3v1 values, the ID3v2 tag didn't get auto-updated.
And when you edited ID3v2 values, the ID3v1 tag didn't get auto-updated.
There was a "Copy to ID3v1" button in the ID3v2 section, and a "Copy to ID3v2" button in the ID3v1 section.
Those buttons are still there in the newer unified editor.

So, because I'm pretty certain that editing an ID3v1 tag shouldn't auto-update an existing ID3v2 tag,
if an ID3v2 tag exists then it should always take precedence over ID3v1 (and APEv2 or Lyrics3 tags).
Therefore, the info in the Basic Info tab should not be updated unless you also edit the ID3v2 tag.
If there's no ID3v2 tag, then yes, when you edit an ID3v1 tag, the Basic Info tab should also update along with the metadata displayed in the Playlist Editor etc.

Only when you edit metadata in the Basic Info tab should both ID3v1 & v2 tags be updated (as long as the relevant setting is enabled in in_mp3 config)

Agreed?

Hope that all makes sense, btw.
DJ Egg is offline  
Old 18th May 2013, 05:24   #333
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Genre drop-down in the “File Info” window is NOT populating correctly for FLAC files

Quote:
Originally Posted by DJ Egg View Post
Winamp 5.7 Beta 7, build 3381 to 3392 changelog
- [in_flac] Possible fix for jph6t's FLAC genre issue
I just installed Beta 7, build 3392.
No joy. I'm still getting the same issue with how the genre displays for FLACs.
I'll take further conversation on the topic to the dedicated thread on the FLAC genre issue.
jph6t is offline  
Old 18th May 2013, 05:46   #334
Chris000001
Senior Member
 
Join Date: Nov 2003
Location: CA
Posts: 105
Quote:
Originally Posted by DrO View Post
that is expected (though annoying) behaviour. if you use the up arrow key when on the components then it'll take you back to your previous install.

without checking, it's likely due to it being used for some of the general download handling of files within the library so it can end up being installed when maybe it's not needed to be cautious. am sure Egg or I will check it out and adjust the installer as needed if it's really not needed based on your install.ini.
Quote:
Originally Posted by DJ Egg View Post
As far as I know, ml_downloads only gets installed alongside Online Services (ml_online.dll) & Podcast Directory (ml_wire.dll).
As Chris000001 installed Online Services, that is why ml_downloads.dll exists.
Online Services such as MP3 Of The Day would use it to download files.
Thanks. I thought default "custom" in the installer was the same as "previous", since the only thing that seems to change is detector for IE. And, thanks for the explanation of why ml_downloads is installed. I only use ml_online for shoutcast radio.
Chris000001 is offline  
Old 18th May 2013, 07:17   #335
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
Quote:
Originally Posted by DJ Egg View Post
@MrSinatra

Yes, it's kind of the same thing, though Ctrl+E in the Playlist Editor (in winamp.exe) is for the Edit Playlist Entry dialog,
whereas Ctrl+E in ml_local is for the ML Edit Metadata dialog.

Positions for both are now saved anyway.
ah, I see. it didn't say playlist editor for either one though. if its meant for the first one, is alt+3 saved for ml_local?

I've kinda lost track.

nevermind, I just tested it, both work where I use em. interestingly, alt+3 is the same for either, and either saves the same location, (cool!) but ctrl-E seems to be a different function, depending on where u do it from [ml or playlist].

Quote:
Originally Posted by DJ Egg View Post
Re: in_mp3/id3 tags

It might have something to do with the ID3v1 genre issue,
though to be perfectly honest, I couldn't reproduce that issue before the changes, and I still can't.
sure would be nice to have a step by step procedure to see who can and can't and try to figure out why.

Quote:
Originally Posted by DJ Egg View Post
However, whilst trying to reproduce it, I noticed some other more pressing issues...

When editing field values in an ID3v1 tag, I noticed that the ID3v2 tag and Basic Info tab info were also being updated.
that definitely seems problematic to me. I would think the v1 tab, and the v2 tab, would NOT impact each other. and I would assume the basic tab would always follow the v2 tabs lead, (assuming a v2 tag was present, even if blank). of course, winamp merges tag levels, which I think is a bad idea. (meaning, if v1 has a track number and v2 doesn't, but has other stuff v1 has, the v2 stuff is used PLUS v1's track number.

a good pref would be to disable such tag merging in winamp.

but anyway, obviously both tabs should follow the basic tabs lead, when basic is being used. with v1 however, it will always be limited by design, and not be able to do what the basic tab says, like genres outside its dopey default list, or strings longer than 30 chars, etc... so you can't have pure harmony between all the tabs.

Quote:
Originally Posted by DJ Egg View Post
Now, I remember the days when ID3v2 tags were seen as the spawn of Satan,
but these days, I very rarely ever use or look at ID3v1 tags anymore.
indeed. you are showing your age! these days, v1 is obsolete/legacy, v2 is king. I strip all v1 stuff to avoid these issues, and that explains why I haven't seen this. winamp should still support v1 of course, but imo, unless u need them for some reason, like old gear, kill em.

Quote:
Originally Posted by DJ Egg View Post
Before we implemented the unified tag editor in v5.5, ID3v1 and ID3v2 tags were both in the same single window in the MP3 tag editor.
When you edited ID3v1 values, the ID3v2 tag didn't get auto-updated.
And when you edited ID3v2 values, the ID3v1 tag didn't get auto-updated.
There was a "Copy to ID3v1" button in the ID3v2 section, and a "Copy to ID3v2" button in the ID3v1 section.
Those buttons are still there in the newer unified editor.
sounds right to me. they should not impact each other. while it could lead to divergence and so on, that's unavoidable anyway, given v1's limitations as noted above.

btw, this raises another bug I noted many months back. if you disable winamps ability to create id3v1 tags, that works, EXCEPT when you hit the "copy to v1" button. now, imo, if you disable v1 creation in the plugin, you probably should not be able to over-ride that via that copy to v1 button, but I let it go b/c it is kinda a handy hacky workaround should someone ever need to create a v1 tag who otherwise has it disabled. I leave it to you to decide how to handle that lil bug.

Quote:
Originally Posted by DJ Egg View Post
So, because I'm pretty certain that editing an ID3v1 tag shouldn't auto-update an existing ID3v2 tag,
if an ID3v2 tag exists then it should always take precedence over ID3v1 (and APEv2 or Lyrics3 tags).
take precedence where? alt+3? the ML? I agree in both cases. (I strip apeV# and lyrics too btw)

as I said above, its confusing to this process to merge tag layers. the basic tag should show only the top most layer imo.

Quote:
Originally Posted by DJ Egg View Post
Therefore, the info in the Basic Info tab should not be updated unless you also edit the ID3v2 tag.
but what if you purposely keep them divergent? i'm kinda confused by what you are saying here, b/c v1 and v2 will often not be the same, yet close to the same.

Quote:
Originally Posted by DJ Egg View Post
If there's no ID3v2 tag, then yes, when you edit an ID3v1 tag, the Basic Info tab should also update along with the metadata displayed in the Playlist Editor etc.
sounds reasonable, but I would not have the basic tab apply any changes to file UNLESS someone actually changed something on that tab. but having it visually update to reflect v1 (if only v1 is present) or v2 (if present) would probably eliminate possible user confusion.

Quote:
Originally Posted by DJ Egg View Post
Only when you edit metadata in the Basic Info tab should both ID3v1 & v2 tags be updated (as long as the relevant setting is enabled in in_mp3 config)

Agreed?

Hope that all makes sense, btw.
I definitely agree that the basic tag should update both v1 and v2, but again, v1 is limited, esp with genres. it can't do any that aren't in its default list. v1 has no albumartist or some other tags, and displays track#s different, truncates strings, etc... while v2 can do everything you can do in basic, v1 can only approximate it.

btw, I would like to see the same things in the same place between basic and v2. the layout is different. move the check marks to the bottom, and get the fields all aligned in the same order between basic and v2 (and v1 to the extent possible). I like the v2 layout mostly, and would copy the others to it, (but move BPM up like in basic).

one last thing... any chance you will include the TCMP frame (compilation) to the ML? allow edits?

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Old 18th May 2013, 15:25   #336
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,072
Just out of interest.

Are Extended/Lyric3 tags still read by Winamp, or has that been completely dropped now ???

UJ
ujay is offline  
Old 18th May 2013, 15:57   #337
Batter Pudding
Major Dude
 
Batter Pudding's Avatar
 
Join Date: Jun 2008
Posts: 1,665
Quote:
Originally Posted by ujay View Post
Just out of interest.

Are Extended/Lyric3 tags still read by Winamp, or has that been completely dropped now ???

UJ
Wasn't that always just a plug-in?
Batter Pudding is offline  
Old 18th May 2013, 17:47   #338
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,072
There were two plugins, in fact, BP.
One to display the lyrics and slide shows etc. and one to embed them in the file.
I liked it as a system very much, but it broke when Winamp went multi user.

Lyric3 was embedded as an extended area placed immediately before the Id3v1 block.
Another feature was the ability to extend the Id3v1 tags beyond the 30 char limit, this was what Winamp itself could access without the plugin and used to be displayed in 'View file info'.

I need to find something that still has lyric3 tags and see what the latest versions make of it.

UJ
ujay is offline  
Old 18th May 2013, 19:42   #339
Aminifu
Forum King
 
Aminifu's Avatar
 
Join Date: Aug 2011
Location: Phoenix, AZ
Posts: 4,658
Quote:
Originally Posted by DJ Egg View Post
Before we implemented the unified tag editor in v5.5, ID3v1 and ID3v2 tags were both in the same single window in the MP3 tag editor.
When you edited ID3v1 values, the ID3v2 tag didn't get auto-updated.
And when you edited ID3v2 values, the ID3v1 tag didn't get auto-updated.
There was a "Copy to ID3v1" button in the ID3v2 section, and a "Copy to ID3v2" button in the ID3v1 section.
Those buttons are still there in the newer unified editor.

So, because I'm pretty certain that editing an ID3v1 tag shouldn't auto-update an existing ID3v2 tag,
if an ID3v2 tag exists then it should always take precedence over ID3v1 (and APEv2 or Lyrics3 tags).
Therefore, the info in the Basic Info tab should not be updated unless you also edit the ID3v2 tag.
If there's no ID3v2 tag, then yes, when you edit an ID3v1 tag, the Basic Info tab should also update along with the metadata displayed in the Playlist Editor etc.

Only when you edit metadata in the Basic Info tab should both ID3v1 & v2 tags be updated (as long as the relevant setting is enabled in in_mp3 config)

Agreed?

Hope that all makes sense, btw.
I think I understand most of the above.

I have enabled all 6 of the configuration options on the in_mp3.dll ID3 Tags tab. I have also selected "System Language" for reading ASCII tags and "Unicode (UTF-16)" for writing tags. Do I need to enable both the tag writing and the tag creation options? What is the difference between these two categories?

I normally use the Basic Info tab for editing mp3 metadata, unless it is the genre tag. For genre updates, I use both the Basic Info and the ID3v1 tabs. I never use the ID3v2 tab because I don't use the additional tags shown on that tab. Would it be better to use the ID3v1 and ID3v2 tabs instead of the Basic Info tab for editing?

Winamp Pro v5.666.3516 fully-patched - Komodo X Touchscreen v1.0 by Victhor skin
Windows 10 Home 64-bit v1809 desktop - Logitech Z906 5.1 speaker system
Aminifu is offline  
Old 18th May 2013, 21:53   #340
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,824
Quote:
Originally Posted by Aminifu View Post
I think I understand most of the above.

I have enabled all 6 of the configuration options on the in_mp3.dll ID3 Tags tab. I have also selected "System Language" for reading ASCII tags and "Unicode (UTF-16)" for writing tags. Do I need to enable both the tag writing and the tag creation options? What is the difference between these two categories?

I normally use the Basic Info tab for editing mp3 metadata, unless it is the genre tag. For genre updates, I use both the Basic Info and the ID3v1 tabs. I never use the ID3v2 tab because I don't use the additional tags shown on that tab. Would it be better to use the ID3v1 and ID3v2 tabs instead of the Basic Info tab for editing?
ID3 Tag Writing options are for modifying existing tags (e.g. when using Edit Metadata in ML or the Basic Info tab)

ID3 Tag Creation options are for when creating new files (e.g. with CD Ripper or Transcoder)

I only ever use the Basic Info tab for editing these days.
I couldn't really care what's in the ID3v1 tag.
Any devices/players which don't support ID3v2 are either very old, crappy, or both.
But yeah, the Basic Info tab will update both, so that is good enough for me.


@ujay

Lyrics3 tag reading should still be working.

in_mp3 > config > APEv2 & Lyrics3 > Read Lyrics3 tags.
If a Lyrics3 tag exists, then it should be displayed, as long as there's no ID3v2 tag.
I think APEv2 also takes precedence over Lyrics3?

Order of precedence = ID3v2, APEv2, Lyrics3, ID3v1

Alas, I'm not even sure what "Extended Lyrics3" tags are.
Some 3rd-party plugins provided support for them, right?
Are said plugins dead/broken?
DJ Egg is offline  
Old 19th May 2013, 02:19   #341
djpete
Major Dude
 
djpete's Avatar
 
Join Date: Apr 2004
Location: Melbourne, Australia
Posts: 940
go up and down the tree in media library in the new beta and you will see a slight flicker in the name you chose. This is not there in other versions. Just thought I would mention in case its a prob down the track. Only slight but definitely there for me. Build 3392.

Cheers, Pete

Anything & Everything Winamp - All In One Place...
Winamp Enthusiasts Group
djpete is offline  
Old 19th May 2013, 03:20   #342
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,072
Hi Egg.

I haven't been in there for years ... spooky

Things seem to have changed since I last did anything with this, as I remember it, there was a Lyric3 tab in the Basic Info window.

Strictly speaking lyric3 is an extention of the Id3v1 spec. and adds 3 extra sets of tags to what is already in the Id3v1 block.

These are :
Extending the length of the 30 char. fields that are already in the Id3v1 tags.
Embedding lyrics.
Embedding images.

From what I remember, Winamp can only natively read the extended fields, you will need a plugin to do anything else.
This means that Winamp cannot write anything to these tags and their main use would be in transferring the info from the extended fields to Id3v2 tags.

The only real problem I remember was if you deleted the Id3v1 tags, as this would leave the Lyric3 tags floating. Not a problem for Winamp as it appears to be able to find the required chunk by inspection and not by reference to the Id3v1 block itself. However, this will probably break the file for use with other readers/plugins.

UJ
ujay is offline  
Old 19th May 2013, 16:02   #343
Aminifu
Forum King
 
Aminifu's Avatar
 
Join Date: Aug 2011
Location: Phoenix, AZ
Posts: 4,658
Quote:
Originally Posted by DJ Egg View Post
ID3 Tag Writing options are for modifying existing tags (e.g. when using Edit Metadata in ML or the Basic Info tab)

ID3 Tag Creation options are for when creating new files (e.g. with CD Ripper or Transcoder)

I only ever use the Basic Info tab for editing these days.
I couldn't really care what's in the ID3v1 tag.
Any devices/players which don't support ID3v2 are either very old, crappy, or both.
But yeah, the Basic Info tab will update both, so that is good enough for me.
Thanks for the info on the in_mp3.dll ID3 Tag Writing and Creation options.

One of my mobile mp3 players is very old and only reads ID3v1 tags. It still works very well, so I take advantage of Winamp's ability to write v1 and v2 tags. I'm content with how the Alt+3 editor is working in version 5.7.3392, i.e. it provides the ability to edit mp3 ID3v1 and ID3v2 tags separately.

If I'm the only one sometimes seeing a discrepancy on the ID3v1 tab for what is in a file's v1 genre tag, then it must be unique to my Winamp configuration. When I see the wrong value, I'm able to verify outside of Winamp (with various 3rd party taggers) that the correct value is actually in the file.

If I do not touch the box showing the wrong value before clicking the "OK" button (or change it to the correct value), then the correct value in the file is not changed (or is updated to the same value). Before version 5.7.3382, I had to select the correct value before clicking the "OK" button (or the wrong value was written to the file). I'm glad this minor annoyance is not affecting others. I had learned to live with it and it's only a single v1 tag, after all. The vast majority of the time, I use the ID3v2 tags with Winamp and with all my other mobile mp3 players.

I first mentioned it last January and only mentioned it again because it seemed similar to the issue jph6t is having with his flacs.

Winamp Pro v5.666.3516 fully-patched - Komodo X Touchscreen v1.0 by Victhor skin
Windows 10 Home 64-bit v1809 desktop - Logitech Z906 5.1 speaker system
Aminifu is offline  
Old 19th May 2013, 21:05   #344
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
I am glad you mentioned it and I am glad it is being addressed, b/c this is basic fundamental functionality and winamp should be as bulletproof as possible, even for something obsolete like v1 tags.

however, it would be good if you would take the time to provide step by step method for reproduction, so all could see if they can see what you see. when I test jph6t's issue, using his steps to, I can not reproduce it. I believe he has it, but this suggests only he has it, or its unique to him/his settings in some way, esp if others test and confirm my results.

your issue may now, as of the latest beta, be only "visual" as opposed to functional, (depending on what someone clicks or not), but it should still be fixed if others can do what you do, and see what you see. of course, that's contingent on knowing that others are taking the same steps to reproduce, and can in fact reproduce.

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Old 20th May 2013, 16:18   #345
Aminifu
Forum King
 
Aminifu's Avatar
 
Join Date: Aug 2011
Location: Phoenix, AZ
Posts: 4,658
Quote:
Originally Posted by MrSinatra View Post
your issue may now, as of the latest beta, be only "visual" as opposed to functional, (depending on what someone clicks or not), but it should still be fixed if others can do what you do, and see what you see.
The Alt+3 tag editor does not need further modification (maybe it never needed any).

Taking jph6t's lead, I ran Winamp in safe mode and the editor worked correctly. I tracked the interfering plug-in to "gen_os_diag.dll". This is one of DrO's plug-ins (no longer available) that allowed certain Winamp dialogs to remember their screen positions from session to session.

It's weird, imo, but something in that plug-in prevents the editor's ID3v1 tab from displaying the v1 genre data in the file. Fortunately, the major Winamp dialogs now remember their screen positions natively, so I don't really need this plug-in anymore.

I use, and have come to depend on, several of DrO's plug-ins. I should have tried safe mode sooner, but I guess I didn't want to believe that one of DrO's plug-ins could have been involved. I had tried removing all my 3rd party plug-ins developed by other people.

This incident in no way changes my confidence in DrO's abilities.

Winamp Pro v5.666.3516 fully-patched - Komodo X Touchscreen v1.0 by Victhor skin
Windows 10 Home 64-bit v1809 desktop - Logitech Z906 5.1 speaker system
Aminifu is offline  
Old 20th May 2013, 16:26   #346
DrO
 
Join Date: Sep 2003
Posts: 27,873
rightio, will be making the Winamp installer remove the plug-in as it's main functionality is implemented natively now (as noted above). i'm not too surprised it's causing an issue as it was probably too invasive for it's own good (but that was needed to handling some of the dialogs correctly).

even i've stopped using it some time back due to it causing stability issues for me which is probably why i hadn't seen the issue despite seeing it originally when i still had the plug-in installed. got to love the crap a 3rd party plug-in can do to Winamp at times...
DrO is offline  
Old 20th May 2013, 17:13   #347
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Quote:
Originally Posted by Aminifu View Post
I tracked the interfering plug-in to "gen_os_diag.dll". This is one of DrO's plug-ins (no longer available) that allowed certain Winamp dialogs to remember their screen positions from session to session.

It's weird, imo, but something in that plug-in prevents the editor's ID3v1 tab from displaying the v1 genre data in the file. Fortunately, the major Winamp dialogs now remember their screen positions natively, so I don't really need this plug-in anymore.
Taking Aminifu's lead I also uninstalled "gen_os_diag.dll", aka DrO's OS Pos Restorer.
Removing this plug-in fixed my FLAC genre issue!

Quote:
Originally Posted by Aminifu View Post
I use, and have come to depend on, several of DrO's plug-ins. I should have tried safe mode sooner. This incident in no way changes my confidence in DrO's abilities.
+1

Quote:
Originally Posted by DrO View Post
rightio, will be making the Winamp installer remove the plug-in as it's main functionality is implemented natively now.
Guess I missed this. In what version of Winamp was this functionality added to the native feature set?
jph6t is offline  
Old 20th May 2013, 17:29   #348
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,824
Quote:
Originally Posted by jph6t View Post
Guess I missed this. In what version of Winamp was this functionality added to the native feature set?
In the last couple of 5.7 open beta builds.

And thanks for confirming the flac genre issue was also caused by gen_os_diag :-)
DJ Egg is offline  
Old 20th May 2013, 17:41   #349
Aminifu
Forum King
 
Aminifu's Avatar
 
Join Date: Aug 2011
Location: Phoenix, AZ
Posts: 4,658
Saving the General Preferences dialog position was added in 5.7 beta build 3367. Saving the position of the tag editors was added in the latest 5.7 beta build 3392. The plug-in could handle a few more dialogs, but Ctrl+P, Alt+3, and Ctrl+E are the major ones.

Maybe, going forward, natively saving the position of a few more dialogs will be added.

Winamp Pro v5.666.3516 fully-patched - Komodo X Touchscreen v1.0 by Victhor skin
Windows 10 Home 64-bit v1809 desktop - Logitech Z906 5.1 speaker system
Aminifu is offline  
Old 20th May 2013, 18:13   #350
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
Originally Posted by Aminifu View Post
Maybe, going forward, natively saving the position of a few more dialogs will be added.
we shall see but at the moment, the main ones have now been done as doing the browse folder ones and open / save dialogs were always hacky and i'm not keen on doing that natively at the moment (due to such quirks as the plug-in showed).
DrO is offline  
Old 20th May 2013, 21:52   #351
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Genre drop-down in the “File Info” window is NOT populating correctly for FLAC files

Quote:
Originally Posted by DJ Egg View Post
And thanks for confirming the flac genre issue was also caused by gen_os_diag :-)
Least I can do. I hate when people ask for help, get others to help them solve the problem, and then don't share the fix with the community.

A big THANKS to all those who put in so much time helping me isolate the cause (DrO, MrSinatra, Aminifu, ...).
I'd have had a real hard time figuring this out without your input.
jph6t is offline  
Old 23rd May 2013, 01:07   #352
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
crash report from a friends machine, not really sure why it happened.
Attached Files
File Type: zip report.zip (43.5 KB, 106 views)

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Old 23rd May 2013, 16:30   #353
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
one thing that has since occurred to me regarding my report above, is a CD was in the drive. but I don't think it was being played.

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Old 23rd May 2013, 17:06   #354
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
Originally Posted by dstudd View Post
The matter has been raised with DFX. Awaiting an outcome from request #277.
dstudd: has there been any update from them about it ? asking as was looking through the 3392 crash reports just now and dsp_dfx is the main 3rd party plug-in that shows up in them (and seems there's a few people using it with the betas when looking back over all of the 5.7 crash reports that have come in).
DrO is offline  
Old 29th May 2013, 14:27   #355
zepper
Senior Member
 
Join Date: Jul 2005
Posts: 113
Is there some way to get around the hardware acceleration that we lose in Windows 7 when aero is turned off? I don’t like that theme at all and prefer the built-in Classic one but unfortunately Microsoft screwed us since we lose graphics hardware in Classic.

Winamp is affected too, at least when using Direct Show. It’s bad when running a video and minimizing to the Taskbar, it gets completely stuck after maximizing again. Works fine in aero theme though. As a result I use mostly VLC Player in Windows 7 now, which is not a problem in Classic theme. Neither is WMP that like Winamp uses the FFDShow codecs for most of the videos.
zepper is offline  
Old 29th May 2013, 15:52   #356
Jojo1104
Junior Member
 
Join Date: May 2013
Posts: 5
I have found 2 problems using Beta 7:

1) Graphic Bug (see Attachment): The grey area between the playlist in the library and the active playlist hasn't been there in Beta 5/6. Thus i can't see the number of songs and the playtime of a saved playlist anymore.

2) Synchronizing with a removable drive using the variable <Albumartist>: If the name of the albumartist ends with "." (i.e. "R.E.M.") and you want to create a folder with <Albumartist> the "." at the end becomes "_" (X:\R.E.M_\...). It's not that bad but i think that's not the way it should be. Don't know it has been there before Beta 7.
Attached Thumbnails
Click image for larger version

Name:	WA57b3392.jpg
Views:	142
Size:	75.7 KB
ID:	50547  
Jojo1104 is offline  
Old 29th May 2013, 16:05   #357
DrO
 
Join Date: Sep 2003
Posts: 27,873
Jojo1104: with the gui issue, what language pack are you using and can you check that it's not an issue when not using a language pack i.e. using english.

as for the sync handling, there was a change with the recent beta which now applies the bad character fixes on albumartist (preventing a load of other issues) which is why it's now behaving as you're seeing.

so how it's now outputting is correct against how the code is done. maybe it should just skip 'illegal' characters at the end of the string but then what happens if all of the string is deemed to be 'illegal' characters. so i think for the moment it's better to leave things as is and is something that'll be reviewed when there's some time to look into it (and the whole handling of such things in the coming months).
DrO is offline  
Old 29th May 2013, 16:39   #358
Jojo1104
Junior Member
 
Join Date: May 2013
Posts: 5
Quote:
Originally Posted by DrO View Post
Jojo1104: with the gui issue, what language pack are you using and can you check that it's not an issue when not using a language pack i.e. using english.
You're right. Switching to english and the problem disappears, switching back to german and the problem is back.
Jojo1104 is offline  
Old 29th May 2013, 16:45   #359
DrO
 
Join Date: Sep 2003
Posts: 27,873
it looks like it's fixed in a newer test copy of the german language pack i've just tried (as a few things changed on the dialog resource which has lead to the visual issue you're seeing).
DrO is offline  
Old 29th May 2013, 18:00   #360
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,624
Send a message via AIM to MrSinatra
Quote:
Originally Posted by DrO View Post
as for the sync handling, there was a change with the recent beta which now applies the bad character fixes on albumartist (preventing a load of other issues) which is why it's now behaving as you're seeing.

so how it's not outputting is correct against how the code is done. maybe it should just skip 'illegal' characters at the end of the string but then what happens if all of the string is deemed to be 'illegal' characters. so i think for the moment it's better to leave things as is and is something that'll be reviewed when there's some time to look into it (and the whole handling of such things in the coming months).
i'm all for this fix, but it should NOT apply to his example, since a trailing period, or any kind of period, is not an illegal character.

the ones windows cites when u try to use one are:

\ / ? : * " < > |

I think EAC has the same list.

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline  
Closed Thread
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump