Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Wishlist

Reply
Thread Tools Search this Thread Display Modes
Old 19th January 2009, 05:39   #1
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Delete button on Artwork tab wrongly deletes physical files.

This is one of those design issues that creates a buggy-type hole in Winamp’s behavior
(but that isn't wholly right for the bug report forum).


Currently, as of Winamp v5.541 I have the following issue ...

Associated album art is displayed on the “Artwork” tab of the “File Info” window. Art will be displayed the same way regardless if the image is embedded in the tags or associated to the file as %album%.jpg/gif/png.

To remove embedded images, one can click the “Delete” button on the “Artwork” tab of the
“File Info” window. However, if no embedded image is present, clicking the “Delete” button will permanently delete the associated physical file. It won’t even send the physical file to the recycling bin, it’ll just be deleted.



I think it would be preferable if the “Delete” button only remove embedded tags. And to remove associated image files, a user must do so by deleting the physical file via another method.

If not this, then I think there should at least be some sort of additional warning (or additional step required) when deleting associated physical files, similar to the special actions required to delete a physical file via the Media Library (as opposed to simply removing the listing of this file within the Media Library).
Attached Images
File Type: jpg file info window - artwork tab.jpg (31.0 KB, 297 views)
jph6t is offline   Reply With Quote
Old 19th January 2009, 06:26   #2
Juanus
Major Dude
 
Juanus's Avatar
 
Join Date: Oct 2004
Location: Santa Monica, CA
Posts: 734
Send a message via AIM to Juanus
I cannot reproduce this.
First of all, the delete button on that screen doesnt really "work". If you have embedded art, when you press delete, it doesnt actually remove it. And if the jpg is in the folder, then it doesnt remove it from the folder.
Second, if there is no art associated, then that delete button is greyed out.
did I miss something?
Juanus is offline   Reply With Quote
Old 19th January 2009, 07:16   #3
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Thanks for your quick reply Juanus!
Quote:
Originally posted by Juanus
I cannot reproduce this.
First of all, the delete button on that screen doesnt really "work". If you have embedded art, when you press delete, it doesnt actually remove it.
Hmmm, it works for me.
After clicking the "Delete" button I get the following confirmation box:



Clicking "Yes" triggers the removal of the embedded image.
Does the "Delete" button remove embedded images for anyone else?

Note that the exact same confirmation box pops up when clicking "Delete" on a file with an associated image file. So this box doesn't provide protection against deleting physical files,
as the user can't tell from the message whether the image is embedded or associated.

Quote:
Originally posted by Juanus
And if the jpg is in the folder, then it doesnt remove it from the folder.
Hmmm, maybe this is just the tip of the iceberg, because I can repeat this behavior every time.
Can anyone else reproduce this issue?
Quote:
Originally posted by Juanus
Second, if there is no art associated, then that delete button is greyed out. did I miss something?
No, the button is greyed out for me too when no art is associated to the song.
Attached Images
File Type: jpg confirmation.jpg (8.6 KB, 276 views)
jph6t is offline   Reply With Quote
Old 19th January 2009, 07:20   #4
Sawg
Forum King
 
Join Date: Jun 2000
Location: Phoenix, AZ
Posts: 7,456
Send a message via ICQ to Sawg Send a message via AIM to Sawg Send a message via Yahoo to Sawg
You hit the delete button and it deletes the file. What exactly is the problem, not offering the recycle bin as an option?

| Brought to you by ^V ^C | The one... the original... no seriously!
Sawg is offline   Reply With Quote
Old 19th January 2009, 07:55   #5
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Quote:
Originally posted by Sawg
You hit the delete button and it deletes the file. What exactly is the problem, not offering the recycle bin as an option?
The problem is not knowing whether an embedded image is being removed,
or a physical file is being deleted.

I often remove unwanted embedded images from downloaded files.
But I don't want to accidently remove physical files in the process.
jph6t is offline   Reply With Quote
Old 19th January 2009, 11:19   #6
J_Darnley
Forum King
 
J_Darnley's Avatar
 
Join Date: Apr 2004
Location: Belgium, Europe
Posts: 3,626
Send a message via ICQ to J_Darnley
So you would like an option (somewhere) that is "Only 'Delete' embbeded artwork" and for all other, do nothing?

Winamp ATF ReferenceMy cPro timer widgetMy port of AVS
Do NOT email me with general tech support questions.
J_Darnley is offline   Reply With Quote
Old 19th January 2009, 16:16   #7
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Quote:
Originally posted by J_Darnley
So you would like an option (somewhere) that is "Only 'Delete' embbeded artwork" and for all other, do nothing?
I think any number of tweaks could provide the necessary safety net.
Brainstorming quickly I can think of:
  1. An option, as you suggested, that limits the action of the existing "Delete" button.
  2. Have the existing "Delete" button only delete embedded artwork.
  3. Add an indicator to the Artwork to show whether the image is embedded or associated.
jph6t is offline   Reply With Quote
Old 19th January 2010, 22:41   #8
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Feature Request - Deleting embedded artwork

Quote:
Originally posted by jph6t
The problem is not knowing whether an embedded image is being removed,
or a physical file is being deleted.

I often remove unwanted embedded images from downloaded files.
But I don't want to accidently remove physical files in the process.
Damnit!!! Just accidently deleted a physical file (%album%.jpg) in the process of removing the embedded images on some new MP3s.

Quote:
Originally posted by jph6t
I think any number of tweaks could provide the necessary safety net.
Brainstorming quickly I can think of:
  1. An option, as you suggested, that limits the action of the existing "Delete" button.
  2. Have the existing "Delete" button only delete embedded artwork.
  3. Add an indicator to the Artwork to show whether the image is embedded or associated.
Please consider one of these improvements as a new feature for an upcoming release.
jph6t is offline   Reply With Quote
Old 24th January 2010, 16:26   #9
jph6t
Major Dude
 
jph6t's Avatar
 
Join Date: May 2004
Location: USA
Posts: 756
Workaround - Protect physical image files

Quote:
Originally posted by jph6t
Damnit!!! Just accidently deleted a physical file (%album%.jpg) in the process of removing the embedded images on some new MP3s.
A work-around that can be used until an upgrade is made to the way Winamp handles Album Art deletions, is to make your physical image files (%album%.jpg) read-only. This should protect them from unwanted Winamp deletions.
jph6t is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Wishlist

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump