Fix breaks Playlist buttons

[ariszlo]

First of all, I wish you all a merry Christmas.

The iNTELLIdesign skin throws two error messages at startup:

• mismatched tag at line 68
• not well-formed (invalid token) at line 347

The first one is caused by this line in XML/system-colors.xml and can be fixed by adding a / before >:

PHP Code:

<color id="wasabi.text.color" value="color.Text" gammagroup="LCD"> 


The second one can be fixed by editing XML/standardframe.xml.

However, fixing the mismatched tag in system-colors.xml breaks the button bar in the playlist editor. I wonder how I could both fix system-colors.xml and not break the playlist editor.

The attached iNTELLIdesign_broken_pledit.wal fixes both standardframe.xml and system-colors.xml but breaks the playlist editor.
iNTELLIdesign_mismatched_tag.wal only fixes standardframe.xml: the playlist editor is ok but it starts up with a mismatched tag error message.

[Aminifu]

Happy Holidays!

What happens if you deactivate the mismatched tag line (remove it or turn it into a comment)?

[PeterK.]

Please bear in mind that this skin was designed (and coded!) for the 5.24 version from 2006(!).

Hence do not expect it to work properly with the latest 5.66 release.

[Victhor]

Actually, from Winamp 3 (when modern skins were implemented), most skins work properly, so is more likely that if it's not working is due to a faulty skin that from something implement by Winamp..

[ariszlo]

Originally Posted by Aminifu

What happens if you deactivate the mismatched tag line (remove it or turn it into a comment)?

The playlist buttons will be broken.

Originally Posted by PeterK.

Please bear in mind that this skin was designed (and coded!) for the 5.24 version from 2006(!).
Hence do not expect it to work properly with the latest 5.66 release.

OK but it is still weird why the playlist buttons are all right with a mismatched tag in system-colors.xml and broken with a syntactically correct system-colors.xml.

Originally Posted by Victhor

Actually, from Winamp 3 (when modern skins were implemented), most skins work properly, so is more likely that if it's not working is due to a faulty skin that from something implement by Winamp..

Yes, I am trying to figure out what is done wrong with this skin.

[Victhor]

On line 347 there is a opening comment-out sign which sort of ends on 356/357. The closing sign ("--") is duplicated. I think that'll solve it.

[ariszlo]

Yes, it fixes the second error message but not the first one.

[Victhor]

Weird.. really fixing a syntax error triggers the other error... tried a lot of things, couldn't make it work really.

The closer I got was to revert the PL buttons to a generic wasabi style... not ideal but functional ¬_¬

Attached just the XML's I've changed.

[ariszlo]

Thanks Victhor for trying to help. I have figured out how to fix this.

1. In skin.xml, I added this line:
<include file="xml/standardframe.xml"/>
after this:
<include file="xml/system-colors.xml"/>

2. Moved this line up:
<include file="xml/tabsheet.xml"/>
before this:
<include file="xml/pledit.xml"/>

The skin is not ready for publication, yet. It still has some minor issues and I will have to get permission from the original authors, too.

[ariszlo]

Fixed everything I wanted to fix. Changelog in the readme.

[ariszlo]

The version number of the skin in the previous post should be relegated to 1.2-wip2.