Old 20th January 2011, 07:33   #1
Squirre1
Member
 
Join Date: Aug 2001
Posts: 55
Send a message via ICQ to Squirre1
Possible MUI2 Super Minor bug

I have dug through the code and believe I have found a very small bug in the MUI2 Finish.nsh file.

I was adding MUI_FINISHPAGE_TITLE_3LINES but for some reason my Title was running into my text. This ONLY occured when I displayed the rebootnow/rebootlater radio options.

Original Line 336:
code:
${NSD_CreateLabel} 120u 45u 195u ${MUI_FINISHPAGE_TEXT_HEIGHT_BUTTONS}u "${MUI_FINISHPAGE_TEXT_REBOOT}"



Fixed Line 336:
code:
${NSD_CreateLabel} 120u ${MUI_FINISHPAGE_TEXT_TOP}u 195u ${MUI_FINISHPAGE_TEXT_HEIGHT_BUTTONS}u "${MUI_FINISHPAGE_TEXT_REBOOT}"



Basically, it was making the finish text static and not allowing it to be dynamic in support of the MUI_FINISHPAGE_TITLE_3LINES define. So the text was not adjusting correctly whenever the reboot option was presented to the installer...
Squirre1 is offline   Reply With Quote
Old 20th January 2011, 13:27   #2
Afrow UK
Moderator
 
Afrow UK's Avatar
 
Join Date: Nov 2002
Location: Surrey, England
Posts: 8,434
Please submit a patch and/or bug report.

Stu
Afrow UK is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump