onkeydown has been changed.

clementj · 30th March 2008, 12:31

Before 5.53 onkeydown only trapped keystrokes for the window that was associated with the script that used this function. Now all instances of onkeydown trap all keystrokes. This caused my skin to stop working properly. Is there any reason for this promiscuous change? The previous behavior was much more consistent and convenient.

DJ Egg · 30th March 2008, 16:57

Which skin? Link please :-)

We can add a flag for backwards compatibility, but need a (non)working example first...

Please also include a step-by-step detailed method of reproduction in your reply.

clementj · 30th March 2008, 19:37

In plmenu.m
------------------------------------------------
System.onKeyDown(String k) {
if(strsearch("abcdefghijklmnopqrstuvwxyz", k) != -1) complete;
-------------------------------------------------

Prior to 5.53 this only killed single key commands when the playlist window was active.

Now it kills all single alpha keystrokes in all windows so that search no longer worked.

I have already changed my skin to fix the problem. It is very annoying when behavior changes.

This type of thing also happened with respect to the onTitleChange which used to be triggered (before 5.34?) whenever a different entry in the playlist started, even if it had the same title. Now it is triggered only when the title changes.

DJ Egg · 30th March 2008, 20:43

Quote:

Originally posted by DJ Egg
Which skin? Link please :-)

We can add a flag for backwards compatibility, but need a (non)working example first...

clementj · 30th March 2008, 21:42

if(strsearch("abcdefghijklmnopqrstuvwxyz", k) != -1) complete;

can be added to the modern skin in plmenu.m after:
System.onKeyDown(String k) {

This kills the ability to enter characters in the search box of the media library when you are running V5.53, but NOT when running V5.52.

this line used to be in my extensive modification of the modern skin which is at:
http://www.hal-pc.org/~clement/Winam...ce%20Skin.html

However I changed that line to check for the context, and the core change is not a problem for me any more in 5.53.

So I no longer have a problem, but who knows about others?

30th March 2008, 12:31	#1
clementj Senior Member Join Date: Oct 2006 Posts: 369	onkeydown has been changed. Before 5.53 onkeydown only trapped keystrokes for the window that was associated with the script that used this function. Now all instances of onkeydown trap all keystrokes. This caused my skin to stop working properly. Is there any reason for this promiscuous change? The previous behavior was much more consistent and convenient.

30th March 2008, 16:57	#2
DJ Egg Techorator Winamp & Shoutcast Team Join Date: Jun 2000 Posts: 36,136	Which skin? Link please :-) We can add a flag for backwards compatibility, but need a (non)working example first... Please also include a step-by-step detailed method of reproduction in your reply. Playlist \| Twitter \| Albums

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

30th March 2008, 19:37	#3
clementj Senior Member Join Date: Oct 2006 Posts: 369	In plmenu.m ------------------------------------------------ System.onKeyDown(String k) { if(strsearch("abcdefghijklmnopqrstuvwxyz", k) != -1) complete; ------------------------------------------------- Prior to 5.53 this only killed single key commands when the playlist window was active. Now it kills all single alpha keystrokes in all windows so that search no longer worked. I have already changed my skin to fix the problem. It is very annoying when behavior changes. This type of thing also happened with respect to the onTitleChange which used to be triggered (before 5.34?) whenever a different entry in the playlist started, even if it had the same title. Now it is triggered only when the title changes.

30th March 2008, 21:42	#5
clementj Senior Member Join Date: Oct 2006 Posts: 369	if(strsearch("abcdefghijklmnopqrstuvwxyz", k) != -1) complete; can be added to the modern skin in plmenu.m after: System.onKeyDown(String k) { This kills the ability to enter characters in the search box of the media library when you are running V5.53, but NOT when running V5.52. this line used to be in my extensive modification of the modern skin which is at: http://www.hal-pc.org/~clement/Winam...ce%20Skin.html However I changed that line to check for the context, and the core change is not a problem for me any more in 5.53. So I no longer have a problem, but who knows about others?