Go Back   Winamp Forums > Developer Center > NSIS Discussion

Reply
Thread Tools Search this Thread Display Modes
Old 27th August 2002, 22:02   #1
Yathosho
Forum King
 
Yathosho's Avatar
 
Join Date: Jan 2002
Location: AT-DE
Posts: 3,167
Send a message via ICQ to Yathosho
Lightbulb http:// prefix detection

how about letting nsis detect whenever the prefix http:// is used in any part of it (messagebox, licence-text, whatever) and making it clickable?
Yathosho is offline   Reply With Quote
Old 27th August 2002, 22:19   #2
Joost Verburg
NSIS MUI Dev
 
Join Date: Nov 2001
Posts: 3,717
NSIS 2 makes links in the License text clickable. Making a hyperlink in a messagebox is not possible in Windows.
Joost Verburg is offline   Reply With Quote
Old 27th August 2002, 23:33   #3
Sunjammer
Major Dude
 
Join Date: Jun 2002
Location: Swindon, UK
Posts: 559
Do Help -> About in IE6 and at the bottom of the dialog you'll see two clickable links... "not possible" hehe :P
Sunjammer is offline   Reply With Quote
Old 28th August 2002, 02:35   #4
rainwater
Senior Member
 
Join Date: Aug 2000
Posts: 396
Send a message via ICQ to rainwater
Quote:
Originally posted by Sunjammer
Do Help -> About in IE6 and at the bottom of the dialog you'll see two clickable links... "not possible" hehe :P
Yes, but that is a dialog, not a MessageBox. Only plain text and line breaks are allowed in a MessageBox. A dialog is owner-drawn which gives you control over all of the elements, while a messageBox only lets you set the title, text, and the icon displayed.
rainwater is offline   Reply With Quote
Old 28th August 2002, 07:47   #5
Sunjammer
Major Dude
 
Join Date: Jun 2002
Location: Swindon, UK
Posts: 559
Ah but a MessageBox is a simple dialog drawn for you by Windows to make your life simpler. There is nothing stopping you replacing the call to MessageBox with your own dialog.
Sunjammer is offline   Reply With Quote
Old 28th August 2002, 10:31   #6
Joost Verburg
NSIS MUI Dev
 
Join Date: Nov 2001
Posts: 3,717
Quote:
Originally posted by Sunjammer
Ah but a MessageBox is a simple dialog drawn for you by Windows to make your life simpler. There is nothing stopping you replacing the call to MessageBox with your own dialog.
Yeah but it is quite a lot of work and extra overhead.
Joost Verburg is offline   Reply With Quote
Old 29th August 2002, 07:51   #7
Sunjammer
Major Dude
 
Join Date: Jun 2002
Location: Swindon, UK
Posts: 559
Before this thread dies completely, killahbite if it's a feature you want I suggest you add it to the NSIS2K SourceForge project feature requests here (if you haven't already).
Sunjammer is offline   Reply With Quote
Old 30th August 2002, 00:16   #8
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
Is hyperlink detection fixed in final alpha 7 (and is mailto: detected ?)? Because I have a preversion and it is not detected in Licen Text
I use Win98 SE, french
Wyz is offline   Reply With Quote
Old 30th August 2002, 01:42   #9
rainwater
Senior Member
 
Join Date: Aug 2000
Posts: 396
Send a message via ICQ to rainwater
Quote:
Originally posted by Wyz
Is hyperlink detection fixed in final alpha 7 (and is mailto: detected ?)? Because I have a preversion and it is not detected in Licen Text
I use Win98 SE, french
No, there is no detection of hyperlinks inside of rtf files for the license data for a7. I'm not sure that this was requested or if its possible or needed.
rainwater is offline   Reply With Quote
Old 30th August 2002, 08:43   #10
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,337
What are you talking about? Hyper links are still detected in the license page in a7 and this was never broken. E-Mails are only detected if they have mailto: before them, that's how Windows does it.

It doesn't work on Windows 98 becuase for some weird reason it always loads the old RichEdit control, even though Windows 98 should have version 2.

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 30th August 2002, 11:50   #11
rainwater
Senior Member
 
Join Date: Aug 2000
Posts: 396
Send a message via ICQ to rainwater
Hmm, you are right, I don't know what I was thinking.
rainwater is offline   Reply With Quote
Old 30th August 2002, 21:55   #12
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
Is there no way to force Win98 to use v2 of RichEdit ?
Otherwise there are some text editors which have htpp:// dectection working, can't you work a code for the licence window in order to make this possible for all Windows build ?
One more thing... I have tested with a .rtf file containing an hyperlink : the link is displayed in blue but no way to activate it
Regards
Wyz is offline   Reply With Quote
Old 31st August 2002, 08:11   #13
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,337
I will try again, but if it works don't you ask me to make it work on 95 too

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 31st August 2002, 08:40   #14
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,337
Seems like my Windows 98 doesn't have v2 even though this MSDN page says it should =/
And yet again we encounter the great, enriched, content filled, not an inch from the truth documentation of Microsoft...

Would you mind searching for RichEd20.dll on your Windows 98 machine and tell me if you can find it?

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 31st August 2002, 09:09   #15
YtseJam
Forum King
 
YtseJam's Avatar
 
Join Date: Dec 2000
Location: Israel
Posts: 2,399
Send a message via ICQ to YtseJam Send a message via AIM to YtseJam
Found it in my Windows 98(first edition) in C:\WINDOWS\SYSTEM.
YtseJam is offline   Reply With Quote
Old 31st August 2002, 09:29   #16
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,337
Thank you nant. I used SFC, and what do you know, it came back!
Seems like Windows 98 want you to specifically say you want v2 unlike others that just assume. I will try to find the best solution that will make it work on all OSes, including 95 (without hyper links because it doesn't v2).

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 31st August 2002, 11:27   #17
Joost Verburg
NSIS MUI Dev
 
Join Date: Nov 2001
Posts: 3,717
Quote:
Originally posted by kichik
Thank you nant. I used SFC, and what do you know, it came back!
Seems like Windows 98 want you to specifically say you want v2 unlike others that just assume. I will try to find the best solution that will make it work on all OSes, including 95 (without hyper links because it doesn't v2).
The v2 dll is often installed by other software on Windows 95. So you should check for v2, even on Win95.
Joost Verburg is offline   Reply With Quote
Old 1st September 2002, 23:03   #18
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
There are also mutiple versions of riched20.dll. On my system I found the following versions :
* 5.0.153.0 (version 5)
* 5.30.23.1200 (version 3)
* 5.40.11.2210 (version 4)
And one may have installed by my text editor which higlight URLs : ConTEXT (http://www.fixedsys.com/context/ ).
So it seems you can make it available for any Win OS...
CU
Wyz is offline   Reply With Quote
Old 3rd September 2002, 11:28   #19
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,337
Done. Now NSIS will always use RichEdit v2 if present.
Get your update at the CVS.

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 3rd September 2002, 19:41   #20
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
I tested w/ makensis 1.57 updated by justin 1014 but in the compiled version the licence text is not displayed (I don't have the window in which the text is displayed) and next button doesn't work ! (it's the same w/ 1.56 and w/ 1.54 : I see only an empty window but next button work...)
CU
Wyz is offline   Reply With Quote
Old 3rd September 2002, 20:23   #21
rainwater
Senior Member
 
Join Date: Aug 2000
Posts: 396
Send a message via ICQ to rainwater
Quote:
Originally posted by Wyz
I tested w/ makensis 1.57 updated by justin 1014 but in the compiled version the licence text is not displayed (I don't have the window in which the text is displayed) and next button doesn't work ! (it's the same w/ 1.56 and w/ 1.54 : I see only an empty window but next button work...)
CU
What exactly did you test? NSIS 1.x doesn't use the richedit control at all.
rainwater is offline   Reply With Quote
Old 3rd September 2002, 20:34   #22
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
I have tested the makensis.exe versions available in the CVS (those were it is mentionned "RichEdit")...
Wyz is offline   Reply With Quote
Old 3rd September 2002, 20:53   #23
Joost Verburg
NSIS MUI Dev
 
Join Date: Nov 2001
Posts: 3,717
Quote:
Originally posted by rainwater


What exactly did you test? NSIS 1.x doesn't use the richedit control at all.
He means the CVS revision 1.x
Joost Verburg is offline   Reply With Quote
Old 3rd September 2002, 21:05   #24
rainwater
Senior Member
 
Join Date: Aug 2000
Posts: 396
Send a message via ICQ to rainwater
Quote:
Originally posted by Joost Verburg

He means the CVS revision 1.x
Oh, thanks, I was starting to lose it for s sec
rainwater is offline   Reply With Quote
Old 3rd September 2002, 21:33   #25
justin
Moderator Alumni
 
Join Date: Apr 2000
Location: USA
Posts: 315
Quote:
Originally posted by Wyz
I tested w/ makensis 1.57 updated by justin 1014 but in the compiled version the licence text is not displayed (I don't have the window in which the text is displayed) and next button doesn't work ! (it's the same w/ 1.56 and w/ 1.54 : I see only an empty window but next button work...)
CU
If you are using a UI.exe, be sure to get latest (I updated modern.exe, modern2.exe, and default.exe) .. If it still doesnt work let me know.

-Justin
justin is offline   Reply With Quote
Old 3rd September 2002, 22:09   #26
Wyz
Junior Member
 
Join Date: Aug 2002
Location: France
Posts: 33
Send a message via ICQ to Wyz Send a message via AIM to Wyz
So you're THE justin ?
Thx for the reply, I didn't think I needed to update modern.exe (the UI I use)
It now works very fine, good job guys !
CU

PS : if we want to change the link color or to disable a link ?
Wyz is offline   Reply With Quote
Reply
Go Back   Winamp Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump