bug report: bzip2 leads to 'corrupt' uninstallers

psyke · 18th September 2003, 05:16

Hello.

I believe I have found a bug with bzip2 compression. (I'm using the latest nightly snapshot). I certainly hope it's a bug, otherwise something is really messed up for me.

Basically, when using bzip2 compression, everything seems to work wonderfully (although the compression doesn't seem all that great but maybe it's my installer data... anyway) except when one goes to uninstall, one is greeted with the dreaded dialog:

Quote:

---------------------------
NSIS ERROR
---------------------------
Installer corrupted or incomplete.

This could be the result of a failed download or corruption from a virus.

If desperate, try the /NCRC command line switch (NOT recommended)
OK

First I thought it was my fault, but then I found the same thing occurs with Example2.nsi (${NSISDIR}\Examples\Example2.nsi). Without bzip, everything works fine, including uninstall, and with bzip2 the uninstaller is corrupt. I've attached two differently compiled versions of Example2.nsi for you to test.

I hope this information is helpful and that the problem can be resolved.

salaam/peace

(this attachment has the crashing example2 - the next post has the one that's fine. i had to split them because one attachment with both was too big.)

psyke · 18th September 2003, 05:17

and here's the working example2, compiled without bzip compression.

kichik · 18th September 2003, 14:03

Which version of makensis.exe are you using? Open CVS\Entries and look for a number such as 1.241 in the makensis.exe line.

psyke · 18th September 2003, 15:18

Short answer: /makensis.exe/1.241/Tue Sep 16 19:07:57 2003/-kb/

Long answer: I always do a normal install of NSIS (without source) and when I searched through the 'Entries' files in my NSIS install dir I found no reference to makensis.exe. I re-downloaded the latest snapshot, unzipped it, and checked the Entries file in the root CVS directory - that's where I got my short answer above from.

Just to be sure, I re-installed the latest snapshot again, but the problem persists. It seems to affect everything, even NSIS itself refuses to uninstall, complaining about corruption! :P

As a test, I recompiled the NSIS installer without bzip compression and now it uninstalls fine.

By the way, here are the file sizes for the compiled NSIS installer:

nsis20b4.exe 1,719,114 bytes (with zlib)
nsis20b4.exe 1,511,271 bytes (with bzip2)

does that amount of compression with bzip2 seem about right?

kichik · 19th September 2003, 11:47

Thanks, fixed.

psyke · 19th September 2003, 14:22

Thank you Kichik, I'm glad you were able to fix it.

I'm surprised no one else seemed to notice the bug though.

25th February 2006, 00:32

How can a non-computer whiz fix this problem? I try to open the installer for WinAmp and it gives me that message that maybe it has a virus (ooooEEEEoooo) or that it just refuses to open it (jerk). I don't understand how to do the things you guys suggested.....

Any help?
Thanks,
Laura

kichik · 25th February 2006, 08:30

See "Why do I get NSIS Error?" from the FAQ.

18th September 2003, 14:03	#3
kichik M.I.A. [NSIS Dev, Mod] Join Date: Oct 2001 Location: Israel Posts: 11,343	Which version of makensis.exe are you using? Open CVS\Entries and look for a number such as 1.241 in the makensis.exe line. NSIS FAQ \| NSIS Home Page \| Donate $ "I hear and I forget. I see and I remember. I do and I understand." -- Confucius

19th September 2003, 11:47	#5
kichik M.I.A. [NSIS Dev, Mod] Join Date: Oct 2001 Location: Israel Posts: 11,343	Thanks, fixed. NSIS FAQ \| NSIS Home Page \| Donate $ "I hear and I forget. I see and I remember. I do and I understand." -- Confucius

25th February 2006, 00:32	#7
clio44 Guest Posts: n/a	help for the non-computer whiz? How can a non-computer whiz fix this problem? I try to open the installer for WinAmp and it gives me that message that maybe it has a virus (ooooEEEEoooo) or that it just refuses to open it (jerk). I don't understand how to do the things you guys suggested..... Any help? Thanks, Laura

25th February 2006, 08:30	#8
kichik M.I.A. [NSIS Dev, Mod] Join Date: Oct 2001 Location: Israel Posts: 11,343	See "Why do I get NSIS Error?" from the FAQ. NSIS FAQ \| NSIS Home Page \| Donate $ "I hear and I forget. I see and I remember. I do and I understand." -- Confucius

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode

18th September 2003, 15:18	#4
psyke Member Join Date: Mar 2003 Posts: 65	Short answer: /makensis.exe/1.241/Tue Sep 16 19:07:57 2003/-kb/ Long answer: I always do a normal install of NSIS (without source) and when I searched through the 'Entries' files in my NSIS install dir I found no reference to makensis.exe. I re-downloaded the latest snapshot, unzipped it, and checked the Entries file in the root CVS directory - that's where I got my short answer above from. Just to be sure, I re-installed the latest snapshot again, but the problem persists. It seems to affect everything, even NSIS itself refuses to uninstall, complaining about corruption! :P As a test, I recompiled the NSIS installer without bzip compression and now it uninstalls fine. By the way, here are the file sizes for the compiled NSIS installer: nsis20b4.exe 1,719,114 bytes (with zlib) nsis20b4.exe 1,511,271 bytes (with bzip2) does that amount of compression with bzip2 seem about right?

19th September 2003, 14:22	#6
psyke Member Join Date: Mar 2003 Posts: 65	Thank you Kichik, I'm glad you were able to fix it. I'm surprised no one else seemed to notice the bug though.