My plugin - gen_library.dll

[Kebabrov]

erm, you know how normal windows textboxes have a light-grey border on the bottom and right edges, and how the dark-grey border on the top and left edges. I think the windows API refers to it as sunken (maybe BDR_SUNKEN?)

[Joonas]

oh you mean like that...you want it like a regular edit field? white and sunken?

I don't know if that's possible really...the "sunken-ness" is drawn with gray colors by Windows and looks really ugly with the black background...

Any particular reason you don't like black?

/Joonas

[Kebabrov]

not always grey... the border colours seem to be skin-dependant for the library's textbox.

[d3x7r0]

well and what about that problem with the "Browse Mode" and "Search Mode" text, it's a real small bug but it will get tons of people complayining if the plugin goes live.

We've isolated the problem as beeing related to the Windows Skin your using, you'll just need to make that text Windows independent.

Many people don't bother to change the default Windows XP skin and some even like it better so it would be quite a pain to tell everyone that the problem was because of their WinXP skin, some people probably don't even know they can change the windows look....

[Joonas]

I'd love to fix it...but how do you change the text color of a radiobutton? Can't find working code anywhere

/Joonas

[siebe83]

I remember DrO making Skinned Preferences, so he might know.
I'm not sure wether with that plugin the radio buttons were skinned right, though.

Those damn XP styles

[Joonas]

Kebabrov: I dunno how they made it in Media Library...I only get it with gray (see screenshot)

I also must say I prefer the font that was large that I used before...this seems so out of place...but maybe that's just me?

/Joonas

[siebe83]

If you would get the text to be positioned a bit lower, it would be ok. Otherwise I prefer bold text as well...

Also, I don't know about the gray border. It's really skin dependant how it should look: black is more neutral, I think.
As it is in your screenshot, it wouldn't look nice in my skin... (border too light)
If you would be able to grab the same colors as ML does, it would be great. Otherwise, I prefer black, I think.

[d3x7r0]

well DrO come across that same problem in Skinned Prefs and the discussion on that plug stopped with me hoping DrO would be able to fix it...


...he never did... JK, at least no one ever touched that thread again LOL

[Joonas]

* Sunken searchbox
* XP Style radiobuttons?

Okay...it was totally impossible to find any example of something as simple (?) as changing the radio buttons text color...so I did it dirty and what do you think?

I also added that little sunken-ness...I was right but also wrong Windows always draw with the gray (at least if you have those colors set...) however...Winamp offered a flag DCW_SUNKENBORDER which cheated and just drew the lines one by one...

Oh and btw, I went back to the bold but oh so pretty (?) font for the search box...I just like it so much better!

Ah well. Happy testing!

/Joonas

[siebe83]

All right!
You did it.
But now it's always white text
Which in a lot of skins isn't readable at all... (in both XP and classic windows theme...)

Maybe make the color undefined, but add an option to change the color yourself in prefs?
I mean, in that case it would always get the correct color, UNLESS you have XP style (and the skin you are using should have white text), with the possibility to change the color yourself.
Now you get always the wrong color, UNLESS the text color in the skin you are using should be white.

[Kebabrov]

erm, wheres the latest version?

i tried the one in the link in your sig, and the border seemed the same.

[Joonas]

How about now?

[edit] the border is different for me? [/edit]


/Joonas

[siebe83]

It's working fine for me...
Try another skin: in some skins you hardly see it.

[Joonas]

Well...what skins are you guys using really? All the skins I try don't seem to skin anything but the main window and the playlist editor

/Joonas

[siebe83]

For instance:
http://www.winamp.com/skins/details.php?id=142087

Or:
http://forums.winamp.com/showthread....55#post1418755

Or:
http://www.winamp.com/skins/details.php?id=138231

Or my own skin (attachment)

the skin needs to support skinning of extra windows
(older skins mostly don't)

[Joonas]

Well both of your example looks splendid for me..

You are aware that I did a change when I asked "how about now?"

/Joonas

[siebe83]

No, I wasn't. Now I am

[siebe83]

wow!
so now it's working for XP style as well?!
good job!
(I think DrO would like to know this )

ok, small issue with the border
when you drag divider from utterright to the left
(see attachment)

[edit]
it would also be nice to have the mode buttons a little bit more to the right
(now, it's position is very close to the search bar)


btw, don't forget to submit

[d3x7r0]

Yup The XP stuff is now fixed

BTW I too can see what siebe83 shoes in his picture. To me it just appears when I open the window, it's right there below the search box.

It's looking really swell aldo I would prefer it to be a ML plugin insted of a General Purpose one but that's up to your judgment

[Kebabrov]

ok, i see it now. Got one problem tho... it still has the black border around it as it did before, aswell as the sunken effect.

I also get the bug shown in siebe's screeny. Maybe remove them manually by drawing background coloured lines over them should suffice, rather than clearing the whole windows.

Nice work fixing the XP stuff

I agree that browse mode should be a few more pixels away from the textbox.

[Carno]

Hi Joonas. I've been using dl for a while. I made it crash last night. When I deleted the root from view, Winamp generated errors & went down. I can duplicate it because I was dumb enough to do this twice in a row. When I added a 2nd folder before removing the 1st one there was no problem. OS is 2k w/ sp4, Athlon XP 2000, 256sdram, inboard sound & graphics

Best,
M

[Joonas]

Okay guys...here's the deal. The lines you mention is actually the lines that make up that sunken-ness of the searchbox...that's still important? In that case I try to make the plugin redraw those areas somehow...else we just remove the sunken-ness...I think the early versions of DL had those lines and were removed for exactly this reason

As for the crashing bugs...I've tried to clean up some code that I guess could crash...I can't seem to duplicate it myself though...you say you create ONE root folder and then you remove it and it crashes? And not when creating two? See if the bug is still there in the new version...if it is please give me some more to work with

I've moved the buttons another 4 pixels away from the search box. Agree that they were a bit too close.

Not that much more to do though...in another few days I guess we know if this is stable or not...noticed a few glitches with the time panel with the total amount of files and so...it says static if you have no roots and doesn't clear when you remove roots.
Anyone have some input how that one should look like btw? Right now I don't think it's very good..

/Joonas

[Kebabrov]

Originally posted by Joonas
noticed a few glitches with the time panel with the total amount of files and so...it says static if you have no roots and doesn't clear when you remove roots.
Anyone have some input how that one should look like btw? Right now I don't think it's very good..

/Joonas

How do you mean?

I think the time thing looks fine as it is. Maybe have it say 'file' for when there is only one file, and 'files' others. C'mon, cant be more than an If statement

Me like sunken-ness


tiny-little completely insignificant bug... when you have 'smooth the edges of screen fonts turned on' and set to cleartype.. drag and window over the 'browse mode' and 'search mode' and they will become slightly bold. probably being caused by the text labels being redrawn over the text labels, and then cleartype doing its work on the graphics previously on the window. clicking on the gets rid of it tho.

Another small thing related to skinning: as much as we both hate the ML, it has an option to use the same font as the playlist. Any chance the DL could use the same truetype font as the playlist? Personally, i dont care. but there may be demand in future.



It may be an idea to publish this as a Beta, or an Alpha just so other people who can play with it, test it and request it. I think most of the current people who use it will be developers (or those interested in developement). If you do release, put a big fat warning somewhere saying it is beta, and it may crash. You dont want people thinking this is the final thing and bad-mouthing it before its even done.

[Joonas]

* Fixed some flickering with listview when window was shown
* Fixed so you can have playlist font in tree and listview now...it doesn't automatically update the font if you change it though...dunno what message is being sent yet. Anyone knows?
* Added a beta warning.

Will look at the sunken-ness tomorrow.

/Joonas

[billyvnilly]

im not sure if it was the beta warning or the acutal dyn.lib.

AppName:winamp.exe AppVer: 5.0.0.4 ModName: gen_library.dll
ModVer: 0.0.0.0 Offset: 00008e8e

but i had a crash. it was right after i installed it on winamp startup...it has only happended once though.

[Kebabrov]

nice work, but for some reason, the listview and treeview dont use ClearType on the text. Any ideas?
Could you make the fontsize the same too.


Joonas, just wondering. What other stuff have u made?

[jojo 544]

Originally posted by Kebabrov
[B]Joonas, just wondering. What other stuff have u made?

Or will be making

[jojo 544]

Originally posted by jojo 544
[B]Everyting'smooth, no crashes here.

a thin seperation line between left and right view, as now sometimes the tekst just dissapears into nothing. Some kind of line like the frame could be used to seperate both views

Just found that infact it is aready there, but in my default skin (resurgence) it's not visable, also in some other skins like MMD3, Invicta, Zygote, Nebular....
another colour issue?

btw, button text colours'splendid

[Joonas]

Don't know much about ClearType really...will see what I can find out when I get back from work. But font size...isn't that correct? If I take a screen dump and measure, on my computer a B is 6 pixels in both DL and PL...

As for what other stuff I've made? What do you mean? Other plugins, programs or other features in this plugin that I'm not telling?

Billynvilly: You always get it to crash

/Joonas

[billyvnilly]

yeah LOL it seems that way...

well it always seems like the first load w/ a new dyn.lib. is bad, and then smooth sailing.

2.4Ghz pentium 4
1g ram
XP pro

the only thing i can think of is, taht im on modern skin, and at the same time folding(which consumes all system idle process)

[Kebabrov]

Originally posted by Joonas
Don't know much about ClearType really...will see what I can find out when I get back from work. But font size...isn't that correct? If I take a screen dump and measure, on my computer a B is 6 pixels in both DL and PL...

As for what other stuff I've made? What do you mean? Other plugins, programs or other features in this plugin that I'm not telling?

Billynvilly: You always get it to crash

/Joonas

Its very odd. If I let DL use its own font, cleartype is enabled, and it looks ok. If i tell DL to use the playlist font... and the playlist is set to use the 'skin or language pack font', cleartype isnt used in the DL. However, if i set the playlist font to any other true type font, cleartype is enabled in the DL.

As for size. it seems to be working.. my bad. (I may have forgot to toggle it on or off to update it). However, if it is set small (less than 10px for arial), then the height of each listview seems to be a minimum of (what looks like) 16 pixel. Maybe due to the fact the listview is expecting 16x16 icons to be drawn.



Other stuff... other plugins, programs, anything.

[jojo 544]

Buggy:

Select a file in any mode,rightclick, view file info.
Then close or cancel. The info keeps popping up, only 'update' helps closing it.

[Kebabrov]

Originally posted by jojo 544
Buggy:

Select a file in any mode,rightclick, view file info.
Then close or cancel. The info keeps popping up, only 'update' helps closing it.

confirmed... i can repeat it too.

[Ikarus7]

equeue after current and
enqueue & play

are such great innovations.
why doesnt winamp use them ?????????

[Joonas]

* Fixed a large memory-leak
* Fixed the bug with View file info - moved an else-statement a bit too far. But now you can Cancel

Have been fighting to remove the contextmenu for the search field to implement different searches...like path or id3-tags etc...no luck. Doesn't help with subclassing...the meny seems to originate from some other window...dunno which one. neither the search box nor the dialog acknowledges it until the menu is already there...

About the size of each row in the listview...I made them 16 pixels high since they looked awful when they were pushed together before...

[Kebabrov]

how have you tried to stop the normal menu appearing? I have some VB code that works. It just pops its own menu, and then stops the message WM_RBUTTONUP from gettin to the original message handler (the bit that says CallWindowProc(PrevWndProc,.....)

not sure if a C++ textbox is the same as a VB one tho

[Joonas]

I've subclassed the searchbox and this is its own WindowProc


LRESULT bleh = CallWindowProc(prevProc, hwnd, msg, wParam, lParam);

switch (msg)
{
case WM_CONTEXTMENU: return 0;
}

return bleh;

[Joonas]

* Fixed it!

Right-click in searchbox now let you select filter.
Test it! Pretty neat I think.

The solution for those interested was to CallWindowProc after processing WM_CONTEXTMENU.

/Joonas

[Joonas]

* Updates font correctly

Yay! Great day

/Joonas