My plugin - gen_library.dll

[Joonas]

Originally posted by siebe83
[B]Great!

Few issues:
- Searching for year/comment only works when 'search id3-tags' is enabled. It does not work when 'search all' is selected.

- When I press the delete button (on my keyboard), it will popup a warning 'Using this command will remove all selected files PERMANENTLY from disk. etc.'
When clicking yes, it will say the selected file can't be removed
This will happen when no file is selected, when nothing is in focus. It even happens when you are typing something in the search field and you press the delete button (to delete a character).

Fixed, yes?

Related to this?
"Added Del and Ctrl+Del keyboard shortcuts to Delete and Remove menu options"
Del should just erase the next character??
What is Ctrl+Del supposed to do?

Well it should call those commands in the menu? Ctrl+Del should work as Remove file(s) from playlist. Only for playlists...

- When you select a file in the listview and press delete (or select Delete in the popup menu), it will popup the warning and after that delete the FIRST FILE in the list view. Whatever file you selected, it will always try to delete the first file. If you select multiple files it will try to delete the first files in the list. Ah, I now find out the same will happen for Copy and Move...

Fixed, no?

- Usual order in Windows is cut, copy, paste, delete (not copy, cut, paste, delete). Bit annoying

Fixed.

- If you drag/drop a file to a specific position in the playlist, it will insert the file 9 items lower. Reproducable?

Reproducable? No...?

- In the past, switching mode would automatically set focus to the search field. It doesn't do that anymore... (I noticed this in an earlier release already, not sure in which one but I think it stopped working with release 0.9.5.1 or 0.9.5.2)

Fixed!

Concerning the m3u/pls: maybe just add pls also: it won't bother people not using pls and people who do use pls will be happy
(just for the record: I don't use them myself)

fixed!

Just a reminder: the resize-column-problem in the prefs (roots tab) is still there. Are you thinking about a fix, or will you just leave it like that? (not a big deal )

Yah, it sucks...but I dunno what's causing it...we'll see if I can fix it. Not very high on priority though

This version: v0.9.5.3d

/Joonas

[siebe83]

Some issues have been fixed, some haven't...

- Searching for year/comment only works when 'search id3-tags' is enabled. It does not work when 'search all' is selected.
I still don't seem to be able to search for year when 'search all' is selected. Maybe I'm overseeing something?

Well it should call those commands in the menu? Ctrl+Del should work as Remove file(s) from playlist. Only for playlists...

I see
(I was still thinking about the search field)

- When you select a file in the listview and press delete (or select Delete in the popup menu), it will popup the warning and after that delete the FIRST FILE in the list view. Whatever file you selected, it will always try to delete the first file. If you select multiple files it will try to delete the first files in the list. Ah, I now find out the same will happen for Copy and Move...
For me, it isn't fixed... It will still delete the first file in the list...

- If you drag/drop a file to a specific position in the playlist, it will insert the file 9 items lower. Reproducable?
I meant it was (and still is) reproducable for me. If it isn't for you, I will try it on a clean install later (maybe others can test as well?)

- The shortcut for paste in the searchfield is ctrl+v, not ctrl+p

- What did you do to the Prefs?!
(screenshot attached)
It looks like the height of the tab is fixed (in the sense that it isn't dynamic). All three tabs have the same height now...

[Joonas]

Originally posted by siebe83
Some issues have been fixed, some haven't...

I agree

- Searching for year/comment only works when 'search id3-tags' is enabled. It does not work when 'search all' is selected.
I still don't seem to be able to search for year when 'search all' is selected. Maybe I'm overseeing something?

Well...year has to have been read since it is an id3-tag...other than that it works for me?

- When you select a file in the listview and press delete (or select Delete in the popup menu), it will popup the warning and after that delete the FIRST FILE in the list view. Whatever file you selected, it will always try to delete the first file. If you select multiple files it will try to delete the first files in the list. Ah, I now find out the same will happen for Copy and Move...
For me, it isn't fixed... It will still delete the first file in the list...

I think this works now...no?

- If you drag/drop a file to a specific position in the playlist, it will insert the file 9 items lower. Reproducable?
I meant it was (and still is) reproducable for me. If it isn't for you, I will try it on a clean install later (maybe others can test as well?)

Yes plz...I have no problem with this...?

- The shortcut for paste in the searchfield is ctrl+v, not ctrl+p

Ah yes...a slip of my mind. Don't know what I was thinking

- What did you do to the Prefs?!
(screenshot attached)
It looks like the height of the tab is fixed (in the sense that it isn't dynamic). All three tabs have the same height now...

Hehe...when I add stuff I have to shrink it down to access the other controls...forgot to set the size back

This version: v0.9.5.4

/Joonas

[billyvnilly]

Well...year has to have been read since it is an id3-tag...other than that it works for me?

works for me too.

- If you drag/drop a file to a specific position in the playlist, it will insert the file 9 items lower. Reproducable?
I meant it was (and still is) reproducable for me. If it isn't for you, I will try it on a clean install later (maybe others can test as well?)

i can reproduce this. 9 items lower indeed?

[Joonas]

How do you drag then? Is this some crappy modern skin thingie?

Still not getting it...perhaps I am misunderstanding you...?

/Joonas

[siebe83]

Classic skin...
When I drag a file from DL to position 14 in the playlist (i.e. 14th item in the playlist) and drop it, the item will be inserted at position 23...
Wait, yeah I got it.

To reproduce, position the playlist lower on the screen (so not at the top).
I looks like DL calculates the position the item is to be inserted based on the vertical position relative to the top of the screen, instead of to the top of the playlist.
Clear?
Weird sentence that was...

Try moving your playlist editor to a lower position on the screen, and then drag a file to a specific position in the playlist.

[edit]
Year thingie still not working... (I don't get it... :/)
Also, the delete issue (i.e. it always tries to delete the first file...) is still there for me
@billyvnilly: second opionion on that one?

Another thing: the length of the search string is limited to the size of the search field. So when DL has its smallest size, you can hardly search: the search field will only allow for input of about 11 characters (depending on the size of the characters: a lot of i's, only some m's ).

[Joonas]

Most issues are fixed now I think...except Year then that seems to work...I dunno why it wouldn't work for you siebe...

about short search strings...I dunno why the edit box won't take more characters than its length...but it's not anything I do...Windows seems to do it that way (?)

This version: Dynamic Library v0.9.5.4b

/Joonas

[billyvnilly]

i just dl 0954b and i cant reproduce the drag 'n drop. fixed for you too siebe? (i was using classic skin as well btw)

As for the delete thing, i didnt try this out on 0954 so i couldnt confirm on that build. it is not present on this build. if i delete something other than first item, it confirms i'm deleting the correct file and deletes correct file.

oOo and i never noticed the searchbar limitation ???? weird. the media library searchbar works fine.

[siebe83]

Originally posted by billyvnilly
i just dl 0954b and i cant reproduce the drag 'n drop. fixed for you too siebe? (i was using classic skin as well btw)

Yep, fixed for me as well

As for the delete thing, i didnt try this out on 0954 so i couldnt confirm on that build. it is not present on this build. if i delete something other than first item, it confirms i'm deleting the correct file and deletes correct file.

Fixed!


Concerning the searching year/comment thing: it isn't limited to those two tags. When 'search all' is selected it won't search any id3-tags for me...
I will test this later with other settings and stuff, and maybe just reset all DL-settings...

- In the root-playlist-popup-menu it will add 'Save playlist' when you clicked an entry: after you used the menu and clicked something, the next time 'Save playlist' will be listed twice... It will be added under the entry root management and it will be available in NON-playlist-roots as well...
(if I'm unclear, I'll post a screenshot)
> Right-click root playlist
> Click 'Select missing files' (or any other entry)
[edit] ^ won't even be necesary to reproduce: just opening the menu will be enough to trigger it[/edit]
> Right-click root playlist again
> 'Save playlist' will have been added under 'Root management'

- Maybe related: I removed a file from the playlist. After that I clicked 'Save playlist' (the original entry, not an added one). Then I went to Root Management > Refresh now. The removed file is there again

[Joonas]

Concerning the searching year/comment thing: it isn't limited to those two tags. When 'search all' is selected it won't search any id3-tags for me...
I will test this later with other settings and stuff, and maybe just reset all DL-settings...

I hope you're aware that no id3-tags are actually read just because this is selected...

- In the root-playlist-popup-menu it will add 'Save playlist' when you clicked an entry: after you used the menu and clicked something, the next time 'Save playlist' will be listed twice... It will be added under the entry root management and it will be available in NON-playlist-roots as well...
(if I'm unclear, I'll post a screenshot)
> Right-click root playlist
> Click 'Select missing files' (or any other entry)
[edit] ^ won't even be necesary to reproduce: just opening the menu will be enough to trigger it[/edit]
> Right-click root playlist again
> 'Save playlist' will have been added under 'Root management'

Fixed.

- Maybe related: I removed a file from the playlist. After that I clicked 'Save playlist' (the original entry, not an added one). Then I went to Root Management > Refresh now. The removed file is there again

Doesn't show up for me...but I have changed a lot of code there for this release...is is still happening?

This version: v0.9.5.5

/Joonas

[siebe83]

Originally posted by Joonas
I hope you're aware that no id3-tags are actually read just because this is selected...

I am
(or ?)

Doesn't show up for me...but I have changed a lot of code there for this release...is is still happening?

Still happening. But maybe leave it atm, I will test this more thoroughly tonight.
(It looks as if playlists are not being saved for me in other occasions as well. Other thing that is happening for me: sometimes when I close Winamp, it will restart instead... Needs some more testing to see what triggers it, and wether it's related (since in the case of such a restart, it gives a message sound, which could be caused by the confirmation box to save the playlist, dunno...))

[Joonas]

Never experienced that...could it be some other plugin? Have you tried it with a clean install?

/Joonas

[AsHopeDies]

My treeview is gone....I only see the listview....WTF ?

[siebe83]

Like this?
(see screenhot)

Try dragging the redmarked 'line' at the left to the right.

@Joonas:
Didn't try clean install yet...
Sorry, but I'm short in time this week... (exams)
Oh, and I didn't mean to blame your plugin for my weird issues. It might be one of DrO's
Nah, seriously, just leave it atm. As long as it's only me I wouldn't be worried
I'll have more time saturday...

[AsHopeDies]

Originally posted by siebe83
Like this?
(see screenhot)

Try dragging the redmarked 'line' at the left to the right.

That's it....tnx a lot

[Joonas]

Originally posted by siebe83
@Joonas:
Didn't try clean install yet...
Sorry, but I'm short in time this week... (exams)
Oh, and I didn't mean to blame your plugin for my weird issues. It might be one of DrO's
Nah, seriously, just leave it atm. As long as it's only me I wouldn't be worried
I'll have more time saturday... [/B]

No prob And what do you mean "as long as it's only me" - maybe it's only you using it? :P

/Joonas

[siebe83]

@AsHopeDies:
You're welcome

@Joonas:
You know that isn't true. In a few days this thread will be flooded by people whose playlists aren't saved

[level50]

hey, i posted on here a while ago, so i'm sorry if this is repeating.

but when i go into a sub-folder and click on a song to play, is there an option which will enqueue the folder in which the mp3 is in? for example my mp3s are divided like this:

MP3s --> albums --> artists --> albums --> song

is there anyway i can double click and song and have the albums be enqueued?

thanks! great work so far, joonas

[Joonas]

I remember this but I still think it's just as easy clicking on the folder...you can even select Go to folder and then just click on that folder instead...seems like a hassle to implement this just since you guys are lazy

But of course...if this is a general request I guess I have to...any takers?

/Joonas

[jojo 544]

level 50: Maybe you never tried clicking a folder, but yes, it is indeed possible to enqueue a selection from the left view, or play a complete map by just clicking it (few more centimeters to the left from where the file is)

[Joonas]

Seem things to be working? In that case I was thinking about putting the plugin up in the General forum and see if anyone's interested...

And in a short while publish it. If you don't have a killer idea I think ideas from hereafter will be put up on the todolist for the next version, ok?

/Joonas

[jojo 544]

Saving playlists doesn't seem to be working properly yet (same thing than siebe here)
Everything else's fine, so if the saving thing is fixed i should say GO! Joonas

note: one more small thing: now i use DL lot more than ML, so it would be great to make the buttons on the skins that open ML, work for DL instead.
I think if DL was a ML plugin this would be no problem, but as i understood that will not happen for this version, so if there was any other way to make buttons work on DL...?

[Joonas]

Originally posted by jojo 544
Saving playlists doesn't seem to be working properly yet (same thing than siebe here)

Okay...you mean if you remove a file from a playlist and then select Save playlist and then Refresh -> Now?

And this returns the file to the playlist?

/Joonas

[DrO]

Originally posted by jojo 544
note: one more small thing: now i use DL lot more than ML, so it would be great to make the buttons on the skins that open ML, work for DL instead.
I think if DL was a ML plugin this would be no problem, but as i understood that will not happen for this version, so if there was any other way to make buttons work on DL...?

you'd need to hook those messages and then prevent Winamp from ever receiving them to process them.

doing the one on the 'about' button in classic skins works like that i believe but anyway, that's how i'd look at doing it

/me wanders off to do some work now after butting into things

-daz

[jojo 544]

Yes, the refresh is greyed at this point, but close & reopen winamp and the removed files (or any other changes made) are back.
Also loading that playlist direct from playlistwindow after DL saved it, doesn't show the changes...

DrO's buttons sollution (great as the man is ) is to much code talking for my not so enlightened brains, heh. But i hope Joonas, you can work it out

[Kebabrov]

Heya Joonas,

Long time, no post i've been busy with real life.

Anyhew... a quick bug report :
When DL is visible, and winamp is minimized, and then winamp is closed (by right clicking its button in the task bar), DL isnt visible next time winamp starts. (probably because it thinks its invisible when winamp minimizes). I can repeat it... anyone else?


good to see developement started again... are you on a break from school? highlighting the drop target for drag+drop is very nifty

[Kebabrov]

Sorry for double post, but its unrelated to that other post.

Joonas... i know you said you will never do this, but it does seem to be quite requested. Make DL *act* like the playlist.

At the moment, i have this:

As you can see two panes (wa playlist+the listview) have exactly the same contents. A nice thing to do would be to get rid of the playlist. The down side to this is that you cant pick a song from the playlist.

What i suggest is an option 'playlist mode'. When in this mode, double clicking an item in the listview causes all songs in the listview to be dumped in winamps playlist, and the song that was double clicked begins playing. finally, when winamp starts playing a new song, it should be highlighted somehow (selecting it is more than enough).

However, this renders the play/enqueue buttons and menu items useless, so maybe hide them while in playlist mode?

I really hope you consider this


(Btw, i really think DL is ready for release now)

[billyvnilly]

Originally posted by DrO
you'd need to hook those messages and then prevent Winamp from ever receiving them to process them.
doing the one on the 'about' button in classic skins works like that i believe but anyway, that's how i'd look at doing it

@joonas, i know saivert knows how to do this, its in his thinger plugin. (if its not already out in the open)

its ready for submission once siebe's bug is taken care of.

If you submit this to general discussion, watch out, youll get alot more feature requests! I suggest submitting to WA.com (skipping GD all together), then collecting features, holding off on your next update.

[Joonas]

Yes I will look into that about overriding ML...it should be pretty straight forward. DrO:s suggestion points pretty much out what has to be done

As for siebe's bug (and jojo:s) it is again one of those pesky bugs that seems to be a bit random...since I don't get it. Do you guys use Autosave or manual save?
Could you please (again) describe exactly what you do to cause this?

I will have to think about the playlist mode...you have no idea how much I'd hate to go in and mess with that code

I seem to recall that DrO had found some bugs in the drawing of the scrollbars...?

/Joonas

[jojo 544]

Ok; i select a rootplaylist (634 files), rightclick, remove broken links, (now 470 files). rightclick again, save playlist. Now:

1) Close winamp, reopen, open DL, goto that playlist, 634 files again..(if close /reopen only DL, 470 files seem to be rememered correctly tho).

or..
2) Goto winamp playlist window, and on the bottom right button open playlist, browse to open the same playlist: 634 files again.

This is just an example, it doesn't matter what kind of changes you make (remove broken links, ad , delete files, move files around...) it also doesn't matter if auto save is on or of. Happens both in classic and moder skins.

[Joonas]

Which version do you use? No problems at my end :/

/Joonas

[DrO]

Originally posted by Joonas
I seem to recall that DrO had found some bugs in the drawing of the scrollbars...?

oh shit, i forgot about posting the updated code for that er let me see what i can get done tonight (between everything else i've got to do )

-daz

[jojo 544]

Originally posted by Joonas
Which version do you use? No problems at my end :/

/Joonas

Latest version, 0955

But it has been like that some versions before also.
Strange thing it works for you i can repeat it every singel time i try.

Maybe Siebe can find out more about this problem?

[Joonas]

Can I ask something? Do you have the root playlists among a folder root? That could explain it...I guess if you change the root and then close Winamp the other playlist treeroot will be saved too...

/Joonas

[jojo 544]

Yes i have it like that, maybe that explains it indeed.
How to fix i dont understand, what do you mean by 'change the root'?

[Joonas]

Never mind...it was just me thinking aloud

Anyway...I never got what you said to be a problem...however if you did the exact same thing on a treeplaylist you got that behaviour...that is fixed in this release...I guess I have to make some sort of connection between a tree playlist and a root playlist if they point at the same playlist file eventually...

If they do point at the same file and you make a change in a root playlist and another change in the tree playlist I don't know which one will be saved...

But anyway...the behaviour you talked about occurs for <b>root</B> playlists and not tree playlists?

This version: v0.9.5.5b

/Joonas

[siebe83]

Ok, so I did a clean install of 5.05, and I removed the DL settings from registry and installed 0.9.5.5b. All clean...
This means 'Autosave playlists' is enabled.
I added three roots:
*ss (a folder on my desktop with other folders in it)
*blahblah.m3u (a playlist created by DL on my desktop)
*testmap (C:\Geluiden\Testmap)
-test.m3u (a tree playlist created by making an empty file in testmap)

In both playlists I put mp3 files from both roots.

- Don't forget to remove the Beta warning at first startup when you're gonna release DL

- When I remove a file from a root playlist or add a file to a root playlist and then click 'Save playlist', the playlist is properly saved. Though when I use the feature 'Remove broken links' and then 'Save playlist', the playlist is NOT saved.
'Remove broken links' > add a song to playlist > 'Save playlist': the playlist IS saved.
'Select missing files' > remove those files from playlist: playlist IS saved.
So it looks as if there's a problem with 'Remove broken links'.
Everything above is also tested with closing Winamp/DL instead of 'Save playlist', which gives the same results.

- Tree playlist:
The same as above.
Only difference: playlist will never be saved when closing Winamp/DL.

- I still have the same problem with the ID3-tags. When 'Search all' is selected, it won't search the ID3-tags. For me, there's no difference between 'Search all' and 'Search path & filename'. I wasn't able to find a preference possibly related...

- How does searching in (root AND tree) playlists work? I've got a feeling it always only searches the path as defined in the m3u file (whatever is selected... 'Search all/(path & )filename/id3'). So it won't search the full path and/or id3-tags, and it will display files with xxx in the filename even when xxx isn't in the id3-tags and 'Search ID3-tags' is selected...

- Cosmetical issues
[blahblah]Take a look at the screenshot. I don't know what I did exactly, I was messing with the colums. The # column would sometimes jump to second position when I try to resize it. So I repositioned it to the first place, and for some reason the title column was suddenly centered. The # column as well, but that went back to normal when I kept on messing
At the same time the column header of the title column became blank and the icons for the folders disappeared... [/blahblah]
Don't take this all too seriously: I was messing a lot... (after closing/reopening DL, everything was normal again).
Another cosmetical issue will be posted in a follow-up post.

If you need more info, or if I forgot something, let me know...

[siebe83]

This one only occurs when the treelist is hidden.

3 screenshots:
1. Draw splitter to the left until treelist is hidden > Resize DL window upwards (decrease vertical size)
2. Draw splitter to the left until treelist is hidden > Resize DL window downwards (increase vertical size)
3. Draw splitter to the left until treelist is hidden > Close/Re-open Winamp/DL

I.e.: the shadow lines on the right and bottom of the treelist should be hidden when the treelist is invisible. In case 1 and 2 the lines are still at the position they were before the treelist was hidden, in case 3 they are at their default position (?).

[Joonas]

Okay...some issues with those pesky playlists have been resolved. Try it and weep Or maybe I should weep...

- I still have the same problem with the ID3-tags. When 'Search all' is selected, it won't search the ID3-tags. For me, there's no difference between 'Search all' and 'Search path & filename'. I wasn't able to find a preference possibly related...
- How does searching in (root AND tree) playlists work? I've got a feeling it always only searches the path as defined in the m3u file (whatever is selected... 'Search all/(path & )filename/id3'). So it won't search the full path and/or id3-tags, and it will display files with xxx in the filename even when xxx isn't in the id3-tags and 'Search ID3-tags' is selected...

Something came to mind as I looked at this code...the tags are actually what DL puts in the columns...if a certain tag is missing it will guess depending on what you have set in Preferences it should do...does this explain anything? If I put Dynamic Library on any tag it will find it when I search for that file...depending of course whether DL has scanned the file before...

I am aware of some issues which are cosmetic...many will probably be there in the full version...sorry. They just appear to random and are (almost) all fixed when close/reopen DL...just don't feel like I have the time right now. Look forward to a 1.1 version without cosmetic bugs

This version: v0.9.5.5c

/Joonas

[siebe83]

Originally posted by Joonas
Okay...some issues with those pesky playlists have been resolved. Try it and weep Or maybe I should weep...

Will take a look at this later

Something came to mind as I looked at this code...the tags are actually what DL puts in the columns...if a certain tag is missing it will guess depending on what you have set in Preferences it should do...does this explain anything? If I put Dynamic Library on any tag it will find it when I search for that file...depending of course whether DL has scanned the file before...

Are you talking about searching playlists? Did you try it? Is searching playlists for you working properly?
I tried it with both guessing off and guessing on: same problem. Shouldn't matter, anyway... (I took content of the columns into account while testing)
Err, apologies if I sound a bit itchy. I don't care about searching playlists really, I'm more concerned with the 'Search all' not working properly. Or actually disappointed
I'd expect DL to display the results of 'Search path & filename' PLUS 'Search id3-tags' when 'Search all' is selected... It doesn't...
And yes, the tags have been read.
(sorry, this makes me a bit touchy: I seem to be the only one experiencing this AND I'm sure it doesn't work properly for me)
If this can't be solved, alas, it can't be solved. Nevertheless, I will summarize (for the last time ) how it behaves for me:
Filename: "Artist - Abum\Artist - Title"
Tags: Artist = "Artist", Title = "Title", Album = "Album", Year = "1995"
Tags have been read. Guessing is OFF, 1995 is properly displayed in the year column.

I type in the search field '1995'.
I select 'Search id3-tags' > file will be displayed
I select 'Search all' > file isn't displayed

To other users: please tell (if you haven't already done so) wether this happens for you as well. I'm confused

I am aware of some issues which are cosmetic...many will probably be there in the full version...sorry. They just appear to random and are (almost) all fixed when close/reopen DL...just don't feel like I have the time right now. Look forward to a 1.1 version without cosmetic bugs

That's ok...
Though the one in my second post shouldn't be too hard to fix, I think. It's especially annoying for users who have the treeview hidden by default (case 3). See what you can/want to do