My plugin - gen_library.dll

[narc0sys]

have you thought about a "delete files/folder" option or was that already pages ago?

[Joonas]

Delete files are already there isn't it?

Delete folder isn't that much trickier...will see what I can do

/Joonas

[narc0sys]

Yeah it's already there..I haven't slept very long you know

I know about the option to open the dl with the winamp icon (the lightning bolt) but because not many skins got that, is it impossible to open the dl with the ml button?

[Joonas]

I doubt it is impossible But the ML button is something supported by the gen_ff plugin I suppose...since it is not a standard Winamp thingie...

Anyone (perhaps DrO) know how to catch that button?

/Joonas

[AnodA]

Hi Joonas!
Could you please add support of saiverts Thinger plugin. It's somewhere mentioned in this thread.
Think it would be nice to deal with some plugin windows on top of each other.
Just an idea.
/Edit:
ah, billyvnilly posted that already - but it would be my wish too.
/
AnodA
(btw. great work! )

[Joonas]

Ahem, when saivert adds support for external icons (next version it seems) I can do that...

Btw...if several programs attempt to catch the lightningbolt click will the last one to subclass the main window then actually get it? Anyone who knows?

Preferences was all messed up on last release.

Thus the only change in this release is proper Preferences

This version: v0.9.5.9b

/Joonas

[narc0sys]

Also, is it right that when you click on the scrollbar in the dl it goes all the way down? Cause it's sometimes frustrating when you got many folders, just found what you searched for and accidentally click there. Maybe there could be an option to turn this on and off?

[Joonas]

Originally posted by narc0sys
Also, is it right that when you click on the scrollbar in the dl it goes all the way down? Cause it's sometimes frustrating when you got many folders, just found what you searched for and accidentally click there. Maybe there could be an option to turn this on and off?

Eh...click where?

/Joonas

[narc0sys]

on the up/down scrollbar in the left where the folders are

[Joonas]

No...it shouldn't jump all the way down if you hit the scrollbar...doesn't for me.

Anyone?

/Joonas

[siebe83]

- Right-click Enqueue button at the bottom > select 'Enqueue after current'/'Enqueue and play'
After that, it's impossible to select 'Enqueue' again.

- I've got the same problem as narc0sys: when I click (without dragging!) on the scrollbar button (i.e. the button you can drag to scroll), it will jump to the bottom of the list (only in tree view in search mode, when the button is not at the ultimate top).

[jojo 544]

Browse mode to, but it only does that when you first scroll it down a bit.
Funny bug

edit: horizontal scrolbar, same thing

[Joonas]

Okay...fixed the Enqueue button thingie. As for the scrollbar...safai?

I know next to nothing about the cool scrollbar library...DrO and safai know much more....

Please help

/Joonas

[narc0sys]

Maybe a bit much but how about an extra button to reload so that it won't reload when you close and re-open it?

But forget about that one. I guess that would steal the dynamic from the library.

[jojo 544]

I don't mean to spoil your fix on the the enqueue button, but... The right click menu has check boxes, i don't see what they do i think there shouldn't be any check boxes, just the 3 rightclick options to make a enqueue action different from the default button action that is set in pref's. (wasn't it ment to be like that a version or 100 ago? i remember something like that)

[Joonas]

Well...what they do is set what action the Enqueue button should perform...but maybe you're right...perhaps when you pick one it should be executed AND set to the default behaviour for single-click on the Enqueue button?

Comments?

/Joonas

[siebe83]

I don't use the enqueue button, so don't count my vote
I do think though that the behaviour you just described could be confusing: people expect a menu to set an option OR execute an action, not both. But maybe people will figure out soon enough what's happening, dunno...

[Joonas]

Well, I don't use it either so I just want to know what ppl want it for

/Joonas

[jojo 544]

Originally posted by Joonas
Well...what they do is set what action the Enqueue button should perform...

In that case it doesn't work for enqueue after current

perhaps when you pick one it should be executed AND set to the default behaviour for single-click on the Enqueue button?

Yes but leave the 'AND' out and execute only, so if you f.i. want to enq & play just one song, you don't have to mess with pref settings and then reset them for only this one song.
Just another thought

[Safai]

Originally posted by Joonas
Okay...fixed the Enqueue button thingie. As for the scrollbar...safai?

I know next to nothing about the cool scrollbar library...DrO and safai know much more....

Please help

/Joonas

interesting... i have no idea what's wrong at the moment...

by the way, it happens with the media library too, although the behaviour is different

[Joonas]

Originally posted by jojo 544
In that case it doesn't work for enqueue after current

Yes but leave the 'AND' out and execute only, so if you f.i. want to enq & play just one song, you don't have to mess with pref settings and then reset them for only this one song.
Just another thought

But does we really need this button in that case? Can't you just right-click in i.e. the listview and get all enqueue items there?

/Joonas

[jojo 544]

Yes we can
but enqueue after current doesn't work that way either, so maybe forget about the button options and just fix the after current? for me good enough

[Joonas]

Enqueue after current are fixed. Didn't work anywhere in the program anymore

This version: v0.9.6.0

/Joonas

[Sire404]

Tjena Joonas!

When will DL become an official plugin? It's so fucking great it should be compiled into Winamp!

Thanks,
Sire404

[Joonas]

Hehe, thanks for the compliment

I doubt it will be included in Winamp but it will become an official plugin when (and if) the staff thinks its worthy which they will decide when we have rooted out the bugs in this thread. Hopefully in the next few weeks we'll be done. No new major features will be included, but please post them since I will probably start work on a new version eventually...

/Joonas

[narc0sys]

If I want to delete a file there are two warnings. One from the dl and one from Windows. Isn't one enough?

[Joonas]

Hmm, perhaps. Thing is that you can remove those dialogs from Windows if you'd like...sending files straight to trash bin without asking first...

What does other ppl think?

/Joonas

[Kebabrov]

Joonas...
I think there should only be one dialog.

either:
DL shouldnt show a dialog, and delete as it is doing now
or:
DL should show the dialog, and just delete the file itself (i.e dont do the windows way of deleting files).

I reckon the first way is better, since DL is explorer-like (i.e tree and listviews), so it should also have the explorer-like way of deleting things like windows.

I think the majority of people have windows set so it moves things to the recycle bin on delete, instead of remove immediately.

[Joonas]

* Some minor changes in some caption messages. (i.e. No files to add has become No files to display.)
* Add playlist manually now also actually loads the playlist. This didn't happen in the last few releases.
* Changes in confirmation dialogs for deletion. Only one dialog when deleting playlists and files.

This version: v0.9.6.1

Btw, DrO at your convenience...the bug fix for the scrollbars?

/Joonas

[jojo 544]

After deleting a playlist (or file) it is still visible in DL until the root is refreshed. Shouldn't DL after deleting auto refresh the root?

[Safai]

Originally posted by Safai
interesting... i have no idea what's wrong at the moment...

by the way, it happens with the media library too, although the behaviour is different

here is the fix... (i hope it works for you too )...

in coolscroll.c

function NCLButtonDown

in the middle of the function there is this switch(uCurrentScrollPortion)

go to case HTSCROLL_THUMB:

replace

nLastPos = -sb->scrollInfo.nPos;

with

nLastPos = sb->scrollInfo.nPos;

(basically remove the minus sign in the statement)

[Joonas]

Originally posted by jojo 544
After deleting a playlist (or file) it is still visible in DL until the root is refreshed. Shouldn't DL after deleting auto refresh the root?

Well...have you turned off Automatic refresh?

Safai: works great...great work

/Joonas

[jojo 544]

Originally posted by Joonas have you turned off Automatic refresh?

No it's on.
Here's another one: When i set the lightning bolt to open DL, after close and reopen winamp, on mouseover ANY button a message pops up showing 'Dynamic Library'. When i uncheck lightning bolt open DL, and close and reopen winamp everything is back to normal.

Edit: refreshing in rightclick menu for root's children is greyed. Isn't it posible to make it work? the F5 does!

[Joonas]

Originally posted by jojo 544
No it's on.

That's strange...works fine for me. (as always )
Anyone else having trouble with this?

Here's another one: When i set the lightning bolt to open DL, after close and reopen winamp, on mouseover ANY button a message pops up showing 'Dynamic Library'. When i uncheck lightning bolt open DL, and close and reopen winamp everything is back to normal.

Fixed.
Thanks saivert for this code - stole it from your Thinger source...hope that's okay

Edit: refreshing in rightclick menu for root's children is greyed. Isn't it posible to make it work? the F5 does! [/B]

Fixed.

This version: v0.9.6.2

Slightly smaller file size now...removed some optimizations for Windows 98...shouldn't be a problem since DL requires 2k or XP.

/Joonas

[jojo 544]

YES! and the scrollbars are fixed too

Some error box pops up when click on collum headers to sort.

As for the autorefresh, maybe i have it off after all, couldn't find the option in prefs. I asumed its the auto tag reading, but then again maybe it's not???

A reproducable crash: rightclick a song in DL makes winamp crash.

[DrO]

Originally posted by Joonas
Btw, DrO at your convenience...the bug fix for the scrollbars?

will be tonight (if not then you can shoot me )

-daz

[Joonas]

Originally posted by jojo 544
YES! and the scrollbars are fixed too

Yes, thanks to safai

Some error box pops up when click on collum headers to sort.

Oops, forgot that one. Removed it.

As for the autorefresh, maybe i have it off after all, couldn't find the option in prefs. I asumed its the auto tag reading, but then again maybe it's not???

No, you still have the two mixed up. Auto-refresh means keeping a mirror of your files in the folders. Auto-read tags are just whether it should try to read the id3-tags contained in the actual files. You have mixed them up before, I mind you I did add auto-refresh to the Preferences too, to make it all easier to see the difference

A reproducable crash: rightclick a song in DL makes winamp crash. [/B]

Yup, fixed.

This version: v0.9.6.3

/Joonas

[nosongunheard]

Hey,

I downloaded the gen_library.dll and put it in the Winamp folder, then started Winamp and nothing happens. How do I activate / start the plugin? I'm running winamp505_full.

Thanks,
O.

[Joonas]

Plugins go in the Plugins folder...

Then you activate it by selecting Dynamic Library in the main Winamp menu.

/Joonas

[nosongunheard]

Thanks Joonas.

When I tried this plugin a while ago, it had a (to me) great function. When I double-clicked on a folder in the treeview, it randomly picked a file in that folder and played it.

When doing the same thing now, it plays the first song in that folder and becomes silent when finished playing that song.

I find this very odd. It seems like it would be much more useful to start a song randomly and when played, pick a new song randomly. A setting in the options could be to pick the first song and continue with the next one (instead of randomness).

The way it is now, you manually have to pick a new song after a song is finished! This is very annoying if you for example your folders are full albums and you want to listen to a certain album, or even more, if you have folders consisting of hundreds of songs and randomly want to play songs from such a folder!

Please add this to the next version. I would appreciate some kind of response on this message.

Greets,
Ola