My plugin - gen_library.dll

[Ampian]

If I have a list of files longer than will fit in the right hand list window, when I sort by track number it only sorts the files in the window. The files that aren't seen are not sorted.

[Ampian]

If I have a list of unsorted files longer than will fit in the list view window, when I do a sort by track number only the files seen in the windows are sorted. The files not seen are not sorted.

[Joonas]

Originally posted by Ampian
If I have a list of files longer than will fit in the right hand list window, when I sort by track number it only sorts the files in the window. The files that aren't seen are not sorted.

That's not a bug. That's standard DL behaviour. And it only sort those files that it can, meaning those where tags have been read. If you want it to sort all files you have to read all tags or grab them from the ML database.

[Ampian]

Thanks, you're right ,of course. When files are first displayed in the Listview Window would it be possible to add an option to sort them in filename sequence as in Explorer?

[Joonas]

Originally posted by Ampian
Thanks, you're right ,of course. When files are first displayed in the Listview Window would it be possible to add an option to sort them in filename sequence as in Explorer?

You can sort by path?

[Pimousse38]

hello,

yes i can sort by path or other item

Joonas, could you update language file because there are terms which are not translated.
thank you.

good job

[Ampian]

Not by path just by filename.

[Lion12]

Originally posted by Ampian
Not by path just by filename.

Rightclick the header bar -> there is a path column.

[Ampian]

I'm talking about when the files are first displayed in list view. When you click on a folder in folder view the files are listed in List view without any order. I'm asking if there could be an option to to load those files in Filename order.

[Joonas]

Originally posted by Ampian
I'm talking about when the files are first displayed in list view. When you click on a folder in folder view the files are listed in List view without any order. I'm asking if there could be an option to to load those files in Filename order.

If you mean filename with no regards to folderpath...ehm no. I don't think that would be very good.

But if you mean filename with folderpath...then yes.
Basically I thought it already did that but I noticed that it seems to depend on how you have sorted the files in Explorer. I have my files sorted by Name so they already were sorted by filename but if I sorted by size the order was totally different also in DL.

[siebe83]

Well, it used to sort all files properly for me on path/filename on DL load (regardless of the order in explorer). In the latest release it doesn't. The files ARE sorted on name in explorer. I don't know, but I'm sure something changed in one of the latest releases.
(using 0.9.9.9.3b now)
On what it IS sorting, I don't know either. It isn't the last changed date or creation date, it seems to be random (although the order is the same each time I close/restart Winamp).

[Joonas]

Now it should sort by path again...at least it does for me (?)

[edit]
Don't ask me what it sorts by when you click # though...what should it really do when you click #? It used to be a unique # for each file but now it is just index from 1 to count - 1. So maybe nothing should happen when you click it? or just reverse the current list?
[/edit]

This version: v0.9.9.9.3c

[siebe83]

[edit]I mean, it sorts fine now [/edit]
I think it shouldn't do anything when you click #.
(heh, when I click it now, I get that weird order from the previous release again )

For some releases now, it says "Press escape to abort tag reading", while I don't have that option 'Automatically get ID-3 tags for files in listview' checked. So it just reads the visible files and then stops (as it should), but it keeps displaying "Press escape to abort tag reading".
When I press escape, it won't read any tags when I scroll down.
Or is this new expected behaviour?

The same goes for the action "read tags in this folder". After pressing escape to abort it, it won't read any tags when I scroll down/up (while it used to).
And something else: when I use "read tags in this folder" and I don't press escape and switch to another folder, and then back, it will continue to read all tags in that folder. Or also expected?

[Ampian]

Originally posted by siebe83
Well, it used to sort all files properly for me on path/filename on DL load (regardless of the order in explorer). In the latest release it doesn't. The files ARE sorted on name in explorer. I don't know, but I'm sure something changed in one of the latest releases.
(using 0.9.9.9.3b now)
On what it IS sorting, I don't know either. It isn't the last changed date or creation date, it seems to be random (although the order is the same each time I close/restart Winamp).

Thanks for saying what I couldn't get across. This is what I'm trying to say.

[Joonas]

* fixes to what siebe reported
* Also updates to the language file - attached
Have I forgot something?

This version: v0.9.9.9.4

[Ampian]

The files display in filename order. I'm a happy camper.

[Ampian]

In eng.lng:

137=Album och sånt

should be just

137=Album

?

[Joonas]

Originally posted by Ampian
In eng.lng:

137=Album och sånt

should be just

137=Album

?

Of course. "och sånt" means "and stuff" in Swedish. I use that file for testing sometimes and apparently I forgot to fix that. (Among other things :P)

[siebe83]

Just a reminder:
"No files to display that match ..." still broken.
(or did you just remove that and is it now just "No files to display that match."?)

Missing line in language file:
"No files available" (displayed at the bottom when a folder is empty or no files match a search)

---------

When DL closes, it asks me everytime to save a certain playlist while I didn't edit it... It's just a .m3u file in a subfolder of a root. I don't even have "Display in treeview...playlist files as nodes" checked...
The contents of the .m3u file if that helps:

#EXTM3U
#EXTINF:302,Ornette Coleman - Lonely Woman
01 - Lonely Woman.mpc
#EXTINF:262,Ornette Coleman - Eventually
02 - Eventually.mpc
#EXTINF:544,Ornette Coleman - Peace
03 - Peace.mpc
#EXTINF:412,Ornette Coleman - Focus On Sanity
04 - Focus On Sanity.mpc
#EXTINF:408,Ornette Coleman - Congeniality
05 - Congeniality.mpc
#EXTINF:363,Ornette Coleman - Chronology
06 - Chronology.mpc

After I click 'Yes' to save the playlist, and I open the .m3u file in Notepad, it has gone empty: all contents erased...
Mmh, wait. I just added .mpc to the filetypes to be displayed, and now it doesn't ask to save it anymore...
So, does DL try to delete any entries in a playlist with an extension it doesn't know? Even when the playlist isn't displayed as a root/node? (the .m3u file just happens to be in a rooted folder, I don't have that option to display them as nodes checked)


On a sidenote: it feels as if loading time has increased (i.e. the amount of time "Loading..." is displayed), especially for large folders. Maybe it's not true, just wondering wether you noticed it. Same goes for loading time in Search mode (when entering a search). Feels as if it's slower, but I'm not sure...

[Ampian]

When in Treeview focused on an empty folder Listview says:
132=No files to display that match.

Would this be more to the point?
103=No files to display.

[Joonas]

Originally posted by siebe83
Just a reminder:
"No files to display that match ..." still broken.
(or did you just remove that and is it now just "No files to display that match."?)

Missing line in language file:
"No files available" (displayed at the bottom when a folder is empty or no files match a search)

How is it broken??

When DL closes, it asks me everytime to save a certain playlist while I didn't edit it... It's just a .m3u file in a subfolder of a root. I don't even have "Display in treeview...playlist files as nodes" checked...
The contents of the .m3u file if that helps:

#EXTM3U
#EXTINF:302,Ornette Coleman - Lonely Woman
01 - Lonely Woman.mpc
#EXTINF:262,Ornette Coleman - Eventually
02 - Eventually.mpc
#EXTINF:544,Ornette Coleman - Peace
03 - Peace.mpc
#EXTINF:412,Ornette Coleman - Focus On Sanity
04 - Focus On Sanity.mpc
#EXTINF:408,Ornette Coleman - Congeniality
05 - Congeniality.mpc
#EXTINF:363,Ornette Coleman - Chronology
06 - Chronology.mpc

After I click 'Yes' to save the playlist, and I open the .m3u file in Notepad, it has gone empty: all contents erased...
Mmh, wait. I just added .mpc to the filetypes to be displayed, and now it doesn't ask to save it anymore...
So, does DL try to delete any entries in a playlist with an extension it doesn't know? Even when the playlist isn't displayed as a root/node? (the .m3u file just happens to be in a rooted folder, I don't have that option to display them as nodes checked)

Actually that was something I never considered...but yes the playlist will mark the file as failed if there is a file in it that doesn't match the file types...hmm. I wonder how to solve that...

On a sidenote: it feels as if loading time has increased (i.e. the amount of time "Loading..." is displayed), especially for large folders. Maybe it's not true, just wondering wether you noticed it. Same goes for loading time in Search mode (when entering a search). Feels as if it's slower, but I'm not sure... [/B]

There can sometimes be a slight delay that wasn't there before I guess...it's because everything is run in the same thread now...I am unsure if I like it. Maybe I should go back to the old style? But that would mean you can't do changes as freely as you are now since the two threads could happen to attempt to access the same memory...

[siebe83]

Originally posted by Joonas
How is it broken??

When you searched for eg. htrjkr it used to say "No files to display that match 'htrjkr'".
It now just says "No files to display that match".

Actually it doesn't matter, since the search string is already in the search bar.
I do agree with Ampian: when a folder is really empty, it would be best if it said 'No files to display' (103).
If the search doesn't return any results, it would say 'No files to display that match.', so the distinction will be there.
(iirc, you built in the 'no files to display that match 'htrjkr'' so users wouldn't be misleaded thinking the folder didn't contain any files at all; Ampian's suggestion would solve that)
Am I still making sense?

There can sometimes be a slight delay that wasn't there before I guess...it's because everything is run in the same thread now...I am unsure if I like it. Maybe I should go back to the old style? But that would mean you can't do changes as freely as you are now since the two threads could happen to attempt to access the same memory...

I don't mind it that much. Just wondering wether it was my imagination or wether there was indeed a slight delay. I prefer it the way it is now, I like to do changes freely
(it used to collapse roots and stuff, I hated that )

[Joonas]

Originally posted by siebe83
[B]When you searched for eg. htrjkr it used to say "No files to display that match 'htrjkr'".
It now just says "No files to display that match".

Actually it doesn't matter, since the search string is already in the search bar.

Are you sure you're not using some language file here...I think the eng.lng might miss something..

132 should read
No files to display that match '%s' in selected folder.

Anyway...if there is indeed an empty folder it now reads
Empty folder (line 171)

So to sum it up
132=No files to display that match '%s' in selected folder.
171=Empty folder
172=No files available [00:00]

This version: v0.9.9.9.4b

[siebe83]

Ok, I see. But it wasn't working when no language file was selected either, I believe...? Now it does

Heh, I assume you meant 271 and 272?
Those two don't work, btw...
It still says "No files to display that match '' in selected folder." (or the translation of that) for empty folders, and it still says 'No files available' (not translated) at the bottom (I tried adding line 271&272).

[edit]
In "No files to display that match '%s' in selected folder." I would leave out 'in selected folder'. Looks a bit weird in search mode.

[Joonas]

Originally posted by siebe83
Heh, I assume you meant 271 and 272?
Those two don't work, btw...
It still says "No files to display that match '' in selected folder." (or the translation of that) for empty folders, and it still says 'No files available' (not translated) at the bottom (I tried adding line 271&272).

Yeah..doh! 271 and 272 yes.
Seems I forgot to upload. It wasn't ...4b version on the ftp.

Should work now.

[edit]
In "No files to display that match '%s' in selected folder." I would leave out 'in selected folder'. Looks a bit weird in search mode. [/B]

Done.

Now 4b should be available.

[siebe83]

Updated language file dutch attached
[edit]See next post [/edit]

Sorry to bother you with separate issues all the time: maybe it's better to post them all at once, dunno. Just posting when I notice something...

- When you add a playlist root and create a file yourself (i.e. box pops up 'file does not exist; you want to create it?') and you select the root afterwards, it says 'File or folder is unavailable'. You can't drag any files to it, so actually it's useless...
(the only way is to drag a file from explorer to the listview when that playlist root is selected. Changes won't be visible until you restart Winamp (playlist .. has been changes, save it?). Only after the restart the dragged file from explorer is visible in the playlist and the .m3u is actually created)
So maybe force DL to actually create that .m3u file when it asks you and you say 'yes'?

- Dragging a file inside the listview of a playlist root (i.e. copy a playlist entry inside the same playlist) will not result in the extra added file (i.e. extra file is not displayed) until you select another root and reselect the folder root. Same goes for dragging files from explorer to the listview of a playlist root.
I.e. listview of playlist root not properly refreshed after dragging...

- Moving files inside playlist by Alt+dragging isn't remembered when you select another root and then reselect the playlist root. Maybe related to the forced ordering you implemented?

[siebe83]

Pff, updated language file for dutch attached...
(rename to .lng)


[edit]
Just a small request:
Would it be possible that when you select a .lng file in DL prefs, it starts browsing in the current Winamp folder?
It now starts in My Documents for me everytime. I think the Winamp folder is more logical to store a .lng file. (or is that just me?)

[Joonas]

this is not my day...my post didn't get through..

anyway, I've tried to fix what you posted before.
I'll put the lng-file browsedialog to the Winamp directory next time...

This version: v0.9.9.9.4c

[siebe83]

- Adding playlist root while creating new .m3u file > fixed
- Not refreshing when dragging to playlist root listview from within listview or explorer > fixed
- Order in playlists still forced? (i.e. alt+dragging not working)

-----------

For an empty playlist root, it now says "Empty folder"
Only when it's already empty on Winamp startup btw (or when creating a new empty playlist root).
It says "No files to display that match ''" when you make it empty yourself by removing all files from playlist).

--------

I did some changes to a root playlist: I added some files to it. Then I refreshed a folder root and all changes to the playlist were gone!
Everytime a folder root is refreshed (forced or automatically) the playlist is reset to how it was the last time it was saved: all changes are lost.
[edit]Note: I'm not talking about tree playlists here... Will test those later.[/edit]

[Ampian]

My directory structure is:

"C:\Music\Genre\Artist\Album" where "Album" contains the tracks and the directories above it are empty.

I have in Display in listview "...files residing in subfolers" unchecked.

When I focus on the empty directories in treeview(C:\Music\Genre\Artist\) I get "No Files to display that match '' in selected folder.". The '' is blank and makes no sense. This is where I think it should display "No files to display." or something similar.

[Joonas]

All fixed?

This version: v0.9.9.9.4d

[edit]

Originally posted by Ampian
My directory structure is:

"C:\Music\Genre\Artist\Album" where "Album" contains the tracks and the directories above it are empty.

I have in Display in listview "...files residing in subfolers" unchecked.

When I focus on the empty directories in treeview(C:\Music\Genre\Artist\) I get "No Files to display that match '' in selected folder.". The '' is blank and makes no sense. This is where I think it should display "No files to display." or something similar.

[/quote]

This is not fixed though...and I am not so sure it will either. A lot of messing for little gain But who knows?

[Ampian]

Now it displays "No files that match ''". Still get the '' that is blank. I think it should display "Empty folder."

[Ampian]

Sorry Joonas, i didn't read the post all the way through. If it can't be fixed easily it's no big thing.

[Joonas]

Hmm, sometimes you're inspired! Does this version do what you want?

This version: v0.9.9.9.4d

[Ampian]

Yes! That's it! Thank you Joonas!

[jojo 544]

When a parent root contains no files, but has root children that are containing files, DL still displays 'empty folder/playlist', instead of 'no files that match ...' when a string is given; even when display files residing in subfolders is checked in preffereces.
I mean DL doesn't seem to see the files in root's children and so sais folder is empty.
When no string is given however, all files from children appear (as they should like set in pref's).

edit: This only happens when no files that match the given string are found ofcourse

[Joonas]

Originally posted by jojo 544
When a parent root contains no files, but has root children that are containing files, DL still displays 'empty folder/playlist', instead of 'no files that match ...' when a string is given; even when display files residing in subfolders is checked in preffereces.
I mean DL doesn't seem to see the files in root's children and so sais folder is empty.
When no string is given however, all files from children appear (as they should like set in pref's).

edit: This only happens when no files that match the given string are found ofcourse

I think I've fixed this now

This version: v0.9.9.9.4f

[jojo 544]

I'm afraid some people might delete folders thinking that they're empty, so maybe change the 'empty folder/playlist'
to 'no files found of selected filetypes', or 'no recognized files found' or something like that. And use 'empty folder/playlist' when folder is realy empty?

[Joonas]

I've made some changes you all can try.

Playlists now grabs all contents that are valid, doesn't matter on filetype. That means that siebe's bug shouldn't cause that much problem anymore with a file that isn't among the filetypes. It doesn't show them though if they aren't in there...

Also added a line to fit with jojo's suggestion.
273=No files found of selected filetypes.

Test and see what you think.

This version: v0.9.9.9.5

[siebe83]

Originally posted by Joonas
Playlists now grabs all contents that are valid, doesn't matter on filetype. That means that siebe's bug shouldn't cause that much problem anymore with a file that isn't among the filetypes. It doesn't show them though if they aren't in there...

Also added a line to fit with jojo's suggestion.
273=No files found of selected filetypes.

Nice! Works for playlists as well

----------

Mmh, about root playlist not saving when a folder root is refreshed: it now asks wether to save it or not when you try to refresh a folder root. If you click 'Yes', the playlist is properly saved, no probs. If you click 'No' the playlist will not be saved (duh) but the changes you did to that playlist are still visible in the playlist root. When you then close Winamp, it won't save the playlist (while it looked as if the playlist had been changed).
So I suggest it would either
a) re-read the .m3u file when you click 'No' and make the playlist root revert to it's old state
or b) ask again to save the .m3u file on Winamp exit
a makes more sense than b, imo...
[edit]Or DON'T try to save the playlist, but just remember the changes and save them on Winamp exit, of course...[/edit]

Same goes for when right-clicking playlist root > Save playlist
When you click 'No', playlist won't be saved, but it doesn't revert back to original state (so it looks as if changes were made, but they won't be saved on exit...).
In this case I'd say just remove the whole confirmation box: if you tell it to save the playlist, you obviously want to save the playlist...

----------

Alt+dragging in playlists is remembered again
Funny you can also Alt+drag in folders, btw
(I don't mind that...)