My plugin - gen_library.dll

[Joonas]

Originally posted by siebe83
Mmh, about root playlist not saving when a folder root is refreshed: it now asks wether to save it or not when you try to refresh a folder root. If you click 'Yes', the playlist is properly saved, no probs. If you click 'No' the playlist will not be saved (duh) but the changes you did to that playlist are still visible in the playlist root. When you then close Winamp, it won't save the playlist (while it looked as if the playlist had been changed).
So I suggest it would either
a) re-read the .m3u file when you click 'No' and make the playlist root revert to it's old state
or b) ask again to save the .m3u file on Winamp exit
a makes more sense than b, imo...
[edit]Or DON'T try to save the playlist, but just remember the changes and save them on Winamp exit, of course...[/edit]
Same goes for when right-clicking playlist root > Save playlist
When you click 'No', playlist won't be saved, but it doesn't revert back to original state (so it looks as if changes were made, but they won't be saved on exit...).
In this case I'd say just remove the whole confirmation box: if you tell it to save the playlist, you obviously want to save the playlist...

I will probably change this to a)

Alt+dragging in playlists is remembered again
Funny you can also Alt+drag in folders, btw
(I don't mind that...) [/B]

You can Alt+Drag in roots since it was a setup to a rename function...you should be able to set the order and then rename with the index in the name...I dropped it because of lack of time though...it doesn't hurt that you can move them I guess. they will revert if you switch folder though...

I am building an experimental thing now you can test in latest...it is a DL-cache which saves tagged items if you need to refresh. If you don't use the ML cache (but it works with it too) it saves you a lot of time just because you changed an id3-tag or something and the whole library is re-scanned and you loose all read tags...now it cache it before dropping it and only free the tags for those file not present anymore...ehm...do anyone follow?

This version: v0.9.9.9.5b

[siebe83]

Mmmh, nice
Some questions:
- It doesn't work for playlists. Intended?
- If you update a tag of a file in an external tagger, it won't re-read the tag? Would it be possible to look at the last changed date, or would that be too slow?
- Why did you change the option "Read ID3-tags" to "Read ID3-tags if necessary"? (or was that changed earlier already?)
I mean, when is reading ID3-tags not necessary?
[edit]Or do you mean it isn't necessary when it's in DL cache? Dunno, a bit confusing?

I do like it btw, very fast

[Joonas]

Originally posted by siebe83
[B]Mmmh, nice
Some questions:
- It doesn't work for playlists. Intended?

Actually no, but it made sense as I tried to implement it. Playlist are plagued by the fact that there can be duplicates and it is a pain to know which entry you actually want to delete...can't make a promise I will implement this for playlists. Playlists are usually short though (or?) so it shouldn't be that big of a problem if the tags are lost for them.

- If you update a tag of a file in an external tagger, it won't re-read the tag? Would it be possible to look at the last changed date, or would that be too slow?

I've tried to implement that now...see if it works.

- Why did you change the option "Read ID3-tags" to "Read ID3-tags if necessary"? (or was that changed earlier already?)
I mean, when is reading ID3-tags not necessary?
[edit]Or do you mean it isn't necessary when it's in DL cache? Dunno, a bit confusing?

It is "old"...It is meant to note that if the tags are read from file only if necessary...meaning that if they are found in the ML-cache they don't need to be read from file.

This version: v0.9.9.9.5c

[Dick65]

Any chance for an option to let DL scan all files in roots whatever the view?
Right now only those files are being scanned that are in current listview. But I'd like DL to scan all files even if I'm in browse mode or in search mode with a search string active.
This way I'm sure that whatever I've been doing, after couple minutes all 9.000 files' tags are read.

Get my point?

[Dick65]

What was the scoop on a genre column? I know it was a subject on one of these 50 pages - but where

[Joonas]

Originally posted by Dick65
Any chance for an option to let DL scan all files in roots whatever the view?
Right now only those files are being scanned that are in current listview. But I'd like DL to scan all files even if I'm in browse mode or in search mode with a search string active.
This way I'm sure that whatever I've been doing, after couple minutes all 9.000 files' tags are read.

Get my point?

It would be good, I agree. Unfortunately DL wasn't built for this originally so I don't know if it is possible...best advice I can give is switch to Search mode and let it read all tags before doing anything else...

What was the scoop on a genre column? I know it was a subject on one of these 50 pages - but where

I don't know...I've basically dropped all tags I find utterly useless :P But genre can be useful for some I guess...have to rebuild some code to allow more columns though...

[siebe83]

Originally posted by Joonas
Actually no, but it made sense as I tried to implement it. Playlist are plagued by the fact that there can be duplicates and it is a pain to know which entry you actually want to delete...can't make a promise I will implement this for playlists. Playlists are usually short though (or?) so it shouldn't be that big of a problem if the tags are lost for them.

No prob.

I've tried to implement that now...see if it works.

Heh, for some reason the tagger I use doesn't update the Last changed date :/
Forget about it...

It is "old"...It is meant to note that if the tags are read from file only if necessary...meaning that if they are found in the ML-cache they don't need to be read from file.

Duh... I see

[Dick65]

siebe83
Heh, for some reason the tagger I use doesn't update the Last changed date.[/B]

mp3Tag has an option whether to update this date or not.

[Dick65]

Originally posted by Joonas
I've basically dropped all tags I find utterly useless :P But genre can be useful for some I guess ... have to rebuild some code to allow more columns though...

I could copy all genre contents to the comment-field. But I rather don't if there will be a genre column sooner or later.

[siebe83]

Originally posted by Dick65
mp3Tag has an option whether to update this date or not.

I don't use mp3tag myself (I use mp3-tagstudio), but thanks anyway

I now just opened the file in Winamp and edited the tag from there (WA does update the last changed date), and DL refreshed correctly (including the changed tag)

[jojo 544]

Originally posted by Joonas
It would be good, I agree. Unfortunately DL wasn't built for this originally so I don't know if it is possible...best advice I can give is switch to Search mode and let it read all tags before doing anything else...

If YOU don't know if it's possible, I sure don't eather But it sure would be good, very good!
I was going to ask the same thing but dick65 was faster
I mean like when finnished scanning the current view, keep scanning the rest in the background.
The workaround you gave (switch to search mode before...)
i'm using everytime i open winamp for some time now.

The cache you implemented is a very good thing, it speeds up browsing a lot. Great improvement.
Only after a close of winamp the whole proces of making cache has to be re-done, so maybe save the files that were scanned to cache, so on the next start of winamp they are already there and only the last changed dates have to be checked. You did implement that check of last change date yes? (never trust saved cache of DL to be up to date )

[siebe83]

Originally posted by jojo 544
The cache you implemented is a very good thing, it speeds up browsing a lot. Great improvement.
Only after a close of winamp the whole proces of making cache has to be re-done, so maybe save the files that were scanned to cache, so on the next start of winamp they are already there and only the last changed dates have to be checked. You did implement that check of last change date yes? (never trust saved cache of DL to be up to date )

I guess that'd be better an option. Last change date isn't that reliable... I think I prefer to start 'clean'

[Joonas]

Originally posted by jojo 544
The cache you implemented is a very good thing, it speeds up browsing a lot. Great improvement.
Only after a close of winamp the whole proces of making cache has to be re-done, so maybe save the files that were scanned to cache, so on the next start of winamp they are already there and only the last changed dates have to be checked. You did implement that check of last change date yes? (never trust saved cache of DL to be up to date ) [/B]

Well the fastest way that can be achieved is by using the ML cache. I tried building a DL-specific cache but it just won't become as fast.

[mrym]

Originally posted by mrym
about the ml cache thing, for me 0.9.9.8m works fine (without "length", "track", "year" field, though)
but latest version doesn't seem to work.

i'm sorry for this post, ml cache is working fine.
I was setting media library referring to
"like the wind".

maybe i'm the only one foolish guy though, if your dl doesn't load ml's cache,
make sure, uncheck "Do not load the Media Library database at Winamp start-up" in the ml preferences.

about the lng file
line 268=Press Escape to abort tag reading. seems not working.

other than that really stable for me so far.

[Joonas]

Originally posted by mrym
about the lng file
line 268=Press Escape to abort tag reading. seems not working.

Seems not to be working in what way?

Added some language lines here...
274=Update Nullsoft database
275=%i file(s) were stored or updated in the Nullsoft Database.
276=The Nullsoft Media Library plugin must be installed.

Also you can now add files directly from DL to the ML database without using ML! Right-click a folder and select Update Nullsoft database. It will update or add if the file is missing with DL contents.

This version: v0.9.9.9.6

[jojo 544]

Originally posted by Joonas
Well the fastest way that can be achieved is by using the ML cache. I tried building a DL-specific cache but it just won't become as fast.

Could it maybe be possible to extend the ML cache instead?(with those files that only used by DL)
I mean i have different files in both ML and DL so using ML cache works not for all files.
Or would that mess up ML?

edit: i just missed your previous post, maybe that's just what i ment, haven't tried it yet. Is it?

[Joonas]

Originally posted by jojo 544
Could it maybe be possible to extend the ML cache instead?(with those files that only used by DL)
I mean i have different files in both ML and DL so using ML cache works not for all files.
Or would that mess up ML?

edit: i just missed your previous post, maybe that's just what i ment, haven't tried it yet. Is it?

Well the files you add from DL will be visible in ML. But they're not part of a watchfolder or anything...dunno what you meant really :/

[siebe83]

Ok, my Media Library was totally empty when I started. I read all files in my music folder in DL, then "Update Nullsoft database". All files were added to ML database, but for some reason they only show up in the Local Media view. When I select the Audio view, no files at all!
They are in the ML, but in a very weird way

I don't like it puts '-' in the album or comment field when there wasn't an album or comment tag. This happens only when the file was not in ML before.
Also, it puts '0000' when year was empty. This does also happen when the file was in ML before.

[jojo 544]

Just tested and it seems to be like it is what i ment
(only i made a mistake by adding to nulsoft before the root had been completely scanned the first time, maybe some notification to say make sure tags are all scanned before adding to ....?)

Before the scanning of files begins there is a short pauze.

Very nice Joonas, DL has never been this fast.

[jojo 544]

Originally posted by siebe83
for some reason they only show up in the Local Media view.

I would prefer that files added by DL don't show up in ML at all and be only used by DL

edit: i'm very curious where this all is going to...
it seems like DL development has come into a very intressting fase, but i have to go now. I'll check up on things later wen i get back. Keep up the good work !

[mrym]

Originally posted by Joonas
Seems not to be working in what way?

checked Automatically get ID-3 tags for files in listview
usually, while dl is reading id3 tags, displays
"100 file(s) scanned out of 1000 available [10:00:00+] Press Escape to abort tag reading."
bottom of it's window.
now, "Press Escape to abort tag reading" is invisible.

is this relate to siebe's post?

[siebe83]

Yep, reproducable...
"Press Escape to abort tag reading" is displayed when you use the 'Read all tags in this folder' action, but not when that option is checked to do it automatically...

Btw,
'Nullsoft database' is not very clear, I think. Everyone refers to it as 'Media Library database' or 'ML database'. Half of the Winamp users don't even know what Nullsoft is. (well maybe I'm exaggerating a bit, but well...)

[Thunder Pussy]

You can drag & move from playlists now. I like it.

[Joonas]

* escape text should be viewed properly
* ML-cache removed -> new DL-cache implemented instead

This cache only works for folders though. Not playlists so far.

Language line changed:
269=Use cache for tag-data
270=Empty folder/playlist.
271=No files available [00:00]
272=No files found of selected filetypes.

the ones below are removed. Not used anymore.

This version: v0.9.9.9.7

[jojo 544]

The new cache 09997 Works Fine here !

pro:
- users that don't have ML can also benefit cache
- files added to cache by DL don't show in ML anymore
- the short pauze before start tags reading is gone
- DL stands now completely on it's own
- (almost) no need to have ML anymore (some more collumns like bitrate f.e.)

contra:

- The DL cache isn't availeble rightaway at startup, the ML cache was.

There are a lot more pro's, but the contra is a heavy one
iI think there has got to be a way (or option) to save the cached data. (also would eliminate the requested feature to keep scanning in background, no mather what view)
I think the 2nd option (use cache) is a bit useless, why not make it default behaviour. I mean who wants to turn that off?
Maybe instead make it like it was before: 'trust saved cache tags to be up to date' or something. For people with many files, that way there would be only once a long scanning, at First instal of DL or by adding roots.

When i came home last night and saw no new post, i already suspected you were working on something 'Big'
Nice Job Joonas,

[Joonas]

Originally posted by jojo 544
- The DL cache isn't availeble rightaway at startup, the ML cache was.

What do you mean by this? The DL cache has to be read the first time but then it is saved (if you have set it in preferences...) and doesn't have to be re-read, no?
Even ML has to read the tags ONCE

iI think there has got to be a way (or option) to save the cached data.

That's the point...it doesn't save for you? Something's broken

[jojo 544]

Originally posted by Joonas
I tried building a DL-specific cache but it just won't become as fast.

It is now

it doesn't save for you? Something's broken

If it is ment to be saved, i think so. Getting that fixed would leave only 'pro's' up there

Another thingy: when switching to at root with f.e. only m3u's, at the bottom it sais 45 files scanned out of 45, (like it was in the pervious selected root), i.o.w. the line doesn't update.

[Joonas]

Originally posted by jojo 544
If it is ment to be saved, i think so.

Weird...it saves properly for me. It should create a file in a Plugins/dl folder...saves all tags for the files which tags has been read..

[jojo 544]

Ok, it does now
Don't know why it didn't first time, my guesse is i closed and re-opened winamp to fast?

edit: in that plugins/DL folder i see now 10 files.
Maybe if DL is gonna use that folder in the future also put the .lng files in there by default?

[mrym]

when i add root folder to latast version(0997) , winamp crashes.
form tree view, preferences menu, same result.

winamp.exe Application Error - The instruction at "0x014dbad5" referenced memory at
"0x00000000". The memory could not be "read".

clean installed 5.08d with in_mp3.dll, out_ds.dll, gen_library.dll(no language file) only.
running on win2k sp4.

[jojo 544]

I have now 10 roots in DL, is that why there are 10 files in plugins/DL folder?
I let DL scan all tags in search mode, maybe the tags should have been scanned root by root in browse mode. Could that be the reason it didn't save at first?
Just guessing ...

[Joonas]

Originally posted by jojo 544
I have now 10 roots in DL, is that why there are 10 files in plugins/DL folder?

One cache file for each root.

I let DL scan all tags in search mode, maybe the tags should have been scanned root by root in browse mode. Could that be the reason it didn't save at first?
Just guessing ...

Shouldn't matter...cache is built-into the node objects which are there even if not visible in Search mode...don't know why it didn't save for you...

* Fixed crash bug

This version: v0.9.9.9.7b

[billyvnilly]

i was just gonna report some bugs, but i dl b and they were not reproducable. i was getting a crash everytime i tried to add a root to the treeview.

however this was:
*change and delete in options do not work. i get a C++ Runtime Library crash. "abnormal program termination"

[mrym]

no more crashes:up

about the cache file, when i delete root folder, dl don't delete cache file automatically.
if possible, please add automatically delete cache future or make cache files name same as root. for example "dl-My Music.tmp" like such.

Originally posted by jojo 544
Maybe if DL is gonna use that folder in the future also put the .lng files in there by default?

i totally agree with you.

[Thunder Pussy]

Hm, caching doesn't seem to be working here. When I close & reopen Winamp the roots scanning starts over from scratch. I have 7 roots. After closing & reopening Winamp twice there are now 21 temp files in the folder. There weren't any changes made to the roots.

I guess ml caching has been done away with? The option's no longer in preferences.

With the most recent beta the right-click menu doesn't pop up in playlists or in folder views, only in the tree column. Keyboard shortcuts like alt-3 & delete still work ok.

Best regards,

[jojo 544]

Originally posted by ¿¢?
When I close & reopen Winamp the roots scanning starts over from scratch.

Happened to me to. I had the impression like there is a delay in tag reading and saving.
I mean when al tags were read, maybe like 60% were saved. so on next start of winamp the reading started not from scratch but from that 60%. After a few time letting DL read all tags, doing some browsing, and given some time, it seems to work now.

[DJ Egg]

Yeah, the 'read from ml database' option was awesome, and superfast too, heh.
Also, I'm getting random system beeps now during the initial roots scan, possibly occurring when trying to read metadata/tags from formats without any (wav, mid, mod, vid)?

[Joonas]

Originally posted by DJ Egg
Yeah, the 'read from ml database' option was awesome, and superfast too, heh.

Yeah but it sucked for ppl using ML for other things...apparently

Also, I'm getting random system beeps now during the initial roots scan, possibly occurring when trying to read metadata/tags from formats without any (wav, mid, mod, vid)?

Oops, fixed!

quote:
--------------------------------------------------------------------------------
Originally posted by ¿¢?
When I close & reopen Winamp the roots scanning starts over from scratch.
--------------------------------------------------------------------------------


Happened to me to. I had the impression like there is a delay in tag reading and saving.
I mean when al tags were read, maybe like 60% were saved. so on next start of winamp the reading started not from scratch but from that 60%. After a few time letting DL read all tags, doing some browsing, and given some time, it seems to work now.

That's not good...doesn't happen for me though..

With the most recent beta the right-click menu doesn't pop up in playlists or in folder views, only in the tree column. Keyboard shortcuts like alt-3 & delete still work ok.

Fixed!

*change and delete in options do not work. i get a C++ Runtime Library crash. "abnormal program termination"

Fixed!

This version: v0.9.9.9.7c

* Cache is now deleted when read and only re-written back if the root is still around at end...

I suggest you delete all cache files before using this release, though it shouldn't cause any crashes if you don't. The files should just be ignored.

Post more if the problems remain and tell me some more what kind of files and settings the folders have.

Thanks!

/Joonas

[jojo 544]

There still is a problem with the saving of cache. I noticed that not all roots were saved, sometimes only 3, sometimes 7, or another random amount (i have 10). I can't find why some roots get skipped. I even saw that when i opened one of the temp files in notepad, links to another drive were in there, wich is not in DL at al (possibly came in there from a playlist refering to files on that drive?).
On previous version i could close, re-open and re-read a few times until all was properly saved, but that doesn't work anymore coz everytime they get deleted. Maybe there is another way to get rid of info when a root gets deleted? How does ML do it?
Also the scanning status line at the bottom still doesn't (always) update when a root with only m3u or wave's gets selected.

[Joonas]

Originally posted by jojo 544
There still is a problem with the saving of cache. I noticed that not all roots were saved, sometimes only 3, sometimes 7, or another random amount (i have 10).

Is that 10 folder roots? Playlists are not cached.

I can't find why some roots get skipped. I even saw that when i opened one of the temp files in notepad, links to another drive were in there, wich is not in DL at al (possibly came in there from a playlist refering to files on that drive?).

Can just be random crap that Windows put in there since more is usually written to the cache than is in memory...(static sized cache vs dynamically sized memory)

On previous version i could close, re-open and re-read a few times until all was properly saved, but that doesn't work anymore coz everytime they get deleted. Maybe there is another way to get rid of info when a root gets deleted? How does ML do it?

Well since DL should read all cache into memory and dump it back on quit it shouldn't matter...

Also the scanning status line at the bottom still doesn't (always) update when a root with only m3u or wave's gets selected. [/B]

That's true. Will look into that.