Old 19th January 2006, 02:06   #1
DrO
 
Join Date: Sep 2003
Posts: 27,873
ML Bookmark Categoriser (v1.2 15-06-2010)

ML Bookmark Categoriser v0.5

The aim of this plugin is to allow your bookmark files to be categorised so you can manage them better compared to having a large list of them to try to contend with.



This will not affect your current bookmark file but instead it will create a winamp.bmc file which stores the relevant category information assigned to your bookmarks (since adding it to winamp.bm would currently confuse winamp and break it's handling of the file).


This should be useable in it's initial state (v0.5) though there are a few minor 'issues' that need to be remembered when using it.
The first is that the edit and remove actions for the sub category pages are disabled so you'll need to edit you bookmarks for the time being on the original bookmark page.

The second is that if you're using ml_icons then the bookmark sub category pages take on the 'unknown' type icon (either ml_icons needs to be fixed or i need to capture things slightly better )

The third is that you can't change the category of an already categorised bookmark from a sub category page (only from the main bookmark page).


There's the above issues to be dealt with and implementing a few other aspects with the auto-category detection from the file being bookmarked to be done but it's viable to use now so here it is

get v0.5

Current version: v1.1.2

-daz
DrO is offline  
Old 19th January 2006, 03:44   #2
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Had this a few times using the Edit box.

AppName: winamp.exe | AppVer: 5.1.2.275 | ModName: user32.dll | ModVer: 5.1.2600.2622 | Offset: 000567d9

<backspace> and <delete> are not working but it's stopped crashing now.

Not very usable as it stands with no reordering or deletes but should be good when you have it finished.

pappadoc is going to be delighted

UJ
ujay is offline  
Old 19th January 2006, 05:00   #3
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
this may be something minor, it may not be, but the focus is on cancel so hitting enter cancels my category.

ctkatz8086 is offline  
Old 19th January 2006, 05:45   #4
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
Quote:
Originally posted by ujay

pappadoc is going to be delighted
thats exactly what i was thinking


but im even more interested in the bottom left corner of your screenshot.
billyvnilly is offline  
Old 19th January 2006, 10:32   #5
DrO
 
Join Date: Sep 2003
Posts: 27,873
ctkatz8086: fixed, i'd managed somehow to set the ok and cancel buttons to both be the default button and due to the order they were created as the dialog is loaded, it made the cancel one take precedence. i've fixed this now

ujay: i've fixed the crash issue (trying to send a message for setting the selection of the text to the wrong window is not a good idea it seems) and i think the delete/backspace will work again as well (though i think i need to look at the autocomplete code a bit more for it since i'm not 100% happy with it).

yeah, i hope he will be though Twilightseer was a bit upset it wasn't named One for Seer but as i said, he got in too late on the request for it

and Seer's just confirmed the user32 crash is gone, yay

billyvnilly: if i can get the horizontal sizing grip code sorted out and also some overrides with the painting being done then that will be part of the next major explorerpl release

-daz
DrO is offline  
Old 19th January 2006, 13:29   #6
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Almost missed the best feature, you've got the left hand pane to remember if it's expanded/collapsed

This is becoming essential as the scope of the ML increases.

[edit] Looks like the Prefs > .... > Config. settings don't stick, has that been impemented yet.
Bookmarking from 'Local Media' breaks something and no further selections can be made.

[edit2] Just closed Winamp after doing the above and get this

AppName: winamp.exe | AppVer: 5.1.2.275 | ModName: unknown |
ModVer: 0.0.0.0 | Offset: 6660cb49

UJ

Last edited by ujay; 19th January 2006 at 13:58.
ujay is offline  
Old 19th January 2006, 14:12   #7
DrO
 
Join Date: Sep 2003
Posts: 27,873
ML Bookmark Categoriser v0.6
  • Fixed duplicate default button state on the edit bookmark dialog (pressing 'return/enter' will behave as expected now)
  • Slight code tweaks and adjustments to make it a bit easier to manage
  • Fixed a crash bug when opening the edit bookmark dialog (was using the wrong window handle for some reason)
  • Implemented an auto-categoriser based on the files genre (with option to query if no genre could be obtained)
  • Expanded the above to allow for querying album, artist, title, year and comment
get v0.6

ujay: try 0.6 (i've not had any issues trying to do what you've said you were doing though i've slightly altered the dialog's handling before i tried it). and the settings should have been saving in 0.5 (and have been since my internal 0.1 so i'm not sure why it's not working quite right for you)

-daz
DrO is offline  
Old 19th January 2006, 14:20   #8
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Faster than a speeding bullet .... I still can't believe the pace you get things done.

I'll d/l 0.6 and get back when I have time.

UJ
ujay is offline  
Old 19th January 2006, 14:23   #9
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
dro, i am having trouble with only one bookmark. using the plugins from a fresh install, my bookmark for kvet (mms://a1065.l1822742457.c18227.g.lm.akamaistream.net/D/1065/18227/v0001/reflector:42457) crashes winamp. any ideas why?

ctkatz8086 is offline  
Old 19th January 2006, 14:24   #10
DrO
 
Join Date: Sep 2003
Posts: 27,873
heh, i've got the day off work and i've been messing around with this from a few things seer has been saying. the first 2 bugs were fixed in a few minutes of looking for them i then got distracted by a film and tv otherwise it'd have been out before lunch

-daz
DrO is offline  
Old 19th January 2006, 14:25   #11
DrO
 
Join Date: Sep 2003
Posts: 27,873
ctkatz8086: is that with the new 0.6 build?

-daz
DrO is offline  
Old 19th January 2006, 14:26   #12
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
yes. if it matters, it did that with the last build as well.

ctkatz8086 is offline  
Old 19th January 2006, 14:31   #13
DrO
 
Join Date: Sep 2003
Posts: 27,873
i've just tried that by adding as a bookmark, editing it's category, doing an enqueue and a play action on it. manually adding to the playlist editor and starting to play it from there as well and i had no crashes. which winamp version are you using? also what's the crash log you get when it happens (i have a feeling it's probably an in_wm issue)

-daz
DrO is offline  
Old 19th January 2006, 14:38   #14
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
i had some issues with the current in_wm so i have still used the old one from a while back.

after using the in_wm from the default 5.12 install, it still crashes. i'd like to give a crash report, but i have windows set up to close the program automatically after it crashes, so no help there.

if it matters, the new version of in_wm crashes the winamp pluginstarter.

ctkatz8086 is offline  
Old 19th January 2006, 15:12   #15
DrO
 
Join Date: Sep 2003
Posts: 27,873
i can't really offer any extra help with the mms:// since the newest in_wm handles the whole wma media better (i've not been able to crash it unlike the older versions). the only other thing is to make sure you've got the lastest wma 9.1 codecs installed (by running the latest winamp installer and setting it to have internet access then it should update them if they're not already present/uptodate). if you're already uptodate then i really don't know what else to say

-daz
DrO is offline  
Old 19th January 2006, 16:33   #16
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
This is moving off topic a bit, maybe it can be split ??

I also get a problem with that particular stream.

Looks like a lack of communication between Winamp and the WMA plugin. You can get a similar thing happening with the Tara plugin.

It seems to come about because the plugins and Winamp can't agree whether they are still streaming or not.
For example the stream you gave plays fine, stop the stream, close Winamp, no crash. But start Winamp again and the stream plays automatically(stopped is expected).

UJ
ujay is offline  
Old 19th January 2006, 18:23   #17
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Back OT.

AppName: winamp.exe | AppVer: 5.1.2.275 | ModName: comctl32.dll | ModVer: 6.0.2900.2180 | Offset: 00023f69

Looks like it happens on lauching the Edit box.

UJ
ujay is offline  
Old 19th January 2006, 21:36   #18
DrO
 
Join Date: Sep 2003
Posts: 27,873
hmm, wonder why that's still happening. is the issue with the local media view still a problem for you with 0.6?

-daz
DrO is offline  
Old 19th January 2006, 22:31   #19
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Can't check much I'm afraid, get a crash as soon as it goes to the Edit box as things stand.

UJ
ujay is offline  
Old 19th January 2006, 22:41   #20
DrO
 
Join Date: Sep 2003
Posts: 27,873
hmm, wonder why you're having issues since my text xp install seems to work correctly. i'll have a look at the code a bit more in a bit/may just disable somethings

-daz
DrO is offline  
Old 19th January 2006, 23:01   #21
papadoc
Comfortably Numb
(Forum King)
 
papadoc's Avatar
 
Join Date: Jun 2001
Location: Behind the Wall
Posts: 4,611
Yipeeeeee Thanks Dr0
Downloading now!

When I tried to Edit Bookmark Catagory, the same thing happened as did ujay...
Winamp crashed and I got the same error message as ujay.

Also, if I try to bookmark a stream using Alt-I,
with "Prompt for a catagory when adding a bookmark" selected, Winamp crashes.

This is gonna be great once the bugs are worked out.
Just what the doctor ordered

Last edited by papadoc; 19th January 2006 at 23:43.
papadoc is offline  
Old 20th January 2006, 05:18   #22
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
something very significant. the plugin interferes with ml_gusb, a plugin for moving files to other devices. it displays the local media view under any device (local hard drives and players). it may have effected the shoutwire and mediamix plugins which i deleted thinking they were corrupted, so this may be an issue of conflict with other media library plugins.

ctkatz8086 is offline  
Old 20th January 2006, 08:28   #23
DrO
 
Join Date: Sep 2003
Posts: 27,873
i don't see why it'd crash out when opening the dialog since it's running fine even on my XP install. i ran out of time last night to see what happens if i disable the auto-complete code (is the only thing i can think off which would cause a crash in comctl32.dll

ctkatz8086: interfers in what way?

-daz
DrO is offline  
Old 20th January 2006, 14:49   #24
papadoc
Comfortably Numb
(Forum King)
 
papadoc's Avatar
 
Join Date: Jun 2001
Location: Behind the Wall
Posts: 4,611
Dr0...I can't do anything with it now, because it's crashing Winamp.
If this issue is resolved, will I be able to simply drag a stream's info
from the right window to a catagory folder I've created under Bookmarks in the left window?
papadoc is offline  
Old 20th January 2006, 17:21   #25
DrO
 
Join Date: Sep 2003
Posts: 27,873
i've confirmed the ml views issue, basically any pages added by other plugins into the ml will break which i need to track down asap (otherwise Egg is going to hang me). as for the crash on opening the dialog, i still can't reproduce it even on a few other machines. so as long as i can get the time tonight i'm hoping to get a newer build out.

papadoc: at the moment it will still add back to the root view since i've not implemented any such handling for this case. once i've got it at least working on all installs then i can start looking at beefing up the ability to control how/why the bookmarks can go. for the moment the main aim is just to get a stable version, heh

-daz
DrO is offline  
Old 20th January 2006, 17:57   #26
papadoc
Comfortably Numb
(Forum King)
 
papadoc's Avatar
 
Join Date: Jun 2001
Location: Behind the Wall
Posts: 4,611
Quote:
once i've got it at least working on all installs then i can start looking at beefing up the ability to control how/why the bookmarks can go. for the moment the main aim is just to get a stable version, heh
Great point. Thanks!
Guess I'm getting ahead of where we are now with it,
when I should remain patient and help any way I can.
papadoc is offline  
Old 22nd January 2006, 00:45   #27
DrO
 
Join Date: Sep 2003
Posts: 27,873
ML Bookmark Categoriser v0.6.5
  • Fixed ml_bkmk's handling of ml view pages to not break 3rd party pages anymore
  • Found a buffer init/overrun in the edit bookmark dialog (is this the cause of the comctl32.dll errors..? )
  • Reworked all handling for when the bookmark root is not the active ml page and a bookmark is added (completely messed things up before)
  • Adjusted all other areas of the plugin to get data from the real files if any attempts to read from current views fail
get v0.6.5

i so hope this one will work properly since it's hard to fix a bug you can't reproduce

-daz
DrO is offline  
Old 22nd January 2006, 03:00   #28
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
No change, still the same error.

There are serious problems maintaining the .bm and.bmc files from what I can test so far, it's even possible to wipe the .bm file completely

UJ
ujay is offline  
Old 22nd January 2006, 04:30   #29
ctkatz8086
Senior Member
 
Join Date: Sep 2002
Location: louisville, ky home of the CARDINALS
Posts: 401
-dro

that above problem that i brought up with the stream? i am now on a machine that has the same setup for winamp but lists the error message instead of closing outright. i tried modifying that same stream above and got an error message. here is the crash data if you need it-

AppName: winamp.exe AppVer: 5.1.2.275 ModName: unknown
ModVer: 0.0.0.0 Offset: 65721d11

also, i can confirm that winamp crashes on startup if there was an error that caused it to crash initially.

ctkatz8086 is offline  
Old 22nd January 2006, 10:46   #30
DrO
 
Join Date: Sep 2003
Posts: 27,873
i just don't know with this since there is no reason for the code to crash like it is since i've tested it on 5 different machines and never managed to reproduce the crash.

ujay: the maintaining between the bm and the bmc shouldn't be an issue with all of the fixes i did last night but if the plugin (or something else) is causing weird and wonderful crashes then it's possible for them to get out of synch tho any deletions of data in winamp.bm are solely down to winamp's own code. grr, this is pissing me off now

ctkatz8086: a crash in an unknown module basically looks like something is trying to read/use memory that it shouldn't and without knowing the module it happened with makes it almost impossible to sort out.

gah, pissed off grr since i went through all of the code last night and made sure that anything dodgy or even potentially dodgy was checked for being valid or had a complete fallback. so tempted right now to not bother with this and work on other projects that need it

-daz
DrO is offline  
Old 22nd January 2006, 14:48   #31
DrO
 
Join Date: Sep 2003
Posts: 27,873
k, i'm a bit more awake now (so maybe my earlier response was a bit ott). if the issue is with the dialog loading (why i just can't see it) then i'm just going to roll out a few different builds once i'm back from work with various parts enabled and disabled and see if any of them work. if none work then i'm going to come round and re-install your pc ujay

-daz
DrO is offline  
Old 22nd January 2006, 19:27   #32
DrO
 
Join Date: Sep 2003
Posts: 27,873
ML Bookmark Categoriser v0.6.6
  • Fixed an incorrect usage of a Win32 api (the crash fix i hope at last)
get v0.6.6

Egg thankfully (i fear saying that) managed to reproduce the same crash and the crash location matched completely with ujay's so i'm hoping this will work ok now.

-daz
DrO is offline  
Old 22nd January 2006, 19:37   #33
Cianca
Senior Member
 
Join Date: Mar 2002
Posts: 336
Greaaaaat!


0.6.6 doesn't crash anymore!!!

0.6.5 and less crash crash and crash



The universal god of light, love, wisdom and rok n rol
Cianca is offline  
Old 22nd January 2006, 19:42   #34
DrO
 
Join Date: Sep 2003
Posts: 27,873
now i just need ujay and papadoc to confirm and i'll be happy. from what i can see, xp handles the api at fault (so it seems) differently from how it is on win2k, etc which is a bit dumb really

-daz
DrO is offline  
Old 22nd January 2006, 19:44   #35
Cianca
Senior Member
 
Join Date: Mar 2002
Posts: 336
mmmm

click on an entry of a created category drag and drop in another created category and the categories duplicates like sheeps


you managed this bug DrO?

The universal god of light, love, wisdom and rok n rol
Cianca is offline  
Old 22nd January 2006, 19:45   #36
DrO
 
Join Date: Sep 2003
Posts: 27,873
extended drag and drop handling is not currently implemented (papadoc made a comment about it a few posts up)

-daz
DrO is offline  
Old 22nd January 2006, 19:49   #37
Cianca
Senior Member
 
Join Date: Mar 2002
Posts: 336
also... delete all bookmarks the views created doesn't clean


however this plugin is in anyway amazing

The universal god of light, love, wisdom and rok n rol
Cianca is offline  
Old 22nd January 2006, 21:20   #38
papadoc
Comfortably Numb
(Forum King)
 
papadoc's Avatar
 
Join Date: Jun 2001
Location: Behind the Wall
Posts: 4,611
Yahoo Great work Dr0!
I've tried everything we did previously and I cannot get Winamp to crash.
Very good so far...
papadoc is offline  
Old 22nd January 2006, 21:22   #39
DrO
 
Join Date: Sep 2003
Posts: 27,873
now for ujay and things are good to go on improving integration

-daz
DrO is offline  
Old 23rd January 2006, 00:09   #40
ujay
Forum King
 
ujay's Avatar
 
Join Date: Jul 2001
Location: London
Posts: 6,074
Not crashing anymore. Hooray !

Still get the problem with backspace/delete in the Edit box though.

.bm and .bmc maintainence are still a problem, suggest turning off re-ordering as well as delete in the catagory views if you can. This should stop it wiping/corrupting .bm.

UJ
ujay is offline  
Closed Thread
Go Back   Winamp & SHOUTcast Forums > Winamp > Winamp Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump