Jump To File Extra (JTFE) Discussion / Bugs / Updates (1.33 Build 1216 - 16/12/2013)

[DrO]

JTFE Development Thread

The purpose of this thread is to track, follow and report any issues/suggestions/other random things regarding the JTFE plug-in. Due to certain machine issues, the builds in this thread are based partly on the older 0.96e2 build of the plug-in but also include a large amount of new code so testing out both the old and new features is essential!


::Useful Links::
JTFE Development Log
(lists changes for all and any builds from the initial re-release build)
Known Issues with the plug-in
(due to the rebuild and new features, somethings will be broken so before posting about a bug please read here first!)


::Current Build::v1.33 (Build 1216) [Distro Build for 5.666 Build 3516+ only]
Release Notes: 16/12/2013
(each build is in a differently named installer so you can easily revert back to any older build if you want to do so otherwise known as DrO messed up the build again)


When reporting any bugs, please try to be concise as possible with the error reports since if i can't follow/understand what you're doing then i can't properly try to re-create and then fix the issue if it does exist (help me to help you as they say ).


::Reporting Issues::
When reporting issues please list the exact method you did to create and reproduce the issue, your OS (it matters at times!), other relevant system specs, Winamp version, any extra plugins that you may have installed (this matters since my own plug-ins can conflict so you can understand what that means for others! (*), and your bank details...

* - you can install and use the One for Nunz plug-in to create a easy to read text listing of all installed plug-ins, so please attach this as needed since it's a single click to create it now

-daz

[DJ Egg]

The silence is killing me. Somebody say something, pleeeease!

[siebe83]

Heh, yeah... I was trying to figure out something...

Did I ever say you rock, Darren? Heh, I probably did, but it can't hurt to say it again
Looks really great, my playlist editor has never been this colourful before
Enqueue and Play from Windows Explorer


Noticed one thing up till now...
All tags in the playlist have been read, so all entries in the JTF dialog just look like Artist - Title. Now if I right-click a file in the JTF dialog > Move after current, the entry will suddenly be in the list with its filename instead. After moving another file after current the same way, that file will be displayed with its filename and the previous one will display properly.

Oh well, I now see this happened in 0.96ff as well so you probably already know about it. Whatever... I tried and I broke the silence

[DrO]

the move after current thing is just how Winamp works in that you can't add an entry into a given position with the extra information about the file like title, artist, etc updated in the view on adding (unless i've missed something in the last 2 years )

you may also want to test out the loading into the jtfe queue that you were having those relative path issues with (i think i've fixed m3u handling, just pls left to go)

-daz

[siebe83]

From a quick test it seems to handle relative paths fine now
Will mess around with it more tomorrow to see if I can break things

[jmatthews112]

From the JTFE 0.97 R Changelog

Implemented the 'Classic Skin Winshade' api into the plugin (cos it's damn shexy!)

If this means users can click a button to send the JTFE dialog to Windowshade mode, I can't see it. Although I may be sight-impaired , I do not see a button to the left of the close button in the dialog, nor do I see a click command to invoke this as such.

Would you mind clarifying, Darren? Great work on the rebuild, I'll let you know if anything breaks

The above issue with Winshade was due to a conflicting third-party plugin. See below. Be sure to read, DrO!

ALL OF THE BELOW BUGS WERE FOUND ON A CLEAN INSTALL OF WINAMP 5.092

[EDIT]

It appears as though the JTFE dialog text formatting is broken, kind of...

The separator character, or whatever you like to call it, default is ^ I believe, doesn't appear. All I get is the other strings... the default "%S - [%N%M]" DOES appear.

[/EDIT]

[EDIT2]

Also, some of the file extensions appear, while others do not, in the dialog. All of the files in the current playlist are mp3 files; for example:

Maroon5 - Harder to Breathe
Maroon5 - Must Get Out.mp3

[/EDIT2]

[EDIT3]

Menu handling doesn't work at all. "Add to queue" does nothing, while "Add to queue and play" sends Winamp to the next song, but nothing is done to the internal queue and nothing is visibly different from the dialog.

[/EDIT3]

[EDIT4]

@billy

I can't reproduce as you have detailed below. I only get one window, regardless of which window is in focus. Which skin are you using, WA Classic, Modern, or a third party of which type?

Winamp does get tripped out though, and it seems redraws the entire skin, although this only occurs in a span of a few milliseconds.

[/EDIT4]

[billyvnilly]

DrO, It seems alot faster, and when you drag the jtfe box it looks smoother..at least to me..its smmmoooooth.


Bu, i gotta bitch like a lady now...I can still get 2 boxes for jtfe. Can reproduce if mainwindow is selected and hit "j" works correctly if pledit is selected.

[JonnyMac]

Originally posted by jmatthews112
If this means users can click a button to send the JTFE dialog to Windowshade mode, I can't see it.

Two questions...[list=a][*] Are you using a classic skin[*]Do you have "Skin 'Jump to file' using the current Winamp Style" enabled?
JTFE options > Display tab > Misc Options box[/list=a]

[jmatthews112]

@JM

Yes I am using a classic skin, and was skinning JTFE. I was using the Ripple Skin, 2.9X and 5.X ready, with GEN.BMP, but could not see the button. I reverted back to the WA Classic Skin, and still could not see it. I even closed Winamp with the classic skin open (Reload JTFE when WA starts is not checked), but to no avail.

On looking at another, clean, install, the WA classic skin, and JTFE skinning enabled, the button appears.

o_O but WHY ... lol ... would this mean a third-party plugin is messing with it in my main install?

More edits above, and below

[EDIT]

JM and DrO, on my main install (with third-parties) I removed the entire section of settings from winamp.ini while WA was closed, but it didn't help.

[/edit]

[JonnyMac]

It looks like one of the third party plug-ins is interfering with JTFE's Classic Skin Winshade button.

[jmatthews112]

Ok, I fixed the issue with the Winshade, and normally I wouldn't fret it, except that the interference comes from the Explorer Playlist plugin. The button now appears in my favorite third-party skin, as well as Classic. So there is a bug, Darren, not with JTFE, but with cross-handling with Explorer Playlist.

[OFF-TOPIC]

@JM,

Isn't it ironic that I'm having issues with third-parties when I tell people they aren't supported, everyday?

[shinobi]

It's fixed the whole "open two windows on 'j'" thing for me. But another thing..

Added in a new %st value for the playlist formatting so you get an idea when a track in the queue should start playing (still alphaish and appears to be out by the current output buffer sizes)

I tried to use that, and it said my enqueued file would start playing in 11:37:40. I know it's still alpha & all, and it's a neat idea (been looking for something like it for ages).

Can't wait for the next release of jtfe.

[JonnyMac]

[off-topic]
@ jmatt

ironic
[/off-topic]

[jmatthews112]

'Enqueue and Play' > "Insert enqueued file after the currently playing file"

Not a bug, but a quirk... What if there is a queue? The enqueued file won't play until after the last in the queue. Kind of defeats the purpose, unless I'm having issues, those that are often thrown at me when I think I have an issue or a bug .

[electricmime]

do you have a written down wishlist for jtfe(i don't want to bring up old suggestions if you are already planning to put them in)

btw, i like the media library function.. although its not exactly what i want, at least it allows me to easily queue up albums/artist(it would still be nice to do it from the playlist though)

[priestlyboy]

Well, I suppose this is on your list somewhere but...

At the present time with this build there's no way to resize the Jump to File window.
So if you do use the Skin the Jump to File window with the present skinstyle and then put it into windowshade mode... then it kinda looks out of place with classic skins.

[DJ Egg]

Originally posted by shinobi
I tried to use that, and it said my enqueued file would start playing in 11:37:40

Not "in", but "at", ie. it's the approximate time of day (hr:min:sec) that the queued file will begin playing at.


Re: other reported issues. I can reproduce the classic winshade issue with Explorer Playlist present, but none of the others (note, feature requests are another thing, heh).


btw, my current fave new features are
1) option to disable the auto scrolling on track change in the playlist
2) show entry in playlist from jtf window right click context menu
3) option to make Enqueue+Play the default action
4) all the others ;-)

[shinobi]

Hahahahaha. Ok, I feel like a total n00b. Sorry man.

[AnodA]

Originally posted by DJ Egg
btw, my current fave new features are
1) option to disable the auto scrolling on track change in the playlist

Is this about this one? My first and only wish - and come true!?

[AWhitman]

I haven't tested the new version, maybe after my final exam tomorrow.
Anyway, as a bit of a feature request, could you add an option to hide separators from the jtfe window? None of my mp3's use id3 tags so the string vars in the separator plugin has no effect, so I simply use dashes. In the jtfe window however I get a load of separator entries at the top of the window. Ok, so they disappear as soon as I start typing a track name, but it would be nice if there was the option to not have them at all.

[niktheguru]

Hey DrO/Darren, wicked release!! You've been doing marvels since starting work on this plugin (making it easy for us winamp 3 lovers when we saw it killed!!)

This new build is wicked, just one question....

The new enqueue and play function is just what i've been waiting for. Only thing is, when winamp is already on and playing, when you click a music file in explorer it enqueues straight after the file that is playing, rather than at the end of the playlist. Is this done intentionally? Is there any way to get an option to whack it on the end of the playlist?

Keep up the great work!! Keeping the winamp Uk contingent proud!! ;-)

[DJ Egg]

@ AnodA

Yes. Your wish has come true

Winamp > Prefs > Jump to File > Menus and Buttons tab
Checkmark "Prevent Winamp from scrolling the currently playing entry into view"

And, as it says...
"You can still use the spacebar to 'force scroll' the current entry into view"


@ AWhitman

Yes, an option to ignore separators in the JTF window would be nice, heh.


@ niktheguru

Maybe uncheck:
Prefs > Jump to File > Shell Options tab
"Insert enqueued file after the currently playing file"

[Cianca]

JTFE winshade doesn't work for me (see attached image)

Win 98 Se, WA 5.08e Classic Skin without Expl PLaylist

[DJ Egg]

Umm, what do you mean? That is JTFE winshade mode in your screenshot.

[Cianca]

ops then... sorry :P

but... what is the utility of that thing?


for example... the playlist winshade is useful (see attachment) the jtfe winshade.... (???)

[DJ Egg]

I guess it's so you don't have to keep opening and closing the JTF window.
eg. you can dock it to the bottom of another window and put it in winshade mode when not using it....

Which is ok if you're using classic skins, heh.

[Cianca]

ah ok :P


i thought that JTFEwinshade was similar to old Winamp3 search box :P (see attachment)



my dream is that in future (with PLEX finished) click JTFE winshade mode and appear the magic search box (winamp3style) in playlist :P :P

[d3x7r0]

UUUUUUUU nice to see this, can't wait to get my hands on this new baby

[DrO]

Cianca: the winshade support is limited to essentially having the titlebar of the skinned frame and the button for the minimise option (as best as can be matched with the hacks from the pledit.bmp where i pull that button from). as for some form of edit box in there it may be possible to add in a decent work around for it which doesn't break things too bad or look awful (which is always a pain when working with skins )

AnodA: yup that's the one was a chance find when i was adding something else in and from it i also found out how to scroll an item into view (see the right click menus on the main jtf list and also the manage views for the 'scroll to..' features [i think that's the name i gave them])

AWhitman: i'll hopefully get an option in for that in build 2 or 3 (doing it will possibly slow the loading of the jtf window a little bit if there's a lot of them and it's a large playlist but hopefully it shouldn't be that noticeable)

jmatthews112: good find on the explorer playlist conflict, i had thought i'd coded it to ignore the jtfe window only on the older < 0.96ff builds but i'll look at updating the plugin and may even do a dual compile in the installer so one will and one won't have the winshade api in it so if the newer jtfe's are present then it'll installer the build without the api in there (which is pretty easy for me to do )

billyvnilly: hmm, what skin, etc are you using since i can't force any miss shows no matter what i try to do to the plugin (or is this the return of the issues your machine used to have ) i'll see if there's anything remotely that could be causing such a conflict in the code.

electricmime: not too sure what you're looking for with the ml integration (since i'm not a major user of the ml i'm not too hot on what people are doing with it)

@ all in general:: thanks for the response, feedbacks and comments so far (and no crashes so far, yipee ) i'll give a bit more of a response on things when i get home (though Egg is doing a great job so far seeing as he's helped with the general testing of things in the last week so he's got a good knowledge of things so far). expect a new build later tonight which should hopefully address a few of the reported issues and may even add in a few more things

-daz

[Cianca]

Originally posted by DrO
Cianca: the winshade support is limited to essentially having the titlebar of the skinned frame and the button for the minimise option (as best as can be matched with the hacks from the pledit.bmp where i pull that button from). as for some form of edit box in there it may be possible to add in a decent work around for it which doesn't break things too bad or look awful (which is always a pain when working with skins )

ok don't worry

good work

[billyvnilly]

I'm sorry DrO
It happens with every classic skin i have tried it with. If there is anyway for me to run a debug jtfe, i would be happy to do it.

winamp 5.092, XP pro sp1


So noone can reproduce? could it be another plugin somehow causing a conflict, ive got a few installed.

[jmatthews112]

which few? ... as can be seen from above ... i had explorer playlist installed --> jtfe r build conflict

i have plenty myself, but i can't reproduce with any of them

[edit]

you're right, i don't even have Extended Playlist installed... damn i don't know what is happening to me ... ugh

btw, darren, did anything conclusive arise from the other things i mentioned in the many edits above?

[/edit]

[DrO]

extended playlist?? explorer playlist i thought

billy: i'll see if i can add in some debug information in build 2 to see why it's possbily happening

-daz

[billyvnilly]

i deleted everything. It might have something to do with nview. when i have nviewfix.dll i get my above error.

when i dont have nviewfix.dll
main window - have to hit "j" twice for anything to popup. only the empty frame pops up, not the unskinned jtfe.

pledit - works normally, unless i just tried to open jtfe from main window. So if i get the empty frame by clicking main window, close it, select pledit and hit j, i get two windows. if i close that window and hit j again, it works like normal.

[edit]CONFIRMED AND FIXED
it was nview...i added winamp to nviews exclusion list, and i no longer get bug. perhaps your nviewfix needs tweaking.
[edit2]sorry about the scare and wasted time.

[iron2000]

The queue number and background colour doesn't show on queued titles on my PC.

Same happened with the last build in 5.08d.

Nice new version seems feature-packed.

[jmatthews112]

Iron, as the last build, 0.96ff, has been available since December 2004, has the problem existed since then?

Are you using any third-party plugins (as you may have seen I had an issue with another of DrO's plugins)? Have you tried selectively disabling them by renaming them as Winamp is closed to pinpoint a problem?

Have you selected 'Defaults' from the main JTFE tab to ensure that no old settings are conflicting? You may also want to delete the section headed by [Jump to File Extra] in winamp_directory\winamp.ini.

Let us know if this works to resolve your issue or not.

[niktheguru]

Originally posted by DJ Egg

@ niktheguru

Maybe uncheck:
Prefs > Jump to File > Shell Options tab
"Insert enqueued file after the currently playing file"

Lol, cheers (just noticed that option!) but it wasn't ticked!!

Also, i seem to be getting every new track that i add from windows explorer being separated by a track called QUEUE.....is this intended or a bug?? So every track i have is separated by this queue strand.

[DrO]

Build 2 is out:: release info

---------------------------------------------------------

right, here goes on the reported issues not already covered...

jmatthews112:

The separator character, or whatever you like to call it, default is ^ I believe, doesn't appear. All I get is the other strings... the default "%S - [%N%M]" DOES appear.

the ^ character is there for when you have the same file queued multiple times so if it's only single queued then it won't appear (and that code hasn't been touched since i don't know when so not sure how else it will be failing for you )


Also, some of the file extensions appear, while others do not, in the dialog. All of the files in the current playlist are mp3 files for example

do all of the entries in the playlist have their titles already read? that's the only reason i can think off for the titles the jtf list (and what winamp is providing) will do something like that. try doing a re-reading the info on the whole playlist and see how that works


Menu handling doesn't work at all. "Add to queue" does nothing, while "Add to queue and play" sends Winamp to the next song, but nothing is done to the internal queue and nothing is visibly different from the dialog.

i'm not at all sure why that's failing for you though niktheguru has an issue as well so it may be related in some way, dunno


* 'Enqueue and Play' > "Insert enqueued file after the currently playing file"

Not a bug, but a quirk... What if there is a queue? The enqueued file won't play until after the last in the queue. Kind of defeats the purpose, unless I'm having issues, those that are often thrown at me when I think I have an issue or a bug

it's more a conflict of the modes since in most cases if you're using the queue then you won't normally do something like that... however i've added in an option now as a sub feature of this to allow the item to be added to the start of the queue if there is one (it's a bit rough still and needs some more love)


priestlyboy:
the winshade mode hack is just that but it's useful to do so even without anything fancy like the built in windows can do. without more hacking and potential compatibility issues i doubt anything else will be done with the feature as things stand. but as for the window contents resizing which could help with the look of things), that is on the todo list and may make it into one of the next few builds (i'm not sure if i've still got the working code i had for doing that which would make my life a lot easier).


iron2000:
what Os, etc are you running and also are the options for displaying in the playlist enabled? (check under the 'Display' tab in the jtfe preferences)


niktheguru:
that shouldn't be appearing in the playlist for you. also is it just 'queue' that appears or is it '\\queue'? (can you also check the actual playlist entry (ctrl+e). what OS are you running?


[edit]
@ all in general, please follow this when making any future issue reports (since i need as much info as possible for some of the more obscure ones at times)

-daz

[jmatthews112]

Originally posted by DrO


jmatthews112:

The separator character, or whatever you like to call it, default is ^ I believe, doesn't appear. All I get is the other strings... the default "%S - [%N%M]" DOES appear.

I had a misunderstanding of the function of the ^ character. Nothing is broken; I just never enqueued the same file more than once in a playlist. Thanks for the clarification.

Originally posted by DrO


Also, some of the file extensions appear, while others do not, in the dialog. All of the files in the current playlist are mp3 files for example

A re-reading of the info on the entire list worked to resolve this issue, by simply scrolling throughout the playlist, to allow Winamp to scan the info "on the fly."

Originally posted by DrO


Menu handling doesn't work at all. "Add to queue" does nothing, while "Add to queue and play" sends Winamp to the next song, but nothing is done to the internal queue and nothing is visibly different from the dialog.

i'm not at all sure why that's failing for you though niktheguru has an issue as well so it may be related in some way, dunno

Relevant specs:

Winamp 5.092
OS Name Microsoft Windows XP Professional
Version 5.1.2600 Service Pack 2 Build 2600
System Type X86-based PC
Processor x86 Family 6 Model 13 Stepping 6 GenuineIntel ~1694 Mhz
[Sound Device] Name SoundMAX Integrated Digital Audio (onboard)
[Display] Name ATI MOBILITY RADEON 9600 Series
DirectX 9.0c

Multiple installs

1) Clean (also occurs on 3rd-party install as well) - Relevant ML Integration options selected > Right-click on any music file (these are mp3s) > Send to: > Add to queue > Nothing appears in the enqueue menu relevant to the track I selected.

2) Clean (also occurs on 3rd-party install as well) - Relevant ML Integration options selected > Right-click on any music file (these are mp3s) > Send to: > Add to queue and play > Nothing appears in the enqueue menu relevant to the track I selected, but the enqueue list is processed if there are other entries in the queue. If not, a random song plays, as I have shuffle enabled. I could swear that I could show an entry that replicated the following "%S - [%N%M]" (something like "Maroon5 - Shiver [0]). To my understanding, 0 shouldn't appear. If I can manage to bring up a screenshot, I'll try to in future posts. Will see if I can break new features as I haven't tried yet

[EDIT]

NEW ISSUE: Added an extra shell handling option when using the 'Insert enqueued file after the currently playing file' mode to add the file to the start of the current queue if there is one present

The changes to the plugin between Build 2 and 1 don't seem to have any effect on this functionality. The files are placed in the playlist, but they aren't enqueued (as nothing appears in the dialog).

Also, I had to completely delete the [Jump to File Extra] section from the winamp.INI file for the ML integration to appear in the PLEditor or in the ML plugins tab. And it doesn't seem to keep this functionality between closing and reopening Winamp. I disabled all of my third-party plugins in that install, and it didn't help to uncover any conflicts. My clean install doesn't experience this problem. Is there some way that the JTFE plugin INI information could conflict with other entries in the INI file, even when the plugins are disabled? Hitting the Default button didn't help either.

[/edit]

[iron2000]

Originally posted by DrO
iron2000:
what Os, etc are you running and also are the options for displaying in the playlist enabled? (check under the 'Display' tab in the jtfe preferences)

I'm running Winamp 5.08d on Windows XP SP2 Home.

Yes, the 3 checkboxes in Formatting Options are all checked.