Winamp Freeform skin engine bug thread

[Mr Jones]

This one specifically....
http://forums.winamp.com/showthread....31#post1952831

[Plague]

yeah, that would be the one...
sounds good, let's hope the w.p skin will work again from next version then..

[Benski]

The layer fx bug (not redrawing on colortheme change) is fixed as well.
http://forums.winamp.com/showthread....27#post1920027

Both will show up in the next feature release.

[martin.deimos]

thanks! and eq-spline gammagroups? can u fix this too?

[Plague]

eq spline gammagroups??
that should work already, you just set the gammagroups inside the eq spline xml..
<eqvis id="spline" gammagroup="eqspline"/>
just like you would in a normal vis..
should work..

Otherwise, I've been away from skinning way too long..

[martin.deimos]

hm, is posted somewhere before, too and i didn't get it to work in vortex!

[Plague]

ah yes, this old one:
http://forums.winamp.com/showthread.php?threadid=202753

I honestly can't remember if I ever made a skin with them working or not.. I just supposed I had.

Anyways, it seems it might be a bug after all, and if so, it would be ultimate if it was possible to assign <color/> elements to the spline colors, and not just one gammagroup as I mentioned above..

Same goes for the regular vis btw, if that's not already possible (don't think it is)..

[martin.deimos]

for vis it is!
hey you've been away from skinning for a very long time!!

[Plague]

Originally posted by martin.deimos
hey you've been away from skinning for a very long time!!

hey! I have a life you know.. well not really, but still!
anyways, good to know atleast the regular vis has it working.. (maybe I've even used it myself and just forgot it.. hehe)

[pjn123]

Bug I:
Error:

PHP Code:

-Assertion Failed-  "Can't unload script while in script"  Expression: VCPU::VSP==0  File: sandbox20060621_125654Wasabiapiscriptvcpu.cpp  Line: 476 


This happens on a button with a tooltip & right-click(maki made, not the stop,play,... button's r-c menus)

When the right button is pressed, move the mouse a litle litle up - the tooltip will show and when the tooltip is unloaded/"goes away"... DONG! with the error message above.
If you can't think of any possible causes for this I will post a skin so you can see it for yourself.

Bug II:
Error:

PHP Code:

When you use the setXMLParam() function on a object that is onTimer(), lets say each 250ms, there will be no tooltip in the hole skin. 


This script is used to change a "<rect" colour but when setTargetX() is used on such a regular interval with no other setXMLParam() there will still be no tooltips.

[pjn123]

Use this demo skin to create bug I.

[Logy]

just a curiosity...!

info on the skin tabs (sections)(in preferences) only can access when the skin unzip it that to the folder.... like the winamp skin default! Then it is useless when it is in .wal extension. and what purpose of the preview skin in skin folder... it is something unimplemented features or it is by design!!!
adios!

[Plague]

Originally posted by Plague
found a bug since Winamp 5.2x:
using the Wasabi.player default skin:
http://www.winamp.com/skins/details.php?id=142841

try resizing the playlist editor width.
Winamp will either crash or show a fugly titlebar. The titlebar will only show properly on skin (re)load.

this bug, although reportedly fixed, is still showing parts of it's ugly face.
there are no more crashes, and the gradients aren't ugly as hell on resize anymore...

However.. If you try the wasabi.player skin linked in the quote, and start resizing a window, you'll see how the right side of the titlebar gradient will start to disappear more and more, and after a while only be shown if you make the width of the window very wide.

So, I guess the bug isn't completely fixed after all...

[Plague]

PHP Code:

extern Int List.findItem(Any _object); 


doesn't seem to work, it gives me the error message attached.

[martin.deimos]

yep, i know!

there are a few otehr functions that don't work, too!

1) extern String System.selectFile(String extlist, String id, String prev_filename); // could be connected to the bug in <wasabiathpicker> object ...

2) extern GroupList.scrollToPercent(Int percent); // really need this for my nest skin!

AND to the list object:

try to add strings in the list addItem() and then enumItem(0) or another number, and debug the string (msgbox or text) sometimes the returned string is buggy!
perhaps that's the problem that you don't find your item

AND a lil question what purpose has CfgGroup script object??

[Plague]

no, I put real objects in my list, and additem, enumitem, removeitem, getnumitems all work.. it's just finditem that doesn't work..
and the string thing has been well known since early winamp3 days... not that it shouldn't be fixed, ofcourse..

[martin.deimos]

AND a lil question what purpose has CfgGroup script object??
can u answer this for me?

[Plague]

I have no idea, never used it..
However, it looks like it may be a way to either save your own config settings, or perhaps to get system config settings..
Although that area should already be covered with ConfigItems and ConfigAttributes..
But I don't know..

Benski?

[Plague]

PHP Code:

extern PopupMenu.disableCommand(int cmd_id, boolean disable); 


doesn't seem to work correctly.
when I try to use it, it behaves exactly like

PHP Code:

extern PopupMenu.checkCommand(int cmd_id, boolean check); 


which it should NOT.
it's supposed to grey out the command, not check it, or have I missed something?

[martin.deimos]

yeah, noticed this one too!
i think this is related to the non wasabi menus, which aren't build dynamic. try to delete your menu each time after getting clicked, and the create it new on showing

[Plague]

won't work...
I really need a way to disable a command in the menu.
I have to use a butt ugly hackish crap way for now, but I really want that disableCommand to work.

[martin.deimos]

PHP Code:

switcher.onRightButtonUp(int x, int y) {
    menu = new PopUpMenu;
    specmenu = new PopUpMenu;
    oscmenu = new PopUpMenu;
    mirmenu = new PopUpMenu;
    watmenu = new PopUpMenu;
    fxmenu = new PopUpMenu;
    pksmenu = new PopUpMenu;
    anamenu = new PopUpMenu;
    stylemenu = new PopUpMenu;
    fxsourcemenu = new PopUpMenu;

    menu.addCommand("Presets:", 999, 0, 1);
    menu.addCommand("No Visualization", 100, curVis == 0, 0);
    specmenu.addCommand("Thick Bands", 1, curVis == 1, 0);
    specmenu.addCommand("Thin Bands", 2, curVis == 2, 0);
    menu.addSubMenu(specmenu, "Spectrum Analyzer");

    oscmenu.addCommand("Solid", 3, curVis == 3, 0);
    oscmenu.addCommand("Dots", 4, curVis == 4, 0);
    oscmenu.addCommand("Lines", 5, curVis == 5, 0);
    menu.addSubMenu(oscmenu, "Oscilloscope");

    mirmenu.addCommand("Thick Analyzer", 6, curVis == 6, 0);
    mirmenu.addCommand("Thin Analyzer", 7, curVis == 7, 0);
    mirmenu.addSeparator();
    mirmenu.addCommand("Oscilloscope", 8, curVis == 8, 0);
    menu.addSubMenu(mirmenu, "Mirrored");

    watmenu.addCommand("Thick Analyzer", 9, curVis == 9, 0);
    watmenu.addCommand("Thin Analyzer", 10, curVis == 10, 0);
    watmenu.addSeparator();
    watmenu.addCommand("Oscilloscope", 11, curVis == 11, 0);
    menu.addSubMenu(watmenu, "Water Reflection");

    fxsourcemenu.addCommand("Spectrum Analyzer", 501, vis_fx_spec_attrib.getData() == "1", 0);
    fxsourcemenu.addCommand("Oscilloscope", 502, vis_fx_osc_attrib.getData() == "1", 0);

    fxmenu.addCommand("Cross", 12, curVis == 12, 0);
    fxmenu.addCommand("Beat Cross", 13, curVis == 13, 0);
    fxmenu.addCommand("Cross goes crazy", 14, curVis == 14, 0);
    fxmenu.addCommand("Ant on drugs", 15, curVis == 15, 0);
    fxmenu.addSeparator();
    fxmenu.addSubMenu(fxsourcemenu, "layer Fx Source");
    menu.addSubMenu(fxmenu, "layer Fx");

    menu.addSeparator();
    menu.addCommand("Options:", 102, 0, 1);
    menu.addCommand("Show Peaks", 101, stringToInteger(vis_peaks_attrib.getData()), 0);
    pksmenu.addCommand("0", 200, vis_peaksfalloff_attrib.getData() == "0", 0);
    pksmenu.addCommand("1", 201, vis_peaksfalloff_attrib.getData() == "1", 0);
    pksmenu.addCommand("2", 202, vis_peaksfalloff_attrib.getData() == "2", 0);
    pksmenu.addCommand("3", 203, vis_peaksfalloff_attrib.getData() == "3", 0);
    pksmenu.addCommand("4", 204, vis_peaksfalloff_attrib.getData() == "4", 0);
    menu.addSubMenu(pksmenu, "Peak Falloff Speed");
    anamenu.addCommand("0 ", 300, vis_analyzerfalloff_attrib.getData() == "0", 0);
    anamenu.addCommand("1 ", 301, vis_analyzerfalloff_attrib.getData() == "1", 0);
    anamenu.addCommand("2 ", 302, vis_analyzerfalloff_attrib.getData() == "2", 0);
    anamenu.addCommand("3 ", 303, vis_analyzerfalloff_attrib.getData() == "3", 0);
    anamenu.addCommand("4 ", 304, vis_analyzerfalloff_attrib.getData() == "4", 0);
    menu.addSubMenu(anamenu, "Analyzer Falloff Speed");
    stylemenu.addCommand("Full", 400, vis_analyzerstyle_attrib.getData() == "0", 0);
    stylemenu.addCommand("Gradient", 401, vis_analyzerstyle_attrib.getData() == "1", 0);
    stylemenu.addCommand("Fire", 402, vis_analyzerstyle_attrib.getData() == "2", 0);
    stylemenu.addCommand("Line", 403, vis_analyzerstyle_attrib.getData() == "3", 0);
    menu.addSubMenu(stylemenu, "Analyzer Style");
    menu.addSubMenu(fxsourcemenu, "layer Fx Source");

    ProcessMenuResult(menu.popAtMouse());

    delete menu;
    delete specmenu;
    delete oscmenu;
    delete mirmenu;
    delete pksmenu;
    delete anamenu;

    complete;
} 


try it this way!

[Plague]

what good will that do me?
I still can't disable the commands I want disabled..
And I don't really wanna remove an item entirely when it's supposed to only be disabled, it can confuse the user into thinking that it won't ever be available.

[martin.deimos]

but you will create a new popup menu each time the button is pressed! so you can determine on the fly if you wanna disable the command! check it out, i'm 80% sure that ot will help you!

[Plague]

yea, well, thing is, I have multiple checks that could all trigger a command to be disabled, so if I use addcommand and disable it right from the get go, it will create a new disabled item for each triggered check.
so I might end up with like 5 items of the same thing..

[Plague]

the new vis setting

PHP Code:

oscstyle="solid" 


has been mixed up with

PHP Code:

oscstyle="lines" 


meaning, solid is showing what lines are supposed to show, and vice versa..
just compare with classic skins and see for your selves..

[martin.deimos]

plague can u bosh me the script (include only button and menu if the rest is secret, and rename the menu commands to disable1 etc., if it is opensourece then of course bosh me the full script)
i will have a try ( martin.deimos [at] gmx [dot] de )

[Plague]

edit: posted about the wrong thing, below is the correct..

no I don't wanna send the script, it's super duper secret at the moment.. thanks anyways..

[martin.deimos]

hehe, i've won! it works!
see below!

[martin.deimos]

ah, and here
http://forums.skinconsortium.com/vie...r=asc&start=60
(somewhere in the middle) is explained how adding gammagroups to eqvis works!

[Plague]

Originally posted by martin.deimos
hehe, i've won! it works!
see below!

ofcourse that works, but other issues have come up when doing it that way, issues that won't go away.
for example, I'm using the same menu on multiple objects, and depending on which object and what circumstances, some commands should or should not be disabled. the problem is that if a command is disabled on one object, it will be disabled on the next object aswell, despite the fact that it shouldn't be.
and even weirder, if for some reason all commands in the menu should be disabled for one object, the menu cease to pop up at all on the other objects!

theese are some of the problems that I cannot seem to shake, when doing the menu this way.

[Plague]

Originally posted by martin.deimos
ah, and here
http://forums.skinconsortium.com/vie...r=asc&start=60
(somewhere in the middle) is explained how adding gammagroups to eqvis works!

Originally posted by martin.deimos
have found out the following (winamp3 beta 3 rocks), with gammagroup "Vis/Eq" you can set the gammagroup for eqvis, although this object won't accept a gammagroup param; altering the values of this gammagroup will also change the gammas for all vises if you havn't declared an extra gammagroup for them so you only need to put the eqvis without any gammagroups in your code and add gammagroup "Vis/Eq" in your gammaset.

This also works for Winamp 5.3.
But Benski will fix the missing gammagroup tag when he finds time! Dunno if it will be in 5.31 - but a workaround is here and there are more important things to be done first, not this lil thing.

lazy ass..

[martin.deimos]

sorry, didn't want to search - had to run

bsck to menu:
am i right you have let's say 5 buttons which the same menu but want different checks / disables? ehy not create a XUI object for this button? then every button has it's own script. and if you want to disable items on more then one button set PrivateInts

[Plague]

xuiobjects won't work because of other issues...
I don't wanna give too much away, but let's just say it's very complicated.

[martin.deimos]

k, i only wanted to help you.
It's your decission if you accept help or not
In my early days as skinner i thought that i would never release any of my source scripts - but now due to my work with skinconsortium i have a different oppinion!

[Plague]

seems there are some bugs with the <slider> object, depending on which action you have on it and what orientation the slider is.
for example:

PHP Code:

  <slider
    id="preamp.h"
    action="EQ_PREAMP"
    fitparent="1"
    thumb="player.slider.horizontal.button"
    downThumb="player.slider.horizontal.button.pressed"
    tooltip="EQ: Preamp"
  /> 


this doesn't work as it's supposed, same with all other EQ sliders in horizontal orientation.
What happens is that they all start at 0, and only climb up.
The EQ sliders are supposed to go from -20 DB to 20 DB, but in horizontal mode, they go from 0 DB to 40 DB.
setting high="128" and low="-128" won't help.

PHP Code:

  <slider
    id="balance.v"
    action="PAN"
    fitparent="1"
    orientation="v"
    thumb="player.slider.vertical.button"
    downThumb="player.slider.vertical.button.pressed"
    tooltip="Balance"
  /> 


This is behaving strangely aswell, this time it's vertical orientation that's behaving strangely.
Everything is fine except that at the center, the thumb disappears and it says it's at 200% left, but the sound is clearly centered. Other than that, everything's fine, it can go from 100% left to 100% right, no problem. It's only the center that's screwed up..

[Michgelsen]

That balance thumb thing is known: http://forums.winamp.com/showthread....47#post1792347

[pjn123]

If someone dont know what these slider problems is they can download BugAmp. BugAmp contains a few other demo bugs as well.
BugAmp

[Plague]

Originally posted by Michgelsen
That balance thumb thing is known: http://forums.winamp.com/showthread....47#post1792347

okay, didn't know that..
So it's been known for a year and still not solved?

Anyways, the EQ slider thing hasn't been known before, and I bet they're related..

[pjn123]

Originally posted by Plague
yea, well, thing is, I have multiple checks that could all trigger a command to be disabled, so if I use addcommand and disable it right from the get go, it will create a new disabled item for each triggered check.
so I might end up with like 5 items of the same thing..

Create the menu just before it is shown. Do this with your own function.

For example. I usually do my menus like this:

PHP Code:

Function ProcessMenuResult(int a);
Function UpdateMenus();

Global Popupmenu visM1;

System.onScriptLoaded() {
}

UpdateMenus(){
  visM1 = new PopupMenu;
  visM1.addCommand("Normal", 1, checkedBoolean, disabledBoolean);
  visM1.addCommand("Fire", 2, checkedBoolean, disabledBoolean);
  visM1.addCommand("Line", 3, checkedBoolean, disabledBoolean);
}

myButton.onRightButtonUp(int x, int y){
  UpdateMenus();
  ProcessMenuResult(visM1.popAtMouse());
  complete;
} 


Because you use this:
visM1 = new PopupMenu;
you wont...

Originally posted by Plague
end up with like 5 items of the same thing..