a problem Im have with my current skin

[Ineedmorcowbell]

hey everyone, it has been sometime since my last post but I've been busy with other projects, some of which will be seen shortly. Anyways I recieved a review/email about some problems with my skin, one being the Green X's when 5.23 came out, which I took care of, but for some reason the older version of my skin is still up, and now 2 other issues, one being with the maki I used to change the custom vis, and the other being the opensource_notifer both by iPlayTheSpoons, the latter was edited by TEM for the Sepultra skin.

The notifier doesn't seem to stay off when the option to "Never Show Notifications" is on thats about it

as for the vis maki I was amazed it worked and didn't notice any problems uptill recently when I now get guru meditations

#001C.0010036A.10 Null Object
Returning 0 - #0013.00000270.15 Division by zero
Returning 0 - #0013.00000130.12 Division by zero
Internal error - #0021.00000137.4 Script Fatal Error
Internal error - #0021.00000148.4 Script Fatal Error
Internal error - #0021.00000148.11 Script Fatal Error
Internal error - #0021.00000137.11 Script Fatal Error
Internal error - #0021.000003D5.10 Script Fatal Error
Internal error - #0021.000003E0.10 Script Fatal Error

these were all taken from the guru.log and its a lot of those
oddly enough, I do get those or any when I used the Sepultra skin which the code is almost exactly the same
I worked real hard on this one, especially for it being my first, and I'm completly stuck on these problems, any help on this would be greatly apprectiated

file available here
since the one on winamp.com still seems to be with green x's

[SLoB]

if your getting divide by zero from an animated strip when getting oneframe count you could try the below, if using multiple animated layers in a cycle you could pass in the animated layer to the getnumframes function and everytime you switch to a diff animated layer pass it to that function and it will get the correct amount of frames

PHP Code:

function setGetNumberFrames();
function StopDivideByZero(int iFrame);
global int iGetOneFrame;
global animatedlayer animlyr;

//dont forget to set your animated layer

StopDivideByZero(int iFrame)
{
    if (iFrame < 1){
        iFrame = 1;
    }
    return iFrame;
}

setGetNumberFrames(){

    iGetOneFrame = integer(255/StopDivideByZero(animlyr.getLength()));
} 


[TheElusiveMelon]

Yeah, the divide by zero error happens when the AnimatedLayer is not defined properly. Make sure you have set the w and h of the Animated Layer correctly. This should be the width and height of one frame. That should fix that problem.

My Sepultura Skin did have a couple of green x's but only on the standard windows, which i then fixed in the latest update.

PS: Nice to see people making use of my scripts

[Ineedmorcowbell]

I only had the infamous X in the notifier lol
I checked all th HxW of the layers for the vis and theyre correct, and I remember when the werent when I first started that the whole image would jump unless Im missing something on what you were say

and Im not exactly sure what to do with the script you just gave me SLoB, I mean I put it in, but I got a

Int : undefined indentifier for
StopDividByZero (int iFrame)

so what should it be defined as?

I was glad I found that sepultura, aside from it being good, it had the .m in it still which many other didnt, I just wish I used it right so it worked properly

[TheElusiveMelon]

Yeah, i like to put the m files in.

Maybe you should just learn from my script and write a new one, that way you wont have any obselete code in there. Just re-use the functions that update the vis, and then add the rest in yourself.

Unless Slob's fix does the job that is.

[SLoB]

it should work if you copy the code above
have used it myself many a time

[NickMikh]

This error sometimes appears to be in the previous function that is not closed so the compiler thinks you try to call the function from the previous, not writing a code for it like:

PHP Code:

PreviousFunction(){
  If (2 == 2){
    a=2;
//  missing }
}

StopDivideByZero(int iFrame)
{
// Stuff
} 


[Ineedmorcowbell]

thanks Nick, SLoB, when I get back from work I shall work on both of your suggestions. one thing though that I noticed while I was working on it today, I couldn't understand why mine had the errors and TEM's didn't so I loaded his up and played a file that I new showed the error, and there it was, also while playing anything else, TEM's errors show up in the Guru log as well, so at least it wasn't anything that I did on my own