Good things always come in threes...

.... well, that's what I'm hoping with these three presets. Thanks to Krash & Rovastar for the use of some of their code, hope you guys don't mind me using it, let me know what you think

Enjoy.

[Rovastar]

....still needs a little work and some suggestions.......

variable names.

In Grand Odyssey you have this code:

per_frame_1=dx = dx - .001;
per_frame_2=dy = dy - .001;
per_frame_3=wave_r = wave_r + 0.500 * sin(time* 0.652);
per_frame_4=wave_g = wave_g + 0.500 * sin(time* 0.729);
per_frame_5=wave_b = wave_b + 0.500 * sin(time* 0.891);
per_pixel_1=angval = 0.3/sqrt((3.14*tan(ang*2.5-time*5))+4);
per_pixel_2=rot = 0.02*zoom-0.05*rad;
per_pixel_3=zoom = 1.05 + 0.4 * (abs(sin(0.006 * time)));
per_pixel_4=sx=sx + 0.01;
per_pixel_5=sy=sx;
per_pixel_6=dx = 0.01 * sin(time * 0.9);
per_pixel_7=dy = dy + 0.005;


one of the variables that you defined 'angval' (this not a reserved variable name within milkdrop so it is a userdefined one) is never used. Don't worry about we all do it sometimes - even the great man himself in the octupus presets there is a similar thing. see
http://forums.winamp.com/showthread.php?threadid=60900

So if you do not call it you can deleted it. If you delete the angval line it will make no difference to the preset expect for maybe speeding it up.

Also go easy on the warp amount. These presets have loads of warp in them and to be honest the warp effect is so powerful is distracts from all your per-frame and per-pixel work. If you reduce the warp value to 0 (ie no warp) you will se what the preset is actually doing.

Very few presets use high warp value to good effect. Try doing it presets without it.

Have a look at my mod not brillant but ideas there. I have made it a bit 'travelling' for you so hopefully you'll like. Using the angval and no warp.

Rovastar & Illusion - Grand Odyssey mod

[preset00]
fRating=3.000000
fGammaAdj=1.500000
fDecay=0.966000
fVideoEchoZoom=2.000000
fVideoEchoAlpha=0.000000
nVideoEchoOrientation=0
nWaveMode=2
bAdditiveWaves=0
bWaveDots=0
bModWaveAlphaByVolume=0
bMaximizeWaveColor=1
bTexWrap=0
bDarkenCenter=0
bMotionVectorsOn=0
bRedBlueStereo=0
nMotionVectorsX=12
nMotionVectorsY=9
bBrighten=0
bDarken=0
bSolarize=0
bInvert=0
fWaveAlpha=1.958904
fWaveScale=0.550447
fWaveSmoothing=0.360000
fWaveParam=-0.500000
fModWaveAlphaStart=0.750000
fModWaveAlphaEnd=0.950000
fWarpAnimSpeed=1.000000
fWarpScale=1.000000
fZoomExponent=1.000000
fShader=0.000000
zoom=1.000000
rot=0.000000
cx=0.500000
cy=0.500000
dx=0.000000
dy=0.000000
warp=0.010000
sx=1.000000
sy=1.000000
wave_r=0.500000
wave_g=0.500000
wave_b=0.500000
wave_x=0.500000
wave_y=0.500000
ob_size=0.010000
ob_r=0.000000
ob_g=0.000000
ob_b=0.000000
ob_a=1.000000
ib_size=0.010000
ib_r=0.250000
ib_g=0.250000
ib_b=0.250000
ib_a=0.000000
per_frame_1=dx = dx - .001;
per_frame_2=dy = dy - .001;
per_frame_3=wave_r = wave_r + 0.500 * sin(time* 0.652);
per_frame_4=wave_g = wave_g + 0.500 * sin(time* 0.729);
per_frame_5=wave_b = wave_b + 0.500 * sin(time* 0.891);
per_pixel_1=angval = 0.3/sqrt((3.14*tan(ang*2.5-time*5))+4);
per_pixel_2=rot = 0.02*zoom-0.05*rad;
per_pixel_3=zoom = 0.96 + angval +bass/6;
per_pixel_4=sx=sx + 0.01;
per_pixel_5=sy=2 -sx;
per_pixel_6=dx = 0.01 * sin(time * 0.9);
per_pixel_7=dy = dy + 0.005;

Hope you like and hope it helped.

Rova

PS What preset of mine did you modify I do not recognise the code??

Thanks very much for the feedback, as you can see, I'm still learning! I think I must have copied some of the per_pixel and per_frame lines from a couple of your presets Rovastar, so I thought I might give you some credit, but who knows, maybe it was from somebody else's.

I'll try and reduce the warp on my next batch, just give me some more time and practice and hopefully I'll come up with some better ones, it takes a long time to work out

I might try and make a mod of the ones I just posted with less warp too..

Thanks once again...

[Krash]

angval is one of mine. I use it to generate a value which is equivalent to ang, but rotates around the screen, so the preset moves a bit more, and you don't get "dead spots". Within the angval equation, there is a part - "ang*2.5". You will notice in rovastar's mod that there are five "arms" that rotate around the screen. If you change the 2.5 in that equation to a 3, you will get 6 arms. Change it to a 2, and you get 4 arms. This allows you to repeat an effect multiple times around the screen, if you want to.

On your presets - they aren't bad. They remind me very much of some of the presets that came with the early versions of milkdrop (and are still included now), in that they're relatively simple.
Don't think that that makes them bad, though. When we have massive numbers of very complex-looking presets coming out, having simple stuff is a breath of fresh air.

Keep at it - practice makes perfect.

- Krash

Thanks for the feedback Krash, yeah, I must have taken angval from one of your presets, and forgotten to change it.

The reason most of them are relatively simple is because a lot of math is just guesswork, or using stuff from other presets. As I get more exprienced, I'll hopefully be able to try some more complex stuff, but I don't want to go crazy with the effects - like Rovastar said, warp and a lot of other things aren't necessary, and usually keeping them simple gives a better framerate.

I've posted another new preset today (under "Here comes another one..."), I think it looks pretty cool myself, although the framerate is a little down on the other presets.

I think there is some potential for some interesting mods on it, see what you think...