DEP fix?

[DrPizza]

It seems really easy to add two lines to Compiler.c to stop MilkDrop crashing on any new processor with DEP enabled. DEP is a good thing. "Turn it off for winamp" is not an acceptable solution. Rewriting the entire expression compiler to get rid of its heap and use a VirtualAlloc/VirtualProtected heap is the best solution but it's far beyond what I have any interest in doing; however, a quick and dirty fix like this:

code:


static void *newBlock(int size)

{

  llBlock *llb;

  int alloc_size;

  DWORD oldProtection;

  if (blocks_head && (LLB_DSIZE - blocks_head->sizeused) >= size)

  {

    void *t=blocks_head->block+blocks_head->sizeused;

    blocks_head->sizeused+=size;

    return t;

  }

  alloc_size=sizeof(llBlock);

  if ((int)size > LLB_DSIZE) alloc_size += size - LLB_DSIZE;

  llb = (llBlock *)GlobalAlloc(GMEM_FIXED,alloc_size); // grab bigger block if absolutely necessary (heh)

  VirtualProtect(llb, alloc_size, PAGE_EXECUTE_READWRITE, &oldProtection);

  llb->sizeused=size;

  llb->next = blocks_head;  

  blocks_head = llb;

  return llb->block;

}

is adequate to allow the thing to not crash; VirtualProtecting memory from GlobalAlloc is naughty, but it's not as bad as not VirtualProtecting the memory at all and subsequently crashing. The realAddress function seems to be wrong to me, too; it should just return the address passed in (at least, with VC++ 7.1; its debug mode doesn't adjust the base address of the functions, which is what one would expect, given that they're naked).

[Phat]

Really I've never seen milkdrop crash ever.

Btw, would you happen to know how to do this?

http://sourceforge.net/forum/forum.p...orum_id=466691

"The ability to write to the q1-q8 variables from custom waveforms would be a huge improvement. Namely, you could use a waveform to do better analysis of the sound data for improved bass, mid, treb response, or even to divide into more than 3 bands. The documentation says you can do this, but it doesn't work. As waveforms come last in the order of things, the variables would have to be on a one frame delay [i.e reading a q variable in per frame would return the value written by a waveform in the preceding frame]."

??

[DrPizza]

Originally posted by Phat
Really I've never seen milkdrop crash ever.

Crashes are guaranteed on Pentium Ms/Pentium 4s/Xeons/Athlons/Opterons if DEP is enabled (this is because Milkdrop attempts to copy executable code to read/write memory and then execute it).

Btw, would you happen to know how to do this?

No; I don't have the time or the inclination to figure out how it works; the only reason I'm suggesting this fix is that it was preventing me from trying out Milkdrop in the first place (having never used it before).

[Phat]

oh, okay. =)

[redi jedi]

few things i can sugust phat, try and find the place where milkdrop cleans up its variables at the end of every frame, and see what it does with q1-q8, it might be as easy as deleting a line like "q1=0", or just changing the 0 to q1, although i guess that would be kinda reduntent, prolly better to just delet it. might also check where md initilizes at the begining of every frame, and see if that q1=0 line is there.
failing that, the only place i can think of that such a line might be is after the waves are drawn, mabe MD has seprate internal vars. for q1-q8 after it gets passed to the waves(mabye wave_q1-wave_q8).... witch actualy makes more sence considering that you can pass q1 to a wave change it in wave_per_frame then pass it to wave_per_point and not effect the value of q1 that's getting passed to wave2..... see what i'm saying?
MD has to be reseting the value somewhere, just need to find out where( mabye search the code for q1=0;

and that is why i'm not an english major....

[Rovastar]

OK I'll look into the DEP problem when I have time. As I don't have a intel box it would be tricky though.

for the variable the easist would be to have global variables I would think. Save trying to work out what Ryan is doing with that part of the code. Maybe pick another 8 variable names for it.

tbh when I do anything it will be larger bug fixes first rather then new features

[DrPizza]

OK I'll look into the DEP problem when I have time. As I don't have a intel box it would be tricky though.

FWIW, the issue will also occur with newer AMD processors with hardware DEP enabled too.

[Mike9182]

This problem also occurs on an Intel E6700 (my processor). I am running 64-bit Vista.

[DrO]

try the version from the 5.5 beta which should resolve the issue now

-daz