Banner with CANCEL button

[Instructor]

There is have one http://nsis.sourceforge.net/archive/...instances=0,32

But this "NxS MSI LoaderDlg" plugin are crashes then it called from Custom Page "Function LeaveCustom" (and MSI Banner too).

I trying contact with saivert (author) with no luck.

Can anybody fix this problem (i'm have poor knowledge of C++)?

[Takhir]

May be attached version.. I had not script to test cross-dialog situation.

[Joel]

Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you

[Instructor]

Thanks, Takhir

Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you

Before Takhir change the code setup crashes immediately after "NxSMSILoaderDlg::Show /NOUNLOAD ..."

Another problem:
"NxSMSILoaderDlg::update /NOUNLOAD ..." is clear the stack I use it in the callback function (of course setup quit from function after it)

[Takhir]

New /end parameter - see attached script.
I also increased height of the static control displaying cuurent path (3 lines max now).

[Instructor]

WOW, Takhir one more thing. CANCEL button is allways disabled (trying: /can 0 and /can 1).

EDIT:
And /top parameter also use default value

[Takhir]

90% of new code

[Instructor]

Takhir, my russian amazing friend, thank you.

P.S.
Necessarily publish it (you fix all problems and reduced the size of packed plugin by 85 %)

[Takhir]

Sources and binaries. Banner path text flicking and foreground window position improved, Task bar button issue fixed, dll and entry points renamed (NxSMSILoaderDlg.dll->nxs.dll, show->Show... - see Readme), file size 5.5 kB now (2.3 kB in zip), 2 samples included - original saivert' and sent by Instructor. "Change history" header added to C file.

Saivert, please don't kill me

[DrO]

Originally posted by Takhir
Saivert, please don't kill me

that'd be an interesting fight to watch

-daz

[Instructor]

Then I run example.nsi in WinMe (in WinXP all fine) it shows:

[Takhir]

I see, 98/Me not updates frame size on window style changes (related to hidden or visible Task bar button /h option), so banner will have on 98/Me toolwindow style - decreased caption height, regular font in the /h 1 mode (no task bar button), bold otherwise (system defines this). I know about hidden parent window and appwindow style tricks, but I don't like this way. New version attached.

[Instructor]

I made some changes in readme and examples. If something will seem to you interesting.

[Takhir]

Thanks, Instructor!
I added your files to package, but I had to do some changes in example.nsi - like saivert wrote, first installer's page stays minimized without explicit ShowWindow in the .onGuiInit if banner was shown in .onInit function. The same happened on my XP with "100% done" message box after banner destroyed in .onInit, so I commented this line in your script.

[Instructor]

I'm grateful to you (and to saivert too).