NSIS 3.0a0

[jpderuiter]

...

[jpderuiter]

Sorry, my crashes happen because I commented out onGUIInit, because I wanted to test it without parameters.

Yatosho, does your script crash when using /help as parameter?

[Afrow UK]

Fixed the memory access violation in nsArray which occurred in the ForEachIn loop (nsArray::Iterate). I tested by running with /install and then running subsequent debugging executions with the default INI file as an argument. I don't get any crashes now.

Edit: I should mention the crash came about because an invalid array name is being used in your ForEachIn loop - it resulted in a NULL pointer in the plug-in and subsequent violation where validation was missing. This should not be an issue now.

Stu

[Yathosho]

The last example doesn't crash for me either. Can you maybe attach the compiled installer too?

attached

Yatosho, does your script crash when using /help as parameter?[/QUOTE]

yes

[Yathosho]

ok, i did some more testing as getting different results on different windows installations seemed strange. computer is virus free, so i renamed my old nsis directory (i installed nsis 3 over nsis 2) and did a clean install of 3.0a. now everything compiles and runs fine. still find it a bit weird (ANSI worked, WinVer seems to have caused this), but for me it's sorted. thanks for all advice.

[bnicer]

I had problem with an installer, where ANSI worked as opposed to UNICODE, that was caused by WinVer. The installer didn't crash, but the ${If} ${AtLeastWin'X'} conditions failed, UNICODE. Though, unlike in Yathosho's example, my script had a mistake. I was including WinVer.nsh before I declared Unicode true/false.

I thought of posting this earlier in response to Yathosho, but it didn't seem related. Maybe it is (worth looking into)? If the Unicode true declaration comes after an included file, a compiler error message would be in order, even though it's an avoidable mistake. I wonder as well if it should be necessary to declare Unicode when the script file is encoded in UNICODE. Make Unicode an optional command?

[Anders]

Thanks Yathosho and bnicer for tracking this down.

The compiler should abort if you use a plugin before switching unicode mode but WinVer does some size calculations when you include it and those are later passed to System::Call, I'll try to come up with a fix for this...

[mariusnegrutiu]

I'm trying to digitally sign the installer using the new !finalize command.
Everything works well as long as I don't use "%1" in the command line. If "%1" is used, makensis.exe crashes...

My code goes like this:
!finalize '"${__FILEDIR__}\SignTool.exe" sign /s MY_CERTSTORE /t "http://timestamp.globalsign.com/scripts/timstamp.dll" /d "Description" /du "http://www.blahblah.com" /v "%1"'

Btw, congratulations for reviving NSIS!

[Anders]

WinVer should be a able to deal with switching modes now but it really is best if the unicode mode is set before files are !included

Everything works well as long as I don't use "%1" in the command line. If "%1" is used, makensis.exe crashes...

Fixed...

[extremecarver]

Is there filesize >2GB support in 3.0a?
Or will it come with x64 branch?

[Anders]

Is there filesize >2GB support in 3.0a?
Or will it come with x64 branch?

No and I'm guessing no, the top bit is already used to store data...

[extremecarver]

thanks for the answer. Well then I hope it will be changed/enabled after x64 intregration sometimes. It would be much better than having the installer call external .zip/7z files (which on top can only be bzip/lzma and not lzma2) to unpack because they don't fit into the 2GB limit.

[yoachan]

Just want to say thank you for everyone's work.

BTW can I use/install both NSIS 2 and NSIS 3 in one PC?
Would like my project to keep running and be able to test NSIS 3 to tell if I found a bug.
So amazing that NSIS 3 exist. Even NSIS 2 is already amaze me.

[Anders]

BTW can I use/install both NSIS 2 and NSIS 3 in one PC?
Would like my project to keep running and be able to test NSIS 3 to tell if I found a bug.
So amazing that NSIS 3 exist. Even NSIS 2 is already amaze me.

The startmenu and add/remove programs entries will be taken over, other than that it should not be a problem. Makensis itself does not depend on any kind of system configuration...

[Yathosho]

are there plans to move the examples (and maybe includes) to the user space? on any modern windows version, the examples won't compile due to lack of privileges. just saying.