Winamp Freeform skin engine bug thread

[Mr Jones]

This is your one stop shop for reporting bugs in the winamp freeform skinning engine.

Notice something that's broken?, noticed something that dosn't work correct? then report it here.

A description of the problem would be a help, any example code you are using would be an even bigger help and any working examples of your bugs would be even better.

Remember this ISN'T a feature request thread, it's for bugs only.

Any non bug related posts will be removed in an effort to keep this thread simple and easy to follow......

[rohan_pwln]

system.selectFile() is having a bug. It gives an assertion error whenver used. Moreover, can we know the exact purpose of that? Currently, i assume it opens a file dialog box and returns the file path of the file selected.

Edit> martin.deimos
It seems that this is broken somewhere deeper inside the wasabi engine. I think this might have been broken due to the move from wa3 to wa5.

[Plague]

First list from me.. will probably add more later.

• wrap="1" doesn't work in <text/> fields
• regions on components don't work (has been broken since after Wa3 beta3):
  Example: let's say I embed an avs component into my layout and then I want to reshape that component into a circle shape. In Wa3 beta3 and less, I could use a map with the same dimensions as the component and where black (or any other color?) would be where I wanted the component to be visible and transparent would be where I wanted to cut something of the component out.
  The code for how to use that map would then look like this:
  

  <layout id="normal">
    <component param="guid:avs" fitparent="1" id="avs" noshowcmdbar="1"/>
    <script file="regions.maki"/>
  </layout> 

  #include <lib/std.mi>
  System.onScriptLoaded() {
    component avs = getScriptGroup().findObject("avs");
    region r = new region;
    r.loadFromBitmap("avs.map");
    avs.setRegion(r);
  } 

• make statusbars show the statusbar text, without having to manually add a text field (this was done in Wa3, but has never worked in Wa5)
• extern String System.getExtFamily(String ext); returns nothing.
• forcefixed and timecolonwidth only work with time, any other type of text will ignore them
• make timecolonwidth work for _every_ colon in the text, not just the one between minutes and seconds. ie: if I add a colon manually, it should be affected aswell.
• ticker="1" only works for songinfo and songname, any other type of text will just ignore it.

note: Jones, if you feel any of theese aren't to be considered bugs, feel free to remove those.

[rpeterclark]

I have a few to add to the list, I'll make small skins to illustrate the problems. Here's my first one, there seems to be a problem where if you have multiple transparent layers on top of each other, and you have desktop alpha enabled, areas that should be a solid color start to become transparent.

In the attached skin, the white circle should be solid, but I have placed several transparent layers over it and it is now significantly see-through.

[SLoB]

Timer
using shadow="1" on timer text shifts the shadow top left (rather than bottom right), positive/negative x,y values have no affect

time elapsed/remaining has no affected if specified


Gammagroups
gammagroup "Text" is the only gammagroup available for fonts, cannot use another name, has no affect

[Plague]

Originally posted by SLoB
Gammagroups
gammagroup "Text" is the only gammagroup available for fonts, cannot use another name, has no affect

actually not true..
Truetype fonts use color id's, and then you can put gammagroups on the color id's..
<color id="font0.color" value="128,128,128" gammagroup="font0"/>
<text id="font0" font="arial" color="font0.color"/>

Bitmap fonts have a small trick to allow for gammagroups:
<bitmap id="font1" file="font1.png" gammagroup="font1"/>
<bitmapfont id="font1.font" file="font1"/>

this also makes it possible to include a bitmap font into another png, and only use the parts of that png that you want for the specific font.
like so:
<bitmap id="font2" file="fontandotherstuff.png" x="0" y="100" w="100" h="20" gammagroup="font2"/>
<bitmapfont id="font2.font" file="font2"/>

smart eh?

[SLoB]

i realise the stuff with the bitmap fonts

it was more to do with the gammagroup="font0"
on the colour id for true type font, this is the one that doesnt seem to have any affect, well at least on the test skin i had a few minutes play with

[Plague]

well, it works fine in D-Reliction if you check it out.. It's used alot in that skin..

[leechbite]

- getVisBand() gives weird values if right-channel is taken but works fine with the left channel.
System.getVisBand(0, 0); // works
System.getVisBand(1, 0); // not

- <eqvis> does not respond to gammagroups

- object.getID() gives an assertion fault when used with a Container object.

- Layout.onMouseEnterLayout() & Layout.onMouseLeaveLayout() does not respond.

- Browser.onDocumentComplete(String url) is not getting called all the time.

- setClipboardText(String text) does not work. although only very few uses this, it might be good to get it fixed. i think its good for debugging.

- system.selectFile() as mention by rohan already.


can we request for new features? if so, i have a few.

- sound effects.
- system.getScreenResWidth() & system.getScreenResHeight() (getViewPortWidth just not enough sometimes)
- Album Art support. maybe a new guiObject child called <albumart/>

thats all i could remember for now.

[carlosp]

and ofcourse the Gradient xml object like all of has realized.

[Plague]

Originally posted by carlosp
and ofcourse the Gradient xml object like all of has realized.

huh? what about it?
Gradients work fine afaik...
the wasabi.player base skin is full of them, and I've ported that skin to wa5 without any problems..

[rpeterclark]

The problem with the <gradient> element, at least in WA, don't know about WP, is that it doesn't seem to render the gradient in a straight line, even when specified. Check out the attached file. You can't tell at larger sizes, but resized down to a narrow space the miscalculation becomes apparent when hot pink starts showing up.

[Plague]

ah, ok, I know what you mean now.. don't even need to check the file... yea, w.p had that too in tooltips. But that's the only place I've seen it...

[rpeterclark]

Another one I'd like to add, although I'm not sure it ever actually worked, is that the "elementframes" way of using <animatedlayer> is broken. I read about it here and it would have been great for a skin I recently did that had some crazy 500+ frame animation because the filmstip method was getting out of hand and turned out to be a very limiting factor. The attached skin file seems to be correct based on that documentation, but it doesn't do anything.

[Plague]

more bugs from me:
Theese are all about the <playlisteditor/> object and the sidecar.
<PlaylistEditor id="pl.editor" fitparent="1" main="1"/>
<Wasabi:TabSheet id="pl.sidecar" windowtype="plsc" type="2" visible="0"/>

• make <playlisteditor/> objects always show the same playlist as the regular playlist editor if main="1" is defined (it's highly unreliable at the moment and doesn't always show the correct files)
• make pe_add, pe_rem, pe_sel, pe_misc, pe_list and pe_info work with <playlisteditor/> objects
• make the prefs setting for showing numbers in playlist apply in <playlisteditor/> objects aswell, if no columns are set (to override that setting).
• make <playlisteditor/> objects work without having to have a sidecar present (at the moment, a sidecar _must_ be present, positioned right after the editor in the xml code, but doesn't have to be visible, in order for the playlist to show up in the editor)
• make the sidecar tabsheet (windowtype="plsc") list the "playlists" section from the media library
  or maybe make it list the local media section, or maybe both? It's a tabsheet after all..

all of the above, if done, _should_ allow for the creation of a custom playlist editor completely in xml and maki, with pretty much the same functionality as the playlist editor in Winamp3.
plus, since the <playlisteditor/> object supports columns, it would be easy to add a playlist which shows only what you want it to show.


Edit:
Oh yea, btw, I have some skin updates/bugfixes to the default Winamp3 theme, if you're interested in merging them into the one in gen_ff. I originally made them for Wasabi.player but wasabi is wasabi, so they should work just the same in gen_ff.