Winamp Freeform skin engine bug thread

[Benski]

Fixed. Sort of.

The problem is that you're creating it on script load. At that point, the window doesn't exist yet. You need to create it when the main window has loaded. Not sure off the top of my head how to do this (but i'll go ahead and look). I hacked up a quick fix just to make sure things were OK.

code:


#include <lib/std.mi>

Global Timer callback;



System.onScriptLoaded() 

{

  callback = new Timer; callback.setDelay(500); callback.start();

}



callback.onTimer() {

callback.stop();

  component avs = getScriptGroup().findObject("avs");

  region r = new region;

  r.loadFromBitmap("avs.map");

  avs.setRegion(r);



	

}

I set the timer kinda high just to be sure, so it'll take 5 seconds before you notice it.

See attached for image

[Plague]

alright!
good news, cool.

should've known about the startup thing.. stupid me.

this is awesome stuff, been missing regions since Wa3 beta3.

edit:
the issue can be resolved by using

code:


System.onGetCancelComponent(String guid, Boolean goingvisible);

[Benski]

Originally posted by pjn123
Focus bug: When using winamp with a skin with more than one components in a single window the focus of the mouse and keyboard should be what the mouse last clicked. For skins with component/s this should be like this, evering else must be kept as it is at the moment.

PLEASE fix the focus bug because this make SingleUI skins useless.

Can you please elaborate more on the focus bug? Maybe a simple step-by-step example using NMP skin.

[Guest232]

I found a bug that has to do with the replacement of components when you switch to windowshade mode. Windows that are snapped together will remain snapped when one of them is switched to shade mode, at least that's the idea. This doesn't always work well however, mainly with the eq/playlist editor combination.

Step by step reproduction:
- Find a skin with separate player, eq and playlist editor windows, all with shade mode, such as Classix10k or Studiosus.
- Place the player on top, below that the eq, and below that the playlist editor, snapped together. Now you have a pretty standard winamp configuration.
- Start switching the components to shade mode, starting with the player, then the eq, then the playlist editor.
- As soon as the playlist editor is switched to the new mode, the eq will displace to a weird location, sometimes even out of screen when the playlist editor is high enough. The eq will then be automatically placed back in screen, that works fine.

The new location of the eq is not completely random. To get the new position, Winamp takes the bottom of the (for example) eq and the bottom of the playlist editor, and replaces the eq so that the space between the two bottoms remains the same. Unfortunately, the playlist editor has got a new height because it was switched to shade mode and therefore Winamp makes a mistake.

I hope you can do something with my kind of blurry story... Just try it out, I think you'll understand what I mean.

[Cianca]

Originally posted by Benski
Can you please elaborate more on the focus bug? Maybe a simple step-by-step example using NMP skin.

With Nullsoft Media Player 10 skin:

1) Mantain the playlist visible

2) Switch to "Library Mode" from "Video Mode" (or conversely)

3) Select with mouse click an entry on playlist

4) BUG: hit DELETE or Q or any shortcuts with playlist doesn't work


My personal explanation on bug:

Winamp get focus on a component only after a showup event and not with a mouse selection





I hope this has been useful for you

[martin.deimos]

I think the problem is, if u have more then one component in one layout, only one can be focused!
use leechbite's idea of dynamic windows moving with the mainwindow (DUI)

[martin.deimos]

another thing:
I noticed an object called: <Wasabi:PathPicker>
if u use it it shows an editbox with a button for opening an pathselectorbox. But if u click this button winamp crashes!

Has this something to do with this std.mi function:
// extlist should be like "jpeg files|*.jpg|all files|*.*||"
// note the extra | on the end
extern String System.selectFile(String extlist, String id, String prev_filename);

And how can someone use this function?

[SLoB]

virtually any edit box without maki error handling crashes due to blank string

[martin.deimos]

can u try to get <Wasabi:PathPicker>, or the function working?

[krckoorascic]

@Benski:
great job with getLeft/RightVu on 5.2 but standard vis object still always displays stereo level (channel="1" and channel="2" still don't work!)

[Guest232]

I'm not sure where the modern skin wishlist is gone, but since this thread is nice and stickified, I'll post it here.

It would be cool to have the right click menu of classic skins, when you right click on repeat, available in modern skins too as a rightclickaction="repeatmenu" or something like that.

I'd say it's not so hard to do, because the menu already exists and just has to be made available in xml, but I'm not a programmer so I'm not sure about that.

I'm sorry if I shouldn't have posted this here.

[Plague]

I think it should be available without having to put an extra line in the xml, just like the rightclick menus for the C-buttons (play, stop, pause, next, prev).

[Guest232]

Even better

[iPlayTheSpoons]

Originally posted by Benski
Can you please elaborate more on the focus bug? Maybe a simple step-by-step example using NMP skin.

The problem is that if you have more than one component in a single layout (like the Single GUI Skin), clicking on a specific component does not focus it. That is to say, when I have a Media Library and Playlist in the same container, if I click the library, mouse scrolls and key board actions work properly. Unfortunately, if you then click on the playlist, the same mouse scrolls and key board actions still just hit the Library, a majoor problem for single window skins.

On a side note, could we add a way to prevent video being played from resizing the window the video component is in? Thats been another big obstical for the single GUI.

[Benski]

Originally posted by iPlayTheSpoons
On a side note, could we add a way to prevent video being played from resizing the window the video component is in? Thats been another big obstical for the single GUI.

I believe there's a way to override some of the video options in a skin or script. I'll dig through the code and see what I can come up with.