Winamp Freeform skin engine bug thread

[pjn123]

Bug I Demo skin

Use this demo skin to create bug I.

[Logy]

just a curiosity...!

info on the skin tabs (sections)(in preferences) only can access when the skin unzip it that to the folder.... like the winamp skin default! Then it is useless when it is in .wal extension. and what purpose of the preview skin in skin folder... it is something unimplemented features or it is by design!!!
adios!

[Plague]

Originally posted by Plague
found a bug since Winamp 5.2x:
using the Wasabi.player default skin:

http://www.winamp.com/skins/details.php?id=142841

try resizing the playlist editor width.
Winamp will either crash or show a fugly titlebar. The titlebar will only show properly on skin (re)load.

this bug, although reportedly fixed, is still showing parts of it's ugly face.
there are no more crashes, and the gradients aren't ugly as hell on resize anymore...

However.. If you try the wasabi.player skin linked in the quote, and start resizing a window, you'll see how the right side of the titlebar gradient will start to disappear more and more, and after a while only be shown if you make the width of the window very wide.

So, I guess the bug isn't completely fixed after all...

[Plague]

extern Int List.findItem(Any _object); 

doesn't seem to work, it gives me the error message attached.

[martin.deimos]

yep, i know!

there are a few otehr functions that don't work, too!

1) extern String System.selectFile(String extlist, String id, String prev_filename); // could be connected to the bug in <wasabiathpicker> object ...

2) extern GroupList.scrollToPercent(Int percent); // really need this for my nest skin!

AND to the list object:

try to add strings in the list addItem() and then enumItem(0) or another number, and debug the string (msgbox or text) sometimes the returned string is buggy!
perhaps that's the problem that you don't find your item

AND a lil question what purpose has CfgGroup script object??

[Plague]

no, I put real objects in my list, and additem, enumitem, removeitem, getnumitems all work.. it's just finditem that doesn't work..
and the string thing has been well known since early winamp3 days... not that it shouldn't be fixed, ofcourse..

[martin.deimos]

AND a lil question what purpose has CfgGroup script object??
can u answer this for me?

[Plague]

I have no idea, never used it..
However, it looks like it may be a way to either save your own config settings, or perhaps to get system config settings..
Although that area should already be covered with ConfigItems and ConfigAttributes..
But I don't know..

Benski?

[Plague]

extern PopupMenu.disableCommand(int cmd_id, boolean disable); 

doesn't seem to work correctly.
when I try to use it, it behaves exactly like

extern PopupMenu.checkCommand(int cmd_id, boolean check); 

which it should NOT.
it's supposed to grey out the command, not check it, or have I missed something?

[martin.deimos]

yeah, noticed this one too!
i think this is related to the non wasabi menus, which aren't build dynamic. try to delete your menu each time after getting clicked, and the create it new on showing

[Plague]

won't work...
I really need a way to disable a command in the menu.
I have to use a butt ugly hackish crap way for now, but I really want that disableCommand to work.

[martin.deimos]

switcher.onRightButtonUp(int x, int y) {
    menu = new PopUpMenu;
    specmenu = new PopUpMenu;
    oscmenu = new PopUpMenu;
    mirmenu = new PopUpMenu;
    watmenu = new PopUpMenu;
    fxmenu = new PopUpMenu;
    pksmenu = new PopUpMenu;
    anamenu = new PopUpMenu;
    stylemenu = new PopUpMenu;
    fxsourcemenu = new PopUpMenu;

    menu.addCommand("Presets:", 999, 0, 1);
    menu.addCommand("No Visualization", 100, curVis == 0, 0);
    specmenu.addCommand("Thick Bands", 1, curVis == 1, 0);
    specmenu.addCommand("Thin Bands", 2, curVis == 2, 0);
    menu.addSubMenu(specmenu, "Spectrum Analyzer");

    oscmenu.addCommand("Solid", 3, curVis == 3, 0);
    oscmenu.addCommand("Dots", 4, curVis == 4, 0);
    oscmenu.addCommand("Lines", 5, curVis == 5, 0);
    menu.addSubMenu(oscmenu, "Oscilloscope");

    mirmenu.addCommand("Thick Analyzer", 6, curVis == 6, 0);
    mirmenu.addCommand("Thin Analyzer", 7, curVis == 7, 0);
    mirmenu.addSeparator();
    mirmenu.addCommand("Oscilloscope", 8, curVis == 8, 0);
    menu.addSubMenu(mirmenu, "Mirrored");

    watmenu.addCommand("Thick Analyzer", 9, curVis == 9, 0);
    watmenu.addCommand("Thin Analyzer", 10, curVis == 10, 0);
    watmenu.addSeparator();
    watmenu.addCommand("Oscilloscope", 11, curVis == 11, 0);
    menu.addSubMenu(watmenu, "Water Reflection");

    fxsourcemenu.addCommand("Spectrum Analyzer", 501, vis_fx_spec_attrib.getData() == "1", 0);
    fxsourcemenu.addCommand("Oscilloscope", 502, vis_fx_osc_attrib.getData() == "1", 0);

    fxmenu.addCommand("Cross", 12, curVis == 12, 0);
    fxmenu.addCommand("Beat Cross", 13, curVis == 13, 0);
    fxmenu.addCommand("Cross goes crazy", 14, curVis == 14, 0);
    fxmenu.addCommand("Ant on drugs", 15, curVis == 15, 0);
    fxmenu.addSeparator();
    fxmenu.addSubMenu(fxsourcemenu, "layer Fx Source");
    menu.addSubMenu(fxmenu, "layer Fx");

    menu.addSeparator();
    menu.addCommand("Options:", 102, 0, 1);
    menu.addCommand("Show Peaks", 101, stringToInteger(vis_peaks_attrib.getData()), 0);
    pksmenu.addCommand("0", 200, vis_peaksfalloff_attrib.getData() == "0", 0);
    pksmenu.addCommand("1", 201, vis_peaksfalloff_attrib.getData() == "1", 0);
    pksmenu.addCommand("2", 202, vis_peaksfalloff_attrib.getData() == "2", 0);
    pksmenu.addCommand("3", 203, vis_peaksfalloff_attrib.getData() == "3", 0);
    pksmenu.addCommand("4", 204, vis_peaksfalloff_attrib.getData() == "4", 0);
    menu.addSubMenu(pksmenu, "Peak Falloff Speed");
    anamenu.addCommand("0 ", 300, vis_analyzerfalloff_attrib.getData() == "0", 0);
    anamenu.addCommand("1 ", 301, vis_analyzerfalloff_attrib.getData() == "1", 0);
    anamenu.addCommand("2 ", 302, vis_analyzerfalloff_attrib.getData() == "2", 0);
    anamenu.addCommand("3 ", 303, vis_analyzerfalloff_attrib.getData() == "3", 0);
    anamenu.addCommand("4 ", 304, vis_analyzerfalloff_attrib.getData() == "4", 0);
    menu.addSubMenu(anamenu, "Analyzer Falloff Speed");
    stylemenu.addCommand("Full", 400, vis_analyzerstyle_attrib.getData() == "0", 0);
    stylemenu.addCommand("Gradient", 401, vis_analyzerstyle_attrib.getData() == "1", 0);
    stylemenu.addCommand("Fire", 402, vis_analyzerstyle_attrib.getData() == "2", 0);
    stylemenu.addCommand("Line", 403, vis_analyzerstyle_attrib.getData() == "3", 0);
    menu.addSubMenu(stylemenu, "Analyzer Style");
    menu.addSubMenu(fxsourcemenu, "layer Fx Source");

    ProcessMenuResult(menu.popAtMouse());

    delete menu;
    delete specmenu;
    delete oscmenu;
    delete mirmenu;
    delete pksmenu;
    delete anamenu;

    complete;
} 

try it this way!

[Plague]

what good will that do me?
I still can't disable the commands I want disabled..
And I don't really wanna remove an item entirely when it's supposed to only be disabled, it can confuse the user into thinking that it won't ever be available.

[martin.deimos]

but you will create a new popup menu each time the button is pressed! so you can determine on the fly if you wanna disable the command! check it out, i'm 80% sure that ot will help you!

[Plague]

yea, well, thing is, I have multiple checks that could all trigger a command to be disabled, so if I use addcommand and disable it right from the get go, it will create a new disabled item for each triggered check.
so I might end up with like 5 items of the same thing..