Plague's wasabi freeform engine bugs and wishes

[Plague]

I'm gonna list both bugs and some wishes here that I come across when working on my projects.
Since the bugreport thread is full of non bug posts despite the fact that it should only contain bugreports and nothing else, not even wishes..

Most of theese bugs and wishes are showstoppers for me and are hindering me from finishing big projects I've worked on off-and-on for many years.

This is the current list, more might come at a later time.

VERY high priority for me:

• wrap="1" doesn't work in <text/> fields
• extern String System.getExtFamily(String ext); returns nothing.
• make ticker="1" work for every kind of text, not just songinfo and songname
• action="PAN" has weird behaviour in a vertical slider (thumb jumps to 200% and disappears when you drag it to the center) > fixed in 5.52
• slider thumbs aren't resized if I change the size of the slider, only the background is. I want everything in the slider object to scale proportionally to whatever size I give it, not just the background.
• extern PopupMenu.disableCommand(int cmd_id, boolean disable); doesn't work
• lists and historyeditboxes always show the columnheader! should not unless specified!
• <PlEditDirectory/> and the sidecar tabsheet (windowtype="plsc") don't have the rightclick menu as the ML PlEdits view has
• make pledit and JTFE have wasabi scrollbars in modern skins, similarily to how the ML finally does it.
• make it possible to hook into JTFE functionality via XML/Maki, for example, make it possible to add/delete items to the queue list aswell as manage the list and show the list, from XML/Maki, without having to show the entire JTFE window
• add extern PlEdit.selectTrack(int item); //think this is already happening
• add extern PlEdit.playTrack(int item); //think this is already happening

HUGE playlist wishes:
Instead of hacking together all theese features on top of the regular pledit without breaking classic skins/plugins, why not just do the below as something optional for skinners?
If done right, no plugins should be affected, right?
The wasabi <PlaylistEditor/> is MUCH better than the Winamp2 pledit.

So pretty please, with sugar on top?

• <PlaylistEditor id="pl.editor" fitparent="1" main="1"/>
  <Wasabi:TabSheet id="pl.sidecar" windowtype="plsc" type="2" visible="0"/>
  
• <PlaylistEditor id="pl.editor" fitparent="1" main="1"/> no longer automatically lists the playlist in use, even if the sidecar is present. you have to manually select it in the sidecar, demanding the sidecar to be visible now, which it didn't have to be before, and it even looses the list on skin refresh, so you need to reselect the list in the sidecar which also causes the player to restart playing the list.
• the <PlaylistEditor/> also won't visually change the selection on the current playing item until you hover the mouse over it and even then, it won't scroll the list to where the new selection is.
  
  solve the two above by a redesign of the object into what I suggest below:
  
• make <PlaylistEditor/> like <PlEditDirectory/> if main="1", in the sense that it simply reflects EXACTLY what the regular pledit does, sorta like a clone or mirror if you will
• make <PlaylistEditor/> share all the menus, button actions (for example: pe_add, pe_rem, pe_sel, pe_misc, pe_list), commands (for example: pe_info), etc that the regular pledit has
• make columns work again in <PlaylistEditor/> (example: columns="Name,-1;Album,120;Length,35,1") (they are broken atm), and if columns are used, maybe the prefs setting for showing playlist item numbers should be ignored/overridden.
• make <PlaylistEditor/> and <PlEditDirectory/> objects behave like any other object and not components, so they can support desktopalpha, etc.

less important bugs/wishes:

• fix multiline="1" for wasabi:editbox (works in regular edit)
• fix editbox scrollbar so it's skinned (ie: make the editbox wasabi, not OS)
• make forcefixed and timecolonwidth work with every kind of text, not just time
• make timecolonwidth work for EVERY colon in the text, not just the one between minutes and seconds. ie: if I add a colon manually, it should be affected aswell.
• textfields wishlist: add scalability to fontsize (relatfontsize="1"), add vertical="1" (for vertical text)
• would love for a PAN/BALANCE maki command

Edit - Small Correction:

Seems like I got my priorities mixed up in my original list so here are some minor corrections..

Theese three are by me considered only semi-high priorities, however they have all been there for ages so it would be nice to finally have 'em fixed.
I also corrected getExtFamily, as it actually does return something theese days, it just doesn't return the right thing.

• wrap="1" doesn't work in <text/> fields, all it seemingly does is take away the ability to manually scroll the text by click+drag
• extern String System.getExtFamily(String ext); returns same as String System.getDecoderName(string playitem); which it shouldn't.
• make ticker="1" work for every kind of text, not just songinfo and songname //this one actually works if you set display="songname" on the text and then reset the text to what you want, however it only seem to start scrolling after you've started playing a song plus you shouldn't have to do it that way as I imagine it makes things slower aswell as potentionally showing the songname for a splitsecond everynow and then

edit:
also found another bug as it seems

• display="songinfo" in a textfield shows the songtitle on skinrefresh, but after you start playing the song it switches to showing the actual info it should

[E-Trance]

[Fixed] MenuButton cannot be accesed from MAKI

Although class MenuButton is in std.mi it cannot be accesed from MAKI. For example we have a group containing 5 "Menu" objects, one "Button" object and a script object. The script is used to test the bug. Here it is:

System.onScriptLoaded() {
  group scgroup = getScriptGroup();
  // Displays number of objects in the group:
  MessageBox(integertostring(scgroup.GetNumObjects()),"",0,"");
  // Trying to get "Menu":
  guiobject s = scgroup.enumObject(0);
  // Did we get "Menu"? No, we didn't. Will indicate TRUE:
  MessageBox(integertostring(s == NULL),"",0,"");
  // Trying to get "Button":
  s = scgroup.enumObject(5);
  // Did we get "Button"? Yes, we did. Will indicate FALSE:
  MessageBox(integertostring(s == NULL),"",0,"");
  /* So why we couldn't get a "Menu" object?*/
} 

The first MessageBox will show that there are 7 objects in the group (5 menus, 1 button and a script). Then the second msgbox should indicate 0 (because there definitely is an object - the "Menu" object). But it shows 1 - so enumObject didn't work. <<< Here is a bug. The third msgbox is to show that anything is allright - it shows 0 because "Button" isn't NULL. That's all.
P.S. The same when trying to use getObject()

Edit> martin.deimos:
this is fixed for 5.52.
there was already a script object called menu for the wa5 menu button - it just wasn't linked to the script objecttable.
here is the functionslist that was already present:

extern Menu.setMenuGroup(String groupId);
extern String Menu.getMenuGroup();
extern Menu.setMenu(String menuId);
extern String Menu.getMenu();
extern Menu.spawnMenu(int monitor);
extern Menu.cancelMenu();
extern Menu.setNormalId(String id);
extern Menu.setDownId(String id);
extern Menu.setHoverId(String id);
extern Menu.onOpenMenu();
extern Menu.onCloseMenu();
extern Menu.nextMenu();
extern Menu.previousMenu(); 

[Plague]

Don't wanna mess up this thread with alot of unneccesary discussion posts so I'll try and keep it short and to the point.

Originally posted by CraigF
I was planning on stickying this thread as a new definitive list thread (without discussion), but I think the addition of wishlist items means it will need refactoring.

yea I realise that, however most of my wishes can be considered bugreports aswell, since they apply to existing things that simply don't work as they should or at all (example: <playlisteditor/>). The very few wishes I have that are totally new stuff (example: vertical text) could perhaps be sorted out from here and be put somewhere else.
Or we could just keep it as-is in it's own thread, linked to the regular thread (as it currently is), both is fine by me.
pm me (so we don't clutter this up further) if you want any changes from how things currently are.

Edit> martin.deimos
Therefore I've deleted Craig's post and your second one (merged into post#1) - and i will insert edits, when something gets fixed etc.

[pjn123]

REPORT #0004

Wasabi:Browser

<Wasabi:Browser/> 

• XUi param for default homepage. > will be included in wa 5.52
• Media Monitor must clip close if the height is to small
• Change language to text so that the translations can change it for all skins > nope
• Play/Download/rescan must hide when obect width is to small
• Editboxes must hide when object is to small

Wasabi:Editbox

<Wasabi:Editbox/> 

• Must hide itself when the parent is to small for this object

Layout

<layout id="normal" minimum_w="317" minimum_h="168" maximum_w="@monitorW@" maximum_h="@monitorH@"> 

• Please add those maximum_w&h stuff to limit the skin to the user screen. Can also just add a maxtomon="1" param
• BUG The minimum_w&h isnt always respected. I use .resize() on the layout for the live resize code in classicPro, but sometimes these minimum params is just ignored and its then posible to resize the skin past these minimum values. Please fix this bug

Color Elements

<elements>
    <color id="xxx.xxxx" value="199,201,207"/>
</elements> 

• Please add a maki function to change a certain color element.
• If this is done, we can make a editable picture of the ml&pl that the skinner can just change to set all the colors of the different color elements of the skin. Would also be usefull for classicPro

Winamp Installer Requist

• Ask on install if the installer must delete the studio.xnf file.
• Add a Winamp option in the prefs to delete this file and load again.

**Theres probably more(was only planning on posting the wasabi:browser one but was on a role).. so might post them on another day

[SOOPRcow]

I haven't worked on a winamp modern skin in quite some time but bellow are a couple things I could come up with..

display="songbitrate" seems to be updating every time the bitrate changes on VBR mp3 (not sure with other formats) files to the point where it looks like a blur. Be nice if this was toned down a bit. Note, this hasn't always been a problem it seems it was changed at some point.

display="songname" Be nice if this could show the current track number like one sees when they are using a winamp classic skin.

I'm sure I'll think of more things at some point.

[Plague]

Originally posted by SOOPRcow
display="songname" Be nice if this could show the current track number like one sees when they are using a winamp classic skin.

Maybe make it a param, like showlen="1"?

Also, this missing feature applies to the new <songticker/> object aswell..

[DrO]

you're lucky classic skins still even show the track number as it was initially removed in the 5.5 dev releases. and none of the jtfe related options are ever likely to happen (especially since i'm considering dropping all support of the plugin).

-daz

[SLoB]

Originally posted by SOOPRcow
I haven't worked on a winamp modern skin in quite some time but bellow are a couple things I could come up with..

display="songbitrate" seems to be updating every time the bitrate changes on VBR mp3 (not sure with other formats) files to the point where it looks like a blur. Be nice if this was toned down a bit. Note, this hasn't always been a problem it seems it was changed at some point.

display="songname" Be nice if this could show the current track number like one sees when they are using a winamp classic skin.

I'm sure I'll think of more things at some point.

not to clutter this thread but

songbitrate

try Prefs, Input, in_mp3.dll, configure, decoder tab, misc options, check "Show average bitrate on VBR files" job done

should be checked by default tho!

[Plague]

Originally posted by DrO
you're lucky classic skins still even show the track number as it was initially removed in the 5.5 dev releases. and none of the jtfe related options are ever likely to happen (especially since i'm considering dropping all support of the plugin).

-daz

ookey? So if you're dropping support of the plugin, what's the plan with the enqueue feature? Will it be incorporated into regular playlist editing stuff or will it be dropped entirely or what?

I don't care _where_ the enqueue feature is, aslong as it's part of the core player package, and not a 3rd party plugin.
And then ofcourse have it exposed to xml/maki.

[SOOPRcow]

Originally posted by SLoB
try Prefs, Input, in_mp3.dll, configure, decoder tab, misc options, check "Show average bitrate on VBR files" job done

I'm well aware of show average bitrate. Even if it was enabled by default people would still be able to turn it off and would thus see the bitrate update every time the bitrate of the mp3 chunk changes.

[pjn123]

AlbumArt

- Requist for a param that disables the resize of the no cover image. Must only resize the nocover image smaller... not bigger.

[martin.deimos]

some fixes for 5.52:
-- made <Winamp:Browser/> respect a home="" param
-- fixed vScrollbars will work now with hotpos="" param (also the pan slider)

btw, did you know there are objects like
<PanBar/>
<EqBand/>
<EQPreAmp/>
<VolBar/>
<SeekBar/> w/ additional option for an updateinterval < 20 sec (INTERVAL=20)
and have you ever used them?! perhaps we will delete them if they aren't used to make skins faster

[Plague]

knew about the objects, been using them everywhere, did not know about (or atleast haven't used afaik) the updateinterval option though..

[pjn123]

antialias

antialias param:

Would like to see this added:
antialias=0 no antialias
antialias=1 always antialias
antialias=2 windows setting(just like the playlist/ml)

[pjn123]

Media Library
- Start using the hover button state if skinversion is > 1.3x

List object
- I want to set the background to a transparent pic… but atm if its transparent it will show a black bg.
- Maybe a param that stretch the bg (atm its tiled)

Playlist & Ml
- Maybe make all skins from version 1.3x use bitmaps for bg.. the one color bg's is getting a little old

Wasabi:TabSheet
- Major rewrite
> Hover states
> Moveable tabs
> Resizable tab text if area get to small (similar to ClassicPro)
> ontabrightclick(int tabNo)
> be able to add tabs in realtime(this would work nice if the plugins can open via guids and we can get their names)
- The events passed on must also be more reliable… when I was busy with cpro I was going to use this object, but some of the functions just didn’t return honest answers. For example.. cant remember 100% but I would check if tabX is openned and it return yes but then its already closed.

Wasabi:Frame
- Just continue what your doing martin

Layout
- Option param to dock this layout inside the windows taskbar
- indesktop=”” is nice…:
- How about a param that will make this layout click events be passed through to the desktop.. or anything under the window. You get a few aps that allows this.