Why does this crash Winamp?

[ariszlo]

The Vortex skin used to work well up until Winamp 5.55 but its draw_r.maki crashes Winamp since Winamp 5.551. What is wrong with draw_r.maki? What makes Winamp crash?

[ariszlo]

Here it is zipped.

[ariszlo]

With a lucky guess, I could fix the crashes. The culprit was this line:

pulseback.setDelay(0.1); 

Increasing the delay to 0.5 fixed it.

effectCore.m also had that line crashing Winamp when Speaker Covers were turned on.

Will you test vortex-fixing.wal, please, if the crashes are really fixed?

The skin is not ready to release yet. It still has some no longer functional features to clean up (like checking updates at web sites which went down years ago).

[PeterK.]

With a lucky guess, I could fix the crashes. The culprit was this line:

pulseback.setDelay(0.1); 

Increasing the delay to 0.5 fixed it.

I would have said: change the delay value from 0.1 to 100 since these are milliseconds and are represented by integer - according to the latest skin version 1.36.

[ariszlo]

I tried that but it stuck the right drawer.

[PeterK.]

I tried that but it stuck the right drawer.

Really? No problems here

[ariszlo]

Did you also change both instances of this:

Grp.SetTargetSpeed(0.5); 

to this?

Grp.SetTargetSpeed(500); 

[PeterK.]

Did you also change both instances of this:

Grp.SetTargetSpeed(0.5); 

to this?

Grp.SetTargetSpeed(500); 

Do not change this.

0.5 means half of a second and is a correct value for Grp.setTargetSpeed(). 500 would mean 500 seconds here.

[ariszlo]

So delays are counted in milliseconds and speed in seconds. I see. Thank you.

[PeterK.]

So delays are counted in milliseconds and speed in seconds. I see. Thank you.

Yes.

code:
Timer.setDelay(int millisec);

GuiObject.setTargetSpeed(float second);

P.S. Did you get an error message while compiling the draw_r.m file?
P.S.2. I think you can delete the files Kopie von dashboard.m and Kopie von dashboard.maki. Someone must have copied and compiled this file for a reason (while updating the skin) but forgot to remove them in the end.

[ariszlo]

P.S. Did you get an error message while compiling the draw_r.m file?

No, I didn't. Did you?

P.S.2. I think you can delete the files Kopie von dashboard.m and Kopie von dashboard.maki. Someone must have copied and compiled this file for a reason (while updating the skin) but forgot to remove them in the end.

Thanks. I have already deleted them while doing some cleanup.

[PeterK.]

No, I didn't. Did you?

Yep, compiler comlains about the line light=main.getObject("lights"); which according to the newest skin version should be light=main.findObject("lights");.

getObject : not an member function nor an event of class 'Layout' at draw_r.m:41 [32] :

Are we not using the same WaSD version? Mine is WaSDP_1.14.

[ariszlo]

I believe I have the same version as you do. At least, the files have the same timestamps. I might have installed it years ago on another machine using WaSDP_1.14.exe but recently I have been installing it by copying the contents of the attached zip archive into Winamp's directory. In addition to what WaSDP_1.14.exe installs, the attached zip archive also contains nscrt.dll, quickPlaylist.mi and cprowidget.mi.

[ariszlo]

This is where I am now: vortex-fixing.zip

The zip contains two versions of the skin: Vortex-CoverArt.wal is more faithful to the original and Vortex-AlbumArt.wal is more usable imho. CoverArt is less functional these days as it used to be but there might still be some users who like to put a coverart.jpg into each of their music subdirectories and watch the picture while listening to music.

Originally, I wanted to replace the notifer for Vortex-AlbumArt but gave up because it would require to recompile a lot of maki's, including some that do not have source m's. So what I did was set the value of the "Display Album Art" attribute to 0 in attribs.m and recompiled loadattribs.maki.

In config/configpages, I replaced several urls with Internet Archive links.

[ariszlo]

Yep, compiler comlains about the line light=main.getObject("lights"); which according to the newest skin version should be light=main.findObject("lights");.

This is how mc.exe compiles draw_r.maki in my Windows XP 5.1 VMware machine:

..\..\..\mc.exe draw_r.m
MC - Maki Compiler v1.2.0
(c)2001-2006, Nullsoft Inc.

Preprocessing...
OK: 95 macro expansions, 136659 bytes, 4280 lines, 4 files
Compiling... OK
Writing Winamp 5.66 (skin version 1.36) binary... OK

draw_r.m (4278 loc) was compiled to draw_r.maki (16890 bytes) in 234 ms

Tested the compiled binary both with Winamp 5.666 in VMware and 5.8 beta in Windows 10.