How ?

[parisienne17]

Yep sorry, I've just thought to the nocover thing.. So I've resized it et voilà !
;.)
(unfortunately the mod won't allow post 180mns editing and you've already replied, so...)


I'm gonna tweak Prev/play/pause/forward then I'll be heading to playlist/medialibrary and colors as the white on light grey of menus is...Beurk.

[parisienne17]

Even if I"m way behind it, I'm wondering about how free form skins are done.
Is the transparency the clipping or is there another coordinates system like image map in html ?

And this one : how one implements menu commands in winamp (I'm thinking about switching between modes : main player, the actual one, a compact one and a tiny minimal one)

[ariszlo]

I'm quite busy this week. I will answer your questions later. Meanwhile, here's a skin for you to learn skinning the other windows.

[parisienne17]

That's strange : AVS won't run anymore inside the container.
If I right click in the player "visualisation/select plug-in" then choose "AVS/start", it starts in a separate windows.

I thought of a transparency hicup so I passed coordinates and sizes allowing a 5 pixels gap around the container inside the player, it didn't matter.

[ariszlo]

It may happen sometimes. Switch to Winamp Modern and see if it runs attached to the main window or in a separate window. If it runs in a separate window then click on Reattach Visualizer and then you can switch back to your own skin.

It may also fix it if you turn off AVS with the albumart/vis button and then click on the button again.

[parisienne17]

No issue there !

About my previous comment there isn't a 'real' issue : selecting the visualisation plug-in THEN clicking the button starts the proprer visualisation.

It's starting it from the options panel that starts it oursde the container.

[parisienne17]

Sometimes I'd pull of my hairs from my head !

I took a look at the sudy skinning skin you provided me. In some-colors.xml I've changed these lines

<!-- These are self-explanatory: -->
<color id="wasabi.list.text.current" value="255,255,255"/> <!-- Playing song text color -->
<color id="wasabi.list.text.selected.background" value="255,0,0"/> <!-- selection bar color  -->
<color id="wasabi.list.text" value="140,140,140" gammagroup="Text"/> <!-- normal text color --> 

refresh the player --> I got the right colors

So in my skin in skin.xml I add

<include file="xml/some-colors.xml/> 

refresh the player --> wrong colors

I put 2 files included in your skin.xml (standardframe.xml & pledit.xml) and include them in skin.xml, refresh the player --> wrong colors.

Maybe I'd go plant some carrots !

[ariszlo]

refresh the player --> I got the right colors

So in my skin in skin.xml I add

code:
<include file="xml/some-colors.xml/>

refresh the player --> wrong colors

Add the missing endquote:

<include file="xml/some-colors.xml"/> 

You are basing your skin on very old skins which lack several elements required by recent versions of Winamp. You might want to have a look at this thread: Fixing old freeform skins.

But first of all you should fix the background and foreground colors for the right-click menu and the window areas outside listview. Since you prefer light text on a dark background, I would darken the backgrounds and lighten the text colors by defining the colors for them like this:

<color id="wasabi.window.background" value="102,102,118"/>
<color id="wasabi.window.text" value="255,255,255"/ 

Maybe I'd go plant some carrots !

Well, Poirot intended to grow vegetable marrows after his retirement.

[parisienne17]

Add the missing endquote

Arggg... Unfortunately 10% left of my eyesight tends to me loosing things... But back to check it was a misspell, quote is in place..

And adding

<color id="wasabi.window.background" value="102,102,118"/>
<color id="wasabi.window.text" value="255,255,255"/ 

doesn't do a thing.

I thought that hiden dependencies might matter, so I've copied the png folder : I get the skinned playlist/medialibrary but wrong colors.

[ariszlo]

doesn't do a thing.

My bad. Add the missing > at the end:

<color id="wasabi.window.text" value="255,255,255"/> 

I get the skinned playlist/medialibrary but wrong colors.

You can recolor the png's as you like. All you need is an image editor.

[parisienne17]

My bad, this one was effectively missing, oddly I didn't got an error running the skin.

I took a look at the system-colors.xml you mentionned. With no more luck. I'm loosing my latin as we say in french.

I have these ones in my skin system-colors.xml called at the 1st line of skin.xml

  <color id="wasabi.list.text.current" value="255,255,255"/>                                                                                     <!-- Playing song text color -->
  <color id="wasabi.list.text.selected.background" value="255,0,0"/>                                                                     <!-- selection bar color  -->
  <color id="wasabi.list.text" value="140,140,140" gammagroup="Text"/>                                                                 <!-- normal text color -->
  <color id="wasabi.list.column.text" value="140,140,140" gammagroup="Text"/>                                                 <!-- Columns text color -->
  <color id="wasabi.list.item.selected.fg" value="255,0,0" gammagroup="Text"/>                                                 <!-- Selected item text foreground color -->
  <color id="wasabi.list.column.separator" value="0,0,0"  gammagroup="Backgrounds"/>                                     <!-- Color of line between columns -->
  <color id="wasabi.itemlist.outline.current" value="255,0,0"/>                                                                             <!-- Currently playing outline color -->
  <color id="wasabi.textBar.text" value="255,0,0" gammagroup="Text"/>                                                                 <!-- Text object & message box text color -->
  <color id="wasabi.textBar.background" value="255,0,0" gammagroup="Text Backgrounds"/>                             <!-- Text object & message box text background color -->
    <color id="wasabi.list.text.selected" value="0,0,255" gammagroup="Text"/>                                                   <!-- from wasabi.list.item.selected.fg -->

<!-- Buttons -->
  <color id="wasabi.button.text" value="255,0,0" gammagroup="Text"/>                                                                     <!-- Buttons text color -->
  <color id="wasabi.button.hiliteText" value="0,240,0" gammagroup="Text"/>                                                         <!-- Buttons hilite text color, used by tab windows-->
  <color id="wasabi.button.dimmedText" value="64,64,64" gammagroup="Text"/>                                                     <!-- Buttons dimmed text color, when disabled -->
  <color id="wasabi.text.color" value="255,0,0" gammagroup="Text"/>
  <color id="wasabi.text.color.inverse" value="0,0,0" gammagroup="Text Inverse"/>

      <color id="wasabi.tree.text" value="255,0,0" gammagroup="Text"/>                                                                     <!-- Item text color ??? -->
      <color id="wasabi.tree.hiliteddrop" value="0,0,0"/>                                                                                         <!-- Drop marker color ??? -->

<color id="wasabi.window.background" value="102,102,118"/>
<color id="wasabi.window.text" value="255,255,255"/> 

and none of the colors changed. I even picked up winamp modern's system.colors.xml without anymore luck.

[ariszlo]

I have these ones in my skin system-colors.xml called at the 1st line of skin.xml

Do you mean the first line right after </skininfo>? The closing tag </skininfo>, not the opening tag <skininfo>.

[ariszlo]

and none of the colors changed.

I copied all your color definitions into this file and Winamp displays all your colors as they are defined. Is your system-colors.xml any different from this?

[parisienne17]

Do you mean the first line right after </skininfo>? The closing tag </skininfo>, not the opening tag <skininfo>.

Yes of course, the 1st line after the closing tag </skininfo>.

I did try with my 1st attempt of striping down existing skins and copy relevant parts in a new one --> wrong colors.

So I tried with beautiful simplicity skin and the rignt colors are showing. So I've checked all opening/closing tags/labels without finding any errors.


There's defintely something wrong in my skin... Is it possible that I have an issue with hidden characters, like CTRL-(I don"t know what) in xml files ?

[parisienne17]

Even if I wasn't sure of the result, I did :

1. Create a new skin folder
2. Copied/pasted from xml's of the previous skin to new files, then save them
3. copied the associated folders/ressources (player, scripts, etc...)

And ran it... still wrong colors.

Here are the files, maybe you'll see what I can't.
https://we.tl/t-Z6f7tbwXAR