AVS fails to work [Trying to fix with v2.91 TEST #1]

[DrO]

can reproduce a crash with the 'Inverse Eruption' preset though it's not liking it when i run it under the debugger so will need to find out why it's struggling to deal with the exception.

just tried the intro preset from the second one and that's a hell of a difference in output between this one and 2.81d (yet all i've ever seen is complaints but never anything to show what is going wrong). have attached a screenshot of 2.81d (left) and my 2.91 (right).

will investigate further on both as time allows in the coming days.

-daz

[QOAL]

I've found a crash with Synth-C's Lift Off pack. Inverse Eruption is the first preset in the pack that seems to trigger it when navigating away.

I suppose it's worth asking about the Dynamic Movement too.
I came across many presets that render incorrectly which seems to be down the DM.
An example could be the intro preset for Unconed's Final Whack.

Edit: Thanks again for your work

[DrO]

v2.91 TEST #1
To install, download the attachment and extract vis_avs.dll into your Winamp\Plugins folder (if you prefer you can rename it to something else before installing or rename the existing vis_avs.dll).

Note: This depends on MSVCR90.DLL so needs to be used with a recent version of Winamp (i can hear the complaints about that already) but this is how all of the official plug-ins are done.


This is my test build (obviously the fullscreen stuff is still borked like all of the other versions on Vista and up) and is the CHAVS 2.9 code combined with the 2.81d changes and then my 'fixes' (so is back to 2.81b as a base with updates and anything i changed in 2.82/2.83 is not part of this).

This should fix the random GVM related crash (we're catching the error instead of failing)
Other crash fixes as i've come across in my tinkerings
Version resource is correct for this version
rand() seems to work as expected now (could do with confirmation)
Indicates the current preset in the right-click menu


If there are issues, will need to know the specific preset (attached to the thread if needed) and any useful information. Otherwise it's basically fullscreen mode that's the main breakage but that's more down to using DirectDraw instead of Direct3D for the overlays etc.

-daz

[QOAL]

Thank you very much for spending your time on this DrO. (I hope it hasn't been too much of a chore to get to this point)
News of the crash fixes alone is very welcome.

I'm surprised Yathosho (or even people from #avs) haven't voiced their opinion on this yet though.

I know it's a long shot (considering the source code for many apes has been lost), but is it worth trying to contact the convolution.ape author? This is their forum account.

[Warrior of the Light]

I posted a journal on my dA page hoping for more replies.
I think that most could live without a working overlay mode.

If only things were better commented.

[DrO]

i think i'm just going to have to put in a block on loading convolution.ape on non-XP installs as i just cannot work out what on earth it's doing which makes it fail on Windows 7 and not XP (unlike http://forums.shoutcast.com/showpost...60&postcount=8 implied which is not the case from my testing with my build on the different OSes).

not an ideal solution but it at least means it's possible to indicate the issue visually without causing things to crash, etc until a solution can be created (as this has to be an issue with that ape specifically on newer OSes as i'd have to expect it not to work on XP if it was specifically due to the AVS version).

and i've updated my post higher up with the status of the 'issues' i'd listed so that some are now classed as done. really the killer seems to be the whole fullscreen/overlay modes being borked now as i've not had a crash in a while (ignoring when i'm allowing convolution.ape to crash). might even consider uploading a test version in the coming week or two...

-daz

[DrO]

i spent more time than i should have trying to figure out the convolver crash and it just seems like that ape really doesn't like newer versions of Windows as i've made sure that the sent data to it is the same between the different versions (only thing might be due to how DirectDraw surfaces are handled between XP and Win7 but i cannot tell anything from the limited crash details i get).

so other than trying to find source code (doubtful) or decompiling it to work out what's going on (painful), i'm not sure what can be done other than looking for a replacement / writing one myself (that'll be fun, not).

-daz

[DrO]

i've had a bit of a look and it's a crash in that ape though the crash location doesn't give me anything useful to work against - it doesn't show as an actual crash unless you 'Disable SEH for effects' on the debug window. though when i try on XP it works ok, which makes me wonder if it's something with the memory handling which is causing the issue.

so will have a bit more of a look tonight as i wouldn't be surprised if it's something simple causing it (like most of the AVS crash issues, heh). otherwise won't be tinkering with it until late next week (or this week as it now seems to be based on the time).

-daz

[Warrior of the Light]

[edit]
so the convolution filter comes from convolution.ape i assume?

Personally, I've never been too confident on that issue. There's one built-in and a separate .ape which originates (I think) from before when it was integrated with AVS.
Same goes for the video delay ape and some other ape's. (I'm on my laptop and it's 2 am now so I can't check which ones exactly). I get duplicates in my list and adding 'the wrong one' crashes AVS.

I personally try to just not install the extra ones, but maybe someone else has a better idea. I'm just a user, and really not a programmer who'd know about how things work internally.

[DrO]

ok, just tried the GVM example from above and with 2.82 (2.81d or 2.83 won't run for me on my dev machine) and i get a reasonably consistent crash when transitioning away from the preset.

using my build with some extra exception handling on where the crash appears to be triggered, the GVM error still happens but AVS keeps going (i just get the odd 'beep' due to how i'm testing for it when forcing it to go through all of the presets quickly).


and just had a look at the other ones and #3 shows the issue the best i think (moving blob which should have blurred edges - when comparing 2.82 vs 2.81d on XP) .

[edit]
so the convolution filter comes from convolution.ape i assume?

-daz

[DrO]

well from what i've seen (haven't tried with the examples) is GVM only crashed when there was a preset transition due to an issue in HeapFree(..) (so some form of memory freeing issue which could be just down to AVS built with a different compiler and abi differences).

i've still to try it out but some extra exception handling in AVS during that phase should help resolve the crash issue.



my main thing from friday night and a few hours today) has been looking into not being able to use AVS in full-screen or overlay modes and if anything, it's looking like trying to move over to use Direct3D instead of DirectDraw to be able to do what's needed (seeing as the DirectDraw interface has been legacy since Vista).

alas i need to read up on that as it's not a simple change from what i've taken in so far (and i could probably do something with re-using Milkdrop's code but that's one heck of a beast to combine into AVS when i don't think most of it's functionality is needed (i.e. just need enough to get the generated frames onto the screen - i believe a Direct3D Surface may be what's needed since we've using DirectDraw Surfaces already).

-daz

[Warrior of the Light]

First off, thank you very much for still wanting to fix this beast. I mean it.

The convolution filter is like a custom blur filter. It works per pixel and can copy that pixel to (or remove from) the surrounding pixels.

The GVM is a variable manager. I added example presets for both effects. The GVM has a help window if you hit the [?] in the bottom right of the window. I remember that Jheriko lost the sourcecode for it, but I'm confident he'll help you if you have specific questions.

[DrO]

i'd really need examples or something specific to know what to look at / attempt to fix as i've no idea what the expected behaviour of the convolution filter or what uses the gvm ape to target testing / fixes for it.

-daz

[QOAL]

In case anyone is looking for the chavs source:

http://1014.org/shiz/code/chavs.zip -- git clone WDL from http://cockos.com/wdl too, it has the latest EEL (which chavs needs).

From: https://twitter.com/JustinFrankel/st...02381790334976




The convolution filter doesn't work in chavs (but I guess that falls under "not doing presets correctly"?)

A unified working version of AVS that works nicely with modern OSes and Winamp versions can't be a bad thing.
I'm a fan of the improvements chavs brings, and as it seems that Justin hasn't worked on chavs since his initial chavs post, fixing the bugs in it may get a couple more people to try out the improved syntax.


But whatever happens, presets that use the GVM APE will still cause crashes. (I assume)

[DrO]

so since it's all screwed up with all of the versions floating about, the following is going to happen and then i need input on what will happen after that...


rather than just shipping 2.81d and it not working on Vista and higher, we're going to include 2.82 in the installer and install 2.82 on Vista and higher (as it's DEP friendlier and less prone to crashing - ignoring the preset display issues, etc) and install 2.81d on XP and before (where that version seems to behave better).

that is to alleviate the posts about it just not working (something is better than nothing).


---------------------------------------------------------------------------

and so for the future, i now have a local build of chavs 2.9 which i've been flipping through presets to get it to crash and then trying to fix those crashes there and then (i'm doing this all on Win7 x64 so the fact it runs at all is welcome).

after re-reading everything, is it even worth me trying to sort out a 2.91 based on chavs (which sadly is based on the 2.81b source code) or just put this to bed and forget about it ? i'm willing to put in the time (if only to get it to a point were we don't get crash reports about it continually) but is this something that will help (and yes i know people don't care much now) ?


from what i can see, the main things that aren't right with the chavs base are:

• still randomly crashes (have seen it and fixed 2 issues so far)
• issues with rand(..) as per http://forums.winamp.com/showpost.ph...27&postcount=6
• people don't like the ui / want it changed to one of the typically used mods (if so which one ?)
• version resource is messed up
• not doing presets correctly compared to 2.8x ? (not sure what can be done about that)
  main example is "convolution.ape" which is incompatible with Vista an up - blocking loading of it for the time being so it gives a UI indicator in the preset editor instead of bombing out, etc
• fullscreen mode won't hold without using compatibility mode
• overlay mode just shows a solid colour instead of the preset
• anything else??

[edit]
as issues are deemed 'resolved' i'll strike them through, as well as adding anything new (assuming anyone cares and reports anything).

-daz