[5.092] GDI object leak

[dracula78]

Reproducible for me:
* Start Winamp, and make sure you're using the default modern skin
* Now open the Preferences
* Go to the Skins->Modern skin page
* Go to the Current skin tab
* Close the Preferences window

I use Windows taskmanager, and enabled the GDI objects column on the Processes tab. After doing the actions above the "GDI objects" count increases by approx. one every second...

When it reaches 10.000 exactly, Winamp crashes.

[drewbar]

Reproduced the GDI Object leak via above instructions. But I don't want to wait the several hours to reproduce the 10,000 crash.

Egg?

[DJ Egg]

Yeah, for sure, I/we reproduced it, but also didn't have a few hours spare to wait for it to reach 10,000 (which is the Windows OS limit, btw).

It keeps leaking as soon as the Current Skin page is viewed (but only for any modern skin that displays an image on that page), and doesn't stop even after switching to another Prefs page. Though refreshing or switching skins makes it go away.

It'll be a bug somewhere in gen_ff no doubt... heh.

[iron2000]

Using 5.08d and by following the instructions I too get the increasing GDI objects.

Something to do with the credits animation of the default modern skin?

[DJ Egg]

Alas, after further analysis, we still aren't sure of the cause :-(

Can you please tell us what the exact crash error message is?

[Kiyouta]

Unfortunately when the crash error message appears, it sort of doesn't because of the 10,000 GDI objects heh.

Something about an assertion failure in a certain .cpp file, but its hard to read anything else. That narrows it down huh?

[DJ Egg]

Yeah, it's the name of the .cpp file we need, heh.

[jmatthews112]

Error message at 10,000 GDI Objects reads:

Title: Assertion failed
Message box text:
Expression: hrgn != NULL
File: C:\projects\wasabi\api\wnd\platform\win32\win32_region.cpp
Line: 472

[jahwz]

bug still in 5.094

just installed 5.094 on Windows XP Pro SP2, happened to open the "Current Skin" window then came back to the computer a few hours later to the crash screen. The error message here was the same:

code:


Expression: hrgn != NULL

File: C:\projects\wasabi\api\wnd\platform\win32\win32_region.cpp

Line: 472

Hope that helps!

[DJ Egg]

Yes. We know... that's why this is still referred to in the Known Bugs list. Thanks.